* [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
@ 2019-05-25 11:55 ` Kefeng Wang
0 siblings, 0 replies; 10+ messages in thread
From: Kefeng Wang @ 2019-05-25 11:55 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski
Cc: Kefeng Wang, linux-samsung-soc, linux-arm-kernel
Use of_clk_get_parent_count() instead of open coding.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/clk/samsung/clk-exynos5433.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
index dae1c96de933..14e253915ca4 100644
--- a/drivers/clk/samsung/clk-exynos5433.c
+++ b/drivers/clk/samsung/clk-exynos5433.c
@@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
data->nr_clk_save = info->nr_clk_regs;
data->clk_suspend = info->suspend_regs;
data->nr_clk_suspend = info->nr_suspend_regs;
- data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
- "#clock-cells");
+ data->nr_pclks = of_clk_get_parent_count(dev->of_node);
+
if (data->nr_pclks > 0) {
data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
data->nr_pclks, GFP_KERNEL);
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
2019-05-25 11:55 ` Kefeng Wang
(?)
@ 2019-05-28 11:10 ` Andrzej Hajda
-1 siblings, 0 replies; 10+ messages in thread
From: Andrzej Hajda @ 2019-05-28 11:10 UTC (permalink / raw)
To: Kefeng Wang, Kukjin Kim, Krzysztof Kozlowski
Cc: linux-samsung-soc, linux-arm-kernel
On 25.05.2019 13:55, Kefeng Wang wrote:
> Use of_clk_get_parent_count() instead of open coding.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index dae1c96de933..14e253915ca4 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
> data->nr_clk_save = info->nr_clk_regs;
> data->clk_suspend = info->suspend_regs;
> data->nr_clk_suspend = info->nr_suspend_regs;
> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
> - "#clock-cells");
> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
> +
> if (data->nr_pclks > 0) {
> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
> data->nr_pclks, GFP_KERNEL);
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
2019-05-25 11:55 ` Kefeng Wang
(?)
(?)
@ 2019-05-29 5:32 ` Chanwoo Choi
-1 siblings, 0 replies; 10+ messages in thread
From: Chanwoo Choi @ 2019-05-29 5:32 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski; +Cc: linux-samsung-soc, linux-arm-kernel
Hi,
On 19. 5. 25. 오후 8:55, Kefeng Wang wrote:
> Use of_clk_get_parent_count() instead of open coding.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index dae1c96de933..14e253915ca4 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
> data->nr_clk_save = info->nr_clk_regs;
> data->clk_suspend = info->suspend_regs;
> data->nr_clk_suspend = info->nr_suspend_regs;
> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
> - "#clock-cells");
> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
> +
> if (data->nr_pclks > 0) {
> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
> data->nr_pclks, GFP_KERNEL);
>
It uses the helper function from CCF. Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
2019-05-25 11:55 ` Kefeng Wang
(?)
@ 2019-05-30 11:13 ` Sylwester Nawrocki
-1 siblings, 0 replies; 10+ messages in thread
From: Sylwester Nawrocki @ 2019-05-30 11:13 UTC (permalink / raw)
To: Kefeng Wang
Cc: Kukjin Kim, Krzysztof Kozlowski, linux-samsung-soc,
linux-arm-kernel, linux-clk, Stephen Boyd, Michael Turquette
On 5/25/19 13:55, Kefeng Wang wrote:
> Use of_clk_get_parent_count() instead of open coding.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Patch applied, thank you.
In future please make sure to also Cc linux-clk@vger.kernel.org mailing list
and the clk maintainers (Stephen, Michael) when sending clk patches.
> ---
> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index dae1c96de933..14e253915ca4 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
> data->nr_clk_save = info->nr_clk_regs;
> data->clk_suspend = info->suspend_regs;
> data->nr_clk_suspend = info->nr_suspend_regs;
> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
> - "#clock-cells");
> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
> +
> if (data->nr_pclks > 0) {
> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
> data->nr_pclks, GFP_KERNEL);
>
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
@ 2019-05-30 11:13 ` Sylwester Nawrocki
0 siblings, 0 replies; 10+ messages in thread
From: Sylwester Nawrocki @ 2019-05-30 11:13 UTC (permalink / raw)
To: Kefeng Wang
Cc: linux-samsung-soc, Stephen Boyd, Michael Turquette,
Krzysztof Kozlowski, Kukjin Kim, linux-clk, linux-arm-kernel
On 5/25/19 13:55, Kefeng Wang wrote:
> Use of_clk_get_parent_count() instead of open coding.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Patch applied, thank you.
In future please make sure to also Cc linux-clk@vger.kernel.org mailing list
and the clk maintainers (Stephen, Michael) when sending clk patches.
> ---
> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index dae1c96de933..14e253915ca4 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
> data->nr_clk_save = info->nr_clk_regs;
> data->clk_suspend = info->suspend_regs;
> data->nr_clk_suspend = info->nr_suspend_regs;
> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
> - "#clock-cells");
> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
> +
> if (data->nr_pclks > 0) {
> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
> data->nr_pclks, GFP_KERNEL);
>
--
Thanks,
Sylwester
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
@ 2019-05-30 11:13 ` Sylwester Nawrocki
0 siblings, 0 replies; 10+ messages in thread
From: Sylwester Nawrocki @ 2019-05-30 11:13 UTC (permalink / raw)
To: Kefeng Wang
Cc: linux-samsung-soc, Stephen Boyd, Michael Turquette,
Krzysztof Kozlowski, Kukjin Kim, linux-clk, linux-arm-kernel
On 5/25/19 13:55, Kefeng Wang wrote:
> Use of_clk_get_parent_count() instead of open coding.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Patch applied, thank you.
In future please make sure to also Cc linux-clk@vger.kernel.org mailing list
and the clk maintainers (Stephen, Michael) when sending clk patches.
> ---
> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index dae1c96de933..14e253915ca4 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
> data->nr_clk_save = info->nr_clk_regs;
> data->clk_suspend = info->suspend_regs;
> data->nr_clk_suspend = info->nr_suspend_regs;
> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
> - "#clock-cells");
> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
> +
> if (data->nr_pclks > 0) {
> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
> data->nr_pclks, GFP_KERNEL);
>
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
2019-05-30 11:13 ` Sylwester Nawrocki
(?)
@ 2019-05-30 12:24 ` Kefeng Wang
-1 siblings, 0 replies; 10+ messages in thread
From: Kefeng Wang @ 2019-05-30 12:24 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: Kukjin Kim, Krzysztof Kozlowski, linux-samsung-soc,
linux-arm-kernel, linux-clk, Stephen Boyd, Michael Turquette
On 2019/5/30 19:13, Sylwester Nawrocki wrote:
> On 5/25/19 13:55, Kefeng Wang wrote:
>> Use of_clk_get_parent_count() instead of open coding.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> Patch applied, thank you.
>
> In future please make sure to also Cc linux-clk@vger.kernel.org mailing list
> and the clk maintainers (Stephen, Michael) when sending clk patches.
OK, thanks for the tip.
>
>> ---
>> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
>> index dae1c96de933..14e253915ca4 100644
>> --- a/drivers/clk/samsung/clk-exynos5433.c
>> +++ b/drivers/clk/samsung/clk-exynos5433.c
>> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
>> data->nr_clk_save = info->nr_clk_regs;
>> data->clk_suspend = info->suspend_regs;
>> data->nr_clk_suspend = info->nr_suspend_regs;
>> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
>> - "#clock-cells");
>> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
>> +
>> if (data->nr_pclks > 0) {
>> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
>> data->nr_pclks, GFP_KERNEL);
>>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
@ 2019-05-30 12:24 ` Kefeng Wang
0 siblings, 0 replies; 10+ messages in thread
From: Kefeng Wang @ 2019-05-30 12:24 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: linux-samsung-soc, Stephen Boyd, Michael Turquette,
Krzysztof Kozlowski, Kukjin Kim, linux-clk, linux-arm-kernel
On 2019/5/30 19:13, Sylwester Nawrocki wrote:
> On 5/25/19 13:55, Kefeng Wang wrote:
>> Use of_clk_get_parent_count() instead of open coding.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> Patch applied, thank you.
>
> In future please make sure to also Cc linux-clk@vger.kernel.org mailing list
> and the clk maintainers (Stephen, Michael) when sending clk patches.
OK, thanks for the tip.
>
>> ---
>> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
>> index dae1c96de933..14e253915ca4 100644
>> --- a/drivers/clk/samsung/clk-exynos5433.c
>> +++ b/drivers/clk/samsung/clk-exynos5433.c
>> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
>> data->nr_clk_save = info->nr_clk_regs;
>> data->clk_suspend = info->suspend_regs;
>> data->nr_clk_suspend = info->nr_suspend_regs;
>> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
>> - "#clock-cells");
>> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
>> +
>> if (data->nr_pclks > 0) {
>> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
>> data->nr_pclks, GFP_KERNEL);
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
@ 2019-05-30 12:24 ` Kefeng Wang
0 siblings, 0 replies; 10+ messages in thread
From: Kefeng Wang @ 2019-05-30 12:24 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: linux-samsung-soc, Stephen Boyd, Michael Turquette,
Krzysztof Kozlowski, Kukjin Kim, linux-clk, linux-arm-kernel
On 2019/5/30 19:13, Sylwester Nawrocki wrote:
> On 5/25/19 13:55, Kefeng Wang wrote:
>> Use of_clk_get_parent_count() instead of open coding.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> Patch applied, thank you.
>
> In future please make sure to also Cc linux-clk@vger.kernel.org mailing list
> and the clk maintainers (Stephen, Michael) when sending clk patches.
OK, thanks for the tip.
>
>> ---
>> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
>> index dae1c96de933..14e253915ca4 100644
>> --- a/drivers/clk/samsung/clk-exynos5433.c
>> +++ b/drivers/clk/samsung/clk-exynos5433.c
>> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
>> data->nr_clk_save = info->nr_clk_regs;
>> data->clk_suspend = info->suspend_regs;
>> data->nr_clk_suspend = info->nr_suspend_regs;
>> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
>> - "#clock-cells");
>> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
>> +
>> if (data->nr_pclks > 0) {
>> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
>> data->nr_pclks, GFP_KERNEL);
>>
^ permalink raw reply [flat|nested] 10+ messages in thread