* [PATCH] rtc: at91rm9200: double locking bug in at91_rtc_interrupt()
@ 2015-03-17 15:38 ` Nicolas Ferre
0 siblings, 0 replies; 12+ messages in thread
From: Nicolas Ferre @ 2015-03-17 15:38 UTC (permalink / raw)
To: linux-arm-kernel
From: Dan Carpenter <dan.carpenter@oracle.com>
There is a typo here so we deadlock.
Fixes: dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reported-also-by: David Dueck <davidcdueck@googlemail.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
Hi Andrew,
Can you please take care of this fix for 4.0?
If you fee that I'd better take it myself please tell me.
Thanks, bye.
drivers/rtc/rtc-at91rm9200.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index b4f7744f6751..b283a1a573b3 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id)
ret = IRQ_HANDLED;
}
- spin_lock(&suspended_lock);
+ spin_unlock(&suspended_lock);
return ret;
}
--
2.1.3
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH] rtc: at91rm9200: double locking bug in at91_rtc_interrupt()
@ 2015-03-17 15:38 ` Nicolas Ferre
0 siblings, 0 replies; 12+ messages in thread
From: Nicolas Ferre @ 2015-03-17 15:38 UTC (permalink / raw)
To: linux-arm-kernel
From: Dan Carpenter <dan.carpenter@oracle.com>
There is a typo here so we deadlock.
Fixes: dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reported-also-by: David Dueck <davidcdueck@googlemail.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
Hi Andrew,
Can you please take care of this fix for 4.0?
If you fee that I'd better take it myself please tell me.
Thanks, bye.
drivers/rtc/rtc-at91rm9200.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index b4f7744f6751..b283a1a573b3 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id)
ret = IRQ_HANDLED;
}
- spin_lock(&suspended_lock);
+ spin_unlock(&suspended_lock);
return ret;
}
--
2.1.3
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] rtc: at91rm9200: double locking bug in at91_rtc_interrupt()
2015-03-17 15:38 ` Nicolas Ferre
(?)
@ 2015-03-17 17:32 ` Dan Carpenter
-1 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2015-03-17 17:32 UTC (permalink / raw)
To: Nicolas Ferre
Cc: Andrew Morton, linux-arm-kernel, linux-kernel, a.zummo,
rtc-linux, kernel-janitors, Boris BREZILLON, Alexandre Belloni,
Jean-Christophe PLAGNIOL-VILLARD
On Tue, Mar 17, 2015 at 04:38:10PM +0100, Nicolas Ferre wrote:
> Reported-also-by: David Dueck <davidcdueck@googlemail.com>
The point of tags is that you collect them by doing:
`git log | grep Reported-by: | sort | uniq -c | sort -rn` to see if you
are the winner. It gives me an unfair advantage if you get creative
with David's tag.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] rtc: at91rm9200: double locking bug in at91_rtc_interrupt()
@ 2015-03-17 17:32 ` Dan Carpenter
0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2015-03-17 17:32 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 17, 2015 at 04:38:10PM +0100, Nicolas Ferre wrote:
> Reported-also-by: David Dueck <davidcdueck@googlemail.com>
The point of tags is that you collect them by doing:
`git log | grep Reported-by: | sort | uniq -c | sort -rn` to see if you
are the winner. It gives me an unfair advantage if you get creative
with David's tag.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] rtc: at91rm9200: double locking bug in at91_rtc_interrupt()
@ 2015-03-17 17:32 ` Dan Carpenter
0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2015-03-17 17:32 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 17, 2015 at 04:38:10PM +0100, Nicolas Ferre wrote:
> Reported-also-by: David Dueck <davidcdueck@googlemail.com>
The point of tags is that you collect them by doing:
`git log | grep Reported-by: | sort | uniq -c | sort -rn` to see if you
are the winner. It gives me an unfair advantage if you get creative
with David's tag.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] rtc: at91rm9200: double locking bug in at91_rtc_interrupt()
2015-03-17 15:38 ` Nicolas Ferre
(?)
@ 2015-03-18 1:20 ` Rafael J. Wysocki
-1 siblings, 0 replies; 12+ messages in thread
From: Rafael J. Wysocki @ 2015-03-18 0:56 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, March 17, 2015 04:38:10 PM Nicolas Ferre wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> There is a typo here so we deadlock.
>
> Fixes: dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-also-by: David Dueck <davidcdueck@googlemail.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> Hi Andrew,
>
> Can you please take care of this fix for 4.0?
> If you fee that I'd better take it myself please tell me.
The commit being fixed went in through my tree, so I'll take this one if that's
not a problem.
> drivers/rtc/rtc-at91rm9200.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index b4f7744f6751..b283a1a573b3 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id)
>
> ret = IRQ_HANDLED;
> }
> - spin_lock(&suspended_lock);
> + spin_unlock(&suspended_lock);
>
> return ret;
> }
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH] rtc: at91rm9200: double locking bug in at91_rtc_interrupt()
@ 2015-03-18 1:20 ` Rafael J. Wysocki
0 siblings, 0 replies; 12+ messages in thread
From: Rafael J. Wysocki @ 2015-03-18 1:20 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, March 17, 2015 04:38:10 PM Nicolas Ferre wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> There is a typo here so we deadlock.
>
> Fixes: dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-also-by: David Dueck <davidcdueck@googlemail.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> Hi Andrew,
>
> Can you please take care of this fix for 4.0?
> If you fee that I'd better take it myself please tell me.
The commit being fixed went in through my tree, so I'll take this one if that's
not a problem.
> drivers/rtc/rtc-at91rm9200.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index b4f7744f6751..b283a1a573b3 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id)
>
> ret = IRQ_HANDLED;
> }
> - spin_lock(&suspended_lock);
> + spin_unlock(&suspended_lock);
>
> return ret;
> }
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] rtc: at91rm9200: double locking bug in at91_rtc_interrupt()
@ 2015-03-18 1:20 ` Rafael J. Wysocki
0 siblings, 0 replies; 12+ messages in thread
From: Rafael J. Wysocki @ 2015-03-18 1:20 UTC (permalink / raw)
To: Nicolas Ferre
Cc: Andrew Morton, linux-arm-kernel, linux-kernel, a.zummo,
dan.carpenter, rtc-linux, kernel-janitors, Boris BREZILLON,
Alexandre Belloni, Jean-Christophe PLAGNIOL-VILLARD
On Tuesday, March 17, 2015 04:38:10 PM Nicolas Ferre wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> There is a typo here so we deadlock.
>
> Fixes: dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-also-by: David Dueck <davidcdueck@googlemail.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> Hi Andrew,
>
> Can you please take care of this fix for 4.0?
> If you fee that I'd better take it myself please tell me.
The commit being fixed went in through my tree, so I'll take this one if that's
not a problem.
> drivers/rtc/rtc-at91rm9200.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index b4f7744f6751..b283a1a573b3 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id)
>
> ret = IRQ_HANDLED;
> }
> - spin_lock(&suspended_lock);
> + spin_unlock(&suspended_lock);
>
> return ret;
> }
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 12+ messages in thread