All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-leds@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v32 3/6] ARM: defconfig: u8500: Add LP55XX_COMMON config flag
Date: Tue, 28 Jul 2020 08:38:38 -0500	[thread overview]
Message-ID: <372891d8-816e-f640-7356-90513f998702@ti.com> (raw)
In-Reply-To: <20200722153146.8767-4-dmurphy@ti.com>

Russel and Linus

On 7/22/20 10:31 AM, Dan Murphy wrote:
> The dependencies for the LP55XX LED drivers have been updated so that
> the child devices (i.e. LP5521) now depends on the LP55XX_COMMON config
> flag as opposed to the device selecting the LP55XX_COMMON flag.  The
> LP55XX_COMMON needs to be set in the defconfig.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>   arch/arm/configs/u8500_defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/u8500_defconfig b/arch/arm/configs/u8500_defconfig
> index 28dd7cf56048..dea599e1c17e 100644
> --- a/arch/arm/configs/u8500_defconfig
> +++ b/arch/arm/configs/u8500_defconfig
> @@ -113,6 +113,7 @@ CONFIG_NEW_LEDS=y
>   CONFIG_LEDS_CLASS=y
>   CONFIG_LEDS_LM3530=y
>   CONFIG_LEDS_GPIO=y
> +CONFIG_LEDS_LP55XX_COMMON=y
>   CONFIG_LEDS_LP5521=y
>   CONFIG_LEDS_TRIGGER_HEARTBEAT=y
>   CONFIG_RTC_CLASS=y


I missed adding you to the patch.

Can you kindly review this change?

Dan


WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v32 3/6] ARM: defconfig: u8500: Add LP55XX_COMMON config flag
Date: Tue, 28 Jul 2020 08:38:38 -0500	[thread overview]
Message-ID: <372891d8-816e-f640-7356-90513f998702@ti.com> (raw)
In-Reply-To: <20200722153146.8767-4-dmurphy@ti.com>

Russel and Linus

On 7/22/20 10:31 AM, Dan Murphy wrote:
> The dependencies for the LP55XX LED drivers have been updated so that
> the child devices (i.e. LP5521) now depends on the LP55XX_COMMON config
> flag as opposed to the device selecting the LP55XX_COMMON flag.  The
> LP55XX_COMMON needs to be set in the defconfig.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>   arch/arm/configs/u8500_defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/u8500_defconfig b/arch/arm/configs/u8500_defconfig
> index 28dd7cf56048..dea599e1c17e 100644
> --- a/arch/arm/configs/u8500_defconfig
> +++ b/arch/arm/configs/u8500_defconfig
> @@ -113,6 +113,7 @@ CONFIG_NEW_LEDS=y
>   CONFIG_LEDS_CLASS=y
>   CONFIG_LEDS_LM3530=y
>   CONFIG_LEDS_GPIO=y
> +CONFIG_LEDS_LP55XX_COMMON=y
>   CONFIG_LEDS_LP5521=y
>   CONFIG_LEDS_TRIGGER_HEARTBEAT=y
>   CONFIG_RTC_CLASS=y


I missed adding you to the patch.

Can you kindly review this change?

Dan


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-28 13:39 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22 15:31 [PATCH v32 0/6] Multicolor Framework v32 Dan Murphy
2020-07-22 15:31 ` Dan Murphy
2020-07-22 15:31 ` [PATCH v32 1/6] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-07-22 15:31   ` Dan Murphy
2020-07-28 13:39   ` Dan Murphy
2020-07-28 13:39     ` Dan Murphy
2020-08-04 19:55     ` Dan Murphy
2020-08-04 19:55       ` Dan Murphy
2020-08-07 13:42       ` Dan Murphy
2020-08-07 13:42         ` Dan Murphy
2020-08-11 10:32         ` Pavel Machek
2020-08-11 10:32           ` Pavel Machek
2020-08-11 10:20   ` Pavel Machek
2020-08-11 10:20     ` Pavel Machek
2020-08-11 17:07     ` Dan Murphy
2020-08-11 17:07       ` Dan Murphy
2020-07-22 15:31 ` [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-07-22 15:31   ` Dan Murphy
2020-08-11 10:29   ` Pavel Machek
2020-08-11 10:29     ` Pavel Machek
2020-08-11 10:31   ` Pavel Machek
2020-08-11 10:31     ` Pavel Machek
2020-08-11 10:54   ` Pavel Machek
2020-08-11 10:54     ` Pavel Machek
2020-08-11 17:27     ` Dan Murphy
2020-08-11 17:27       ` Dan Murphy
2020-08-11 22:01       ` Pavel Machek
2020-08-11 22:01         ` Pavel Machek
2020-08-11 22:16         ` Dan Murphy
2020-08-11 22:16           ` Dan Murphy
2020-08-11 22:26           ` Pavel Machek
2020-08-11 22:26             ` Pavel Machek
2020-08-12 16:00             ` Dan Murphy
2020-08-12 16:00               ` Dan Murphy
2020-07-22 15:31 ` [PATCH v32 3/6] ARM: defconfig: u8500: Add LP55XX_COMMON config flag Dan Murphy
2020-07-22 15:31   ` Dan Murphy
2020-07-28 13:38   ` Dan Murphy [this message]
2020-07-28 13:38     ` Dan Murphy
2020-08-03 23:14   ` Linus Walleij
2020-08-03 23:14     ` Linus Walleij
2020-07-22 15:31 ` [PATCH v32 4/6] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-07-22 15:31   ` Dan Murphy
2020-07-22 15:31 ` [PATCH v32 5/6] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-07-22 15:31   ` Dan Murphy
2020-07-22 15:31 ` [PATCH v32 6/6] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-07-22 15:31   ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=372891d8-816e-f640-7356-90513f998702@ti.com \
    --to=dmurphy@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.