From: Billy Tsai <billy_tsai@aspeedtech.com> To: Rob Herring <robh@kernel.org> Cc: "lee.jones@linaro.org" <lee.jones@linaro.org>, "joel@jms.id.au" <joel@jms.id.au>, "andrew@aj.id.au" <andrew@aj.id.au>, "thierry.reding@gmail.com" <thierry.reding@gmail.com>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>, BMC-SW <BMC-SW@aspeedtech.com> Subject: Re: [v6 1/2] dt-bindings: Add bindings for aspeed pwm-tach. Date: Thu, 20 May 2021 01:06:43 +0000 [thread overview] Message-ID: <37458AA4-17E4-4329-88A1-C18C0AFC47D5@aspeedtech.com> (raw) In-Reply-To: <20210519202004.GA3566127@robh.at.kernel.org> Hi Rob, On 2021/5/20, 4:20 AM,Rob Herringwrote: On Tue, May 18, 2021 at 08:55:16AM +0800, Billy Tsai wrote: > > + }; > > + }; > > + > > + tach: tach { > > + compatible = "aspeed,ast2600-tach"; > Are pwm and tach separate h/w blocks? Yes, they are the separate h/w blocks. > > + #address-cells = <1>; > > + #size-cells = <0>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_tach0_default>; > > + fan@0 { > > + reg = <0>; > How does one configure which PWM is connected to each fan? > Existing bindings use 'reg' for PWM channel and another property for > tach channel. Please don't do something different. The fan node in this place specifically refers tach pin, maybe I need to change the naming to avoid confusion. We just focus on the fan properties on this tach channel has nothing to do with pwm. > + aspeed,min-rpm = <1000>; > + aspeed,pulse-pr = <2>; > + aspeed,tach-div = <5>; > + }; > + }; > + };
WARNING: multiple messages have this Message-ID (diff)
From: Billy Tsai <billy_tsai@aspeedtech.com> To: Rob Herring <robh@kernel.org> Cc: "lee.jones@linaro.org" <lee.jones@linaro.org>, "joel@jms.id.au" <joel@jms.id.au>, "andrew@aj.id.au" <andrew@aj.id.au>, "thierry.reding@gmail.com" <thierry.reding@gmail.com>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>, BMC-SW <BMC-SW@aspeedtech.com> Subject: Re: [v6 1/2] dt-bindings: Add bindings for aspeed pwm-tach. Date: Thu, 20 May 2021 01:06:43 +0000 [thread overview] Message-ID: <37458AA4-17E4-4329-88A1-C18C0AFC47D5@aspeedtech.com> (raw) In-Reply-To: <20210519202004.GA3566127@robh.at.kernel.org> Hi Rob, On 2021/5/20, 4:20 AM,Rob Herringwrote: On Tue, May 18, 2021 at 08:55:16AM +0800, Billy Tsai wrote: > > + }; > > + }; > > + > > + tach: tach { > > + compatible = "aspeed,ast2600-tach"; > Are pwm and tach separate h/w blocks? Yes, they are the separate h/w blocks. > > + #address-cells = <1>; > > + #size-cells = <0>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_tach0_default>; > > + fan@0 { > > + reg = <0>; > How does one configure which PWM is connected to each fan? > Existing bindings use 'reg' for PWM channel and another property for > tach channel. Please don't do something different. The fan node in this place specifically refers tach pin, maybe I need to change the naming to avoid confusion. We just focus on the fan properties on this tach channel has nothing to do with pwm. > + aspeed,min-rpm = <1000>; > + aspeed,pulse-pr = <2>; > + aspeed,tach-div = <5>; > + }; > + }; > + }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-20 1:06 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-18 0:55 [v6 0/2] Support pwm driver for aspeed ast26xx Billy Tsai 2021-05-18 0:55 ` Billy Tsai 2021-05-18 0:55 ` [v6 1/2] dt-bindings: Add bindings for aspeed pwm-tach Billy Tsai 2021-05-18 0:55 ` Billy Tsai 2021-05-19 20:20 ` Rob Herring 2021-05-19 20:20 ` Rob Herring 2021-05-20 1:06 ` Billy Tsai [this message] 2021-05-20 1:06 ` Billy Tsai 2021-05-18 0:55 ` [v6 2/2] pwm: Add Aspeed ast2600 PWM support Billy Tsai 2021-05-18 0:55 ` Billy Tsai 2021-05-22 16:07 ` Uwe Kleine-König 2021-05-22 16:07 ` Uwe Kleine-König 2021-05-24 1:56 ` Billy Tsai 2021-05-24 1:56 ` Billy Tsai 2021-05-24 11:02 ` Uwe Kleine-König 2021-05-24 11:02 ` Uwe Kleine-König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=37458AA4-17E4-4329-88A1-C18C0AFC47D5@aspeedtech.com \ --to=billy_tsai@aspeedtech.com \ --cc=BMC-SW@aspeedtech.com \ --cc=andrew@aj.id.au \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=robh@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.