All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong.eric@gmail.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Pankaj Gupta <pagupta@redhat.com>,
	Rik van Riel <riel@redhat.com>, Jan Kara <jack@suse.cz>,
	kvm-devel <kvm@vger.kernel.org>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Ross Zwisler <ross.zwisler@intel.com>,
	Qemu Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Nitesh Narayan Lal <nilal@redhat.com>
Subject: Re: KVM "fake DAX" flushing interface - discussion
Date: Wed, 1 Nov 2017 11:43:40 +0800	[thread overview]
Message-ID: <378b10f3-b32f-84f5-2bbc-50c2ec5bcdd4@gmail.com> (raw)
In-Reply-To: <CAPcyv4iw2cCpDmr+4kxsFvdy+iGZiz=ok-kLhsDKpqDy+szf-Q@mail.gmail.com>



On 10/31/2017 10:20 PM, Dan Williams wrote:
> On Tue, Oct 31, 2017 at 12:13 AM, Xiao Guangrong
> <xiaoguangrong.eric@gmail.com> wrote:
>>
>>
>> On 07/27/2017 08:54 AM, Dan Williams wrote:
>>
>>>> At that point, would it make sense to expose these special
>>>> virtio-pmem areas to the guest in a slightly different way,
>>>> so the regions that need virtio flushing are not bound by
>>>> the regular driver, and the regular driver can continue to
>>>> work for memory regions that are backed by actual pmem in
>>>> the host?
>>>
>>>
>>> Hmm, yes that could be feasible especially if it uses the ACPI NFIT
>>> mechanism. It would basically involve defining a new SPA (System
>>> Phyiscal Address) range GUID type, and then teaching libnvdimm to
>>> treat that as a new pmem device type.
>>
>>
>> I would prefer a new flush mechanism to a new memory type introduced
>> to NFIT, e.g, in that mechanism we can define request queues and
>> completion queues and any other features to make virtualization
>> friendly. That would be much simpler.
>>
> 
> No that's more confusing because now we are overloading the definition
> of persistent memory. I want this memory type identified from the top
> of the stack so it can appear differently in /proc/iomem and also
> implement this alternate flush communication.
> 

For the characteristic of memory, I have no idea why VM should know this
difference. It can be completely transparent to VM, that means, VM
does not need to know where this virtual PMEM comes from (for a really
nvdimm backend or a normal storage). The only discrepancy is the flush
interface.

> In what way is this "more complicated"? It was trivial to add support
> for the "volatile" NFIT range, this will not be any more complicated
> than that.
> 

Introducing memory type is easy indeed, however, a new flush interface
definition is inevitable, i.e, we need a standard way to discover the
MMIOs to communicate with host.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <xiaoguangrong.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Kevin Wolf <kwolf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Pankaj Gupta <pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Rik van Riel <riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
	kvm-devel <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Stefan Hajnoczi
	<stefanha-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ross Zwisler
	<ross.zwisler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Qemu Developers
	<qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org>,
	Stefan Hajnoczi
	<stefanha-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org"
	<linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org>,
	Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Nitesh Narayan Lal
	<nilal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: KVM "fake DAX" flushing interface - discussion
Date: Wed, 1 Nov 2017 11:43:40 +0800	[thread overview]
Message-ID: <378b10f3-b32f-84f5-2bbc-50c2ec5bcdd4@gmail.com> (raw)
In-Reply-To: <CAPcyv4iw2cCpDmr+4kxsFvdy+iGZiz=ok-kLhsDKpqDy+szf-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>



On 10/31/2017 10:20 PM, Dan Williams wrote:
> On Tue, Oct 31, 2017 at 12:13 AM, Xiao Guangrong
> <xiaoguangrong.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>
>>
>> On 07/27/2017 08:54 AM, Dan Williams wrote:
>>
>>>> At that point, would it make sense to expose these special
>>>> virtio-pmem areas to the guest in a slightly different way,
>>>> so the regions that need virtio flushing are not bound by
>>>> the regular driver, and the regular driver can continue to
>>>> work for memory regions that are backed by actual pmem in
>>>> the host?
>>>
>>>
>>> Hmm, yes that could be feasible especially if it uses the ACPI NFIT
>>> mechanism. It would basically involve defining a new SPA (System
>>> Phyiscal Address) range GUID type, and then teaching libnvdimm to
>>> treat that as a new pmem device type.
>>
>>
>> I would prefer a new flush mechanism to a new memory type introduced
>> to NFIT, e.g, in that mechanism we can define request queues and
>> completion queues and any other features to make virtualization
>> friendly. That would be much simpler.
>>
> 
> No that's more confusing because now we are overloading the definition
> of persistent memory. I want this memory type identified from the top
> of the stack so it can appear differently in /proc/iomem and also
> implement this alternate flush communication.
> 

For the characteristic of memory, I have no idea why VM should know this
difference. It can be completely transparent to VM, that means, VM
does not need to know where this virtual PMEM comes from (for a really
nvdimm backend or a normal storage). The only discrepancy is the flush
interface.

> In what way is this "more complicated"? It was trivial to add support
> for the "volatile" NFIT range, this will not be any more complicated
> than that.
> 

Introducing memory type is easy indeed, however, a new flush interface
definition is inevitable, i.e, we need a standard way to discover the
MMIOs to communicate with host.

WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <xiaoguangrong.eric@gmail.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Rik van Riel <riel@redhat.com>, Pankaj Gupta <pagupta@redhat.com>,
	Jan Kara <jack@suse.cz>, Stefan Hajnoczi <stefanha@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	kvm-devel <kvm@vger.kernel.org>,
	Qemu Developers <qemu-devel@nongnu.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
	ross zwisler <ross.zwisler@linux.intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Nitesh Narayan Lal <nilal@redhat.com>,
	Haozhong Zhang <haozhong.zhang@intel.com>,
	Ross Zwisler <ross.zwisler@intel.com>
Subject: Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion
Date: Wed, 1 Nov 2017 11:43:40 +0800	[thread overview]
Message-ID: <378b10f3-b32f-84f5-2bbc-50c2ec5bcdd4@gmail.com> (raw)
In-Reply-To: <CAPcyv4iw2cCpDmr+4kxsFvdy+iGZiz=ok-kLhsDKpqDy+szf-Q@mail.gmail.com>



On 10/31/2017 10:20 PM, Dan Williams wrote:
> On Tue, Oct 31, 2017 at 12:13 AM, Xiao Guangrong
> <xiaoguangrong.eric@gmail.com> wrote:
>>
>>
>> On 07/27/2017 08:54 AM, Dan Williams wrote:
>>
>>>> At that point, would it make sense to expose these special
>>>> virtio-pmem areas to the guest in a slightly different way,
>>>> so the regions that need virtio flushing are not bound by
>>>> the regular driver, and the regular driver can continue to
>>>> work for memory regions that are backed by actual pmem in
>>>> the host?
>>>
>>>
>>> Hmm, yes that could be feasible especially if it uses the ACPI NFIT
>>> mechanism. It would basically involve defining a new SPA (System
>>> Phyiscal Address) range GUID type, and then teaching libnvdimm to
>>> treat that as a new pmem device type.
>>
>>
>> I would prefer a new flush mechanism to a new memory type introduced
>> to NFIT, e.g, in that mechanism we can define request queues and
>> completion queues and any other features to make virtualization
>> friendly. That would be much simpler.
>>
> 
> No that's more confusing because now we are overloading the definition
> of persistent memory. I want this memory type identified from the top
> of the stack so it can appear differently in /proc/iomem and also
> implement this alternate flush communication.
> 

For the characteristic of memory, I have no idea why VM should know this
difference. It can be completely transparent to VM, that means, VM
does not need to know where this virtual PMEM comes from (for a really
nvdimm backend or a normal storage). The only discrepancy is the flush
interface.

> In what way is this "more complicated"? It was trivial to add support
> for the "volatile" NFIT range, this will not be any more complicated
> than that.
> 

Introducing memory type is easy indeed, however, a new flush interface
definition is inevitable, i.e, we need a standard way to discover the
MMIOs to communicate with host.

  reply	other threads:[~2017-11-01  3:43 UTC|newest]

Thread overview: 176+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1455443283.33337333.1500618150787.JavaMail.zimbra@redhat.com>
2017-07-21  6:56 ` KVM "fake DAX" flushing interface - discussion Pankaj Gupta
2017-07-21  6:56   ` [Qemu-devel] " Pankaj Gupta
2017-07-21  6:56   ` Pankaj Gupta
2017-07-21  9:51   ` Haozhong Zhang
2017-07-21  9:51     ` [Qemu-devel] " Haozhong Zhang
2017-07-21  9:51     ` Haozhong Zhang
2017-07-21 10:21     ` Pankaj Gupta
2017-07-21 10:21       ` [Qemu-devel] " Pankaj Gupta
2017-07-21 10:21       ` Pankaj Gupta
2017-07-21 12:12   ` Stefan Hajnoczi
2017-07-21 12:12     ` [Qemu-devel] " Stefan Hajnoczi
2017-07-21 13:29     ` Pankaj Gupta
2017-07-21 13:29       ` [Qemu-devel] " Pankaj Gupta
2017-07-21 13:29       ` Pankaj Gupta
2017-07-21 14:00       ` Rik van Riel
2017-07-21 14:00         ` [Qemu-devel] " Rik van Riel
2017-07-21 14:00         ` Rik van Riel
2017-07-21 15:58       ` Stefan Hajnoczi
2017-07-21 15:58         ` [Qemu-devel] " Stefan Hajnoczi
2017-07-22 19:34         ` Dan Williams
2017-07-22 19:34           ` [Qemu-devel] " Dan Williams
2017-07-22 19:34           ` Dan Williams
2017-07-23 14:04           ` Rik van Riel
2017-07-23 14:04             ` [Qemu-devel] " Rik van Riel
2017-07-23 14:04             ` Rik van Riel
2017-07-23 16:01             ` Dan Williams
2017-07-23 16:01               ` [Qemu-devel] " Dan Williams
2017-07-23 16:01               ` Dan Williams
2017-07-23 18:10               ` Rik van Riel
2017-07-23 18:10                 ` [Qemu-devel] " Rik van Riel
2017-07-23 18:10                 ` Rik van Riel
2017-07-23 20:10                 ` Dan Williams
2017-07-23 20:10                   ` [Qemu-devel] " Dan Williams
2017-07-23 20:10                   ` Dan Williams
2017-07-24 10:23                   ` Jan Kara
2017-07-24 10:23                     ` [Qemu-devel] " Jan Kara
2017-07-24 10:23                     ` Jan Kara
2017-07-24 12:06                     ` Pankaj Gupta
2017-07-24 12:06                       ` [Qemu-devel] " Pankaj Gupta
2017-07-24 12:06                       ` Pankaj Gupta
2017-07-24 12:37                       ` Jan Kara
2017-07-24 12:37                         ` [Qemu-devel] " Jan Kara
2017-07-24 12:37                         ` Jan Kara
2017-07-24 15:10                         ` Dan Williams
2017-07-24 15:10                           ` [Qemu-devel] " Dan Williams
2017-07-24 15:10                           ` Dan Williams
2017-07-24 15:48                           ` Jan Kara
2017-07-24 15:48                             ` [Qemu-devel] " Jan Kara
2017-07-24 15:48                             ` Jan Kara
2017-07-24 16:19                             ` Dan Williams
2017-07-24 16:19                               ` [Qemu-devel] " Dan Williams
2017-07-24 16:19                               ` Dan Williams
2017-07-25 14:27                         ` Pankaj Gupta
2017-07-25 14:27                           ` [Qemu-devel] " Pankaj Gupta
2017-07-25 14:27                           ` Pankaj Gupta
2017-07-25 14:46                           ` Dan Williams
2017-07-25 14:46                             ` [Qemu-devel] " Dan Williams
2017-07-25 14:46                             ` Dan Williams
2017-07-25 20:59                             ` Rik van Riel
2017-07-25 20:59                               ` [Qemu-devel] " Rik van Riel
2017-07-26 13:47                               ` Pankaj Gupta
2017-07-26 13:47                                 ` [Qemu-devel] " Pankaj Gupta
2017-07-26 13:47                                 ` Pankaj Gupta
2017-07-26 21:27                                 ` Rik van Riel
2017-07-26 21:27                                   ` [Qemu-devel] " Rik van Riel
2017-07-26 21:40                                   ` Dan Williams
2017-07-26 21:40                                     ` [Qemu-devel] " Dan Williams
2017-07-26 21:40                                     ` Dan Williams
2017-07-26 23:46                                     ` Rik van Riel
2017-07-26 23:46                                       ` [Qemu-devel] " Rik van Riel
2017-07-26 23:46                                       ` Rik van Riel
2017-07-27  0:54                                       ` Dan Williams
2017-07-27  0:54                                         ` [Qemu-devel] " Dan Williams
2017-07-27  0:54                                         ` Dan Williams
2017-10-31  7:13                                         ` Xiao Guangrong
2017-10-31  7:13                                           ` [Qemu-devel] " Xiao Guangrong
2017-10-31  7:13                                           ` Xiao Guangrong
2017-10-31 14:20                                           ` Dan Williams
2017-10-31 14:20                                             ` [Qemu-devel] " Dan Williams
2017-10-31 14:20                                             ` Dan Williams
2017-11-01  3:43                                             ` Xiao Guangrong [this message]
2017-11-01  3:43                                               ` [Qemu-devel] " Xiao Guangrong
2017-11-01  3:43                                               ` Xiao Guangrong
2017-11-01  4:25                                               ` Dan Williams
2017-11-01  4:25                                                 ` [Qemu-devel] " Dan Williams
2017-11-01  4:25                                                 ` Dan Williams
2017-11-01  6:46                                                 ` Xiao Guangrong
2017-11-01  6:46                                                   ` [Qemu-devel] " Xiao Guangrong
2017-11-01  6:46                                                   ` Xiao Guangrong
2017-11-01 15:20                                                   ` Dan Williams
2017-11-01 15:20                                                     ` [Qemu-devel] " Dan Williams
2017-11-01 15:20                                                     ` Dan Williams
2017-11-02  8:50                                                     ` Xiao Guangrong
2017-11-02  8:50                                                       ` [Qemu-devel] " Xiao Guangrong
2017-11-02  8:50                                                       ` Xiao Guangrong
2017-11-02 16:30                                                       ` Dan Williams
2017-11-02 16:30                                                         ` [Qemu-devel] " Dan Williams
2017-11-02 16:30                                                         ` Dan Williams
2017-11-03  6:21                                                         ` Xiao Guangrong
2017-11-03  6:21                                                           ` [Qemu-devel] " Xiao Guangrong
2017-11-03  6:21                                                           ` Xiao Guangrong
2017-11-21 18:19                                                           ` Rik van Riel
2017-11-21 18:19                                                             ` [Qemu-devel] " Rik van Riel
2017-11-21 18:26                                                             ` Dan Williams
2017-11-21 18:26                                                               ` [Qemu-devel] " Dan Williams
2017-11-21 18:26                                                               ` Dan Williams
2017-11-21 18:35                                                               ` Rik van Riel
2017-11-21 18:35                                                                 ` [Qemu-devel] " Rik van Riel
2017-11-23  4:05                                                             ` Xiao Guangrong
2017-11-23  4:05                                                               ` [Qemu-devel] " Xiao Guangrong
2017-11-23  4:05                                                               ` Xiao Guangrong
2017-11-23 16:14                                                               ` Dan Williams
2017-11-23 16:14                                                                 ` [Qemu-devel] " Dan Williams
2017-11-23 16:14                                                                 ` Dan Williams
2017-11-23 16:28                                                                 ` Paolo Bonzini
2017-11-23 16:28                                                                   ` [Qemu-devel] " Paolo Bonzini
2017-11-23 16:28                                                                   ` Paolo Bonzini
2017-11-24 12:40                                                                   ` Pankaj Gupta
2017-11-24 12:40                                                                     ` [Qemu-devel] " Pankaj Gupta
2017-11-24 12:40                                                                     ` Pankaj Gupta
2017-11-24 12:44                                                                     ` Paolo Bonzini
2017-11-24 12:44                                                                       ` [Qemu-devel] " Paolo Bonzini
2017-11-24 12:44                                                                       ` Paolo Bonzini
2017-11-24 13:02                                                                       ` [Qemu-devel] " Pankaj Gupta
2017-11-24 13:02                                                                         ` Pankaj Gupta
2017-11-24 13:20                                                                         ` Paolo Bonzini
2017-11-24 13:20                                                                           ` Paolo Bonzini
2017-11-28 18:03                                                                     ` Dan Williams
2017-11-28 18:03                                                                       ` [Qemu-devel] " Dan Williams
2017-11-28 18:03                                                                       ` Dan Williams
2018-01-13  6:23                                                                       ` Pankaj Gupta
2018-01-13  6:23                                                                         ` [Qemu-devel] " Pankaj Gupta
2018-01-13  6:23                                                                         ` Pankaj Gupta
2018-01-17 16:17                                                                         ` Dan Williams
2018-01-17 16:17                                                                           ` [Qemu-devel] " Dan Williams
2018-01-17 16:17                                                                           ` Dan Williams
2018-01-17 17:31                                                                           ` Pankaj Gupta
2018-01-17 17:31                                                                             ` [Qemu-devel] " Pankaj Gupta
2018-01-17 17:31                                                                             ` Pankaj Gupta
2018-01-18 16:53                                                                     ` David Hildenbrand
2018-01-18 16:53                                                                       ` [Qemu-devel] " David Hildenbrand
2018-01-18 16:53                                                                       ` David Hildenbrand
2018-01-18 17:38                                                                       ` Dan Williams
2018-01-18 17:38                                                                         ` [Qemu-devel] " Dan Williams
2018-01-18 17:38                                                                         ` Dan Williams
2018-01-18 17:48                                                                         ` David Hildenbrand
2018-01-18 17:48                                                                           ` [Qemu-devel] " David Hildenbrand
2018-01-18 17:48                                                                           ` David Hildenbrand
2018-01-18 18:45                                                                           ` Dan Williams
2018-01-18 18:45                                                                             ` [Qemu-devel] " Dan Williams
2018-01-18 18:45                                                                             ` Dan Williams
2018-01-18 18:54                                                                           ` Pankaj Gupta
2018-01-18 18:54                                                                             ` [Qemu-devel] " Pankaj Gupta
2018-01-18 18:54                                                                             ` Pankaj Gupta
2018-01-18 18:59                                                                             ` Dan Williams
2018-01-18 18:59                                                                               ` [Qemu-devel] " Dan Williams
2018-01-18 18:59                                                                               ` Dan Williams
2018-01-18 19:36                                                                               ` Pankaj Gupta
2018-01-18 19:36                                                                                 ` [Qemu-devel] " Pankaj Gupta
2018-01-18 19:36                                                                                 ` Pankaj Gupta
2018-01-18 19:48                                                                                 ` Dan Williams
2018-01-18 19:48                                                                                   ` [Qemu-devel] " Dan Williams
2018-01-18 19:48                                                                                   ` Dan Williams
2018-01-18 19:51                                                                               ` David Hildenbrand
2018-01-18 19:51                                                                                 ` [Qemu-devel] " David Hildenbrand
2018-01-18 19:51                                                                                 ` David Hildenbrand
2018-01-18 20:11                                                                                 ` Dan Williams
2018-01-18 20:11                                                                                   ` [Qemu-devel] " Dan Williams
2018-01-18 20:11                                                                                   ` Dan Williams
2017-11-06  7:57                                                         ` [Qemu-devel] " Pankaj Gupta
2017-11-06  7:57                                                           ` Pankaj Gupta
2017-11-06 16:57                                                           ` Dan Williams
2017-11-06 16:57                                                             ` Dan Williams
2017-11-07 11:21                                                             ` Pankaj Gupta
2017-11-07 11:21                                                               ` Pankaj Gupta
2017-11-07 11:21                                                               ` Pankaj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=378b10f3-b32f-84f5-2bbc-50c2ec5bcdd4@gmail.com \
    --to=xiaoguangrong.eric@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=jack@suse.cz \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=nilal@redhat.com \
    --cc=pagupta@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riel@redhat.com \
    --cc=ross.zwisler@intel.com \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.