All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Neil Armstrong <neil.armstrong@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Caleb Connolly <caleb@connolly.tech>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@somainline.org>,
	Martin Botka <martin.botka@somainline.org>,
	Jami Kettunen <jami.kettunen@somainline.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Kuogee Hsieh <quic_khsieh@quicinc.com>,
	Jessica Zhang <quic_jesszhan@quicinc.com>,
	Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH RFC 08/10] drm/panel/samsung-sofef03: Add panel driver for Sony Xperia 5 II
Date: Tue, 30 May 2023 01:22:54 +0300	[thread overview]
Message-ID: <3839853f-eca7-5ff2-db90-51c014baff06@linaro.org> (raw)
In-Reply-To: <80372e51-e72f-e70e-c205-8bd79ad57515@linaro.org>

On 30/05/2023 00:29, Konrad Dybcio wrote:
> 
> 
> On 29.05.2023 23:21, Marijn Suijten wrote:
>> On 2023-05-22 11:08:12, Neil Armstrong wrote:
>>> On 22/05/2023 03:23, Dmitry Baryshkov wrote:
>>>> On 22/05/2023 00:23, Marijn Suijten wrote:
>>>>> The SOFEF03-M Display-IC paired with an unknown panel in the Sony Xperia
>>>>> 5 II always uses Display Stream Compression 1.1 and features a 60hz and
>>>>> 120hz refresh-rate mode.
>>>>>
>>>>> Co-developed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>>>>
>>>> Konrad's S-o-b is also required then
>>
>> I am unsure what to include here, since Konrad originally "authored" the
>> commit but I believe it was nothing more than a completely broken and
>> unusable driver spit out by "The mdss panel generator".  This needed
>> enough rewriting that I don't feel like giving it much credit ;)
> Might have been. I won't be mad if you drop this!

I'd say, either add S-o-B, or drop C-D-B. The Co-developed-by should 
always come with the Signed-of-by, otherwise one can not be sure that 
the co-developer didn't copy-paste some super-proprietary stolen code.

> 
> Konrad
>>
>>>>
>>>>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>


-- 
With best wishes
Dmitry


WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Neil Armstrong <neil.armstrong@linaro.org>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Jami Kettunen <jami.kettunen@somainline.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Andy Gross <agross@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Caleb Connolly <caleb@connolly.tech>,
	Rob Herring <robh+dt@kernel.org>,
	Martin Botka <martin.botka@somainline.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@somainline.org>,
	Jessica Zhang <quic_jesszhan@quicinc.com>,
	Kuogee Hsieh <quic_khsieh@quicinc.com>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH RFC 08/10] drm/panel/samsung-sofef03: Add panel driver for Sony Xperia 5 II
Date: Tue, 30 May 2023 01:22:54 +0300	[thread overview]
Message-ID: <3839853f-eca7-5ff2-db90-51c014baff06@linaro.org> (raw)
In-Reply-To: <80372e51-e72f-e70e-c205-8bd79ad57515@linaro.org>

On 30/05/2023 00:29, Konrad Dybcio wrote:
> 
> 
> On 29.05.2023 23:21, Marijn Suijten wrote:
>> On 2023-05-22 11:08:12, Neil Armstrong wrote:
>>> On 22/05/2023 03:23, Dmitry Baryshkov wrote:
>>>> On 22/05/2023 00:23, Marijn Suijten wrote:
>>>>> The SOFEF03-M Display-IC paired with an unknown panel in the Sony Xperia
>>>>> 5 II always uses Display Stream Compression 1.1 and features a 60hz and
>>>>> 120hz refresh-rate mode.
>>>>>
>>>>> Co-developed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>>>>
>>>> Konrad's S-o-b is also required then
>>
>> I am unsure what to include here, since Konrad originally "authored" the
>> commit but I believe it was nothing more than a completely broken and
>> unusable driver spit out by "The mdss panel generator".  This needed
>> enough rewriting that I don't feel like giving it much credit ;)
> Might have been. I won't be mad if you drop this!

I'd say, either add S-o-B, or drop C-D-B. The Co-developed-by should 
always come with the Signed-of-by, otherwise one can not be sure that 
the co-developer didn't copy-paste some super-proprietary stolen code.

> 
> Konrad
>>
>>>>
>>>>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>


-- 
With best wishes
Dmitry


  reply	other threads:[~2023-05-29 22:23 UTC|newest]

Thread overview: 146+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-21 21:23 [PATCH RFC 00/10] drm/panel: Drivers for four Sony CMD-mode (and DSC) panels Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 01/10] drm/panel: Clean up SOFEF00 config dependencies Marijn Suijten
2023-05-21 21:23   ` Marijn Suijten
2023-05-22  9:01   ` Neil Armstrong
2023-05-22  9:01     ` Neil Armstrong
2023-05-28 22:00   ` Caleb Connolly
2023-05-28 22:00     ` Caleb Connolly
2023-05-21 21:23 ` [PATCH RFC 02/10] dt-bindings: display: panel: Describe Sony Xperia XZ3's LGD panel Marijn Suijten
2023-05-21 21:23   ` Marijn Suijten
2023-05-22  0:10   ` Dmitry Baryshkov
2023-05-22  0:10     ` Dmitry Baryshkov
2023-05-21 21:23 ` [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3 Marijn Suijten
2023-05-21 21:23   ` Marijn Suijten
2023-05-22  1:16   ` Dmitry Baryshkov
2023-05-22  1:16     ` Dmitry Baryshkov
2023-05-22  9:04     ` Neil Armstrong
2023-05-22  9:04       ` Neil Armstrong
2023-05-22 12:58       ` Dmitry Baryshkov
2023-05-22 12:58         ` Dmitry Baryshkov
2023-05-29 21:07         ` Marijn Suijten
2023-05-29 21:07           ` Marijn Suijten
2023-05-29 22:18           ` Dmitry Baryshkov
2023-05-29 22:18             ` Dmitry Baryshkov
2023-05-29 22:37             ` Marijn Suijten
2023-05-29 22:37               ` Marijn Suijten
2023-05-29 22:39               ` Dmitry Baryshkov
2023-05-29 22:39                 ` Dmitry Baryshkov
2023-05-30  8:27                 ` Marijn Suijten
2023-05-30  8:27                   ` Marijn Suijten
2023-05-30 11:11                   ` Dmitry Baryshkov
2023-05-30 11:11                     ` Dmitry Baryshkov
2023-05-30 18:19                     ` Marijn Suijten
2023-05-30 18:19                       ` Marijn Suijten
2023-05-30 17:54             ` Abhinav Kumar
2023-05-30 17:54               ` Abhinav Kumar
2023-05-30 18:13               ` Marijn Suijten
2023-05-30 18:13                 ` Marijn Suijten
2023-05-30 23:16                 ` Dmitry Baryshkov
2023-05-30 23:16                   ` Dmitry Baryshkov
2023-05-29 21:11     ` Marijn Suijten
2023-05-29 21:11       ` Marijn Suijten
2023-05-29 22:17       ` Dmitry Baryshkov
2023-05-29 22:17         ` Dmitry Baryshkov
2023-05-29 22:36       ` Dmitry Baryshkov
2023-05-29 22:36         ` Dmitry Baryshkov
2023-05-30  7:24       ` Neil Armstrong
2023-05-30  7:24         ` Neil Armstrong
2023-05-30  8:41         ` Marijn Suijten
2023-05-30  8:41           ` Marijn Suijten
2023-05-30  9:29           ` Konrad Dybcio
2023-05-30  9:29             ` Konrad Dybcio
2023-05-30 11:44         ` RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3) Dmitry Baryshkov
2023-05-30 11:44           ` Dmitry Baryshkov
2023-05-30 12:15           ` AngeloGioacchino Del Regno
2023-05-30 12:15             ` AngeloGioacchino Del Regno
2023-05-30 12:36             ` Dmitry Baryshkov
2023-05-30 12:36               ` Dmitry Baryshkov
2023-05-30 15:44               ` Neil Armstrong
2023-05-30 15:44                 ` Neil Armstrong
2023-05-31  8:02                 ` AngeloGioacchino Del Regno
2023-05-31  8:02                   ` AngeloGioacchino Del Regno
2023-07-05 12:04               ` Maxime Ripard
2023-07-05 12:04                 ` Maxime Ripard
2023-07-05 13:05                 ` Neil Armstrong
2023-07-05 13:05                   ` Neil Armstrong
2023-07-05 13:29                   ` Maxime Ripard
2023-07-05 13:29                     ` Maxime Ripard
2023-07-05 13:37                     ` Dmitry Baryshkov
2023-07-05 13:37                       ` Dmitry Baryshkov
2023-07-05 14:24                       ` Maxime Ripard
2023-07-05 14:24                         ` Maxime Ripard
2023-07-05 15:20                         ` Dmitry Baryshkov
2023-07-05 15:20                           ` Dmitry Baryshkov
2023-07-05 16:53                           ` Maxime Ripard
2023-07-05 16:53                             ` Maxime Ripard
2023-07-05 20:09                             ` Dmitry Baryshkov
2023-07-05 20:09                               ` Dmitry Baryshkov
2023-07-06  7:24                               ` Maxime Ripard
2023-07-06  7:24                                 ` Maxime Ripard
2023-07-06  7:33                                 ` Neil Armstrong
2023-07-06  7:33                                   ` Neil Armstrong
2023-07-06  7:59                                   ` Maxime Ripard
2023-07-06  7:59                                     ` Maxime Ripard
2023-07-06  8:03                                     ` Neil Armstrong
2023-07-06  8:03                                       ` Neil Armstrong
2023-07-05 15:58                         ` Neil Armstrong
2023-07-05 15:58                           ` Neil Armstrong
2023-05-21 21:23 ` [PATCH RFC 04/10] arm64: dts: qcom: sdm845-akatsuki: Configure OLED panel Marijn Suijten
2023-05-21 21:23   ` Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 05/10] dt-bindings: display: panel: Describe Samsung SOFEF01-M Display-IC Marijn Suijten
2023-05-21 21:23   ` Marijn Suijten
2023-05-21 22:23   ` Rob Herring
2023-05-21 22:23     ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 06/10] drm/panel/samsung-sofef01: Add panel driver for Sony Xperia 5 / 10 II Marijn Suijten
2023-05-21 21:23   ` Marijn Suijten
2023-05-22  1:19   ` Dmitry Baryshkov
2023-05-22  1:19     ` Dmitry Baryshkov
2023-05-22 16:30     ` Konrad Dybcio
2023-05-22 16:30       ` Konrad Dybcio
2023-05-22 22:38       ` Marijn Suijten
2023-05-22 22:38         ` Marijn Suijten
2023-05-22 22:32     ` Marijn Suijten
2023-05-22 22:32       ` Marijn Suijten
2023-05-22 22:56       ` Dmitry Baryshkov
2023-05-22 22:56         ` Dmitry Baryshkov
2023-05-29 20:58         ` Marijn Suijten
2023-05-29 20:58           ` Marijn Suijten
2023-05-29 22:20           ` Dmitry Baryshkov
2023-05-29 22:20             ` Dmitry Baryshkov
2023-05-29 22:35             ` Marijn Suijten
2023-05-29 22:35               ` Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 07/10] dt-bindings: display: panel: Describe Samsung SOFEF03-M Display-IC Marijn Suijten
2023-05-21 21:23   ` Marijn Suijten
2023-06-08 19:43   ` Rob Herring
2023-06-08 19:43     ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 08/10] drm/panel/samsung-sofef03: Add panel driver for Sony Xperia 5 II Marijn Suijten
2023-05-21 21:23   ` Marijn Suijten
2023-05-22  1:23   ` Dmitry Baryshkov
2023-05-22  1:23     ` Dmitry Baryshkov
2023-05-22  9:08     ` Neil Armstrong
2023-05-22  9:08       ` Neil Armstrong
2023-05-22 12:57       ` Dmitry Baryshkov
2023-05-22 12:57         ` Dmitry Baryshkov
2023-05-29 21:21       ` Marijn Suijten
2023-05-29 21:21         ` Marijn Suijten
2023-05-29 21:29         ` Konrad Dybcio
2023-05-29 21:29           ` Konrad Dybcio
2023-05-29 22:22           ` Dmitry Baryshkov [this message]
2023-05-29 22:22             ` Dmitry Baryshkov
2023-05-29 22:33             ` Marijn Suijten
2023-05-29 22:33               ` Marijn Suijten
2023-05-22 16:31     ` Konrad Dybcio
2023-05-22 16:31       ` Konrad Dybcio
2023-05-21 21:23 ` [PATCH RFC 09/10] dt-bindings: display: panel: Describe Sony Xperia 1 display Marijn Suijten
2023-05-21 21:23   ` Marijn Suijten
2023-05-21 22:23   ` Rob Herring
2023-05-21 22:23     ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 10/10] drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1 Marijn Suijten
2023-05-21 21:23   ` Marijn Suijten
2023-06-28  9:22   ` Linus Walleij
2023-06-28  9:22     ` Linus Walleij
2023-06-28 14:20     ` Marijn Suijten
2023-06-28 14:20       ` Marijn Suijten
2023-06-28 19:18       ` Linus Walleij
2023-06-28 19:18         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3839853f-eca7-5ff2-db90-51c014baff06@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=caleb@connolly.tech \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jami.kettunen@somainline.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=martin.botka@somainline.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_jesszhan@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.