From: Linus Walleij <linus.walleij@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Caleb Connolly <caleb@connolly.tech>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
devicetree@vger.kernel.org,
Jami Kettunen <jami.kettunen@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Martin Botka <martin.botka@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Kuogee Hsieh <quic_khsieh@quicinc.com>
Subject: Re: [PATCH RFC 10/10] drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1
Date: Wed, 28 Jun 2023 21:18:38 +0200 [thread overview]
Message-ID: <CACRpkdZSNzeh8v=HW6948dJ8j0xNMhgrAz2+CpvQX=meGwPkyg@mail.gmail.com> (raw)
In-Reply-To: <a7h7hudmgg3ldb334o2knga7dqilvp47tfd46se4szpri2xi35@lxg5i5igjfmj>
On Wed, Jun 28, 2023 at 4:20 PM Marijn Suijten
<marijn.suijten@somainline.org> wrote:
> But for now we might already create a step-up version of that by having
> a "Samsung panel driver library" to deduplicate generic commands, which
> drivers can freely call into?
Yeah something like that is likely what we want.
> On the other hand of the spectrum we currently have 4 downstream panels
> for Sony devices that all declare to be using the sofef01 controller,
> but with vastly different command sets. And even if we "accidentally"
> send the wrong set for the wrong device, the panel works anyway with no
> noticeable color shifts or otherwise...
Yeah that is typically the case :/
We should try to group the similar code together and expect that sooner
or later we will figure out what display controller(s) it is and name it after
that rather than after the panel (which I define as the combination of
a display controller and an actual panel).
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: dri-devel@lists.freedesktop.org,
Caleb Connolly <caleb@connolly.tech>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Sam Ravnborg <sam@ravnborg.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Andy Gross <agross@kernel.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Herring <robh+dt@kernel.org>,
Martin Botka <martin.botka@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht,
Neil Armstrong <neil.armstrong@linaro.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH RFC 10/10] drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1
Date: Wed, 28 Jun 2023 21:18:38 +0200 [thread overview]
Message-ID: <CACRpkdZSNzeh8v=HW6948dJ8j0xNMhgrAz2+CpvQX=meGwPkyg@mail.gmail.com> (raw)
In-Reply-To: <a7h7hudmgg3ldb334o2knga7dqilvp47tfd46se4szpri2xi35@lxg5i5igjfmj>
On Wed, Jun 28, 2023 at 4:20 PM Marijn Suijten
<marijn.suijten@somainline.org> wrote:
> But for now we might already create a step-up version of that by having
> a "Samsung panel driver library" to deduplicate generic commands, which
> drivers can freely call into?
Yeah something like that is likely what we want.
> On the other hand of the spectrum we currently have 4 downstream panels
> for Sony devices that all declare to be using the sofef01 controller,
> but with vastly different command sets. And even if we "accidentally"
> send the wrong set for the wrong device, the panel works anyway with no
> noticeable color shifts or otherwise...
Yeah that is typically the case :/
We should try to group the similar code together and expect that sooner
or later we will figure out what display controller(s) it is and name it after
that rather than after the panel (which I define as the combination of
a display controller and an actual panel).
Yours,
Linus Walleij
next prev parent reply other threads:[~2023-06-28 19:19 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 21:23 [PATCH RFC 00/10] drm/panel: Drivers for four Sony CMD-mode (and DSC) panels Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 01/10] drm/panel: Clean up SOFEF00 config dependencies Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-05-22 9:01 ` Neil Armstrong
2023-05-22 9:01 ` Neil Armstrong
2023-05-28 22:00 ` Caleb Connolly
2023-05-28 22:00 ` Caleb Connolly
2023-05-21 21:23 ` [PATCH RFC 02/10] dt-bindings: display: panel: Describe Sony Xperia XZ3's LGD panel Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-05-22 0:10 ` Dmitry Baryshkov
2023-05-22 0:10 ` Dmitry Baryshkov
2023-05-21 21:23 ` [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3 Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-05-22 1:16 ` Dmitry Baryshkov
2023-05-22 1:16 ` Dmitry Baryshkov
2023-05-22 9:04 ` Neil Armstrong
2023-05-22 9:04 ` Neil Armstrong
2023-05-22 12:58 ` Dmitry Baryshkov
2023-05-22 12:58 ` Dmitry Baryshkov
2023-05-29 21:07 ` Marijn Suijten
2023-05-29 21:07 ` Marijn Suijten
2023-05-29 22:18 ` Dmitry Baryshkov
2023-05-29 22:18 ` Dmitry Baryshkov
2023-05-29 22:37 ` Marijn Suijten
2023-05-29 22:37 ` Marijn Suijten
2023-05-29 22:39 ` Dmitry Baryshkov
2023-05-29 22:39 ` Dmitry Baryshkov
2023-05-30 8:27 ` Marijn Suijten
2023-05-30 8:27 ` Marijn Suijten
2023-05-30 11:11 ` Dmitry Baryshkov
2023-05-30 11:11 ` Dmitry Baryshkov
2023-05-30 18:19 ` Marijn Suijten
2023-05-30 18:19 ` Marijn Suijten
2023-05-30 17:54 ` Abhinav Kumar
2023-05-30 17:54 ` Abhinav Kumar
2023-05-30 18:13 ` Marijn Suijten
2023-05-30 18:13 ` Marijn Suijten
2023-05-30 23:16 ` Dmitry Baryshkov
2023-05-30 23:16 ` Dmitry Baryshkov
2023-05-29 21:11 ` Marijn Suijten
2023-05-29 21:11 ` Marijn Suijten
2023-05-29 22:17 ` Dmitry Baryshkov
2023-05-29 22:17 ` Dmitry Baryshkov
2023-05-29 22:36 ` Dmitry Baryshkov
2023-05-29 22:36 ` Dmitry Baryshkov
2023-05-30 7:24 ` Neil Armstrong
2023-05-30 7:24 ` Neil Armstrong
2023-05-30 8:41 ` Marijn Suijten
2023-05-30 8:41 ` Marijn Suijten
2023-05-30 9:29 ` Konrad Dybcio
2023-05-30 9:29 ` Konrad Dybcio
2023-05-30 11:44 ` RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3) Dmitry Baryshkov
2023-05-30 11:44 ` Dmitry Baryshkov
2023-05-30 12:15 ` AngeloGioacchino Del Regno
2023-05-30 12:15 ` AngeloGioacchino Del Regno
2023-05-30 12:36 ` Dmitry Baryshkov
2023-05-30 12:36 ` Dmitry Baryshkov
2023-05-30 15:44 ` Neil Armstrong
2023-05-30 15:44 ` Neil Armstrong
2023-05-31 8:02 ` AngeloGioacchino Del Regno
2023-05-31 8:02 ` AngeloGioacchino Del Regno
2023-07-05 12:04 ` Maxime Ripard
2023-07-05 12:04 ` Maxime Ripard
2023-07-05 13:05 ` Neil Armstrong
2023-07-05 13:05 ` Neil Armstrong
2023-07-05 13:29 ` Maxime Ripard
2023-07-05 13:29 ` Maxime Ripard
2023-07-05 13:37 ` Dmitry Baryshkov
2023-07-05 13:37 ` Dmitry Baryshkov
2023-07-05 14:24 ` Maxime Ripard
2023-07-05 14:24 ` Maxime Ripard
2023-07-05 15:20 ` Dmitry Baryshkov
2023-07-05 15:20 ` Dmitry Baryshkov
2023-07-05 16:53 ` Maxime Ripard
2023-07-05 16:53 ` Maxime Ripard
2023-07-05 20:09 ` Dmitry Baryshkov
2023-07-05 20:09 ` Dmitry Baryshkov
2023-07-06 7:24 ` Maxime Ripard
2023-07-06 7:24 ` Maxime Ripard
2023-07-06 7:33 ` Neil Armstrong
2023-07-06 7:33 ` Neil Armstrong
2023-07-06 7:59 ` Maxime Ripard
2023-07-06 7:59 ` Maxime Ripard
2023-07-06 8:03 ` Neil Armstrong
2023-07-06 8:03 ` Neil Armstrong
2023-07-05 15:58 ` Neil Armstrong
2023-07-05 15:58 ` Neil Armstrong
2023-05-21 21:23 ` [PATCH RFC 04/10] arm64: dts: qcom: sdm845-akatsuki: Configure OLED panel Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 05/10] dt-bindings: display: panel: Describe Samsung SOFEF01-M Display-IC Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-05-21 22:23 ` Rob Herring
2023-05-21 22:23 ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 06/10] drm/panel/samsung-sofef01: Add panel driver for Sony Xperia 5 / 10 II Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-05-22 1:19 ` Dmitry Baryshkov
2023-05-22 1:19 ` Dmitry Baryshkov
2023-05-22 16:30 ` Konrad Dybcio
2023-05-22 16:30 ` Konrad Dybcio
2023-05-22 22:38 ` Marijn Suijten
2023-05-22 22:38 ` Marijn Suijten
2023-05-22 22:32 ` Marijn Suijten
2023-05-22 22:32 ` Marijn Suijten
2023-05-22 22:56 ` Dmitry Baryshkov
2023-05-22 22:56 ` Dmitry Baryshkov
2023-05-29 20:58 ` Marijn Suijten
2023-05-29 20:58 ` Marijn Suijten
2023-05-29 22:20 ` Dmitry Baryshkov
2023-05-29 22:20 ` Dmitry Baryshkov
2023-05-29 22:35 ` Marijn Suijten
2023-05-29 22:35 ` Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 07/10] dt-bindings: display: panel: Describe Samsung SOFEF03-M Display-IC Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-06-08 19:43 ` Rob Herring
2023-06-08 19:43 ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 08/10] drm/panel/samsung-sofef03: Add panel driver for Sony Xperia 5 II Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-05-22 1:23 ` Dmitry Baryshkov
2023-05-22 1:23 ` Dmitry Baryshkov
2023-05-22 9:08 ` Neil Armstrong
2023-05-22 9:08 ` Neil Armstrong
2023-05-22 12:57 ` Dmitry Baryshkov
2023-05-22 12:57 ` Dmitry Baryshkov
2023-05-29 21:21 ` Marijn Suijten
2023-05-29 21:21 ` Marijn Suijten
2023-05-29 21:29 ` Konrad Dybcio
2023-05-29 21:29 ` Konrad Dybcio
2023-05-29 22:22 ` Dmitry Baryshkov
2023-05-29 22:22 ` Dmitry Baryshkov
2023-05-29 22:33 ` Marijn Suijten
2023-05-29 22:33 ` Marijn Suijten
2023-05-22 16:31 ` Konrad Dybcio
2023-05-22 16:31 ` Konrad Dybcio
2023-05-21 21:23 ` [PATCH RFC 09/10] dt-bindings: display: panel: Describe Sony Xperia 1 display Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-05-21 22:23 ` Rob Herring
2023-05-21 22:23 ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 10/10] drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1 Marijn Suijten
2023-05-21 21:23 ` Marijn Suijten
2023-06-28 9:22 ` Linus Walleij
2023-06-28 9:22 ` Linus Walleij
2023-06-28 14:20 ` Marijn Suijten
2023-06-28 14:20 ` Marijn Suijten
2023-06-28 19:18 ` Linus Walleij [this message]
2023-06-28 19:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZSNzeh8v=HW6948dJ8j0xNMhgrAz2+CpvQX=meGwPkyg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=caleb@connolly.tech \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.