All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair <alistair@alistair23.me>
To: "Guenter Roeck" <linux@roeck-us.net>,
	shawnguo@kernel.org, linux-watchdog@vger.kernel.org,
	s.hauer@pengutronix.de, wim@linux-watchdog.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, kernel@pengutronix.de,
	linux-imx@nxp.com, festevam@gmail.com,
	"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v4] watchdog: imx2_wdg: Allow ping on suspend
Date: Thu, 24 Mar 2022 07:08:53 +1000	[thread overview]
Message-ID: <38779286-d176-4f2e-8908-d82bf8d60f07@www.fastmail.com> (raw)
In-Reply-To: <d6c61a10-e671-3543-5653-ceb3d9ed60cf@roeck-us.net>

On Wed, 23 Mar 2022, at 11:07 PM, Guenter Roeck wrote:
> On 3/23/22 04:57, Alistair Francis wrote:
> > The i.MX watchdog cannot be disabled by software once it has been
> > enabled. This means that it can't be stopped before suspend.
> > 
> > For systems that enter low power mode this is fine, as the watchdog will
> > be automatically stopped by hardware in low power mode. Not all i.MX
> > platforms support low power mode in the mainline kernel. For example the
> > i.MX7D does not enter low power mode and so will be rebooted 2 minutes
> > after entering sleep states.
> > 
> > This patch introduces a device tree property "fsl,ping-during-suspend"
> > that can be used to enable ping on suspend support for these systems.
> > 
> > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> What is the difference to earlier versions ?

Sorry, I should have included a changelog.

I just fixed the spelling of alow/allow in the title

Alistair

> 
> Guenter
> 

WARNING: multiple messages have this Message-ID (diff)
From: Alistair <alistair@alistair23.me>
To: "Guenter Roeck" <linux@roeck-us.net>,
	shawnguo@kernel.org, linux-watchdog@vger.kernel.org,
	s.hauer@pengutronix.de, wim@linux-watchdog.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, kernel@pengutronix.de,
	linux-imx@nxp.com, festevam@gmail.com,
	"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v4] watchdog: imx2_wdg: Allow ping on suspend
Date: Thu, 24 Mar 2022 07:08:53 +1000	[thread overview]
Message-ID: <38779286-d176-4f2e-8908-d82bf8d60f07@www.fastmail.com> (raw)
In-Reply-To: <d6c61a10-e671-3543-5653-ceb3d9ed60cf@roeck-us.net>

On Wed, 23 Mar 2022, at 11:07 PM, Guenter Roeck wrote:
> On 3/23/22 04:57, Alistair Francis wrote:
> > The i.MX watchdog cannot be disabled by software once it has been
> > enabled. This means that it can't be stopped before suspend.
> > 
> > For systems that enter low power mode this is fine, as the watchdog will
> > be automatically stopped by hardware in low power mode. Not all i.MX
> > platforms support low power mode in the mainline kernel. For example the
> > i.MX7D does not enter low power mode and so will be rebooted 2 minutes
> > after entering sleep states.
> > 
> > This patch introduces a device tree property "fsl,ping-during-suspend"
> > that can be used to enable ping on suspend support for these systems.
> > 
> > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> What is the difference to earlier versions ?

Sorry, I should have included a changelog.

I just fixed the spelling of alow/allow in the title

Alistair

> 
> Guenter
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-23 21:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23 11:57 [PATCH v4] watchdog: imx2_wdg: Allow ping on suspend Alistair Francis
2022-03-23 11:57 ` Alistair Francis
2022-03-23 13:07 ` Guenter Roeck
2022-03-23 13:07   ` Guenter Roeck
2022-03-23 21:08   ` Alistair [this message]
2022-03-23 21:08     ` Alistair
2022-03-28  8:01 ` Sascha Hauer
2022-03-28  8:01   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38779286-d176-4f2e-8908-d82bf8d60f07@www.fastmail.com \
    --to=alistair@alistair23.me \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.