All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Suniel Mahesh <sunil@amarulasolutions.com>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-amarula <linux-amarula@amarulasolutions.com>
Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding
Date: Thu, 23 Jul 2020 01:13:39 +0200	[thread overview]
Message-ID: <3893924.cuH9TW0V3R@phil> (raw)
In-Reply-To: <20200722190949.215656-3-jagan@amarulasolutions.com>

Hi Jagan,

Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki:
> Add dt-bindings for ROCKPi 4B which is similar to 4A with
> additional AP6256 Wifi/BT, PoE.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - new patch
> 
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 36057c9e4b83..7250adb43d24 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -448,6 +448,12 @@ properties:
>            - const: radxa,rockpi4a
>            - const: rockchip,rk3399
>  
> +      - description: Radxa ROCK Pi 4B
> +        items:
> +          - const: radxa,rockpi4
> +          - const: radxa,rockpi4b
> +          - const: rockchip,rk3399
> +

Please do all RockPi4 variants into one entry, so we want something like:

      - description: Radxa ROCK Pi 4
        items:
          - enum:
              - radxa,rockpi4a
              - radxa,rockpi4b
              - radxa,rockpi4c
          - const: radxa,rockpi4
          - const: rockchip,rk3399

And as the {a,b,c} variant is the most specific it also should be the
first entry, not the second.


Heiko

>        - description: Radxa ROCK Pi N8
>          items:
>            - const: radxa,rockpi-n8
> 





WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Suniel Mahesh
	<sunil-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
	Michael Trimarchi
	<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-amarula
	<linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding
Date: Thu, 23 Jul 2020 01:13:39 +0200	[thread overview]
Message-ID: <3893924.cuH9TW0V3R@phil> (raw)
In-Reply-To: <20200722190949.215656-3-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>

Hi Jagan,

Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki:
> Add dt-bindings for ROCKPi 4B which is similar to 4A with
> additional AP6256 Wifi/BT, PoE.
> 
> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> ---
> Changes for v2:
> - new patch
> 
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 36057c9e4b83..7250adb43d24 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -448,6 +448,12 @@ properties:
>            - const: radxa,rockpi4a
>            - const: rockchip,rk3399
>  
> +      - description: Radxa ROCK Pi 4B
> +        items:
> +          - const: radxa,rockpi4
> +          - const: radxa,rockpi4b
> +          - const: rockchip,rk3399
> +

Please do all RockPi4 variants into one entry, so we want something like:

      - description: Radxa ROCK Pi 4
        items:
          - enum:
              - radxa,rockpi4a
              - radxa,rockpi4b
              - radxa,rockpi4c
          - const: radxa,rockpi4
          - const: rockchip,rk3399

And as the {a,b,c} variant is the most specific it also should be the
first entry, not the second.


Heiko

>        - description: Radxa ROCK Pi N8
>          items:
>            - const: radxa,rockpi-n8
> 

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Suniel Mahesh <sunil@amarulasolutions.com>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding
Date: Thu, 23 Jul 2020 01:13:39 +0200	[thread overview]
Message-ID: <3893924.cuH9TW0V3R@phil> (raw)
In-Reply-To: <20200722190949.215656-3-jagan@amarulasolutions.com>

Hi Jagan,

Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki:
> Add dt-bindings for ROCKPi 4B which is similar to 4A with
> additional AP6256 Wifi/BT, PoE.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - new patch
> 
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 36057c9e4b83..7250adb43d24 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -448,6 +448,12 @@ properties:
>            - const: radxa,rockpi4a
>            - const: rockchip,rk3399
>  
> +      - description: Radxa ROCK Pi 4B
> +        items:
> +          - const: radxa,rockpi4
> +          - const: radxa,rockpi4b
> +          - const: rockchip,rk3399
> +

Please do all RockPi4 variants into one entry, so we want something like:

      - description: Radxa ROCK Pi 4
        items:
          - enum:
              - radxa,rockpi4a
              - radxa,rockpi4b
              - radxa,rockpi4c
          - const: radxa,rockpi4
          - const: rockchip,rk3399

And as the {a,b,c} variant is the most specific it also should be the
first entry, not the second.


Heiko

>        - description: Radxa ROCK Pi N8
>          items:
>            - const: radxa,rockpi-n8
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-22 23:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22 19:09 [PATCH v2 1/6] dt-bindings: arm: rockchip: Update ROCKPi 4 with 4A binding Jagan Teki
2020-07-22 19:09 ` Jagan Teki
2020-07-22 19:09 ` [PATCH v2 2/6] arm64: dts: rockchip: Mark rock-pi-4 as rock-pi-4a dts Jagan Teki
2020-07-22 19:09   ` Jagan Teki
2020-07-22 19:09 ` [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding Jagan Teki
2020-07-22 19:09   ` Jagan Teki
2020-07-22 19:09   ` Jagan Teki
2020-07-22 23:13   ` Heiko Stuebner [this message]
2020-07-22 23:13     ` Heiko Stuebner
2020-07-22 23:13     ` Heiko Stuebner
2020-07-23  6:34     ` Jagan Teki
2020-07-23  6:34       ` Jagan Teki
2020-07-23  6:34       ` Jagan Teki
2020-07-23  8:27       ` Heiko Stübner
2020-07-23  8:27         ` Heiko Stübner
2020-07-23  8:27         ` Heiko Stübner
2020-07-22 19:09 ` [PATCH v2 4/6] arm64: dts: rockchip: Add Radxa ROCK Pi 4B support Jagan Teki
2020-07-22 19:09   ` Jagan Teki
2020-07-22 19:09   ` Jagan Teki
2020-07-22 19:09 ` [PATCH v2 5/6] dt-bindings: arm: rockchip: Add ROCKPi 4C binding Jagan Teki
2020-07-22 19:09   ` Jagan Teki
2020-07-22 19:09   ` Jagan Teki
2020-07-22 19:09 ` [PATCH v2 6/6] arm64: dts: rockchip: Add Radxa ROCK Pi 4C support Jagan Teki
2020-07-22 19:09   ` Jagan Teki
2020-07-22 19:09   ` Jagan Teki
2020-07-23 20:22 ` [PATCH v2 1/6] dt-bindings: arm: rockchip: Update ROCKPi 4 with 4A binding Rob Herring
2020-07-23 20:22   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3893924.cuH9TW0V3R@phil \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jagan@amarulasolutions.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michael@amarulasolutions.com \
    --cc=robh+dt@kernel.org \
    --cc=sunil@amarulasolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.