* [PATCH 1/1] drm/msm/dp: remove unused local variable 'hpd'
@ 2021-04-07 8:23 ` Zhen Lei
0 siblings, 0 replies; 4+ messages in thread
From: Zhen Lei @ 2021-04-07 8:23 UTC (permalink / raw)
To: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, linux-arm-msm,
dri-devel, freedreno, linux-kernel
Cc: Zhen Lei
Fixes the following W=1 kernel build warning:
drivers/gpu/drm/msm/dp/dp_display.c: In function ‘dp_display_usbpd_attention_cb’:
drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ set but not used [-Wunused-but-set-variable]
Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at irq_hpd")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/gpu/drm/msm/dp/dp_display.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 5a39da6e1eaf277..31bf2a40a9eb2c9 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -493,7 +493,6 @@ static int dp_display_usbpd_attention_cb(struct device *dev)
int rc = 0;
u32 sink_request;
struct dp_display_private *dp;
- struct dp_usbpd *hpd;
if (!dev) {
DRM_ERROR("invalid dev\n");
@@ -507,8 +506,6 @@ static int dp_display_usbpd_attention_cb(struct device *dev)
return -ENODEV;
}
- hpd = dp->usbpd;
-
/* check for any test request issued by sink */
rc = dp_link_process_request(dp->link);
if (!rc) {
--
1.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 1/1] drm/msm/dp: remove unused local variable 'hpd'
@ 2021-04-07 8:23 ` Zhen Lei
0 siblings, 0 replies; 4+ messages in thread
From: Zhen Lei @ 2021-04-07 8:23 UTC (permalink / raw)
To: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, linux-arm-msm,
dri-devel, freedreno, linux-kernel
Cc: Zhen Lei
Fixes the following W=1 kernel build warning:
drivers/gpu/drm/msm/dp/dp_display.c: In function ‘dp_display_usbpd_attention_cb’:
drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ set but not used [-Wunused-but-set-variable]
Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at irq_hpd")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/gpu/drm/msm/dp/dp_display.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 5a39da6e1eaf277..31bf2a40a9eb2c9 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -493,7 +493,6 @@ static int dp_display_usbpd_attention_cb(struct device *dev)
int rc = 0;
u32 sink_request;
struct dp_display_private *dp;
- struct dp_usbpd *hpd;
if (!dev) {
DRM_ERROR("invalid dev\n");
@@ -507,8 +506,6 @@ static int dp_display_usbpd_attention_cb(struct device *dev)
return -ENODEV;
}
- hpd = dp->usbpd;
-
/* check for any test request issued by sink */
rc = dp_link_process_request(dp->link);
if (!rc) {
--
1.8.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] drm/msm/dp: remove unused local variable 'hpd'
2021-04-07 8:23 ` Zhen Lei
@ 2021-04-07 17:51 ` abhinavk
-1 siblings, 0 replies; 4+ messages in thread
From: abhinavk @ 2021-04-07 17:51 UTC (permalink / raw)
To: Zhen Lei
Cc: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, linux-arm-msm,
dri-devel, freedreno, linux-kernel
On 2021-04-07 01:23, Zhen Lei wrote:
> Fixes the following W=1 kernel build warning:
>
> drivers/gpu/drm/msm/dp/dp_display.c: In function
> ‘dp_display_usbpd_attention_cb’:
> drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’
> set but not used [-Wunused-but-set-variable]
>
> Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at
> irq_hpd")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> b/drivers/gpu/drm/msm/dp/dp_display.c
> index 5a39da6e1eaf277..31bf2a40a9eb2c9 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -493,7 +493,6 @@ static int dp_display_usbpd_attention_cb(struct
> device *dev)
> int rc = 0;
> u32 sink_request;
> struct dp_display_private *dp;
> - struct dp_usbpd *hpd;
>
> if (!dev) {
> DRM_ERROR("invalid dev\n");
> @@ -507,8 +506,6 @@ static int dp_display_usbpd_attention_cb(struct
> device *dev)
> return -ENODEV;
> }
>
> - hpd = dp->usbpd;
> -
> /* check for any test request issued by sink */
> rc = dp_link_process_request(dp->link);
> if (!rc) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] drm/msm/dp: remove unused local variable 'hpd'
@ 2021-04-07 17:51 ` abhinavk
0 siblings, 0 replies; 4+ messages in thread
From: abhinavk @ 2021-04-07 17:51 UTC (permalink / raw)
To: Zhen Lei
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Sean Paul
On 2021-04-07 01:23, Zhen Lei wrote:
> Fixes the following W=1 kernel build warning:
>
> drivers/gpu/drm/msm/dp/dp_display.c: In function
> ‘dp_display_usbpd_attention_cb’:
> drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’
> set but not used [-Wunused-but-set-variable]
>
> Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at
> irq_hpd")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> b/drivers/gpu/drm/msm/dp/dp_display.c
> index 5a39da6e1eaf277..31bf2a40a9eb2c9 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -493,7 +493,6 @@ static int dp_display_usbpd_attention_cb(struct
> device *dev)
> int rc = 0;
> u32 sink_request;
> struct dp_display_private *dp;
> - struct dp_usbpd *hpd;
>
> if (!dev) {
> DRM_ERROR("invalid dev\n");
> @@ -507,8 +506,6 @@ static int dp_display_usbpd_attention_cb(struct
> device *dev)
> return -ENODEV;
> }
>
> - hpd = dp->usbpd;
> -
> /* check for any test request issued by sink */
> rc = dp_link_process_request(dp->link);
> if (!rc) {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-07 17:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 8:23 [PATCH 1/1] drm/msm/dp: remove unused local variable 'hpd' Zhen Lei
2021-04-07 8:23 ` Zhen Lei
2021-04-07 17:51 ` abhinavk
2021-04-07 17:51 ` abhinavk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.