All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johnson Wang <johnson.wang@mediatek.com>,
	cw00.choi@samsung.com, krzk+dt@kernel.org, robh+dt@kernel.org,
	kyungmin.park@samsung.com
Cc: khilman@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, jia-wei.chang@mediatek.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 1/2] dt-bindings: devfreq: mediatek: Add mtk cci devfreq dt-bindings
Date: Tue, 12 Apr 2022 11:17:06 +0200	[thread overview]
Message-ID: <39152c86-ca11-2792-6b25-ae55ffb47b09@linaro.org> (raw)
In-Reply-To: <fe7d2b878c18a42ff36ebd9911ecb562fe29c953.camel@mediatek.com>

On 11/04/2022 14:10, Johnson Wang wrote:
>> Also please put it in the "interconnect" directory.
>>
> 
> I don't really know about "interconnect".
> However, it looks like a Linux framework about data transfer and "NoC".
> 
> While this cci driver is more like a power managment which is
> responsible for adjusting voltages and frequencies.
> In my opinion, "devfreq" should be more suitable.
> 
> Please correct me if my understanding is wrong.

devfreq is a Linux mechanism, not a real device/hardware. We try to put
the bindings in directories/subsystems matching the hardware, therefore
devfreq is not appropriate.

Whether interconnect - or other subsystem - is appropriate, I am not
sure. To me this looks exactly like bus bandwidth management and you
even use "interconnect" in several places. So interconnect matches.

Best regards,
Krzysztof

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johnson Wang <johnson.wang@mediatek.com>,
	cw00.choi@samsung.com, krzk+dt@kernel.org, robh+dt@kernel.org,
	kyungmin.park@samsung.com
Cc: khilman@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, jia-wei.chang@mediatek.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 1/2] dt-bindings: devfreq: mediatek: Add mtk cci devfreq dt-bindings
Date: Tue, 12 Apr 2022 11:17:06 +0200	[thread overview]
Message-ID: <39152c86-ca11-2792-6b25-ae55ffb47b09@linaro.org> (raw)
In-Reply-To: <fe7d2b878c18a42ff36ebd9911ecb562fe29c953.camel@mediatek.com>

On 11/04/2022 14:10, Johnson Wang wrote:
>> Also please put it in the "interconnect" directory.
>>
> 
> I don't really know about "interconnect".
> However, it looks like a Linux framework about data transfer and "NoC".
> 
> While this cci driver is more like a power managment which is
> responsible for adjusting voltages and frequencies.
> In my opinion, "devfreq" should be more suitable.
> 
> Please correct me if my understanding is wrong.

devfreq is a Linux mechanism, not a real device/hardware. We try to put
the bindings in directories/subsystems matching the hardware, therefore
devfreq is not appropriate.

Whether interconnect - or other subsystem - is appropriate, I am not
sure. To me this looks exactly like bus bandwidth management and you
even use "interconnect" in several places. So interconnect matches.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johnson Wang <johnson.wang@mediatek.com>,
	cw00.choi@samsung.com, krzk+dt@kernel.org, robh+dt@kernel.org,
	kyungmin.park@samsung.com
Cc: khilman@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, jia-wei.chang@mediatek.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 1/2] dt-bindings: devfreq: mediatek: Add mtk cci devfreq dt-bindings
Date: Tue, 12 Apr 2022 11:17:06 +0200	[thread overview]
Message-ID: <39152c86-ca11-2792-6b25-ae55ffb47b09@linaro.org> (raw)
In-Reply-To: <fe7d2b878c18a42ff36ebd9911ecb562fe29c953.camel@mediatek.com>

On 11/04/2022 14:10, Johnson Wang wrote:
>> Also please put it in the "interconnect" directory.
>>
> 
> I don't really know about "interconnect".
> However, it looks like a Linux framework about data transfer and "NoC".
> 
> While this cci driver is more like a power managment which is
> responsible for adjusting voltages and frequencies.
> In my opinion, "devfreq" should be more suitable.
> 
> Please correct me if my understanding is wrong.

devfreq is a Linux mechanism, not a real device/hardware. We try to put
the bindings in directories/subsystems matching the hardware, therefore
devfreq is not appropriate.

Whether interconnect - or other subsystem - is appropriate, I am not
sure. To me this looks exactly like bus bandwidth management and you
even use "interconnect" in several places. So interconnect matches.

Best regards,
Krzysztof

  reply	other threads:[~2022-04-12  9:17 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  5:21 [PATCH v2 0/2] Introduce MediaTek CCI devfreq driver Johnson Wang
2022-04-08  5:21 ` Johnson Wang
2022-04-08  5:21 ` Johnson Wang
2022-04-08  5:21 ` [PATCH v2 1/2] dt-bindings: devfreq: mediatek: Add mtk cci devfreq dt-bindings Johnson Wang
2022-04-08  5:21   ` Johnson Wang
2022-04-08  5:21   ` Johnson Wang
2022-04-08  8:17   ` Krzysztof Kozlowski
2022-04-08  8:17     ` Krzysztof Kozlowski
2022-04-08  8:17     ` Krzysztof Kozlowski
2022-04-11 12:10     ` Johnson Wang
2022-04-11 12:10       ` Johnson Wang
2022-04-11 12:10       ` Johnson Wang
2022-04-12  9:17       ` Krzysztof Kozlowski [this message]
2022-04-12  9:17         ` Krzysztof Kozlowski
2022-04-12  9:17         ` Krzysztof Kozlowski
2022-04-13 20:54         ` Chanwoo Choi
2022-04-13 20:54           ` Chanwoo Choi
2022-04-13 20:54           ` Chanwoo Choi
2022-04-14 21:55         ` Kevin Hilman
2022-04-14 21:55           ` Kevin Hilman
2022-04-14 21:55           ` Kevin Hilman
2022-04-08  5:21 ` [PATCH v2 2/2] PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver Johnson Wang
2022-04-08  5:21   ` Johnson Wang
2022-04-08  5:21   ` Johnson Wang
2022-04-08  8:21   ` Krzysztof Kozlowski
2022-04-08  8:21     ` Krzysztof Kozlowski
2022-04-08  8:21     ` Krzysztof Kozlowski
2022-04-12  8:39     ` Johnson Wang
2022-04-12  8:39       ` Johnson Wang
2022-04-12  8:39       ` Johnson Wang
2022-04-12  8:51       ` Krzysztof Kozlowski
2022-04-12  8:51         ` Krzysztof Kozlowski
2022-04-12  8:51         ` Krzysztof Kozlowski
2022-04-08 11:51   ` AngeloGioacchino Del Regno
2022-04-08 11:51     ` AngeloGioacchino Del Regno
2022-04-08 11:51     ` AngeloGioacchino Del Regno
2022-04-14  5:19     ` Johnson Wang
2022-04-14  5:19       ` Johnson Wang
2022-04-14  5:19       ` Johnson Wang
2022-04-13 21:43   ` Chanwoo Choi
2022-04-13 21:43     ` Chanwoo Choi
2022-04-13 21:43     ` Chanwoo Choi
2022-04-15 12:46     ` Johnson Wang
2022-04-15 12:46       ` Johnson Wang
2022-04-15 12:46       ` Johnson Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39152c86-ca11-2792-6b25-ae55ffb47b09@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jia-wei.chang@mediatek.com \
    --cc=johnson.wang@mediatek.com \
    --cc=khilman@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.