All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johnson Wang <johnson.wang@mediatek.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	cw00.choi@samsung.com, krzk+dt@kernel.org, robh+dt@kernel.org,
	kyungmin.park@samsung.com
Cc: khilman@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, jia-wei.chang@mediatek.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 2/2] PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver
Date: Tue, 12 Apr 2022 10:51:29 +0200	[thread overview]
Message-ID: <ad2c72e8-4608-9527-146d-43aa006e1306@linaro.org> (raw)
In-Reply-To: <d900f8181bddb20a56231310d46b9427c40e77b8.camel@mediatek.com>

On 12/04/2022 10:39, Johnson Wang wrote:
>>> +static struct platform_driver mtk_ccifreq_platdrv = {
>>> +	.probe	= mtk_ccifreq_probe,
>>> +	.remove	= mtk_ccifreq_remove,
>>> +	.driver = {
>>> +		.name = "mtk-ccifreq",
>>> +		.of_match_table = of_match_ptr(mtk_ccifreq_machines),
>>
>> You use of_match_ptr() so is it possible to build it without OF? If
>> so,
>> then mtk_ccifreq_machines needs maybe_unused.
>>
> 
> No, this driver must be built with OF due to our CPU arch.

COMPILE_TEST does not use your arch... There are stubs for most of
of-like functions, so !OF should build anyway.

> Should I add some dependencies in Kconfig to ensure OF is enabled?

There are different ways to solve it and it depends on what goal do you
want to achieve? One ways is to use maybe_unused and of_match_ptr. Other
way is to do not use them (skip both).

Best regards,
Krzysztof

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johnson Wang <johnson.wang@mediatek.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	cw00.choi@samsung.com, krzk+dt@kernel.org, robh+dt@kernel.org,
	kyungmin.park@samsung.com
Cc: khilman@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, jia-wei.chang@mediatek.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 2/2] PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver
Date: Tue, 12 Apr 2022 10:51:29 +0200	[thread overview]
Message-ID: <ad2c72e8-4608-9527-146d-43aa006e1306@linaro.org> (raw)
In-Reply-To: <d900f8181bddb20a56231310d46b9427c40e77b8.camel@mediatek.com>

On 12/04/2022 10:39, Johnson Wang wrote:
>>> +static struct platform_driver mtk_ccifreq_platdrv = {
>>> +	.probe	= mtk_ccifreq_probe,
>>> +	.remove	= mtk_ccifreq_remove,
>>> +	.driver = {
>>> +		.name = "mtk-ccifreq",
>>> +		.of_match_table = of_match_ptr(mtk_ccifreq_machines),
>>
>> You use of_match_ptr() so is it possible to build it without OF? If
>> so,
>> then mtk_ccifreq_machines needs maybe_unused.
>>
> 
> No, this driver must be built with OF due to our CPU arch.

COMPILE_TEST does not use your arch... There are stubs for most of
of-like functions, so !OF should build anyway.

> Should I add some dependencies in Kconfig to ensure OF is enabled?

There are different ways to solve it and it depends on what goal do you
want to achieve? One ways is to use maybe_unused and of_match_ptr. Other
way is to do not use them (skip both).

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johnson Wang <johnson.wang@mediatek.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	cw00.choi@samsung.com, krzk+dt@kernel.org, robh+dt@kernel.org,
	kyungmin.park@samsung.com
Cc: khilman@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, jia-wei.chang@mediatek.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 2/2] PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver
Date: Tue, 12 Apr 2022 10:51:29 +0200	[thread overview]
Message-ID: <ad2c72e8-4608-9527-146d-43aa006e1306@linaro.org> (raw)
In-Reply-To: <d900f8181bddb20a56231310d46b9427c40e77b8.camel@mediatek.com>

On 12/04/2022 10:39, Johnson Wang wrote:
>>> +static struct platform_driver mtk_ccifreq_platdrv = {
>>> +	.probe	= mtk_ccifreq_probe,
>>> +	.remove	= mtk_ccifreq_remove,
>>> +	.driver = {
>>> +		.name = "mtk-ccifreq",
>>> +		.of_match_table = of_match_ptr(mtk_ccifreq_machines),
>>
>> You use of_match_ptr() so is it possible to build it without OF? If
>> so,
>> then mtk_ccifreq_machines needs maybe_unused.
>>
> 
> No, this driver must be built with OF due to our CPU arch.

COMPILE_TEST does not use your arch... There are stubs for most of
of-like functions, so !OF should build anyway.

> Should I add some dependencies in Kconfig to ensure OF is enabled?

There are different ways to solve it and it depends on what goal do you
want to achieve? One ways is to use maybe_unused and of_match_ptr. Other
way is to do not use them (skip both).

Best regards,
Krzysztof

  reply	other threads:[~2022-04-12  8:51 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  5:21 [PATCH v2 0/2] Introduce MediaTek CCI devfreq driver Johnson Wang
2022-04-08  5:21 ` Johnson Wang
2022-04-08  5:21 ` Johnson Wang
2022-04-08  5:21 ` [PATCH v2 1/2] dt-bindings: devfreq: mediatek: Add mtk cci devfreq dt-bindings Johnson Wang
2022-04-08  5:21   ` Johnson Wang
2022-04-08  5:21   ` Johnson Wang
2022-04-08  8:17   ` Krzysztof Kozlowski
2022-04-08  8:17     ` Krzysztof Kozlowski
2022-04-08  8:17     ` Krzysztof Kozlowski
2022-04-11 12:10     ` Johnson Wang
2022-04-11 12:10       ` Johnson Wang
2022-04-11 12:10       ` Johnson Wang
2022-04-12  9:17       ` Krzysztof Kozlowski
2022-04-12  9:17         ` Krzysztof Kozlowski
2022-04-12  9:17         ` Krzysztof Kozlowski
2022-04-13 20:54         ` Chanwoo Choi
2022-04-13 20:54           ` Chanwoo Choi
2022-04-13 20:54           ` Chanwoo Choi
2022-04-14 21:55         ` Kevin Hilman
2022-04-14 21:55           ` Kevin Hilman
2022-04-14 21:55           ` Kevin Hilman
2022-04-08  5:21 ` [PATCH v2 2/2] PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver Johnson Wang
2022-04-08  5:21   ` Johnson Wang
2022-04-08  5:21   ` Johnson Wang
2022-04-08  8:21   ` Krzysztof Kozlowski
2022-04-08  8:21     ` Krzysztof Kozlowski
2022-04-08  8:21     ` Krzysztof Kozlowski
2022-04-12  8:39     ` Johnson Wang
2022-04-12  8:39       ` Johnson Wang
2022-04-12  8:39       ` Johnson Wang
2022-04-12  8:51       ` Krzysztof Kozlowski [this message]
2022-04-12  8:51         ` Krzysztof Kozlowski
2022-04-12  8:51         ` Krzysztof Kozlowski
2022-04-08 11:51   ` AngeloGioacchino Del Regno
2022-04-08 11:51     ` AngeloGioacchino Del Regno
2022-04-08 11:51     ` AngeloGioacchino Del Regno
2022-04-14  5:19     ` Johnson Wang
2022-04-14  5:19       ` Johnson Wang
2022-04-14  5:19       ` Johnson Wang
2022-04-13 21:43   ` Chanwoo Choi
2022-04-13 21:43     ` Chanwoo Choi
2022-04-13 21:43     ` Chanwoo Choi
2022-04-15 12:46     ` Johnson Wang
2022-04-15 12:46       ` Johnson Wang
2022-04-15 12:46       ` Johnson Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad2c72e8-4608-9527-146d-43aa006e1306@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jia-wei.chang@mediatek.com \
    --cc=johnson.wang@mediatek.com \
    --cc=khilman@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.