* [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types
@ 2018-08-31 6:32 Prashant Bhole
2018-08-31 8:45 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Prashant Bhole @ 2018-08-31 6:32 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Jakub Kicinski, Quentin Monnet
Cc: Prashant Bhole, netdev
When listed all maps, bpftool currently shows (null) for xskmap.
Added xskmap type in map_type_name[] to show correct type.
Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
---
tools/bpf/bpftool/map.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
index df175bc33c5d..9c55077ca5dd 100644
--- a/tools/bpf/bpftool/map.c
+++ b/tools/bpf/bpftool/map.c
@@ -68,6 +68,7 @@ static const char * const map_type_name[] = {
[BPF_MAP_TYPE_DEVMAP] = "devmap",
[BPF_MAP_TYPE_SOCKMAP] = "sockmap",
[BPF_MAP_TYPE_CPUMAP] = "cpumap",
+ [BPF_MAP_TYPE_XSKMAP] = "xskmap",
[BPF_MAP_TYPE_SOCKHASH] = "sockhash",
[BPF_MAP_TYPE_CGROUP_STORAGE] = "cgroup_storage",
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types
2018-08-31 6:32 [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types Prashant Bhole
@ 2018-08-31 8:45 ` Jakub Kicinski
2018-09-02 20:39 ` Daniel Borkmann
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2018-08-31 8:45 UTC (permalink / raw)
To: Prashant Bhole
Cc: Alexei Starovoitov, Daniel Borkmann, Quentin Monnet, netdev
On Fri, 31 Aug 2018 15:32:42 +0900, Prashant Bhole wrote:
> When listed all maps, bpftool currently shows (null) for xskmap.
> Added xskmap type in map_type_name[] to show correct type.
>
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Thank you! I feel tempted to suggest considering the bpf tree, but
perhaps that's a stretch..
> diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
> index df175bc33c5d..9c55077ca5dd 100644
> --- a/tools/bpf/bpftool/map.c
> +++ b/tools/bpf/bpftool/map.c
> @@ -68,6 +68,7 @@ static const char * const map_type_name[] = {
> [BPF_MAP_TYPE_DEVMAP] = "devmap",
> [BPF_MAP_TYPE_SOCKMAP] = "sockmap",
> [BPF_MAP_TYPE_CPUMAP] = "cpumap",
> + [BPF_MAP_TYPE_XSKMAP] = "xskmap",
> [BPF_MAP_TYPE_SOCKHASH] = "sockhash",
> [BPF_MAP_TYPE_CGROUP_STORAGE] = "cgroup_storage",
> };
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types
2018-08-31 8:45 ` Jakub Kicinski
@ 2018-09-02 20:39 ` Daniel Borkmann
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2018-09-02 20:39 UTC (permalink / raw)
To: Jakub Kicinski, Prashant Bhole; +Cc: Alexei Starovoitov, Quentin Monnet, netdev
On 08/31/2018 10:45 AM, Jakub Kicinski wrote:
> On Fri, 31 Aug 2018 15:32:42 +0900, Prashant Bhole wrote:
>> When listed all maps, bpftool currently shows (null) for xskmap.
>> Added xskmap type in map_type_name[] to show correct type.
>>
>> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
>
> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>
> Thank you! I feel tempted to suggest considering the bpf tree, but
> perhaps that's a stretch..
Applied it to bpf, thanks guys!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-03 0:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-31 6:32 [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types Prashant Bhole
2018-08-31 8:45 ` Jakub Kicinski
2018-09-02 20:39 ` Daniel Borkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.