[PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types

[PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types

[Prashant Bhole]

When listed all maps, bpftool currently shows (null) for xskmap.
Added xskmap type in map_type_name[] to show correct type.

Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
---
 tools/bpf/bpftool/map.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
index df175bc33c5d..9c55077ca5dd 100644
--- a/tools/bpf/bpftool/map.c
+++ b/tools/bpf/bpftool/map.c
@@ -68,6 +68,7 @@ static const char * const map_type_name[] = {
 	[BPF_MAP_TYPE_DEVMAP]		= "devmap",
 	[BPF_MAP_TYPE_SOCKMAP]		= "sockmap",
 	[BPF_MAP_TYPE_CPUMAP]		= "cpumap",
+	[BPF_MAP_TYPE_XSKMAP]           = "xskmap",
 	[BPF_MAP_TYPE_SOCKHASH]		= "sockhash",
 	[BPF_MAP_TYPE_CGROUP_STORAGE]	= "cgroup_storage",
 };
-- 
2.17.1

Re: [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types

[Jakub Kicinski]

On Fri, 31 Aug 2018 15:32:42 +0900, Prashant Bhole wrote:
> When listed all maps, bpftool currently shows (null) for xskmap.
> Added xskmap type in map_type_name[] to show correct type.
> 
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Thank you!  I feel tempted to suggest considering the bpf tree, but
perhaps that's a stretch..

> diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
> index df175bc33c5d..9c55077ca5dd 100644
> --- a/tools/bpf/bpftool/map.c
> +++ b/tools/bpf/bpftool/map.c
> @@ -68,6 +68,7 @@ static const char * const map_type_name[] = {
>  	[BPF_MAP_TYPE_DEVMAP]		= "devmap",
>  	[BPF_MAP_TYPE_SOCKMAP]		= "sockmap",
>  	[BPF_MAP_TYPE_CPUMAP]		= "cpumap",
> +	[BPF_MAP_TYPE_XSKMAP]           = "xskmap",
>  	[BPF_MAP_TYPE_SOCKHASH]		= "sockhash",
>  	[BPF_MAP_TYPE_CGROUP_STORAGE]	= "cgroup_storage",
>  };

Re: [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types

[Daniel Borkmann]

On 08/31/2018 10:45 AM, Jakub Kicinski wrote:
> On Fri, 31 Aug 2018 15:32:42 +0900, Prashant Bhole wrote:
>> When listed all maps, bpftool currently shows (null) for xskmap.
>> Added xskmap type in map_type_name[] to show correct type.
>>
>> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> 
> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> 
> Thank you!  I feel tempted to suggest considering the bpf tree, but
> perhaps that's a stretch..

Applied it to bpf, thanks guys!