* [PATCH] edk2-firmware: Fix configure sed typo
@ 2022-09-15 13:15 Andrei Gherzan
2022-09-15 15:06 ` [meta-arm] " Ross Burton
2022-09-20 22:36 ` Jon Mason
0 siblings, 2 replies; 5+ messages in thread
From: Andrei Gherzan @ 2022-09-15 13:15 UTC (permalink / raw)
To: meta-arm; +Cc: andrei, Andrei Gherzan
From: Andrei Gherzan <andrei.gherzan@huawei.com>
The configure sed operation will not behave as expected because '*'
match misses a preceeding '.'.
Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com>
---
meta-arm/recipes-bsp/uefi/edk2-firmware.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-arm/recipes-bsp/uefi/edk2-firmware.inc b/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
index e0dfa28..c9f1f1d 100644
--- a/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
+++ b/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
@@ -81,7 +81,7 @@ export CLANG38_ARM_PREFIX = "${TARGET_PREFIX}"
TOOLCHAIN:arm = "gcc"
do_configure:prepend() {
- sed -i -e "s#-target ${HOST_ARCH}-linux-gnu*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
+ sed -i -e "s#-target ${HOST_ARCH}-linux-gnu.*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
}
do_compile() {
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [meta-arm] [PATCH] edk2-firmware: Fix configure sed typo
2022-09-15 13:15 [PATCH] edk2-firmware: Fix configure sed typo Andrei Gherzan
@ 2022-09-15 15:06 ` Ross Burton
2022-09-15 18:22 ` Andrei Gherzan
2022-09-20 22:36 ` Jon Mason
1 sibling, 1 reply; 5+ messages in thread
From: Ross Burton @ 2022-09-15 15:06 UTC (permalink / raw)
To: andrei; +Cc: meta-arm, Andrei Gherzan
On 15 Sep 2022, at 14:15, Andrei Gherzan via lists.yoctoproject.org <andrei=gherzan.com@lists.yoctoproject.org> wrote:
> - sed -i -e "s#-target ${HOST_ARCH}-linux-gnu*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
> + sed -i -e "s#-target ${HOST_ARCH}-linux-gnu.*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
Did this break something for you, or is this a line that can actually be removed?
Ross
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [meta-arm] [PATCH] edk2-firmware: Fix configure sed typo
2022-09-15 15:06 ` [meta-arm] " Ross Burton
@ 2022-09-15 18:22 ` Andrei Gherzan
0 siblings, 0 replies; 5+ messages in thread
From: Andrei Gherzan @ 2022-09-15 18:22 UTC (permalink / raw)
To: Ross Burton; +Cc: meta-arm, Andrei Gherzan
Hi,
On Thu, 15 Sep 2022, at 16:06, Ross Burton wrote:
> On 15 Sep 2022, at 14:15, Andrei Gherzan via lists.yoctoproject.org
> <andrei=gherzan.com@lists.yoctoproject.org> wrote:
>> - sed -i -e "s#-target ${HOST_ARCH}-linux-gnu*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
>> + sed -i -e "s#-target ${HOST_ARCH}-linux-gnu.*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
>
> Did this break something for you, or is this a line that can actually
> be removed?
It is definitely still needed. The template includes hardcoded values. It was breaking for me for arm EFI support.
Andrei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] edk2-firmware: Fix configure sed typo
2022-09-15 13:15 [PATCH] edk2-firmware: Fix configure sed typo Andrei Gherzan
2022-09-15 15:06 ` [meta-arm] " Ross Burton
@ 2022-09-20 22:36 ` Jon Mason
2022-09-21 14:49 ` Andrei Gherzan
1 sibling, 1 reply; 5+ messages in thread
From: Jon Mason @ 2022-09-20 22:36 UTC (permalink / raw)
To: meta-arm, Andrei Gherzan; +Cc: Andrei Gherzan
On Thu, 15 Sep 2022 15:15:30 +0200, Andrei Gherzan wrote:
> The configure sed operation will not behave as expected because '*'
> match misses a preceeding '.'.
Applied, thanks!
[1/1] edk2-firmware: Fix configure sed typo
commit: fde0575aeac3b86102d521a55f4a26e6afa623fd
Best regards,
--
Jon Mason <jon.mason@arm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] edk2-firmware: Fix configure sed typo
2022-09-20 22:36 ` Jon Mason
@ 2022-09-21 14:49 ` Andrei Gherzan
0 siblings, 0 replies; 5+ messages in thread
From: Andrei Gherzan @ 2022-09-21 14:49 UTC (permalink / raw)
To: Jon Mason, meta-arm; +Cc: Andrei Gherzan
On Tue, 20 Sep 2022, at 23:36, Jon Mason wrote:
> On Thu, 15 Sep 2022 15:15:30 +0200, Andrei Gherzan wrote:
>> The configure sed operation will not behave as expected because '*'
>> match misses a preceeding '.'.
>
> Applied, thanks!
Awesome. Thanks.
Andrei
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-21 14:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-15 13:15 [PATCH] edk2-firmware: Fix configure sed typo Andrei Gherzan
2022-09-15 15:06 ` [meta-arm] " Ross Burton
2022-09-15 18:22 ` Andrei Gherzan
2022-09-20 22:36 ` Jon Mason
2022-09-21 14:49 ` Andrei Gherzan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.