From: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: daniel.vetter@ffwll.ch, michel@daenzer.net, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, ckoenig.leichtzumerken@gmail.com Subject: Re: [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space Date: Tue, 23 Jun 2020 01:00:02 -0400 [thread overview] Message-ID: <3a365581-0f00-32de-6656-77348dcd0ea2@amd.com> (raw) In-Reply-To: <20200622094502.GB20149@phenom.ffwll.local> On 6/22/20 5:45 AM, Daniel Vetter wrote: > On Sun, Jun 21, 2020 at 02:03:03AM -0400, Andrey Grodzovsky wrote: >> Helper function to be used to invalidate all BOs CPU mappings >> once device is removed. >> >> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com> > This seems to be missing the code to invalidate all the dma-buf mmaps? > > Probably needs more testcases if you're not yet catching this. Or am I > missing something, and we're exchanging the the address space also for > dma-buf? > -Daniel IMHO the device address space includes all user clients having a CPU view of the BO either from direct mapping though drm file or by mapping through imported BO's FD. Andrey > >> --- >> drivers/gpu/drm/ttm/ttm_bo.c | 8 ++++++-- >> include/drm/ttm/ttm_bo_driver.h | 7 +++++++ >> 2 files changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c >> index c5b516f..926a365 100644 >> --- a/drivers/gpu/drm/ttm/ttm_bo.c >> +++ b/drivers/gpu/drm/ttm/ttm_bo.c >> @@ -1750,10 +1750,14 @@ void ttm_bo_unmap_virtual(struct ttm_buffer_object *bo) >> ttm_bo_unmap_virtual_locked(bo); >> ttm_mem_io_unlock(man); >> } >> - >> - >> EXPORT_SYMBOL(ttm_bo_unmap_virtual); >> >> +void ttm_bo_unmap_virtual_address_space(struct ttm_bo_device *bdev) >> +{ >> + unmap_mapping_range(bdev->dev_mapping, 0, 0, 1); >> +} >> +EXPORT_SYMBOL(ttm_bo_unmap_virtual_address_space); >> + >> int ttm_bo_wait(struct ttm_buffer_object *bo, >> bool interruptible, bool no_wait) >> { >> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h >> index c9e0fd0..39ea44f 100644 >> --- a/include/drm/ttm/ttm_bo_driver.h >> +++ b/include/drm/ttm/ttm_bo_driver.h >> @@ -601,6 +601,13 @@ int ttm_bo_device_init(struct ttm_bo_device *bdev, >> void ttm_bo_unmap_virtual(struct ttm_buffer_object *bo); >> >> /** >> + * ttm_bo_unmap_virtual_address_space >> + * >> + * @bdev: tear down all the virtual mappings for this device >> + */ >> +void ttm_bo_unmap_virtual_address_space(struct ttm_bo_device *bdev); >> + >> +/** >> * ttm_bo_unmap_virtual >> * >> * @bo: tear down the virtual mappings for this BO >> -- >> 2.7.4 >> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: daniel.vetter@ffwll.ch, michel@daenzer.net, dri-devel@lists.freedesktop.org, ppaalanen@gmail.com, amd-gfx@lists.freedesktop.org, ckoenig.leichtzumerken@gmail.com, alexdeucher@gmail.com Subject: Re: [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space Date: Tue, 23 Jun 2020 01:00:02 -0400 [thread overview] Message-ID: <3a365581-0f00-32de-6656-77348dcd0ea2@amd.com> (raw) In-Reply-To: <20200622094502.GB20149@phenom.ffwll.local> On 6/22/20 5:45 AM, Daniel Vetter wrote: > On Sun, Jun 21, 2020 at 02:03:03AM -0400, Andrey Grodzovsky wrote: >> Helper function to be used to invalidate all BOs CPU mappings >> once device is removed. >> >> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com> > This seems to be missing the code to invalidate all the dma-buf mmaps? > > Probably needs more testcases if you're not yet catching this. Or am I > missing something, and we're exchanging the the address space also for > dma-buf? > -Daniel IMHO the device address space includes all user clients having a CPU view of the BO either from direct mapping though drm file or by mapping through imported BO's FD. Andrey > >> --- >> drivers/gpu/drm/ttm/ttm_bo.c | 8 ++++++-- >> include/drm/ttm/ttm_bo_driver.h | 7 +++++++ >> 2 files changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c >> index c5b516f..926a365 100644 >> --- a/drivers/gpu/drm/ttm/ttm_bo.c >> +++ b/drivers/gpu/drm/ttm/ttm_bo.c >> @@ -1750,10 +1750,14 @@ void ttm_bo_unmap_virtual(struct ttm_buffer_object *bo) >> ttm_bo_unmap_virtual_locked(bo); >> ttm_mem_io_unlock(man); >> } >> - >> - >> EXPORT_SYMBOL(ttm_bo_unmap_virtual); >> >> +void ttm_bo_unmap_virtual_address_space(struct ttm_bo_device *bdev) >> +{ >> + unmap_mapping_range(bdev->dev_mapping, 0, 0, 1); >> +} >> +EXPORT_SYMBOL(ttm_bo_unmap_virtual_address_space); >> + >> int ttm_bo_wait(struct ttm_buffer_object *bo, >> bool interruptible, bool no_wait) >> { >> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h >> index c9e0fd0..39ea44f 100644 >> --- a/include/drm/ttm/ttm_bo_driver.h >> +++ b/include/drm/ttm/ttm_bo_driver.h >> @@ -601,6 +601,13 @@ int ttm_bo_device_init(struct ttm_bo_device *bdev, >> void ttm_bo_unmap_virtual(struct ttm_buffer_object *bo); >> >> /** >> + * ttm_bo_unmap_virtual_address_space >> + * >> + * @bdev: tear down all the virtual mappings for this device >> + */ >> +void ttm_bo_unmap_virtual_address_space(struct ttm_bo_device *bdev); >> + >> +/** >> * ttm_bo_unmap_virtual >> * >> * @bo: tear down the virtual mappings for this BO >> -- >> 2.7.4 >> _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-06-23 5:00 UTC|newest] Thread overview: 194+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-21 6:03 [PATCH v2 0/8] RFC Support hot device unplug in amdgpu Andrey Grodzovsky 2020-06-21 6:03 ` Andrey Grodzovsky 2020-06-21 6:03 ` [PATCH v2 1/8] drm: Add dummy page per device or GEM object Andrey Grodzovsky 2020-06-21 6:03 ` Andrey Grodzovsky 2020-06-22 9:35 ` Daniel Vetter 2020-06-22 9:35 ` Daniel Vetter 2020-06-22 14:21 ` Pekka Paalanen 2020-06-22 14:21 ` Pekka Paalanen 2020-06-22 14:24 ` Daniel Vetter 2020-06-22 14:24 ` Daniel Vetter 2020-06-22 14:28 ` Pekka Paalanen 2020-06-22 14:28 ` Pekka Paalanen 2020-11-09 20:34 ` Andrey Grodzovsky 2020-11-09 20:34 ` Andrey Grodzovsky 2020-11-15 6:39 ` Andrey Grodzovsky 2020-11-15 6:39 ` Andrey Grodzovsky 2020-06-22 13:18 ` Christian König 2020-06-22 13:18 ` Christian König 2020-06-22 14:23 ` Daniel Vetter 2020-06-22 14:23 ` Daniel Vetter 2020-06-22 14:32 ` Andrey Grodzovsky 2020-06-22 14:32 ` Andrey Grodzovsky 2020-06-22 17:45 ` Christian König 2020-06-22 17:45 ` Christian König 2020-06-22 17:50 ` Daniel Vetter 2020-06-22 17:50 ` Daniel Vetter 2020-11-09 20:53 ` Andrey Grodzovsky 2020-11-09 20:53 ` Andrey Grodzovsky 2020-11-13 20:52 ` Andrey Grodzovsky 2020-11-13 20:52 ` Andrey Grodzovsky 2020-11-14 8:41 ` Christian König 2020-11-14 8:41 ` Christian König 2020-11-14 9:51 ` Daniel Vetter 2020-11-14 9:51 ` Daniel Vetter 2020-11-14 9:57 ` Daniel Vetter 2020-11-14 9:57 ` Daniel Vetter 2020-11-16 9:42 ` Michel Dänzer 2020-11-16 9:42 ` Michel Dänzer 2020-11-15 6:34 ` Andrey Grodzovsky 2020-11-15 6:34 ` Andrey Grodzovsky 2020-11-16 9:48 ` Christian König 2020-11-16 9:48 ` Christian König 2020-11-16 19:00 ` Andrey Grodzovsky 2020-11-16 19:00 ` Andrey Grodzovsky 2020-11-16 20:36 ` Christian König 2020-11-16 20:36 ` Christian König 2020-11-16 20:42 ` Andrey Grodzovsky 2020-11-16 20:42 ` Andrey Grodzovsky 2020-11-19 10:01 ` Christian König 2020-11-19 10:01 ` Christian König 2020-06-21 6:03 ` [PATCH v2 2/8] drm/ttm: Remap all page faults to per process dummy page Andrey Grodzovsky 2020-06-21 6:03 ` Andrey Grodzovsky 2020-06-22 9:41 ` Daniel Vetter 2020-06-22 9:41 ` Daniel Vetter 2020-06-24 3:31 ` Andrey Grodzovsky 2020-06-24 3:31 ` Andrey Grodzovsky 2020-06-24 7:19 ` Daniel Vetter 2020-06-24 7:19 ` Daniel Vetter 2020-11-10 17:41 ` Andrey Grodzovsky 2020-11-10 17:41 ` Andrey Grodzovsky 2020-06-22 19:30 ` Christian König 2020-06-22 19:30 ` Christian König 2020-06-21 6:03 ` [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space Andrey Grodzovsky 2020-06-21 6:03 ` Andrey Grodzovsky 2020-06-22 9:45 ` Daniel Vetter 2020-06-22 9:45 ` Daniel Vetter 2020-06-23 5:00 ` Andrey Grodzovsky [this message] 2020-06-23 5:00 ` Andrey Grodzovsky 2020-06-23 10:25 ` Daniel Vetter 2020-06-23 10:25 ` Daniel Vetter 2020-06-23 12:55 ` Christian König 2020-06-23 12:55 ` Christian König 2020-06-22 19:37 ` Christian König 2020-06-22 19:37 ` Christian König 2020-06-22 19:47 ` Alex Deucher 2020-06-22 19:47 ` Alex Deucher 2020-06-21 6:03 ` [PATCH v2 4/8] drm/amdgpu: Split amdgpu_device_fini into early and late Andrey Grodzovsky 2020-06-21 6:03 ` Andrey Grodzovsky 2020-06-22 9:48 ` Daniel Vetter 2020-06-22 9:48 ` Daniel Vetter 2020-11-12 4:19 ` Andrey Grodzovsky 2020-11-12 4:19 ` Andrey Grodzovsky 2020-11-12 9:29 ` Daniel Vetter 2020-11-12 9:29 ` Daniel Vetter 2020-06-21 6:03 ` [PATCH v2 5/8] drm/amdgpu: Refactor sysfs removal Andrey Grodzovsky 2020-06-21 6:03 ` Andrey Grodzovsky 2020-06-22 9:51 ` Daniel Vetter 2020-06-22 9:51 ` Daniel Vetter 2020-06-22 11:21 ` Greg KH 2020-06-22 11:21 ` Greg KH 2020-06-22 16:07 ` Andrey Grodzovsky 2020-06-22 16:07 ` Andrey Grodzovsky 2020-06-22 16:45 ` Greg KH 2020-06-22 16:45 ` Greg KH 2020-06-23 4:51 ` Andrey Grodzovsky 2020-06-23 4:51 ` Andrey Grodzovsky 2020-06-23 6:05 ` Greg KH 2020-06-23 6:05 ` Greg KH 2020-06-24 3:04 ` Andrey Grodzovsky 2020-06-24 3:04 ` Andrey Grodzovsky 2020-06-24 6:11 ` Greg KH 2020-06-24 6:11 ` Greg KH 2020-06-25 1:52 ` Andrey Grodzovsky 2020-06-25 1:52 ` Andrey Grodzovsky 2020-11-10 17:54 ` Andrey Grodzovsky 2020-11-10 17:54 ` Andrey Grodzovsky 2020-11-10 17:59 ` Greg KH 2020-11-10 17:59 ` Greg KH 2020-11-11 15:13 ` Andrey Grodzovsky 2020-11-11 15:13 ` Andrey Grodzovsky 2020-11-11 15:34 ` Greg KH 2020-11-11 15:34 ` Greg KH 2020-11-11 15:45 ` Andrey Grodzovsky 2020-11-11 15:45 ` Andrey Grodzovsky 2020-11-11 16:06 ` Greg KH 2020-11-11 16:06 ` Greg KH 2020-11-11 16:34 ` Andrey Grodzovsky 2020-11-11 16:34 ` Andrey Grodzovsky 2020-12-02 15:48 ` Andrey Grodzovsky 2020-12-02 15:48 ` Andrey Grodzovsky 2020-12-02 17:34 ` Greg KH 2020-12-02 17:34 ` Greg KH 2020-12-02 18:02 ` Andrey Grodzovsky 2020-12-02 18:02 ` Andrey Grodzovsky 2020-12-02 18:20 ` Greg KH 2020-12-02 18:20 ` Greg KH 2020-12-02 18:40 ` Andrey Grodzovsky 2020-12-02 18:40 ` Andrey Grodzovsky 2020-06-22 13:19 ` Christian König 2020-06-22 13:19 ` Christian König 2020-06-21 6:03 ` [PATCH v2 6/8] drm/amdgpu: Unmap entire device address space on device remove Andrey Grodzovsky 2020-06-21 6:03 ` Andrey Grodzovsky 2020-06-22 9:56 ` Daniel Vetter 2020-06-22 9:56 ` Daniel Vetter 2020-06-22 19:38 ` Christian König 2020-06-22 19:38 ` Christian König 2020-06-22 19:48 ` Alex Deucher 2020-06-22 19:48 ` Alex Deucher 2020-06-23 10:22 ` Daniel Vetter 2020-06-23 10:22 ` Daniel Vetter 2020-06-23 13:16 ` Christian König 2020-06-23 13:16 ` Christian König 2020-06-24 3:12 ` Andrey Grodzovsky 2020-06-24 3:12 ` Andrey Grodzovsky 2020-06-21 6:03 ` [PATCH v2 7/8] drm/amdgpu: Fix sdma code crash post device unplug Andrey Grodzovsky 2020-06-21 6:03 ` Andrey Grodzovsky 2020-06-22 9:55 ` Daniel Vetter 2020-06-22 9:55 ` Daniel Vetter 2020-06-22 19:40 ` Christian König 2020-06-22 19:40 ` Christian König 2020-06-23 5:11 ` Andrey Grodzovsky 2020-06-23 5:11 ` Andrey Grodzovsky 2020-06-23 7:14 ` Christian König 2020-06-23 7:14 ` Christian König 2020-06-21 6:03 ` [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged Andrey Grodzovsky 2020-06-21 6:03 ` Andrey Grodzovsky 2020-06-22 9:53 ` Daniel Vetter 2020-06-22 9:53 ` Daniel Vetter 2020-11-17 18:38 ` Andrey Grodzovsky 2020-11-17 18:38 ` Andrey Grodzovsky 2020-11-17 18:52 ` Daniel Vetter 2020-11-17 18:52 ` Daniel Vetter 2020-11-17 19:18 ` Andrey Grodzovsky 2020-11-17 19:18 ` Andrey Grodzovsky 2020-11-17 19:49 ` Daniel Vetter 2020-11-17 19:49 ` Daniel Vetter 2020-11-17 20:07 ` Andrey Grodzovsky 2020-11-17 20:07 ` Andrey Grodzovsky 2020-11-18 7:39 ` Daniel Vetter 2020-11-18 7:39 ` Daniel Vetter 2020-11-18 12:01 ` Christian König 2020-11-18 12:01 ` Christian König 2020-11-18 15:43 ` Luben Tuikov 2020-11-18 15:43 ` Luben Tuikov 2020-11-18 16:20 ` Andrey Grodzovsky 2020-11-18 16:20 ` Andrey Grodzovsky 2020-11-19 7:55 ` Christian König 2020-11-19 7:55 ` Christian König 2020-11-19 15:02 ` Andrey Grodzovsky 2020-11-19 15:02 ` Andrey Grodzovsky 2020-11-19 15:29 ` Daniel Vetter 2020-11-19 15:29 ` Daniel Vetter 2020-11-19 21:24 ` Andrey Grodzovsky 2020-11-19 21:24 ` Andrey Grodzovsky 2020-11-18 0:46 ` Luben Tuikov 2020-11-18 0:46 ` Luben Tuikov 2020-06-22 9:46 ` [PATCH v2 0/8] RFC Support hot device unplug in amdgpu Daniel Vetter 2020-06-22 9:46 ` Daniel Vetter 2020-06-23 5:14 ` Andrey Grodzovsky 2020-06-23 5:14 ` Andrey Grodzovsky 2020-06-23 9:04 ` Michel Dänzer 2020-06-23 9:04 ` Michel Dänzer 2020-06-24 3:21 ` Andrey Grodzovsky 2020-06-24 3:21 ` Andrey Grodzovsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3a365581-0f00-32de-6656-77348dcd0ea2@amd.com \ --to=andrey.grodzovsky@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=ckoenig.leichtzumerken@gmail.com \ --cc=daniel.vetter@ffwll.ch \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=michel@daenzer.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.