From: Robin Murphy <robin.murphy@arm.com>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: will@kernel.org, joro@8bytes.org, pdaly@codeaurora.org,
pratikp@codeaurora.org, kernel-team@android.com
Subject: Re: [PATCH v2 3/7] iommu/arm-smmu: Add dependency on io-pgtable format modules
Date: Tue, 22 Dec 2020 19:27:18 +0000 [thread overview]
Message-ID: <3b0c191d-3fd0-73db-c1e3-4a80aa7953d7@arm.com> (raw)
In-Reply-To: <1608597876-32367-4-git-send-email-isaacm@codeaurora.org>
On 2020-12-22 00:44, Isaac J. Manjarres wrote:
> The SMMU driver depends on the availability of the ARM LPAE and
> ARM V7S io-pgtable format code to work properly. In preparation
Nit: we don't really depend on v7s - we *can* use it if it's available,
address constraints are suitable, and the SMMU implementation actually
supports it (many don't), but we can still quite happily not use it even
so. LPAE is mandatory in the architecture so that's our only hard
requirement, embodied in the kconfig select.
This does mean there may technically still be a corner case involving
ARM_SMMU=y and IO_PGTABLE_ARM_V7S=m, but at worst it's now a runtime
failure rather than a build error, so unless and until anyone
demonstrates that it actually matters I don't feel particularly inclined
to give it much thought.
Robin.
> for having the io-pgtable formats as modules, add a "pre"
> dependency with MODULE_SOFTDEP() to ensure that the io-pgtable
> format modules are loaded before loading the ARM SMMU driver module.
>
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> index d8c6bfd..a72649f 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> @@ -2351,3 +2351,4 @@ MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations");
> MODULE_AUTHOR("Will Deacon <will@kernel.org>");
> MODULE_ALIAS("platform:arm-smmu");
> MODULE_LICENSE("GPL v2");
> +MODULE_SOFTDEP("pre: io-pgtable-arm io-pgtable-arm-v7s");
>
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: pratikp@codeaurora.org, kernel-team@android.com, will@kernel.org,
pdaly@codeaurora.org
Subject: Re: [PATCH v2 3/7] iommu/arm-smmu: Add dependency on io-pgtable format modules
Date: Tue, 22 Dec 2020 19:27:18 +0000 [thread overview]
Message-ID: <3b0c191d-3fd0-73db-c1e3-4a80aa7953d7@arm.com> (raw)
In-Reply-To: <1608597876-32367-4-git-send-email-isaacm@codeaurora.org>
On 2020-12-22 00:44, Isaac J. Manjarres wrote:
> The SMMU driver depends on the availability of the ARM LPAE and
> ARM V7S io-pgtable format code to work properly. In preparation
Nit: we don't really depend on v7s - we *can* use it if it's available,
address constraints are suitable, and the SMMU implementation actually
supports it (many don't), but we can still quite happily not use it even
so. LPAE is mandatory in the architecture so that's our only hard
requirement, embodied in the kconfig select.
This does mean there may technically still be a corner case involving
ARM_SMMU=y and IO_PGTABLE_ARM_V7S=m, but at worst it's now a runtime
failure rather than a build error, so unless and until anyone
demonstrates that it actually matters I don't feel particularly inclined
to give it much thought.
Robin.
> for having the io-pgtable formats as modules, add a "pre"
> dependency with MODULE_SOFTDEP() to ensure that the io-pgtable
> format modules are loaded before loading the ARM SMMU driver module.
>
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> index d8c6bfd..a72649f 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> @@ -2351,3 +2351,4 @@ MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations");
> MODULE_AUTHOR("Will Deacon <will@kernel.org>");
> MODULE_ALIAS("platform:arm-smmu");
> MODULE_LICENSE("GPL v2");
> +MODULE_SOFTDEP("pre: io-pgtable-arm io-pgtable-arm-v7s");
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: pratikp@codeaurora.org, joro@8bytes.org, kernel-team@android.com,
will@kernel.org, pdaly@codeaurora.org
Subject: Re: [PATCH v2 3/7] iommu/arm-smmu: Add dependency on io-pgtable format modules
Date: Tue, 22 Dec 2020 19:27:18 +0000 [thread overview]
Message-ID: <3b0c191d-3fd0-73db-c1e3-4a80aa7953d7@arm.com> (raw)
In-Reply-To: <1608597876-32367-4-git-send-email-isaacm@codeaurora.org>
On 2020-12-22 00:44, Isaac J. Manjarres wrote:
> The SMMU driver depends on the availability of the ARM LPAE and
> ARM V7S io-pgtable format code to work properly. In preparation
Nit: we don't really depend on v7s - we *can* use it if it's available,
address constraints are suitable, and the SMMU implementation actually
supports it (many don't), but we can still quite happily not use it even
so. LPAE is mandatory in the architecture so that's our only hard
requirement, embodied in the kconfig select.
This does mean there may technically still be a corner case involving
ARM_SMMU=y and IO_PGTABLE_ARM_V7S=m, but at worst it's now a runtime
failure rather than a build error, so unless and until anyone
demonstrates that it actually matters I don't feel particularly inclined
to give it much thought.
Robin.
> for having the io-pgtable formats as modules, add a "pre"
> dependency with MODULE_SOFTDEP() to ensure that the io-pgtable
> format modules are loaded before loading the ARM SMMU driver module.
>
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> index d8c6bfd..a72649f 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> @@ -2351,3 +2351,4 @@ MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations");
> MODULE_AUTHOR("Will Deacon <will@kernel.org>");
> MODULE_ALIAS("platform:arm-smmu");
> MODULE_LICENSE("GPL v2");
> +MODULE_SOFTDEP("pre: io-pgtable-arm io-pgtable-arm-v7s");
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: pratikp@codeaurora.org, joro@8bytes.org, kernel-team@android.com,
will@kernel.org, pdaly@codeaurora.org
Subject: Re: [PATCH v2 3/7] iommu/arm-smmu: Add dependency on io-pgtable format modules
Date: Tue, 22 Dec 2020 19:27:18 +0000 [thread overview]
Message-ID: <3b0c191d-3fd0-73db-c1e3-4a80aa7953d7@arm.com> (raw)
In-Reply-To: <1608597876-32367-4-git-send-email-isaacm@codeaurora.org>
On 2020-12-22 00:44, Isaac J. Manjarres wrote:
> The SMMU driver depends on the availability of the ARM LPAE and
> ARM V7S io-pgtable format code to work properly. In preparation
Nit: we don't really depend on v7s - we *can* use it if it's available,
address constraints are suitable, and the SMMU implementation actually
supports it (many don't), but we can still quite happily not use it even
so. LPAE is mandatory in the architecture so that's our only hard
requirement, embodied in the kconfig select.
This does mean there may technically still be a corner case involving
ARM_SMMU=y and IO_PGTABLE_ARM_V7S=m, but at worst it's now a runtime
failure rather than a build error, so unless and until anyone
demonstrates that it actually matters I don't feel particularly inclined
to give it much thought.
Robin.
> for having the io-pgtable formats as modules, add a "pre"
> dependency with MODULE_SOFTDEP() to ensure that the io-pgtable
> format modules are loaded before loading the ARM SMMU driver module.
>
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> index d8c6bfd..a72649f 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> @@ -2351,3 +2351,4 @@ MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations");
> MODULE_AUTHOR("Will Deacon <will@kernel.org>");
> MODULE_ALIAS("platform:arm-smmu");
> MODULE_LICENSE("GPL v2");
> +MODULE_SOFTDEP("pre: io-pgtable-arm io-pgtable-arm-v7s");
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-22 19:28 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 0:44 [RFC PATCH v2 0/7] iommu: Permit modular builds of io-pgtable drivers Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` [PATCH v2 1/7] iommu/io-pgtable: Introduce dynamic io-pgtable fmt registration Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 19:27 ` Robin Murphy
2020-12-22 19:27 ` Robin Murphy
2020-12-22 19:27 ` Robin Murphy
2020-12-22 19:27 ` Robin Murphy
2020-12-22 19:54 ` isaacm
2020-12-22 19:54 ` isaacm
2020-12-22 19:54 ` isaacm
2020-12-23 13:44 ` Robin Murphy
2020-12-23 13:44 ` Robin Murphy
2020-12-23 13:44 ` Robin Murphy
2020-12-23 13:44 ` Robin Murphy
2020-12-23 15:14 ` isaacm
2020-12-23 15:14 ` isaacm
2020-12-23 15:14 ` isaacm
2020-12-23 15:38 ` Georgi Djakov
2020-12-23 15:38 ` Georgi Djakov
2020-12-23 15:38 ` Georgi Djakov
2020-12-23 15:38 ` Georgi Djakov
2020-12-23 19:17 ` kernel test robot
2020-12-23 19:17 ` kernel test robot
2020-12-23 19:17 ` kernel test robot
2020-12-23 19:17 ` kernel test robot
2020-12-23 19:17 ` kernel test robot
2020-12-22 0:44 ` [PATCH v2 2/7] iommu/io-pgtable: Add refcounting for io-pgtable format modules Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` [PATCH v2 3/7] iommu/arm-smmu: Add dependency on " Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 19:27 ` Robin Murphy [this message]
2020-12-22 19:27 ` Robin Murphy
2020-12-22 19:27 ` Robin Murphy
2020-12-22 19:27 ` Robin Murphy
2020-12-22 19:49 ` isaacm
2020-12-22 19:49 ` isaacm
2020-12-22 19:49 ` isaacm
2020-12-23 13:05 ` Robin Murphy
2020-12-23 13:05 ` Robin Murphy
2020-12-23 13:05 ` Robin Murphy
2020-12-23 13:05 ` Robin Murphy
2020-12-23 15:10 ` isaacm
2020-12-23 15:10 ` isaacm
2020-12-23 15:10 ` isaacm
2020-12-22 0:44 ` [PATCH v2 4/7] iommu/arm-smmu-v3: Add dependency on io-pgtable-arm format module Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` [PATCH v2 5/7] drm/msm: " Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2021-01-18 21:16 ` Rob Clark
2021-01-18 21:16 ` Rob Clark
2021-01-18 21:16 ` Rob Clark
2021-01-18 21:16 ` Rob Clark
2021-01-18 21:39 ` Will Deacon
2021-01-18 21:39 ` Will Deacon
2021-01-18 21:39 ` Will Deacon
2021-01-18 21:39 ` Will Deacon
2021-01-19 17:19 ` Rob Clark
2021-01-19 17:19 ` Rob Clark
2021-01-19 17:19 ` Rob Clark
2021-01-19 17:19 ` Rob Clark
2020-12-22 0:44 ` [PATCH v2 6/7] drm/panfrost: " Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` [PATCH v2 7/7] iommu/io-pgtable-arm: Allow building modular io-pgtable fmts Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
2020-12-22 0:44 ` Isaac J. Manjarres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b0c191d-3fd0-73db-c1e3-4a80aa7953d7@arm.com \
--to=robin.murphy@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdaly@codeaurora.org \
--cc=pratikp@codeaurora.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.