All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: Mark Brown <broonie@kernel.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Dave Airlie <airlied@gmail.com>,
	Andrew Jackson <Andrew.Jackson@arm.com>,
	Jyri Sarha <jsarha@ti.com>,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v9 4/4] drm/i2c: tda998x: set cts_n according to the sample width
Date: Wed, 7 Jan 2015 12:01:23 +0100	[thread overview]
Message-ID: <3b99496107b6653ef27b86d8cdf516a4815910cf.1420628786.git.moinejf@free.fr> (raw)
In-Reply-To: <cover.1420628786.git.moinejf@free.fr>

With I2S input, the CTS_N predivider depends on the sample width.

Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index a26a516..8af84cd 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -50,6 +50,7 @@ struct tda998x_priv {
 	wait_queue_head_t wq_edid;
 	volatile int wq_edid_wait;
 	struct drm_encoder *encoder;
 
+	int audio_sample_format;
 	u8 audio_ports[2];
 #ifdef WITH_CODEC
@@ -671,7 +672,17 @@ tda998x_configure_audio(struct tda998x_priv *priv,
 		reg_write(priv, REG_MUX_AP, MUX_AP_SELECT_I2S);
 		clksel_aip = AIP_CLKSEL_AIP_I2S;
 		clksel_fs = AIP_CLKSEL_FS_ACLK;
-		cts_n = CTS_N_M(3) | CTS_N_K(3);
+
+		/* with I2S input, the CTS_N predivider depends on
+		 * the sample width */
+		switch (priv->audio_sample_format) {
+		case SNDRV_PCM_FORMAT_S16_LE:
+			cts_n = CTS_N_M(3) | CTS_N_K(1);
+			break;
+		default:
+			cts_n = CTS_N_M(3) | CTS_N_K(3);
+			break;
+		}
 		break;
 
 	default:
@@ -778,7 +789,8 @@ static int tda998x_set_audio_input(struct device *dev,
 
 	/* if same audio parameters, just enable the audio port */
 	if (p->audio_cfg == priv->audio_ports[port_index] &&
-	    p->audio_sample_rate == sample_rate) {
+	    p->audio_sample_rate == sample_rate &&
+	    priv->audio_sample_format == sample_format) {
 		reg_write(priv, REG_ENA_AP, p->audio_cfg);
 		return 0;
 	}
@@ -787,6 +799,7 @@ static int tda998x_set_audio_input(struct device *dev,
 	p->audio_clk_cfg = port_index == PORT_SPDIF ? 0 : 1;
 	p->audio_cfg = priv->audio_ports[port_index];
 	p->audio_sample_rate = sample_rate;
+	priv->audio_sample_format = sample_format;
 	tda998x_configure_audio(priv, &priv->encoder->crtc->hwmode, p);
 	return 0;
 }
@@ -1388,6 +1401,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv)
 
 	priv->params.audio_frame[1] = 1;		/* channels - 1 */
 	priv->params.audio_sample_rate = 48000;		/* 48kHz */
+	priv->audio_sample_format = SNDRV_PCM_FORMAT_S24_LE;
 
 	priv->current_page = 0xff;
 	priv->hdmi = client;
-- 
2.1.4


  parent reply	other threads:[~2015-01-07 11:52 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 11:06 [PATCH v9 0/4] ASoC: tda998x: add a codec to the HDMI transmitter Jean-Francois Moine
2015-01-07 11:06 ` Jean-Francois Moine
2015-01-07  9:10 ` [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio Jean-Francois Moine
2015-01-07  9:10   ` Jean-Francois Moine
2015-01-07 14:39   ` Andrew Jackson
2015-01-07 14:39     ` Andrew Jackson
2015-01-07 17:08     ` Jean-Francois Moine
2015-01-07 17:08       ` Jean-Francois Moine
2015-01-07 17:18       ` Andrew Jackson
2015-01-07 17:18         ` Andrew Jackson
2015-01-07 17:33         ` Mark Brown
2015-01-08 14:53   ` Jyri Sarha
2015-01-08 14:53     ` Jyri Sarha
2015-01-08 16:42     ` Jean-Francois Moine
2015-01-08 16:42       ` Jean-Francois Moine
2015-01-08 20:04       ` Mark Brown
2015-01-08 20:04         ` Mark Brown
2015-01-09  9:25         ` Andrew Jackson
2015-01-09  9:25           ` Andrew Jackson
2015-01-09 10:13       ` Jyri Sarha
2015-01-09 10:13         ` Jyri Sarha
2015-01-09 11:30         ` Jean-Francois Moine
2015-01-09 11:30           ` Jean-Francois Moine
2015-01-09 11:45           ` Russell King - ARM Linux
2015-01-09 11:45             ` Russell King - ARM Linux
2015-01-09 12:54             ` Jean-Francois Moine
2015-01-09 12:54               ` Jean-Francois Moine
2015-01-09 13:07               ` Russell King - ARM Linux
2015-01-09 13:07                 ` Russell King - ARM Linux
2015-01-09 13:58                 ` Andrew Jackson
2015-01-09 13:58                   ` Andrew Jackson
2015-01-09 14:57                   ` Russell King - ARM Linux
2015-01-09 17:38                     ` Jean-Francois Moine
2015-01-09 17:38                       ` Jean-Francois Moine
2015-01-09 20:01                       ` Russell King - ARM Linux
2015-01-09 20:01                         ` Russell King - ARM Linux
2015-01-10 15:47                         ` [alsa-devel] " Jean-Francois Moine
2015-01-10 15:47                           ` Jean-Francois Moine
2015-01-12  9:25                         ` Philipp Zabel
2015-01-12  9:25                           ` Philipp Zabel
2015-01-12 12:25                           ` Russell King - ARM Linux
2015-01-12 13:59                             ` Philipp Zabel
2015-01-12 13:59                               ` Philipp Zabel
2015-01-12 14:04                               ` Russell King - ARM Linux
2015-01-12 14:04                                 ` Russell King - ARM Linux
2015-01-12 17:13                                 ` Jean-Francois Moine
2015-01-12 17:13                                   ` Jean-Francois Moine
2015-01-12 17:57                                   ` Russell King - ARM Linux
2015-01-12 17:57                                     ` Russell King - ARM Linux
2015-01-12 19:14                                     ` Jean-Francois Moine
2015-01-12 19:14                                       ` Jean-Francois Moine
2015-01-13 12:21                                     ` Philipp Zabel
2015-01-13 12:21                                       ` Philipp Zabel
2015-01-13 12:27                                       ` Russell King - ARM Linux
2015-01-13 12:27                                         ` Russell King - ARM Linux
2015-01-13 15:54                                         ` Jean-Francois Moine
2015-01-13 15:54                                           ` Jean-Francois Moine
2015-01-13 16:03                                           ` Russell King - ARM Linux
2015-01-13 16:03                                             ` Russell King - ARM Linux
2015-01-13 19:02                                             ` Jean-Francois Moine
2015-01-13 19:02                                               ` Jean-Francois Moine
2015-01-13 19:26                                               ` Russell King - ARM Linux
2015-01-13 19:26                                                 ` Russell King - ARM Linux
2015-01-13 19:41                                                 ` Jyri Sarha
2015-01-13 19:41                                                   ` Jyri Sarha
2015-01-13 19:54                                                   ` Russell King - ARM Linux
2015-01-13 19:54                                                     ` Russell King - ARM Linux
2015-01-14  7:55                                                     ` Jean-Francois Moine
2015-01-14  7:55                                                       ` Jean-Francois Moine
2015-01-14 12:12                                                       ` Russell King - ARM Linux
2015-01-14 12:12                                                         ` Russell King - ARM Linux
2015-01-14 10:46                                                     ` Philipp Zabel
2015-01-14 10:46                                                       ` Philipp Zabel
2015-01-14 12:50                                                       ` Mark Brown
2015-01-14 12:50                                                         ` Mark Brown
2015-01-14 14:23                                                         ` Russell King - ARM Linux
2015-01-14 14:23                                                           ` Russell King - ARM Linux
2015-01-07 10:00 ` [PATCH v9 2/4] drm/i2c: tda998x: Change drvdata for audio extension Jean-Francois Moine
2015-01-07 10:00   ` Jean-Francois Moine
2015-01-07 10:51 ` [PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter Jean-Francois Moine
2015-01-07 15:10   ` Andrew Jackson
2015-01-07 15:10     ` Andrew Jackson
2015-01-07 15:41     ` Russell King - ARM Linux
2015-01-07 15:41       ` Russell King - ARM Linux
2015-01-07 18:02       ` Jean-Francois Moine
2015-01-09 10:24         ` Jyri Sarha
2015-01-09 10:24           ` Jyri Sarha
2015-01-09 11:15           ` Jean-Francois Moine
2015-01-09 11:15             ` Jean-Francois Moine
2015-01-09 11:19           ` Russell King - ARM Linux
2015-01-09 11:19             ` Russell King - ARM Linux
2015-01-09 11:45             ` Jean-Francois Moine
2015-01-09 11:45               ` Jean-Francois Moine
2015-01-09 11:48               ` Russell King - ARM Linux
2015-01-09 11:48                 ` Russell King - ARM Linux
2015-01-07 17:34     ` Mark Brown
2015-01-07 17:34       ` Mark Brown
2015-01-08 14:55   ` Jyri Sarha
2015-01-08 14:55     ` Jyri Sarha
2015-01-09 17:39   ` Andrew Jackson
2015-01-09 17:39     ` Andrew Jackson
2015-01-09 17:54     ` Mark Brown
2015-01-09 17:54       ` Mark Brown
2015-01-13  9:24     ` Jean-Francois Moine
2015-01-13  9:24       ` Jean-Francois Moine
2015-01-11 21:03   ` Jyri Sarha
2015-01-11 21:03     ` Jyri Sarha
2015-01-13  7:41     ` Jean-Francois Moine
2015-01-13  7:41       ` Jean-Francois Moine
2015-01-07 11:01 ` Jean-Francois Moine [this message]
2015-01-08 14:53 ` [PATCH v9 0/4] " Jyri Sarha
2015-01-08 14:53   ` Jyri Sarha
2015-01-08 20:05   ` Mark Brown
2015-01-09 10:15     ` Jyri Sarha
2015-01-09 10:15       ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b99496107b6653ef27b86d8cdf516a4815910cf.1420628786.git.moinejf@free.fr \
    --to=moinejf@free.fr \
    --cc=Andrew.Jackson@arm.com \
    --cc=airlied@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.