From: Jyri Sarha <jsarha@ti.com> To: Jean-Francois Moine <moinejf@free.fr>, Russell King - ARM Linux <linux@arm.linux.org.uk> Cc: Andrew Jackson <Andrew.Jackson@arm.com>, Mark Brown <broonie@kernel.org>, Dave Airlie <airlied@gmail.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter Date: Fri, 9 Jan 2015 12:24:12 +0200 [thread overview] Message-ID: <54AFAC4C.7010209@ti.com> (raw) In-Reply-To: <20150107190241.27ebac8b@armhf> On 01/07/2015 08:02 PM, Jean-Francois Moine wrote: > On Wed, 7 Jan 2015 15:41:38 +0000 > Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > >> On Wed, Jan 07, 2015 at 03:10:47PM +0000, Andrew Jackson wrote: >>> On 01/07/15 10:51, Jean-Francois Moine wrote: >>>> diff --git a/drivers/gpu/drm/i2c/Kconfig b/drivers/gpu/drm/i2c/Kconfig >>>> index 22c7ed6..24fc975 100644 >>>> --- a/drivers/gpu/drm/i2c/Kconfig >>>> +++ b/drivers/gpu/drm/i2c/Kconfig >>>> @@ -28,6 +28,7 @@ config DRM_I2C_SIL164 >>>> config DRM_I2C_NXP_TDA998X >>>> tristate "NXP Semiconductors TDA998X HDMI encoder" >>>> default m if DRM_TILCDC >>>> + select SND_SOC_TDA998X >>> >>> Do you need this since sound/soc/codecs/Kconfig conditionally brings in the >>> CODEC driver? > > For SND_SOC_ALL_CODECS only. > >> More importantly, it's broken, because it'll cause Kconfig to complain >> if you enable DRM_I2C_NXP_TDA998X, but have ASoC disabled. >> >> Moreover, if you decide you want the sound and ASoC built as a module, >> but want to build in DRM and TDA998x support (so you can get video >> output working on boot before initramfs/rootfs), Kconfig may well >> complain. > > select SND_SOC_TDA998X if SND_SOC > > should work in all cases. > I think that would still fail if DRM and TDA998x is built in and SND_SOC is built as modules. A request_module() call before tda9998x_codec_register() should help. Or could could write: select SND_SOC_TDA998X if (SND_SOC=DRM_I2C_NXP_TDA998X || SND_SOC=y) >>>> +static int __init tda998x_codec_init(void) >>>> +{ >>>> + return 0; >>>> +} >>>> +static void __exit tda998x_codec_exit(void) >>>> +{ >>>> +} >>>> +module_init(tda998x_codec_init); >>>> +module_exit(tda998x_codec_exit); >> >> There's no need for these if they remain as the above. Modules can have >> both init/exit functions, or neither, and they are still unloadable. >> Only modules which provide only an init function get locked in on load. > > Thanks. >
WARNING: multiple messages have this Message-ID (diff)
From: Jyri Sarha <jsarha@ti.com> To: Jean-Francois Moine <moinejf@free.fr>, Russell King - ARM Linux <linux@arm.linux.org.uk> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, Andrew Jackson <Andrew.Jackson@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Mark Brown <broonie@kernel.org>, Dave Airlie <airlied@gmail.com> Subject: Re: [PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter Date: Fri, 9 Jan 2015 12:24:12 +0200 [thread overview] Message-ID: <54AFAC4C.7010209@ti.com> (raw) In-Reply-To: <20150107190241.27ebac8b@armhf> On 01/07/2015 08:02 PM, Jean-Francois Moine wrote: > On Wed, 7 Jan 2015 15:41:38 +0000 > Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > >> On Wed, Jan 07, 2015 at 03:10:47PM +0000, Andrew Jackson wrote: >>> On 01/07/15 10:51, Jean-Francois Moine wrote: >>>> diff --git a/drivers/gpu/drm/i2c/Kconfig b/drivers/gpu/drm/i2c/Kconfig >>>> index 22c7ed6..24fc975 100644 >>>> --- a/drivers/gpu/drm/i2c/Kconfig >>>> +++ b/drivers/gpu/drm/i2c/Kconfig >>>> @@ -28,6 +28,7 @@ config DRM_I2C_SIL164 >>>> config DRM_I2C_NXP_TDA998X >>>> tristate "NXP Semiconductors TDA998X HDMI encoder" >>>> default m if DRM_TILCDC >>>> + select SND_SOC_TDA998X >>> >>> Do you need this since sound/soc/codecs/Kconfig conditionally brings in the >>> CODEC driver? > > For SND_SOC_ALL_CODECS only. > >> More importantly, it's broken, because it'll cause Kconfig to complain >> if you enable DRM_I2C_NXP_TDA998X, but have ASoC disabled. >> >> Moreover, if you decide you want the sound and ASoC built as a module, >> but want to build in DRM and TDA998x support (so you can get video >> output working on boot before initramfs/rootfs), Kconfig may well >> complain. > > select SND_SOC_TDA998X if SND_SOC > > should work in all cases. > I think that would still fail if DRM and TDA998x is built in and SND_SOC is built as modules. A request_module() call before tda9998x_codec_register() should help. Or could could write: select SND_SOC_TDA998X if (SND_SOC=DRM_I2C_NXP_TDA998X || SND_SOC=y) >>>> +static int __init tda998x_codec_init(void) >>>> +{ >>>> + return 0; >>>> +} >>>> +static void __exit tda998x_codec_exit(void) >>>> +{ >>>> +} >>>> +module_init(tda998x_codec_init); >>>> +module_exit(tda998x_codec_exit); >> >> There's no need for these if they remain as the above. Modules can have >> both init/exit functions, or neither, and they are still unloadable. >> Only modules which provide only an init function get locked in on load. > > Thanks. >
next prev parent reply other threads:[~2015-01-09 10:24 UTC|newest] Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-07 11:06 [PATCH v9 0/4] ASoC: tda998x: add a codec to the HDMI transmitter Jean-Francois Moine 2015-01-07 11:06 ` Jean-Francois Moine 2015-01-07 9:10 ` [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio Jean-Francois Moine 2015-01-07 9:10 ` Jean-Francois Moine 2015-01-07 14:39 ` Andrew Jackson 2015-01-07 14:39 ` Andrew Jackson 2015-01-07 17:08 ` Jean-Francois Moine 2015-01-07 17:08 ` Jean-Francois Moine 2015-01-07 17:18 ` Andrew Jackson 2015-01-07 17:18 ` Andrew Jackson 2015-01-07 17:33 ` Mark Brown 2015-01-08 14:53 ` Jyri Sarha 2015-01-08 14:53 ` Jyri Sarha 2015-01-08 16:42 ` Jean-Francois Moine 2015-01-08 16:42 ` Jean-Francois Moine 2015-01-08 20:04 ` Mark Brown 2015-01-08 20:04 ` Mark Brown 2015-01-09 9:25 ` Andrew Jackson 2015-01-09 9:25 ` Andrew Jackson 2015-01-09 10:13 ` Jyri Sarha 2015-01-09 10:13 ` Jyri Sarha 2015-01-09 11:30 ` Jean-Francois Moine 2015-01-09 11:30 ` Jean-Francois Moine 2015-01-09 11:45 ` Russell King - ARM Linux 2015-01-09 11:45 ` Russell King - ARM Linux 2015-01-09 12:54 ` Jean-Francois Moine 2015-01-09 12:54 ` Jean-Francois Moine 2015-01-09 13:07 ` Russell King - ARM Linux 2015-01-09 13:07 ` Russell King - ARM Linux 2015-01-09 13:58 ` Andrew Jackson 2015-01-09 13:58 ` Andrew Jackson 2015-01-09 14:57 ` Russell King - ARM Linux 2015-01-09 17:38 ` Jean-Francois Moine 2015-01-09 17:38 ` Jean-Francois Moine 2015-01-09 20:01 ` Russell King - ARM Linux 2015-01-09 20:01 ` Russell King - ARM Linux 2015-01-10 15:47 ` [alsa-devel] " Jean-Francois Moine 2015-01-10 15:47 ` Jean-Francois Moine 2015-01-12 9:25 ` Philipp Zabel 2015-01-12 9:25 ` Philipp Zabel 2015-01-12 12:25 ` Russell King - ARM Linux 2015-01-12 13:59 ` Philipp Zabel 2015-01-12 13:59 ` Philipp Zabel 2015-01-12 14:04 ` Russell King - ARM Linux 2015-01-12 14:04 ` Russell King - ARM Linux 2015-01-12 17:13 ` Jean-Francois Moine 2015-01-12 17:13 ` Jean-Francois Moine 2015-01-12 17:57 ` Russell King - ARM Linux 2015-01-12 17:57 ` Russell King - ARM Linux 2015-01-12 19:14 ` Jean-Francois Moine 2015-01-12 19:14 ` Jean-Francois Moine 2015-01-13 12:21 ` Philipp Zabel 2015-01-13 12:21 ` Philipp Zabel 2015-01-13 12:27 ` Russell King - ARM Linux 2015-01-13 12:27 ` Russell King - ARM Linux 2015-01-13 15:54 ` Jean-Francois Moine 2015-01-13 15:54 ` Jean-Francois Moine 2015-01-13 16:03 ` Russell King - ARM Linux 2015-01-13 16:03 ` Russell King - ARM Linux 2015-01-13 19:02 ` Jean-Francois Moine 2015-01-13 19:02 ` Jean-Francois Moine 2015-01-13 19:26 ` Russell King - ARM Linux 2015-01-13 19:26 ` Russell King - ARM Linux 2015-01-13 19:41 ` Jyri Sarha 2015-01-13 19:41 ` Jyri Sarha 2015-01-13 19:54 ` Russell King - ARM Linux 2015-01-13 19:54 ` Russell King - ARM Linux 2015-01-14 7:55 ` Jean-Francois Moine 2015-01-14 7:55 ` Jean-Francois Moine 2015-01-14 12:12 ` Russell King - ARM Linux 2015-01-14 12:12 ` Russell King - ARM Linux 2015-01-14 10:46 ` Philipp Zabel 2015-01-14 10:46 ` Philipp Zabel 2015-01-14 12:50 ` Mark Brown 2015-01-14 12:50 ` Mark Brown 2015-01-14 14:23 ` Russell King - ARM Linux 2015-01-14 14:23 ` Russell King - ARM Linux 2015-01-07 10:00 ` [PATCH v9 2/4] drm/i2c: tda998x: Change drvdata for audio extension Jean-Francois Moine 2015-01-07 10:00 ` Jean-Francois Moine 2015-01-07 10:51 ` [PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter Jean-Francois Moine 2015-01-07 15:10 ` Andrew Jackson 2015-01-07 15:10 ` Andrew Jackson 2015-01-07 15:41 ` Russell King - ARM Linux 2015-01-07 15:41 ` Russell King - ARM Linux 2015-01-07 18:02 ` Jean-Francois Moine 2015-01-09 10:24 ` Jyri Sarha [this message] 2015-01-09 10:24 ` Jyri Sarha 2015-01-09 11:15 ` Jean-Francois Moine 2015-01-09 11:15 ` Jean-Francois Moine 2015-01-09 11:19 ` Russell King - ARM Linux 2015-01-09 11:19 ` Russell King - ARM Linux 2015-01-09 11:45 ` Jean-Francois Moine 2015-01-09 11:45 ` Jean-Francois Moine 2015-01-09 11:48 ` Russell King - ARM Linux 2015-01-09 11:48 ` Russell King - ARM Linux 2015-01-07 17:34 ` Mark Brown 2015-01-07 17:34 ` Mark Brown 2015-01-08 14:55 ` Jyri Sarha 2015-01-08 14:55 ` Jyri Sarha 2015-01-09 17:39 ` Andrew Jackson 2015-01-09 17:39 ` Andrew Jackson 2015-01-09 17:54 ` Mark Brown 2015-01-09 17:54 ` Mark Brown 2015-01-13 9:24 ` Jean-Francois Moine 2015-01-13 9:24 ` Jean-Francois Moine 2015-01-11 21:03 ` Jyri Sarha 2015-01-11 21:03 ` Jyri Sarha 2015-01-13 7:41 ` Jean-Francois Moine 2015-01-13 7:41 ` Jean-Francois Moine 2015-01-07 11:01 ` [PATCH v9 4/4] drm/i2c: tda998x: set cts_n according to the sample width Jean-Francois Moine 2015-01-08 14:53 ` [PATCH v9 0/4] ASoC: tda998x: add a codec to the HDMI transmitter Jyri Sarha 2015-01-08 14:53 ` Jyri Sarha 2015-01-08 20:05 ` Mark Brown 2015-01-09 10:15 ` Jyri Sarha 2015-01-09 10:15 ` Jyri Sarha
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54AFAC4C.7010209@ti.com \ --to=jsarha@ti.com \ --cc=Andrew.Jackson@arm.com \ --cc=airlied@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=moinejf@free.fr \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.