All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	Andrew Jackson <Andrew.Jackson@arm.com>,
	Jyri Sarha <jsarha@ti.com>, Mark Brown <broonie@kernel.org>,
	Dave Airlie <airlied@gmail.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio
Date: Mon, 12 Jan 2015 20:14:37 +0100	[thread overview]
Message-ID: <20150112201437.07254212@armhf> (raw)
In-Reply-To: <20150112175705.GN12302@n2100.arm.linux.org.uk>

On Mon, 12 Jan 2015 17:57:06 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> I don't particularly like that - that makes the assumption that AP0
> always means I2S.  What if a future chip decides to allow SPDIF on
> AP0?  Why should we need to re-invent the binding?
> 
> IMHO, it would be much better to make this explicit.

OK.

> Note that the "video-ports" and "audio-ports" are just labels in the
> DT file; they aren't carried through to the resulting DT binary file,
> so they don't have any meaning to the kernel.

Right, so, either the port type must be explicitly defined, or the name
of the property giving the port value also gives the port type
(nxp,video-port / nxp,audio-port).

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

WARNING: multiple messages have this Message-ID (diff)
From: Jean-Francois Moine <moinejf@free.fr>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Andrew Jackson <Andrew.Jackson@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jyri Sarha <jsarha@ti.com>, Mark Brown <broonie@kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio
Date: Mon, 12 Jan 2015 20:14:37 +0100	[thread overview]
Message-ID: <20150112201437.07254212@armhf> (raw)
In-Reply-To: <20150112175705.GN12302@n2100.arm.linux.org.uk>

On Mon, 12 Jan 2015 17:57:06 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> I don't particularly like that - that makes the assumption that AP0
> always means I2S.  What if a future chip decides to allow SPDIF on
> AP0?  Why should we need to re-invent the binding?
> 
> IMHO, it would be much better to make this explicit.

OK.

> Note that the "video-ports" and "audio-ports" are just labels in the
> DT file; they aren't carried through to the resulting DT binary file,
> so they don't have any meaning to the kernel.

Right, so, either the port type must be explicitly defined, or the name
of the property giving the port value also gives the port type
(nxp,video-port / nxp,audio-port).

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-01-12 19:12 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 11:06 [PATCH v9 0/4] ASoC: tda998x: add a codec to the HDMI transmitter Jean-Francois Moine
2015-01-07 11:06 ` Jean-Francois Moine
2015-01-07  9:10 ` [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio Jean-Francois Moine
2015-01-07  9:10   ` Jean-Francois Moine
2015-01-07 14:39   ` Andrew Jackson
2015-01-07 14:39     ` Andrew Jackson
2015-01-07 17:08     ` Jean-Francois Moine
2015-01-07 17:08       ` Jean-Francois Moine
2015-01-07 17:18       ` Andrew Jackson
2015-01-07 17:18         ` Andrew Jackson
2015-01-07 17:33         ` Mark Brown
2015-01-08 14:53   ` Jyri Sarha
2015-01-08 14:53     ` Jyri Sarha
2015-01-08 16:42     ` Jean-Francois Moine
2015-01-08 16:42       ` Jean-Francois Moine
2015-01-08 20:04       ` Mark Brown
2015-01-08 20:04         ` Mark Brown
2015-01-09  9:25         ` Andrew Jackson
2015-01-09  9:25           ` Andrew Jackson
2015-01-09 10:13       ` Jyri Sarha
2015-01-09 10:13         ` Jyri Sarha
2015-01-09 11:30         ` Jean-Francois Moine
2015-01-09 11:30           ` Jean-Francois Moine
2015-01-09 11:45           ` Russell King - ARM Linux
2015-01-09 11:45             ` Russell King - ARM Linux
2015-01-09 12:54             ` Jean-Francois Moine
2015-01-09 12:54               ` Jean-Francois Moine
2015-01-09 13:07               ` Russell King - ARM Linux
2015-01-09 13:07                 ` Russell King - ARM Linux
2015-01-09 13:58                 ` Andrew Jackson
2015-01-09 13:58                   ` Andrew Jackson
2015-01-09 14:57                   ` Russell King - ARM Linux
2015-01-09 17:38                     ` Jean-Francois Moine
2015-01-09 17:38                       ` Jean-Francois Moine
2015-01-09 20:01                       ` Russell King - ARM Linux
2015-01-09 20:01                         ` Russell King - ARM Linux
2015-01-10 15:47                         ` [alsa-devel] " Jean-Francois Moine
2015-01-10 15:47                           ` Jean-Francois Moine
2015-01-12  9:25                         ` Philipp Zabel
2015-01-12  9:25                           ` Philipp Zabel
2015-01-12 12:25                           ` Russell King - ARM Linux
2015-01-12 13:59                             ` Philipp Zabel
2015-01-12 13:59                               ` Philipp Zabel
2015-01-12 14:04                               ` Russell King - ARM Linux
2015-01-12 14:04                                 ` Russell King - ARM Linux
2015-01-12 17:13                                 ` Jean-Francois Moine
2015-01-12 17:13                                   ` Jean-Francois Moine
2015-01-12 17:57                                   ` Russell King - ARM Linux
2015-01-12 17:57                                     ` Russell King - ARM Linux
2015-01-12 19:14                                     ` Jean-Francois Moine [this message]
2015-01-12 19:14                                       ` Jean-Francois Moine
2015-01-13 12:21                                     ` Philipp Zabel
2015-01-13 12:21                                       ` Philipp Zabel
2015-01-13 12:27                                       ` Russell King - ARM Linux
2015-01-13 12:27                                         ` Russell King - ARM Linux
2015-01-13 15:54                                         ` Jean-Francois Moine
2015-01-13 15:54                                           ` Jean-Francois Moine
2015-01-13 16:03                                           ` Russell King - ARM Linux
2015-01-13 16:03                                             ` Russell King - ARM Linux
2015-01-13 19:02                                             ` Jean-Francois Moine
2015-01-13 19:02                                               ` Jean-Francois Moine
2015-01-13 19:26                                               ` Russell King - ARM Linux
2015-01-13 19:26                                                 ` Russell King - ARM Linux
2015-01-13 19:41                                                 ` Jyri Sarha
2015-01-13 19:41                                                   ` Jyri Sarha
2015-01-13 19:54                                                   ` Russell King - ARM Linux
2015-01-13 19:54                                                     ` Russell King - ARM Linux
2015-01-14  7:55                                                     ` Jean-Francois Moine
2015-01-14  7:55                                                       ` Jean-Francois Moine
2015-01-14 12:12                                                       ` Russell King - ARM Linux
2015-01-14 12:12                                                         ` Russell King - ARM Linux
2015-01-14 10:46                                                     ` Philipp Zabel
2015-01-14 10:46                                                       ` Philipp Zabel
2015-01-14 12:50                                                       ` Mark Brown
2015-01-14 12:50                                                         ` Mark Brown
2015-01-14 14:23                                                         ` Russell King - ARM Linux
2015-01-14 14:23                                                           ` Russell King - ARM Linux
2015-01-07 10:00 ` [PATCH v9 2/4] drm/i2c: tda998x: Change drvdata for audio extension Jean-Francois Moine
2015-01-07 10:00   ` Jean-Francois Moine
2015-01-07 10:51 ` [PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter Jean-Francois Moine
2015-01-07 15:10   ` Andrew Jackson
2015-01-07 15:10     ` Andrew Jackson
2015-01-07 15:41     ` Russell King - ARM Linux
2015-01-07 15:41       ` Russell King - ARM Linux
2015-01-07 18:02       ` Jean-Francois Moine
2015-01-09 10:24         ` Jyri Sarha
2015-01-09 10:24           ` Jyri Sarha
2015-01-09 11:15           ` Jean-Francois Moine
2015-01-09 11:15             ` Jean-Francois Moine
2015-01-09 11:19           ` Russell King - ARM Linux
2015-01-09 11:19             ` Russell King - ARM Linux
2015-01-09 11:45             ` Jean-Francois Moine
2015-01-09 11:45               ` Jean-Francois Moine
2015-01-09 11:48               ` Russell King - ARM Linux
2015-01-09 11:48                 ` Russell King - ARM Linux
2015-01-07 17:34     ` Mark Brown
2015-01-07 17:34       ` Mark Brown
2015-01-08 14:55   ` Jyri Sarha
2015-01-08 14:55     ` Jyri Sarha
2015-01-09 17:39   ` Andrew Jackson
2015-01-09 17:39     ` Andrew Jackson
2015-01-09 17:54     ` Mark Brown
2015-01-09 17:54       ` Mark Brown
2015-01-13  9:24     ` Jean-Francois Moine
2015-01-13  9:24       ` Jean-Francois Moine
2015-01-11 21:03   ` Jyri Sarha
2015-01-11 21:03     ` Jyri Sarha
2015-01-13  7:41     ` Jean-Francois Moine
2015-01-13  7:41       ` Jean-Francois Moine
2015-01-07 11:01 ` [PATCH v9 4/4] drm/i2c: tda998x: set cts_n according to the sample width Jean-Francois Moine
2015-01-08 14:53 ` [PATCH v9 0/4] ASoC: tda998x: add a codec to the HDMI transmitter Jyri Sarha
2015-01-08 14:53   ` Jyri Sarha
2015-01-08 20:05   ` Mark Brown
2015-01-09 10:15     ` Jyri Sarha
2015-01-09 10:15       ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112201437.07254212@armhf \
    --to=moinejf@free.fr \
    --cc=Andrew.Jackson@arm.com \
    --cc=airlied@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.