All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Forissier <jerome.forissier@linaro.org>
To: John Keeping <john@metanate.com>, Jaehoon Chung <jh80.chung@samsung.com>
Cc: Peng Fan <peng.fan@nxp.com>, u-boot@lists.denx.de
Subject: Re: [PATCH] mmc: dwmmc: only clear handled interrupts
Date: Fri, 16 Sep 2022 10:20:32 +0200	[thread overview]
Message-ID: <3b9a71b0-6105-4736-49bb-add913bc1e2a@linaro.org> (raw)
In-Reply-To: <20220915175656.3447093-1-john@metanate.com>



On 9/15/22 19:56, John Keeping wrote:
> Unconditionally clearing DTO when RXDR is set leads to spurious timeouts
> in FIFO mode transfers if events occur in the following order:
> 
> 	mask = dwmci_readl(host, DWMCI_RINTSTS);
> 
> 	// Hardware asserts DWMCI_INTMSK_DTO here
> 
> 	dwmci_writel(host, DWMCI_RINTSTS, DWMCI_INTMSK_DTO);
> 
> 	if (mask & DWMCI_INTMSK_DTO) {
> 		// Unreachable as DTO is cleared without being handled!
> 		return 0;
> 	}
> 
> Only clear interrupts that we have seen and are handling so that DTO is
> not missed.
> 
> Signed-off-by: John Keeping <john@metanate.com>
> ---
>  drivers/mmc/dw_mmc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index 4232c5eb8c..5085a3b491 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -168,7 +168,8 @@ static int dwmci_data_transfer(struct dwmci_host *host, struct mmc_data *data)
>  			if (data->flags == MMC_DATA_READ &&
>  			    (mask & (DWMCI_INTMSK_RXDR | DWMCI_INTMSK_DTO))) {
>  				dwmci_writel(host, DWMCI_RINTSTS,
> -					     DWMCI_INTMSK_RXDR | DWMCI_INTMSK_DTO);
> +					     mask & (DWMCI_INTMSK_RXDR |
> +						     DWMCI_INTMSK_DTO));
>  				while (size) {
>  					ret = dwmci_fifo_ready(host,
>  							DWMCI_FIFO_EMPTY,

Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (Rock PI 4B)

Boot logs:

- 2022.04 without this patch:

[...]
U-Boot SPL 2022.04 (Apr 04 2022 - 14:31:32 +0000)

Trying to boot from MMC1

## Checking hash(es) for config config_1 ... sha1,rsa2048:dev+ OK

## Checking hash(es) for Image atf_1 ... sha1+ sha1,rsa2048:dev+ OK

## Checking hash(es) for Image uboot ... sha1+ sha1,rsa2048:dev+ OK

## Checking hash(es) for Image fdt_1 ... sha1+ sha1,rsa2048:dev+ OK

spl_load_simple_fit: can't load image loadables index 1 (ret = -5)

mmc_load_image_raw_sector: mmc block read error


[...]

- 2022.04 with this patch:

[...]
U-Boot SPL 2022.04 (Apr 04 2022 - 14:31:32 +0000)

Trying to boot from MMC1

## Checking hash(es) for config config_1 ... sha1,rsa2048:dev+ OK

## Checking hash(es) for Image atf_1 ... sha1+ sha1,rsa2048:dev+ OK

## Checking hash(es) for Image uboot ... sha1+ sha1,rsa2048:dev+ OK

## Checking hash(es) for Image fdt_1 ... sha1+ sha1,rsa2048:dev+ OK

## Checking hash(es) for Image atf_2 ... sha1+ sha1,rsa2048:dev+ OK

## Checking hash(es) for Image atf_3 ... sha1+ sha1,rsa2048:dev+ OK

## Checking hash(es) for Image atf_4 ... sha1+ sha1,rsa2048:dev+ OK

NOTICE:  BL31: v2.6(debug):v2.6-879-gc3bdd3d3cf-dirty

[...]

Thanks,
-- 
Jerome

  reply	other threads:[~2022-09-16  8:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 17:56 [PATCH] mmc: dwmmc: only clear handled interrupts John Keeping
2022-09-16  8:20 ` Jerome Forissier [this message]
2022-09-16  8:56 ` Quentin Schulz
2022-10-07 12:34 ` Jaehoon Chung
     [not found] ` <CGME20221025000216epcas1p3175ad85b4e7212f3304e9b616c27000f@epcas1p3.samsung.com>
2022-10-25  0:02   ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b9a71b0-6105-4736-49bb-add913bc1e2a@linaro.org \
    --to=jerome.forissier@linaro.org \
    --cc=jh80.chung@samsung.com \
    --cc=john@metanate.com \
    --cc=peng.fan@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.