All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
To: John Keeping <john@metanate.com>, Jaehoon Chung <jh80.chung@samsung.com>
Cc: Peng Fan <peng.fan@nxp.com>, u-boot@lists.denx.de
Subject: Re: [PATCH] mmc: dwmmc: only clear handled interrupts
Date: Fri, 16 Sep 2022 10:56:56 +0200	[thread overview]
Message-ID: <3c95dc1f-0434-6ba7-a570-d781876605b9@theobroma-systems.com> (raw)
In-Reply-To: <20220915175656.3447093-1-john@metanate.com>

Hi John,

On 9/15/22 19:56, John Keeping wrote:
> Unconditionally clearing DTO when RXDR is set leads to spurious timeouts
> in FIFO mode transfers if events occur in the following order:
> 
> 	mask = dwmci_readl(host, DWMCI_RINTSTS);
> 
> 	// Hardware asserts DWMCI_INTMSK_DTO here
> 
> 	dwmci_writel(host, DWMCI_RINTSTS, DWMCI_INTMSK_DTO);
> 
> 	if (mask & DWMCI_INTMSK_DTO) {
> 		// Unreachable as DTO is cleared without being handled!
> 		return 0;
> 	}
> 
> Only clear interrupts that we have seen and are handling so that DTO is
> not missed.
> 
> Signed-off-by: John Keeping <john@metanate.com>

Awesome! I was having what I thought were stability issues on a board 
I'm bringing up and this fixes the issue. Thanks!

Tested-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> 
(PX30-based eMMC+SD, Puma RK3399 eMMC)

Cheers,
Quentin

  parent reply	other threads:[~2022-09-16  8:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 17:56 [PATCH] mmc: dwmmc: only clear handled interrupts John Keeping
2022-09-16  8:20 ` Jerome Forissier
2022-09-16  8:56 ` Quentin Schulz [this message]
2022-10-07 12:34 ` Jaehoon Chung
     [not found] ` <CGME20221025000216epcas1p3175ad85b4e7212f3304e9b616c27000f@epcas1p3.samsung.com>
2022-10-25  0:02   ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c95dc1f-0434-6ba7-a570-d781876605b9@theobroma-systems.com \
    --to=quentin.schulz@theobroma-systems.com \
    --cc=jh80.chung@samsung.com \
    --cc=john@metanate.com \
    --cc=peng.fan@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.