From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com> To: Mark Brown <broonie@kernel.org> Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v7 1/4] arm64: Make all stack walking functions use arch_stack_walk() Date: Thu, 12 Aug 2021 11:30:41 -0500 [thread overview] Message-ID: <3c8b7882-047f-089d-a0e4-e62aedd6e045@linux.microsoft.com> (raw) In-Reply-To: <20210812152331.GA4239@sirena.org.uk> On 8/12/21 10:23 AM, Mark Brown wrote: > On Thu, Aug 12, 2021 at 08:24:32AM -0500, madvenka@linux.microsoft.com wrote: > >> Here is the list of functions: >> >> perf_callchain_kernel() >> get_wchan() >> return_address() >> dump_backtrace() >> profile_pc() > > I've not actually gone through this properly yet but my first thought is > that for clarity this should be split out into a patch per user plus one > to delete the old interface - I'd not worry about it unless it needs to > get resubmitted though. > OK. I will address it in the next version. > It'll definitely be good to get this done! Yes. Thanks! Madhavan
WARNING: multiple messages have this Message-ID (diff)
From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com> To: Mark Brown <broonie@kernel.org> Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v7 1/4] arm64: Make all stack walking functions use arch_stack_walk() Date: Thu, 12 Aug 2021 11:30:41 -0500 [thread overview] Message-ID: <3c8b7882-047f-089d-a0e4-e62aedd6e045@linux.microsoft.com> (raw) In-Reply-To: <20210812152331.GA4239@sirena.org.uk> On 8/12/21 10:23 AM, Mark Brown wrote: > On Thu, Aug 12, 2021 at 08:24:32AM -0500, madvenka@linux.microsoft.com wrote: > >> Here is the list of functions: >> >> perf_callchain_kernel() >> get_wchan() >> return_address() >> dump_backtrace() >> profile_pc() > > I've not actually gone through this properly yet but my first thought is > that for clarity this should be split out into a patch per user plus one > to delete the old interface - I'd not worry about it unless it needs to > get resubmitted though. > OK. I will address it in the next version. > It'll definitely be good to get this done! Yes. Thanks! Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-12 16:30 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <3f2aab69a35c243c5e97f47c4ad84046355f5b90> 2021-06-30 22:33 ` [RFC PATCH v6 0/3] arm64: Implement stack trace reliability checks madvenka 2021-06-30 22:33 ` madvenka 2021-06-30 22:33 ` [RFC PATCH v6 1/3] arm64: Improve the unwinder return value madvenka 2021-06-30 22:33 ` madvenka 2021-07-28 16:56 ` Mark Rutland 2021-07-28 16:56 ` Mark Rutland 2021-07-29 13:54 ` Madhavan T. Venkataraman 2021-07-29 13:54 ` Madhavan T. Venkataraman 2021-06-30 22:33 ` [RFC PATCH v6 2/3] arm64: Introduce stack trace reliability checks in the unwinder madvenka 2021-06-30 22:33 ` madvenka 2021-06-30 22:33 ` [RFC PATCH v6 3/3] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka 2021-06-30 22:33 ` madvenka 2021-07-28 17:25 ` Mark Rutland 2021-07-28 17:25 ` Mark Rutland 2021-07-29 14:06 ` Madhavan T. Venkataraman 2021-07-29 14:06 ` Madhavan T. Venkataraman 2021-07-29 14:52 ` Mark Brown 2021-07-29 14:52 ` Mark Brown 2021-07-29 17:07 ` Madhavan T. Venkataraman 2021-07-29 17:07 ` Madhavan T. Venkataraman 2021-07-29 15:48 ` Mark Rutland 2021-07-29 15:48 ` Mark Rutland 2021-07-29 16:27 ` Mark Brown 2021-07-29 16:27 ` Mark Brown 2021-07-29 17:09 ` Madhavan T. Venkataraman 2021-07-29 17:09 ` Madhavan T. Venkataraman 2021-07-26 13:49 ` [RFC PATCH v6 0/3] arm64: Implement stack trace reliability checks Madhavan T. Venkataraman 2021-07-26 13:49 ` Madhavan T. Venkataraman 2021-08-12 13:24 ` [RFC PATCH v7 0/4] arm64: Reorganize the unwinder and implement " madvenka 2021-08-12 13:24 ` madvenka 2021-08-12 13:24 ` [RFC PATCH v7 1/4] arm64: Make all stack walking functions use arch_stack_walk() madvenka 2021-08-12 13:24 ` madvenka 2021-08-12 15:23 ` Mark Brown 2021-08-12 15:23 ` Mark Brown 2021-08-12 16:30 ` Madhavan T. Venkataraman [this message] 2021-08-12 16:30 ` Madhavan T. Venkataraman 2021-08-12 20:59 ` kernel test robot 2021-08-12 13:24 ` [RFC PATCH v7 2/4] arm64: Reorganize the unwinder code for better consistency and maintenance madvenka 2021-08-12 13:24 ` madvenka 2021-08-12 13:24 ` [RFC PATCH v7 3/4] arm64: Introduce stack trace reliability checks in the unwinder madvenka 2021-08-12 13:24 ` madvenka 2021-08-12 13:24 ` [RFC PATCH v7 4/4] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka 2021-08-12 13:24 ` madvenka 2021-08-12 18:53 ` kernel test robot 2021-08-12 18:31 ` [RFC PATCH v7 0/4] arm64: Reorganize the unwinder and implement stack trace reliability checks Madhavan T. Venkataraman 2021-08-12 18:31 ` Madhavan T. Venkataraman 2021-08-12 18:45 ` Madhavan T. Venkataraman 2021-08-12 18:45 ` Madhavan T. Venkataraman 2021-08-12 18:35 ` madvenka 2021-08-12 18:35 ` madvenka 2021-08-12 18:35 ` [RFC PATCH v7 1/4] arm64: Make all stack walking functions use arch_stack_walk() madvenka 2021-08-12 18:35 ` madvenka 2021-08-12 18:35 ` [RFC PATCH v7 2/4] arm64: Reorganize the unwinder code for better consistency and maintenance madvenka 2021-08-12 18:35 ` madvenka 2021-08-12 18:35 ` [RFC PATCH v7 3/4] arm64: Introduce stack trace reliability checks in the unwinder madvenka 2021-08-12 18:35 ` madvenka 2021-08-12 18:35 ` [RFC PATCH v7 4/4] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka 2021-08-12 18:35 ` madvenka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3c8b7882-047f-089d-a0e4-e62aedd6e045@linux.microsoft.com \ --to=madvenka@linux.microsoft.com \ --cc=ardb@kernel.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=jmorris@namei.org \ --cc=jpoimboe@redhat.com \ --cc=jthierry@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=live-patching@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nobuta.keiya@fujitsu.com \ --cc=pasha.tatashin@soleen.com \ --cc=sjitindarsingh@gmail.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.