From: Mark Brown <broonie@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>,
jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com,
sjitindarsingh@gmail.com, catalin.marinas@arm.com,
will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com,
jthierry@redhat.com, linux-arm-kernel@lists.infradead.org,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v6 3/3] arm64: Create a list of SYM_CODE functions, check return PC against list
Date: Thu, 29 Jul 2021 17:27:49 +0100 [thread overview]
Message-ID: <20210729162749.GA51855@sirena.org.uk> (raw)
In-Reply-To: <20210729154804.GA59940@C02TD0UTHF1T.local>
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
On Thu, Jul 29, 2021 at 04:48:04PM +0100, Mark Rutland wrote:
> For clarity, let's take your bullet-point list above as a list of
> examples, and make that:
> /*
> * As SYM_CODE functions don't follow the usual calling
> * conventions, we assume by default that any SYM_CODE function
> * cannot be unwound reliably.
> *
> * Note that this includes:
> *
> * - Exception handlers and entry assembly
> * - Trampoline assembly (e.g., ftrace, kprobes)
> * - Hypervisor-related assembly
> * - Hibernation-related assembly
> * - CPU start-stop, suspend-resume assembly
> * - Kernel relocation assembly
> */
This looks good to me too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>,
jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com,
sjitindarsingh@gmail.com, catalin.marinas@arm.com,
will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com,
jthierry@redhat.com, linux-arm-kernel@lists.infradead.org,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v6 3/3] arm64: Create a list of SYM_CODE functions, check return PC against list
Date: Thu, 29 Jul 2021 17:27:49 +0100 [thread overview]
Message-ID: <20210729162749.GA51855@sirena.org.uk> (raw)
In-Reply-To: <20210729154804.GA59940@C02TD0UTHF1T.local>
[-- Attachment #1.1: Type: text/plain, Size: 657 bytes --]
On Thu, Jul 29, 2021 at 04:48:04PM +0100, Mark Rutland wrote:
> For clarity, let's take your bullet-point list above as a list of
> examples, and make that:
> /*
> * As SYM_CODE functions don't follow the usual calling
> * conventions, we assume by default that any SYM_CODE function
> * cannot be unwound reliably.
> *
> * Note that this includes:
> *
> * - Exception handlers and entry assembly
> * - Trampoline assembly (e.g., ftrace, kprobes)
> * - Hypervisor-related assembly
> * - Hibernation-related assembly
> * - CPU start-stop, suspend-resume assembly
> * - Kernel relocation assembly
> */
This looks good to me too.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-29 16:28 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3f2aab69a35c243c5e97f47c4ad84046355f5b90>
2021-06-30 22:33 ` [RFC PATCH v6 0/3] arm64: Implement stack trace reliability checks madvenka
2021-06-30 22:33 ` madvenka
2021-06-30 22:33 ` [RFC PATCH v6 1/3] arm64: Improve the unwinder return value madvenka
2021-06-30 22:33 ` madvenka
2021-07-28 16:56 ` Mark Rutland
2021-07-28 16:56 ` Mark Rutland
2021-07-29 13:54 ` Madhavan T. Venkataraman
2021-07-29 13:54 ` Madhavan T. Venkataraman
2021-06-30 22:33 ` [RFC PATCH v6 2/3] arm64: Introduce stack trace reliability checks in the unwinder madvenka
2021-06-30 22:33 ` madvenka
2021-06-30 22:33 ` [RFC PATCH v6 3/3] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka
2021-06-30 22:33 ` madvenka
2021-07-28 17:25 ` Mark Rutland
2021-07-28 17:25 ` Mark Rutland
2021-07-29 14:06 ` Madhavan T. Venkataraman
2021-07-29 14:06 ` Madhavan T. Venkataraman
2021-07-29 14:52 ` Mark Brown
2021-07-29 14:52 ` Mark Brown
2021-07-29 17:07 ` Madhavan T. Venkataraman
2021-07-29 17:07 ` Madhavan T. Venkataraman
2021-07-29 15:48 ` Mark Rutland
2021-07-29 15:48 ` Mark Rutland
2021-07-29 16:27 ` Mark Brown [this message]
2021-07-29 16:27 ` Mark Brown
2021-07-29 17:09 ` Madhavan T. Venkataraman
2021-07-29 17:09 ` Madhavan T. Venkataraman
2021-07-26 13:49 ` [RFC PATCH v6 0/3] arm64: Implement stack trace reliability checks Madhavan T. Venkataraman
2021-07-26 13:49 ` Madhavan T. Venkataraman
2021-08-12 13:24 ` [RFC PATCH v7 0/4] arm64: Reorganize the unwinder and implement " madvenka
2021-08-12 13:24 ` madvenka
2021-08-12 13:24 ` [RFC PATCH v7 1/4] arm64: Make all stack walking functions use arch_stack_walk() madvenka
2021-08-12 13:24 ` madvenka
2021-08-12 15:23 ` Mark Brown
2021-08-12 15:23 ` Mark Brown
2021-08-12 16:30 ` Madhavan T. Venkataraman
2021-08-12 16:30 ` Madhavan T. Venkataraman
2021-08-12 20:59 ` kernel test robot
2021-08-12 13:24 ` [RFC PATCH v7 2/4] arm64: Reorganize the unwinder code for better consistency and maintenance madvenka
2021-08-12 13:24 ` madvenka
2021-08-12 13:24 ` [RFC PATCH v7 3/4] arm64: Introduce stack trace reliability checks in the unwinder madvenka
2021-08-12 13:24 ` madvenka
2021-08-12 13:24 ` [RFC PATCH v7 4/4] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka
2021-08-12 13:24 ` madvenka
2021-08-12 18:53 ` kernel test robot
2021-08-12 18:31 ` [RFC PATCH v7 0/4] arm64: Reorganize the unwinder and implement stack trace reliability checks Madhavan T. Venkataraman
2021-08-12 18:31 ` Madhavan T. Venkataraman
2021-08-12 18:45 ` Madhavan T. Venkataraman
2021-08-12 18:45 ` Madhavan T. Venkataraman
2021-08-12 18:35 ` madvenka
2021-08-12 18:35 ` madvenka
2021-08-12 18:35 ` [RFC PATCH v7 1/4] arm64: Make all stack walking functions use arch_stack_walk() madvenka
2021-08-12 18:35 ` madvenka
2021-08-12 18:35 ` [RFC PATCH v7 2/4] arm64: Reorganize the unwinder code for better consistency and maintenance madvenka
2021-08-12 18:35 ` madvenka
2021-08-12 18:35 ` [RFC PATCH v7 3/4] arm64: Introduce stack trace reliability checks in the unwinder madvenka
2021-08-12 18:35 ` madvenka
2021-08-12 18:35 ` [RFC PATCH v7 4/4] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka
2021-08-12 18:35 ` madvenka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729162749.GA51855@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jmorris@namei.org \
--cc=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=madvenka@linux.microsoft.com \
--cc=mark.rutland@arm.com \
--cc=nobuta.keiya@fujitsu.com \
--cc=pasha.tatashin@soleen.com \
--cc=sjitindarsingh@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.