From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> To: Li Jun <jun.li@nxp.com>, robh+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, linux@roeck-us.net Cc: a.hajda@samsung.com, cw00.choi@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, gsomlo@gmail.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH v5 08/14] staging: typec: tcpci: register port before request irq Date: Thu, 3 May 2018 11:34:33 +0300 [thread overview] Message-ID: <3d764d7b-9829-8f49-f2c9-70e5413f76ba@cogentembedded.com> (raw) In-Reply-To: <9e9dcdba-f46d-483f-e544-d1d55cd4ed23@cogentembedded.com> On 5/3/2018 11:29 AM, Sergei Shtylyov wrote: >> From: Peter Chen <peter.chen@nxp.com> >> >> With that we can clear any pending events and the port is registered >> so driver can be ready to handle typec events once we request irq. >> >> Signed-off-by: Peter Chen <peter.chen@nxp.com> >> Signed-off-by: Li Jun <jun.li@nxp.com> >> --- >> drivers/staging/typec/tcpci.c | 15 +++++++++------ >> 1 file changed, 9 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c >> index a21aaf5..139c2ab 100644 >> --- a/drivers/staging/typec/tcpci.c >> +++ b/drivers/staging/typec/tcpci.c >> @@ -537,24 +537,27 @@ static int tcpci_probe(struct i2c_client *client, >> if (IS_ERR(chip->data.regmap)) >> return PTR_ERR(chip->data.regmap); >> + i2c_set_clientdata(client, chip); >> + >> /* Disable chip interrupts before requesting irq */ >> err = regmap_raw_write(chip->data.regmap, TCPC_ALERT_MASK, &val, >> sizeof(u16)); >> if (err < 0) >> return err; >> + chip->tcpci = tcpci_register_port(&client->dev, &chip->data); >> + if (PTR_ERR_OR_ZERO(chip->tcpci)) > > Is NULL an error indication too? > >> + return PTR_ERR(chip->tcpci); > > If so, you'll return a success indication here. ... when chip->tcpci is NULL, I mean. Seems wrong... >> + >> err = devm_request_threaded_irq(&client->dev, client->irq, NULL, >> _tcpci_irq, >> IRQF_ONESHOT | IRQF_TRIGGER_LOW, >> dev_name(&client->dev), chip); >> - if (err < 0) >> + if (err < 0) { >> + tcpci_unregister_port(chip->tcpci); >> return err; >> + } >> - chip->tcpci = tcpci_register_port(&client->dev, &chip->data); >> - if (PTR_ERR_OR_ZERO(chip->tcpci)) >> - return PTR_ERR(chip->tcpci); >> - Ah, you're only moving the questionable code... >> - i2c_set_clientdata(client, chip); >> return 0; >> } MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> To: Li Jun <jun.li@nxp.com>, robh+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, linux@roeck-us.net Cc: a.hajda@samsung.com, cw00.choi@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, gsomlo@gmail.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com Subject: [v5,08/14] staging: typec: tcpci: register port before request irq Date: Thu, 3 May 2018 11:34:33 +0300 [thread overview] Message-ID: <3d764d7b-9829-8f49-f2c9-70e5413f76ba@cogentembedded.com> (raw) On 5/3/2018 11:29 AM, Sergei Shtylyov wrote: >> From: Peter Chen <peter.chen@nxp.com> >> >> With that we can clear any pending events and the port is registered >> so driver can be ready to handle typec events once we request irq. >> >> Signed-off-by: Peter Chen <peter.chen@nxp.com> >> Signed-off-by: Li Jun <jun.li@nxp.com> >> --- >> drivers/staging/typec/tcpci.c | 15 +++++++++------ >> 1 file changed, 9 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c >> index a21aaf5..139c2ab 100644 >> --- a/drivers/staging/typec/tcpci.c >> +++ b/drivers/staging/typec/tcpci.c >> @@ -537,24 +537,27 @@ static int tcpci_probe(struct i2c_client *client, >> if (IS_ERR(chip->data.regmap)) >> return PTR_ERR(chip->data.regmap); >> + i2c_set_clientdata(client, chip); >> + >> /* Disable chip interrupts before requesting irq */ >> err = regmap_raw_write(chip->data.regmap, TCPC_ALERT_MASK, &val, >> sizeof(u16)); >> if (err < 0) >> return err; >> + chip->tcpci = tcpci_register_port(&client->dev, &chip->data); >> + if (PTR_ERR_OR_ZERO(chip->tcpci)) > > Is NULL an error indication too? > >> + return PTR_ERR(chip->tcpci); > > If so, you'll return a success indication here. ... when chip->tcpci is NULL, I mean. Seems wrong... >> + >> err = devm_request_threaded_irq(&client->dev, client->irq, NULL, >> _tcpci_irq, >> IRQF_ONESHOT | IRQF_TRIGGER_LOW, >> dev_name(&client->dev), chip); >> - if (err < 0) >> + if (err < 0) { >> + tcpci_unregister_port(chip->tcpci); >> return err; >> + } >> - chip->tcpci = tcpci_register_port(&client->dev, &chip->data); >> - if (PTR_ERR_OR_ZERO(chip->tcpci)) >> - return PTR_ERR(chip->tcpci); >> - Ah, you're only moving the questionable code... >> - i2c_set_clientdata(client, chip); >> return 0; >> } MBR, Sergei --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-03 8:34 UTC|newest] Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-03 0:24 [PATCH v5 00/14] staging: typec: tcpci: move out of staging Li Jun 2018-05-03 0:24 ` [PATCH v5 01/14] dt-bindings: connector: add properties for typec Li Jun 2018-05-03 0:24 ` [v5,01/14] " Jun Li 2018-05-03 7:27 ` [PATCH v5 01/14] " Oliver Neukum 2018-05-03 7:27 ` [v5,01/14] " Oliver Neukum 2018-05-03 8:35 ` [PATCH v5 01/14] " Jun Li 2018-05-03 8:35 ` [v5,01/14] " Jun Li 2018-05-03 9:17 ` [PATCH v5 01/14] " Oliver Neukum 2018-05-03 9:17 ` [v5,01/14] " Oliver Neukum 2018-05-04 8:59 ` [PATCH v5 01/14] " Jun Li 2018-05-04 8:59 ` [v5,01/14] " Jun Li 2018-05-08 10:03 ` [PATCH v5 01/14] " Oliver Neukum 2018-05-08 10:03 ` [v5,01/14] " Oliver Neukum 2018-05-10 0:43 ` [PATCH v5 01/14] " Jun Li 2018-05-10 0:43 ` [v5,01/14] " Jun Li 2018-05-07 15:58 ` [PATCH v5 01/14] " Rob Herring 2018-05-07 15:58 ` [v5,01/14] " Rob Herring 2018-05-08 5:36 ` [PATCH v5 01/14] " Jun Li 2018-05-08 5:36 ` [v5,01/14] " Jun Li 2018-05-11 19:49 ` [PATCH v5 01/14] " Mats Karrman 2018-05-11 19:49 ` [v5,01/14] " Mats Karrman 2018-05-14 9:06 ` [PATCH v5 01/14] " Jun Li 2018-05-14 9:06 ` [v5,01/14] " Jun Li 2018-05-16 7:21 ` [PATCH v5 01/14] " Peter Chen 2018-05-16 7:21 ` [v5,01/14] " Peter Chen 2018-05-17 13:16 ` [PATCH v5 01/14] " Jun Li 2018-05-17 13:16 ` [v5,01/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 02/14] dt-bindings: usb: add documentation for typec port controller(TCPCI) Li Jun 2018-05-03 0:24 ` [v5,02/14] " Jun Li 2018-05-07 16:01 ` [PATCH v5 02/14] " Rob Herring 2018-05-07 16:01 ` [v5,02/14] " Rob Herring 2018-05-03 0:24 ` [PATCH v5 03/14] staging: typec: tcpci: add compatible string for nxp ptn5110 Li Jun 2018-05-03 0:24 ` [v5,03/14] " Jun Li 2018-05-11 19:51 ` [PATCH v5 03/14] " Mats Karrman 2018-05-11 19:51 ` [v5,03/14] " Mats Karrman 2018-05-14 9:15 ` [PATCH v5 03/14] " Jun Li 2018-05-14 9:15 ` [v5,03/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 04/14] usb: typec: add fwnode to tcpc Li Jun 2018-05-03 0:24 ` [v5,04/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config Li Jun 2018-05-03 0:24 ` [v5,05/14] " Jun Li 2018-05-11 19:55 ` [PATCH v5 05/14] " Mats Karrman 2018-05-11 19:55 ` [v5,05/14] " Mats Karrman 2018-05-14 9:36 ` [PATCH v5 05/14] " Jun Li 2018-05-14 9:36 ` [v5,05/14] " Jun Li 2018-05-15 20:52 ` [PATCH v5 05/14] " Mats Karrman 2018-05-15 20:52 ` [v5,05/14] " Mats Karrman 2018-05-16 12:25 ` [PATCH v5 05/14] " Heikki Krogerus 2018-05-16 12:25 ` [v5,05/14] " Heikki Krogerus 2018-05-16 20:55 ` [PATCH v5 05/14] " Mats Karrman 2018-05-16 20:55 ` [v5,05/14] " Mats Karrman 2018-05-17 12:35 ` [PATCH v5 05/14] " Heikki Krogerus 2018-05-17 12:35 ` [v5,05/14] " Heikki Krogerus 2018-05-17 14:05 ` [PATCH v5 05/14] " Jun Li 2018-05-17 14:05 ` [v5,05/14] " Jun Li 2018-05-17 14:24 ` [PATCH v5 05/14] " Heikki Krogerus 2018-05-17 14:24 ` [v5,05/14] " Heikki Krogerus 2018-05-17 14:41 ` [PATCH v5 05/14] " Jun Li 2018-05-17 14:41 ` [v5,05/14] " Jun Li 2018-05-21 13:12 ` [PATCH v5 05/14] " Heikki Krogerus 2018-05-21 13:12 ` [v5,05/14] " Heikki Krogerus 2018-05-22 14:19 ` [PATCH v5 05/14] " Jun Li 2018-05-22 14:19 ` [v5,05/14] " Jun Li 2018-05-17 13:53 ` [PATCH v5 05/14] " Jun Li 2018-05-17 13:53 ` [v5,05/14] " Jun Li 2018-05-17 13:26 ` [PATCH v5 05/14] " Jun Li 2018-05-17 13:26 ` [v5,05/14] " Jun Li 2018-05-17 13:16 ` [PATCH v5 05/14] " Jun Li 2018-05-17 13:16 ` [v5,05/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 06/14] usb: typec: tcpm: support get typec and pd config from device properties Li Jun 2018-05-03 0:24 ` [v5,06/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 07/14] staging: typec: tcpci: remove unused tcpci_tcpc_config Li Jun 2018-05-03 0:24 ` [v5,07/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 08/14] staging: typec: tcpci: register port before request irq Li Jun 2018-05-03 0:24 ` [v5,08/14] " Jun Li 2018-05-03 8:29 ` [PATCH v5 08/14] " Sergei Shtylyov 2018-05-03 8:29 ` [v5,08/14] " Sergei Shtylyov 2018-05-03 8:34 ` Sergei Shtylyov [this message] 2018-05-03 8:34 ` Sergei Shtylyov 2018-05-03 0:24 ` [PATCH v5 09/14] staging: typec: tcpci: enable vbus detection Li Jun 2018-05-03 0:24 ` [v5,09/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 10/14] typec: tcpm: add starting value for drp toggling Li Jun 2018-05-03 0:24 ` [v5,10/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 11/14] usb: typec: tcpm: set cc for drp toggling attach Li Jun 2018-05-03 0:24 ` [v5,11/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 12/14] staging: typec: tcpci: keep the not connecting cc line open Li Jun 2018-05-03 0:24 ` [v5,12/14] " Jun Li 2018-05-16 8:35 ` [PATCH v5 12/14] " Peter Chen 2018-05-16 8:35 ` [v5,12/14] " Peter Chen 2018-05-17 13:17 ` [PATCH v5 12/14] " Jun Li 2018-05-17 13:17 ` [v5,12/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 13/14] staging: typec: tcpci: Only touch target bit when enable vconn Li Jun 2018-05-03 0:24 ` [v5,13/14] " Jun Li 2018-05-03 0:24 ` [PATCH v5 14/14] staging: typec: tcpci: move tcpci driver out of staging Li Jun 2018-05-03 0:24 ` [v5,14/14] " Jun Li 2018-05-11 21:37 ` [PATCH v5 14/14] " Mats Karrman 2018-05-11 21:37 ` [v5,14/14] " Mats Karrman 2018-05-14 9:38 ` [PATCH v5 14/14] " Jun Li 2018-05-14 9:38 ` [v5,14/14] " Jun Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3d764d7b-9829-8f49-f2c9-70e5413f76ba@cogentembedded.com \ --to=sergei.shtylyov@cogentembedded.com \ --cc=a.hajda@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=gsomlo@gmail.com \ --cc=heikki.krogerus@linux.intel.com \ --cc=jun.li@nxp.com \ --cc=linux-imx@nxp.com \ --cc=linux-usb@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=peter.chen@nxp.com \ --cc=robh+dt@kernel.org \ --cc=shufan_lee@richtek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.