From: Eric Auger <eauger@redhat.com> To: Gavin Shan <gshan@redhat.com>, Shannon Zhao <shannon.zhaosl@gmail.com>, kvmarm@lists.cs.columbia.edu Cc: maz@kernel.org, pbonzini@redhat.com, will@kernel.org, linux-kernel@vger.kernel.org, Jonathan.Cameron@huawei.com Subject: Re: [PATCH v4 06/21] KVM: arm64: Support SDEI_EVENT_CONTEXT hypercall Date: Tue, 25 Jan 2022 19:31:39 +0100 [thread overview] Message-ID: <3d791443-d3d3-29fb-98a4-bebadb84597e@redhat.com> (raw) In-Reply-To: <798ecbb0-f369-f3e7-ad50-78acfd902d1d@redhat.com> Hi Gavin, On 1/13/22 8:02 AM, Gavin Shan wrote: > Hi Shannon, > > On 1/11/22 5:43 PM, Shannon Zhao wrote: >> On 2021/8/15 8:13, Gavin Shan wrote: >>> +static unsigned long kvm_sdei_hypercall_context(struct kvm_vcpu *vcpu) >>> +{ >>> + struct kvm *kvm = vcpu->kvm; >>> + struct kvm_sdei_kvm *ksdei = kvm->arch.sdei; >>> + struct kvm_sdei_vcpu *vsdei = vcpu->arch.sdei; >>> + struct kvm_sdei_vcpu_regs *regs; >>> + unsigned long index = smccc_get_arg1(vcpu); >>> + unsigned long ret = SDEI_SUCCESS; >>> + >>> + /* Sanity check */ >>> + if (!(ksdei && vsdei)) { >>> + ret = SDEI_NOT_SUPPORTED; >>> + goto out; >>> + } >> Maybe we could move these common sanity check codes to >> kvm_sdei_hypercall to save some lines. >> > > Not all hypercalls need this check. For example, > COMPLETE/COMPLETE_RESUME/CONTEXT don't > have SDEI event number as the argument. If we really want move this > check into function > kvm_sdei_hypercall(), we would have code like below. Too much duplicated > snippets will > be seen. I don't think it's better than what we have if I fully > understand your comments. > > switch (...) { > case REGISTER: > if (!(ksdei && vsdei)) { > ret = SDEI_NOT_SUPPORTED; > break; > } at least you can use an inline function taking the vcpu as param? Thanks Eric > > ret = kvm_sdei_hypercall_register(vcpu); > break; > case UNREGISTER: > if (!(ksdei && vsdei)) { > ret = SDEI_NOT_SUPPORTED; > break; > } > > ret = kvm_sdei_hypercall_unregister(vcpu); > break; > case CONTEXT: > ret = kvm_sdei_hypercall_context(vcpu); > break; > : > } > > Thanks, > Gavin > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Eric Auger <eauger@redhat.com> To: Gavin Shan <gshan@redhat.com>, Shannon Zhao <shannon.zhaosl@gmail.com>, kvmarm@lists.cs.columbia.edu Cc: maz@kernel.org, Jonathan.Cameron@huawei.com, will@kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com Subject: Re: [PATCH v4 06/21] KVM: arm64: Support SDEI_EVENT_CONTEXT hypercall Date: Tue, 25 Jan 2022 19:31:39 +0100 [thread overview] Message-ID: <3d791443-d3d3-29fb-98a4-bebadb84597e@redhat.com> (raw) In-Reply-To: <798ecbb0-f369-f3e7-ad50-78acfd902d1d@redhat.com> Hi Gavin, On 1/13/22 8:02 AM, Gavin Shan wrote: > Hi Shannon, > > On 1/11/22 5:43 PM, Shannon Zhao wrote: >> On 2021/8/15 8:13, Gavin Shan wrote: >>> +static unsigned long kvm_sdei_hypercall_context(struct kvm_vcpu *vcpu) >>> +{ >>> + struct kvm *kvm = vcpu->kvm; >>> + struct kvm_sdei_kvm *ksdei = kvm->arch.sdei; >>> + struct kvm_sdei_vcpu *vsdei = vcpu->arch.sdei; >>> + struct kvm_sdei_vcpu_regs *regs; >>> + unsigned long index = smccc_get_arg1(vcpu); >>> + unsigned long ret = SDEI_SUCCESS; >>> + >>> + /* Sanity check */ >>> + if (!(ksdei && vsdei)) { >>> + ret = SDEI_NOT_SUPPORTED; >>> + goto out; >>> + } >> Maybe we could move these common sanity check codes to >> kvm_sdei_hypercall to save some lines. >> > > Not all hypercalls need this check. For example, > COMPLETE/COMPLETE_RESUME/CONTEXT don't > have SDEI event number as the argument. If we really want move this > check into function > kvm_sdei_hypercall(), we would have code like below. Too much duplicated > snippets will > be seen. I don't think it's better than what we have if I fully > understand your comments. > > switch (...) { > case REGISTER: > if (!(ksdei && vsdei)) { > ret = SDEI_NOT_SUPPORTED; > break; > } at least you can use an inline function taking the vcpu as param? Thanks Eric > > ret = kvm_sdei_hypercall_register(vcpu); > break; > case UNREGISTER: > if (!(ksdei && vsdei)) { > ret = SDEI_NOT_SUPPORTED; > break; > } > > ret = kvm_sdei_hypercall_unregister(vcpu); > break; > case CONTEXT: > ret = kvm_sdei_hypercall_context(vcpu); > break; > : > } > > Thanks, > Gavin > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2022-01-25 18:32 UTC|newest] Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-15 0:13 [PATCH v4 00/21] Support SDEI Virtualization Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 01/21] KVM: arm64: Introduce template for inline functions Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 15:26 ` Eric Auger 2021-11-09 15:26 ` Eric Auger 2022-01-11 7:52 ` Gavin Shan 2022-01-11 7:52 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 02/21] KVM: arm64: Add SDEI virtualization infrastructure Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 15:45 ` Eric Auger 2021-11-09 15:45 ` Eric Auger 2022-01-11 9:20 ` Gavin Shan 2022-01-11 9:20 ` Gavin Shan 2022-01-27 13:17 ` Eric Auger 2022-01-27 13:17 ` Eric Auger 2022-01-11 9:40 ` Shannon Zhao 2022-01-11 9:40 ` Shannon Zhao 2022-01-13 7:09 ` Gavin Shan 2022-01-13 7:09 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 03/21] KVM: arm64: Support SDEI_VERSION hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 15:26 ` Eric Auger 2021-11-09 15:26 ` Eric Auger 2022-01-11 9:25 ` Gavin Shan 2022-01-11 9:25 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 04/21] KVM: arm64: Support SDEI_EVENT_REGISTER hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 15:50 ` Eric Auger 2021-11-09 15:50 ` Eric Auger 2022-01-12 2:19 ` Gavin Shan 2022-01-12 2:19 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 05/21] KVM: arm64: Support SDEI_EVENT_{ENABLE, DISABLE} hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 16:02 ` Eric Auger 2021-11-09 16:02 ` Eric Auger 2022-01-12 2:29 ` Gavin Shan 2022-01-12 2:29 ` Gavin Shan 2022-01-25 18:23 ` Eric Auger 2022-01-25 18:23 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 06/21] KVM: arm64: Support SDEI_EVENT_CONTEXT hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 11:16 ` Eric Auger 2021-11-10 11:16 ` Eric Auger 2022-01-12 2:33 ` Gavin Shan 2022-01-12 2:33 ` Gavin Shan 2022-01-25 18:29 ` Eric Auger 2022-01-25 18:29 ` Eric Auger 2022-01-11 9:43 ` Shannon Zhao 2022-01-11 9:43 ` Shannon Zhao 2022-01-13 7:02 ` Gavin Shan 2022-01-13 7:02 ` Gavin Shan 2022-01-13 7:13 ` Gavin Shan 2022-01-13 7:13 ` Gavin Shan 2022-01-25 18:32 ` Eric Auger 2022-01-25 18:32 ` Eric Auger 2022-01-25 18:31 ` Eric Auger [this message] 2022-01-25 18:31 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 07/21] KVM: arm64: Support SDEI_EVENT_UNREGISTER hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 17:05 ` Eric Auger 2021-11-09 17:05 ` Eric Auger 2022-01-12 2:38 ` Gavin Shan 2022-01-12 2:38 ` Gavin Shan 2022-01-25 18:42 ` Eric Auger 2022-01-25 18:42 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 08/21] KVM: arm64: Support SDEI_EVENT_STATUS hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 17:12 ` Eric Auger 2021-11-09 17:12 ` Eric Auger 2022-01-12 2:40 ` Gavin Shan 2022-01-12 2:40 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 09/21] KVM: arm64: Support SDEI_EVENT_GET_INFO hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 17:19 ` Eric Auger 2021-11-09 17:19 ` Eric Auger 2022-01-12 2:46 ` Gavin Shan 2022-01-12 2:46 ` Gavin Shan 2022-01-27 14:19 ` Eric Auger 2022-01-27 14:19 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 10/21] KVM: arm64: Support SDEI_EVENT_ROUTING_SET hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 18:47 ` Eric Auger 2021-11-09 18:47 ` Eric Auger 2022-01-12 2:54 ` Gavin Shan 2022-01-12 2:54 ` Gavin Shan 2022-01-27 14:13 ` Eric Auger 2022-01-27 14:13 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 11/21] KVM: arm64: Support SDEI_PE_{MASK, UNMASK} hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 20:31 ` Eric Auger 2021-11-09 20:31 ` Eric Auger 2022-01-12 2:58 ` Gavin Shan 2022-01-12 2:58 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 12/21] KVM: arm64: Support SDEI_{PRIVATE, SHARED}_RESET hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 20:37 ` Eric Auger 2021-11-09 20:37 ` Eric Auger 2022-01-12 3:01 ` Gavin Shan 2022-01-12 3:01 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 13/21] KVM: arm64: Impment SDEI event delivery Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 10:58 ` Eric Auger 2021-11-10 10:58 ` Eric Auger 2022-01-12 6:34 ` Gavin Shan 2022-01-12 6:34 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 14/21] KVM: arm64: Support SDEI_EVENT_{COMPLETE, COMPLETE_AND_RESUME} hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 10:58 ` Eric Auger 2021-11-10 10:58 ` Eric Auger 2022-01-12 6:43 ` Gavin Shan 2022-01-12 6:43 ` Gavin Shan 2022-01-27 14:47 ` Eric Auger 2022-01-27 14:47 ` Eric Auger 2022-01-27 15:20 ` Eric Auger 2022-01-27 15:20 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 15/21] KVM: arm64: Support SDEI event notifier Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 11:35 ` Eric Auger 2021-11-10 11:35 ` Eric Auger 2022-01-12 6:48 ` Gavin Shan 2022-01-12 6:48 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 16/21] KVM: arm64: Support SDEI ioctl commands on VM Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 13:48 ` Eric Auger 2021-11-10 13:48 ` Eric Auger 2022-01-12 7:03 ` Gavin Shan 2022-01-12 7:03 ` Gavin Shan 2022-01-27 13:48 ` Eric Auger 2022-01-27 13:48 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 17/21] KVM: arm64: Support SDEI ioctl commands on vCPU Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 18/21] KVM: arm64: Support SDEI event injection Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 14:05 ` Eric Auger 2021-11-10 14:05 ` Eric Auger 2022-01-12 7:12 ` Gavin Shan 2022-01-12 7:12 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 19/21] KVM: arm64: Support SDEI event cancellation Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 14:09 ` Eric Auger 2021-11-10 14:09 ` Eric Auger 2022-01-12 7:19 ` Gavin Shan 2022-01-12 7:19 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 20/21] KVM: arm64: Export SDEI capability Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 13:55 ` Eric Auger 2021-11-10 13:55 ` Eric Auger 2022-01-12 7:20 ` Gavin Shan 2022-01-12 7:20 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 21/21] KVM: selftests: Add SDEI test case Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-08-15 0:19 ` [PATCH v4 00/21] Support SDEI Virtualization Gavin Shan 2021-08-15 0:19 ` Gavin Shan 2021-11-10 14:29 ` Eric Auger 2021-11-10 14:29 ` Eric Auger 2022-01-12 7:24 ` Gavin Shan 2022-01-12 7:24 ` Gavin Shan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3d791443-d3d3-29fb-98a4-bebadb84597e@redhat.com \ --to=eauger@redhat.com \ --cc=Jonathan.Cameron@huawei.com \ --cc=gshan@redhat.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=pbonzini@redhat.com \ --cc=shannon.zhaosl@gmail.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.