From: Eric Auger <eauger@redhat.com> To: Gavin Shan <gshan@redhat.com>, kvmarm@lists.cs.columbia.edu Cc: maz@kernel.org, pbonzini@redhat.com, will@kernel.org, linux-kernel@vger.kernel.org, Jonathan.Cameron@huawei.com Subject: Re: [PATCH v4 05/21] KVM: arm64: Support SDEI_EVENT_{ENABLE, DISABLE} hypercall Date: Tue, 25 Jan 2022 19:23:40 +0100 [thread overview] Message-ID: <69cdc2b8-ccbe-dbe2-4805-04f1a53d9a53@redhat.com> (raw) In-Reply-To: <d7fdb8f8-d0f7-32c4-9644-0ab7cb46dfdf@redhat.com> Hi Gavin, On 1/12/22 3:29 AM, Gavin Shan wrote: > Hi Eric, > > On 11/10/21 12:02 AM, Eric Auger wrote: >> On 8/15/21 2:13 AM, Gavin Shan wrote: >>> This supports SDEI_EVENT_{ENABLE, DISABLE} hypercall. After SDEI >>> event is registered by guest, it won't be delivered to the guest >>> until it's enabled. On the other hand, the SDEI event won't be >>> raised to the guest or specific vCPU if it's has been disabled >>> on the guest or specific vCPU. >>> >>> Signed-off-by: Gavin Shan <gshan@redhat.com> >>> --- >>> arch/arm64/kvm/sdei.c | 68 +++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 68 insertions(+) >>> >>> diff --git a/arch/arm64/kvm/sdei.c b/arch/arm64/kvm/sdei.c >>> index d3ea3eee154b..b022ce0a202b 100644 >>> --- a/arch/arm64/kvm/sdei.c >>> +++ b/arch/arm64/kvm/sdei.c >>> @@ -206,6 +206,70 @@ static unsigned long >>> kvm_sdei_hypercall_register(struct kvm_vcpu *vcpu) >>> return ret; >>> } >>> +static unsigned long kvm_sdei_hypercall_enable(struct kvm_vcpu *vcpu, >>> + bool enable) >>> +{ >>> + struct kvm *kvm = vcpu->kvm; >>> + struct kvm_sdei_kvm *ksdei = kvm->arch.sdei; >>> + struct kvm_sdei_vcpu *vsdei = vcpu->arch.sdei; >>> + struct kvm_sdei_event *kse = NULL; >>> + struct kvm_sdei_kvm_event *kske = NULL; >>> + unsigned long event_num = smccc_get_arg1(vcpu); >>> + int index = 0; >>> + unsigned long ret = SDEI_SUCCESS; >>> + >>> + /* Sanity check */ >>> + if (!(ksdei && vsdei)) { >>> + ret = SDEI_NOT_SUPPORTED; >>> + goto out; >>> + } >>> + >>> + if (!kvm_sdei_is_valid_event_num(event_num)) { >> I would rename into is_exposed_event_num() > > kvm_sdei_is_virtual() has been recommended by you when you reviewed the > following > patch. I think kvm_sdei_is_virtual() is good enough :) argh, is_virtual() then :) Eric > > [PATCH v4 02/21] KVM: arm64: Add SDEI virtualization infrastructure > >>> + ret = SDEI_INVALID_PARAMETERS; >>> + goto out; >>> + } >>> + >>> + /* Check if the KVM event exists */ >>> + spin_lock(&ksdei->lock); >>> + kske = kvm_sdei_find_kvm_event(kvm, event_num); >>> + if (!kske) { >>> + ret = SDEI_INVALID_PARAMETERS; >> should be DENIED according to the spec, ie. nobody registered that event? > > Ok. > >>> + goto unlock; >>> + } >>> + >>> + /* Check if there is pending events */ >> does that match the "handler-unregister-pending state" case mentionned >> in the spec? >>> + if (kske->state.refcount) { >>> + ret = SDEI_PENDING; >> ? not documented in my A spec? DENIED? > > Yep, It should be DENIED. > >>> + goto unlock; >>> + } >>> + >>> + /* Check if it has been registered */ >> isn't duplicate of /* Check if the KVM event exists */ ? > > It's not duplicate check, but the comment here seems misleading. I will > correct this to: > > /* Check if it has been defined or exposed */ > >>> + kse = kske->kse; >>> + index = (kse->state.type == SDEI_EVENT_TYPE_PRIVATE) ? >>> + vcpu->vcpu_idx : 0; >>> + if (!kvm_sdei_is_registered(kske, index)) { >>> + ret = SDEI_DENIED; >>> + goto unlock; >>> + } >>> + >>> + /* Verify its enablement state */ >>> + if (enable == kvm_sdei_is_enabled(kske, index)) { >> spec says: >> Enabling/disabled an event, which is already enabled/disabled, is >> permitted and has no effect. I guess ret should be OK. > > yep, it should be ok. > >>> + ret = SDEI_DENIED; >>> + goto unlock; >>> + } >>> + >>> + /* Update enablement state */ >>> + if (enable) >>> + kvm_sdei_set_enabled(kske, index); >>> + else >>> + kvm_sdei_clear_enabled(kske, index); >>> + >>> +unlock: >>> + spin_unlock(&ksdei->lock); >>> +out: >>> + return ret; >>> +} >>> + >>> int kvm_sdei_hypercall(struct kvm_vcpu *vcpu) >>> { >>> u32 func = smccc_get_function(vcpu); >>> @@ -220,7 +284,11 @@ int kvm_sdei_hypercall(struct kvm_vcpu *vcpu) >>> ret = kvm_sdei_hypercall_register(vcpu); >>> break; >>> case SDEI_1_0_FN_SDEI_EVENT_ENABLE: >>> + ret = kvm_sdei_hypercall_enable(vcpu, true); >>> + break; >>> case SDEI_1_0_FN_SDEI_EVENT_DISABLE: >>> + ret = kvm_sdei_hypercall_enable(vcpu, false); >>> + break; >>> case SDEI_1_0_FN_SDEI_EVENT_CONTEXT: >>> case SDEI_1_0_FN_SDEI_EVENT_COMPLETE: >>> case SDEI_1_0_FN_SDEI_EVENT_COMPLETE_AND_RESUME: >>> > > Thanks, > Gavin > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Eric Auger <eauger@redhat.com> To: Gavin Shan <gshan@redhat.com>, kvmarm@lists.cs.columbia.edu Cc: maz@kernel.org, linux-kernel@vger.kernel.org, Jonathan.Cameron@huawei.com, pbonzini@redhat.com, will@kernel.org Subject: Re: [PATCH v4 05/21] KVM: arm64: Support SDEI_EVENT_{ENABLE, DISABLE} hypercall Date: Tue, 25 Jan 2022 19:23:40 +0100 [thread overview] Message-ID: <69cdc2b8-ccbe-dbe2-4805-04f1a53d9a53@redhat.com> (raw) In-Reply-To: <d7fdb8f8-d0f7-32c4-9644-0ab7cb46dfdf@redhat.com> Hi Gavin, On 1/12/22 3:29 AM, Gavin Shan wrote: > Hi Eric, > > On 11/10/21 12:02 AM, Eric Auger wrote: >> On 8/15/21 2:13 AM, Gavin Shan wrote: >>> This supports SDEI_EVENT_{ENABLE, DISABLE} hypercall. After SDEI >>> event is registered by guest, it won't be delivered to the guest >>> until it's enabled. On the other hand, the SDEI event won't be >>> raised to the guest or specific vCPU if it's has been disabled >>> on the guest or specific vCPU. >>> >>> Signed-off-by: Gavin Shan <gshan@redhat.com> >>> --- >>> arch/arm64/kvm/sdei.c | 68 +++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 68 insertions(+) >>> >>> diff --git a/arch/arm64/kvm/sdei.c b/arch/arm64/kvm/sdei.c >>> index d3ea3eee154b..b022ce0a202b 100644 >>> --- a/arch/arm64/kvm/sdei.c >>> +++ b/arch/arm64/kvm/sdei.c >>> @@ -206,6 +206,70 @@ static unsigned long >>> kvm_sdei_hypercall_register(struct kvm_vcpu *vcpu) >>> return ret; >>> } >>> +static unsigned long kvm_sdei_hypercall_enable(struct kvm_vcpu *vcpu, >>> + bool enable) >>> +{ >>> + struct kvm *kvm = vcpu->kvm; >>> + struct kvm_sdei_kvm *ksdei = kvm->arch.sdei; >>> + struct kvm_sdei_vcpu *vsdei = vcpu->arch.sdei; >>> + struct kvm_sdei_event *kse = NULL; >>> + struct kvm_sdei_kvm_event *kske = NULL; >>> + unsigned long event_num = smccc_get_arg1(vcpu); >>> + int index = 0; >>> + unsigned long ret = SDEI_SUCCESS; >>> + >>> + /* Sanity check */ >>> + if (!(ksdei && vsdei)) { >>> + ret = SDEI_NOT_SUPPORTED; >>> + goto out; >>> + } >>> + >>> + if (!kvm_sdei_is_valid_event_num(event_num)) { >> I would rename into is_exposed_event_num() > > kvm_sdei_is_virtual() has been recommended by you when you reviewed the > following > patch. I think kvm_sdei_is_virtual() is good enough :) argh, is_virtual() then :) Eric > > [PATCH v4 02/21] KVM: arm64: Add SDEI virtualization infrastructure > >>> + ret = SDEI_INVALID_PARAMETERS; >>> + goto out; >>> + } >>> + >>> + /* Check if the KVM event exists */ >>> + spin_lock(&ksdei->lock); >>> + kske = kvm_sdei_find_kvm_event(kvm, event_num); >>> + if (!kske) { >>> + ret = SDEI_INVALID_PARAMETERS; >> should be DENIED according to the spec, ie. nobody registered that event? > > Ok. > >>> + goto unlock; >>> + } >>> + >>> + /* Check if there is pending events */ >> does that match the "handler-unregister-pending state" case mentionned >> in the spec? >>> + if (kske->state.refcount) { >>> + ret = SDEI_PENDING; >> ? not documented in my A spec? DENIED? > > Yep, It should be DENIED. > >>> + goto unlock; >>> + } >>> + >>> + /* Check if it has been registered */ >> isn't duplicate of /* Check if the KVM event exists */ ? > > It's not duplicate check, but the comment here seems misleading. I will > correct this to: > > /* Check if it has been defined or exposed */ > >>> + kse = kske->kse; >>> + index = (kse->state.type == SDEI_EVENT_TYPE_PRIVATE) ? >>> + vcpu->vcpu_idx : 0; >>> + if (!kvm_sdei_is_registered(kske, index)) { >>> + ret = SDEI_DENIED; >>> + goto unlock; >>> + } >>> + >>> + /* Verify its enablement state */ >>> + if (enable == kvm_sdei_is_enabled(kske, index)) { >> spec says: >> Enabling/disabled an event, which is already enabled/disabled, is >> permitted and has no effect. I guess ret should be OK. > > yep, it should be ok. > >>> + ret = SDEI_DENIED; >>> + goto unlock; >>> + } >>> + >>> + /* Update enablement state */ >>> + if (enable) >>> + kvm_sdei_set_enabled(kske, index); >>> + else >>> + kvm_sdei_clear_enabled(kske, index); >>> + >>> +unlock: >>> + spin_unlock(&ksdei->lock); >>> +out: >>> + return ret; >>> +} >>> + >>> int kvm_sdei_hypercall(struct kvm_vcpu *vcpu) >>> { >>> u32 func = smccc_get_function(vcpu); >>> @@ -220,7 +284,11 @@ int kvm_sdei_hypercall(struct kvm_vcpu *vcpu) >>> ret = kvm_sdei_hypercall_register(vcpu); >>> break; >>> case SDEI_1_0_FN_SDEI_EVENT_ENABLE: >>> + ret = kvm_sdei_hypercall_enable(vcpu, true); >>> + break; >>> case SDEI_1_0_FN_SDEI_EVENT_DISABLE: >>> + ret = kvm_sdei_hypercall_enable(vcpu, false); >>> + break; >>> case SDEI_1_0_FN_SDEI_EVENT_CONTEXT: >>> case SDEI_1_0_FN_SDEI_EVENT_COMPLETE: >>> case SDEI_1_0_FN_SDEI_EVENT_COMPLETE_AND_RESUME: >>> > > Thanks, > Gavin >
next prev parent reply other threads:[~2022-01-25 18:23 UTC|newest] Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-15 0:13 [PATCH v4 00/21] Support SDEI Virtualization Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 01/21] KVM: arm64: Introduce template for inline functions Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 15:26 ` Eric Auger 2021-11-09 15:26 ` Eric Auger 2022-01-11 7:52 ` Gavin Shan 2022-01-11 7:52 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 02/21] KVM: arm64: Add SDEI virtualization infrastructure Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 15:45 ` Eric Auger 2021-11-09 15:45 ` Eric Auger 2022-01-11 9:20 ` Gavin Shan 2022-01-11 9:20 ` Gavin Shan 2022-01-27 13:17 ` Eric Auger 2022-01-27 13:17 ` Eric Auger 2022-01-11 9:40 ` Shannon Zhao 2022-01-11 9:40 ` Shannon Zhao 2022-01-13 7:09 ` Gavin Shan 2022-01-13 7:09 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 03/21] KVM: arm64: Support SDEI_VERSION hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 15:26 ` Eric Auger 2021-11-09 15:26 ` Eric Auger 2022-01-11 9:25 ` Gavin Shan 2022-01-11 9:25 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 04/21] KVM: arm64: Support SDEI_EVENT_REGISTER hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 15:50 ` Eric Auger 2021-11-09 15:50 ` Eric Auger 2022-01-12 2:19 ` Gavin Shan 2022-01-12 2:19 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 05/21] KVM: arm64: Support SDEI_EVENT_{ENABLE, DISABLE} hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 16:02 ` Eric Auger 2021-11-09 16:02 ` Eric Auger 2022-01-12 2:29 ` Gavin Shan 2022-01-12 2:29 ` Gavin Shan 2022-01-25 18:23 ` Eric Auger [this message] 2022-01-25 18:23 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 06/21] KVM: arm64: Support SDEI_EVENT_CONTEXT hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 11:16 ` Eric Auger 2021-11-10 11:16 ` Eric Auger 2022-01-12 2:33 ` Gavin Shan 2022-01-12 2:33 ` Gavin Shan 2022-01-25 18:29 ` Eric Auger 2022-01-25 18:29 ` Eric Auger 2022-01-11 9:43 ` Shannon Zhao 2022-01-11 9:43 ` Shannon Zhao 2022-01-13 7:02 ` Gavin Shan 2022-01-13 7:02 ` Gavin Shan 2022-01-13 7:13 ` Gavin Shan 2022-01-13 7:13 ` Gavin Shan 2022-01-25 18:32 ` Eric Auger 2022-01-25 18:32 ` Eric Auger 2022-01-25 18:31 ` Eric Auger 2022-01-25 18:31 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 07/21] KVM: arm64: Support SDEI_EVENT_UNREGISTER hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 17:05 ` Eric Auger 2021-11-09 17:05 ` Eric Auger 2022-01-12 2:38 ` Gavin Shan 2022-01-12 2:38 ` Gavin Shan 2022-01-25 18:42 ` Eric Auger 2022-01-25 18:42 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 08/21] KVM: arm64: Support SDEI_EVENT_STATUS hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 17:12 ` Eric Auger 2021-11-09 17:12 ` Eric Auger 2022-01-12 2:40 ` Gavin Shan 2022-01-12 2:40 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 09/21] KVM: arm64: Support SDEI_EVENT_GET_INFO hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 17:19 ` Eric Auger 2021-11-09 17:19 ` Eric Auger 2022-01-12 2:46 ` Gavin Shan 2022-01-12 2:46 ` Gavin Shan 2022-01-27 14:19 ` Eric Auger 2022-01-27 14:19 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 10/21] KVM: arm64: Support SDEI_EVENT_ROUTING_SET hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 18:47 ` Eric Auger 2021-11-09 18:47 ` Eric Auger 2022-01-12 2:54 ` Gavin Shan 2022-01-12 2:54 ` Gavin Shan 2022-01-27 14:13 ` Eric Auger 2022-01-27 14:13 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 11/21] KVM: arm64: Support SDEI_PE_{MASK, UNMASK} hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 20:31 ` Eric Auger 2021-11-09 20:31 ` Eric Auger 2022-01-12 2:58 ` Gavin Shan 2022-01-12 2:58 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 12/21] KVM: arm64: Support SDEI_{PRIVATE, SHARED}_RESET hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-09 20:37 ` Eric Auger 2021-11-09 20:37 ` Eric Auger 2022-01-12 3:01 ` Gavin Shan 2022-01-12 3:01 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 13/21] KVM: arm64: Impment SDEI event delivery Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 10:58 ` Eric Auger 2021-11-10 10:58 ` Eric Auger 2022-01-12 6:34 ` Gavin Shan 2022-01-12 6:34 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 14/21] KVM: arm64: Support SDEI_EVENT_{COMPLETE, COMPLETE_AND_RESUME} hypercall Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 10:58 ` Eric Auger 2021-11-10 10:58 ` Eric Auger 2022-01-12 6:43 ` Gavin Shan 2022-01-12 6:43 ` Gavin Shan 2022-01-27 14:47 ` Eric Auger 2022-01-27 14:47 ` Eric Auger 2022-01-27 15:20 ` Eric Auger 2022-01-27 15:20 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 15/21] KVM: arm64: Support SDEI event notifier Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 11:35 ` Eric Auger 2021-11-10 11:35 ` Eric Auger 2022-01-12 6:48 ` Gavin Shan 2022-01-12 6:48 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 16/21] KVM: arm64: Support SDEI ioctl commands on VM Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 13:48 ` Eric Auger 2021-11-10 13:48 ` Eric Auger 2022-01-12 7:03 ` Gavin Shan 2022-01-12 7:03 ` Gavin Shan 2022-01-27 13:48 ` Eric Auger 2022-01-27 13:48 ` Eric Auger 2021-08-15 0:13 ` [PATCH v4 17/21] KVM: arm64: Support SDEI ioctl commands on vCPU Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 18/21] KVM: arm64: Support SDEI event injection Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 14:05 ` Eric Auger 2021-11-10 14:05 ` Eric Auger 2022-01-12 7:12 ` Gavin Shan 2022-01-12 7:12 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 19/21] KVM: arm64: Support SDEI event cancellation Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 14:09 ` Eric Auger 2021-11-10 14:09 ` Eric Auger 2022-01-12 7:19 ` Gavin Shan 2022-01-12 7:19 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 20/21] KVM: arm64: Export SDEI capability Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-11-10 13:55 ` Eric Auger 2021-11-10 13:55 ` Eric Auger 2022-01-12 7:20 ` Gavin Shan 2022-01-12 7:20 ` Gavin Shan 2021-08-15 0:13 ` [PATCH v4 21/21] KVM: selftests: Add SDEI test case Gavin Shan 2021-08-15 0:13 ` Gavin Shan 2021-08-15 0:19 ` [PATCH v4 00/21] Support SDEI Virtualization Gavin Shan 2021-08-15 0:19 ` Gavin Shan 2021-11-10 14:29 ` Eric Auger 2021-11-10 14:29 ` Eric Auger 2022-01-12 7:24 ` Gavin Shan 2022-01-12 7:24 ` Gavin Shan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=69cdc2b8-ccbe-dbe2-4805-04f1a53d9a53@redhat.com \ --to=eauger@redhat.com \ --cc=Jonathan.Cameron@huawei.com \ --cc=gshan@redhat.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=pbonzini@redhat.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.