* [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument
@ 2019-01-30 3:02 Wei Yang
2019-01-30 8:16 ` Igor Mammedov
2019-01-30 11:15 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 5+ messages in thread
From: Wei Yang @ 2019-01-30 3:02 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: mst, imammedo, Wei Yang
The second argument of build_facs() is not used, just remove it.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
hw/i386/acpi-build.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 236a20eaa8..023729c1f2 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)
/* FACS */
static void
-build_facs(GArray *table_data, BIOSLinker *linker)
+build_facs(GArray *table_data)
{
AcpiFacsDescriptorRev1 *facs = acpi_data_push(table_data, sizeof *facs);
memcpy(&facs->signature, "FACS", 4);
@@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
* requirements.
*/
facs = tables_blob->len;
- build_facs(tables_blob, tables->linker);
+ build_facs(tables_blob);
/* DSDT is pointed to by FADT */
dsdt = tables_blob->len;
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument
2019-01-30 3:02 [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument Wei Yang
@ 2019-01-30 8:16 ` Igor Mammedov
2019-01-30 8:54 ` Wei Yang
2019-01-30 11:15 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 5+ messages in thread
From: Igor Mammedov @ 2019-01-30 8:16 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, qemu-trivial, mst
On Wed, 30 Jan 2019 11:02:07 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:
> The second argument of build_facs() is not used, just remove it.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/i386/acpi-build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 236a20eaa8..023729c1f2 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)
>
> /* FACS */
> static void
> -build_facs(GArray *table_data, BIOSLinker *linker)
> +build_facs(GArray *table_data)
> {
> AcpiFacsDescriptorRev1 *facs = acpi_data_push(table_data, sizeof *facs);
> memcpy(&facs->signature, "FACS", 4);
> @@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
> * requirements.
> */
> facs = tables_blob->len;
> - build_facs(tables_blob, tables->linker);
> + build_facs(tables_blob);
>
> /* DSDT is pointed to by FADT */
> dsdt = tables_blob->len;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument
2019-01-30 8:16 ` Igor Mammedov
@ 2019-01-30 8:54 ` Wei Yang
0 siblings, 0 replies; 5+ messages in thread
From: Wei Yang @ 2019-01-30 8:54 UTC (permalink / raw)
To: Igor Mammedov; +Cc: Wei Yang, qemu-devel, qemu-trivial, mst
On Wed, Jan 30, 2019 at 09:16:50AM +0100, Igor Mammedov wrote:
>On Wed, 30 Jan 2019 11:02:07 +0800
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>
>> The second argument of build_facs() is not used, just remove it.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>
>Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Thanks :-)
>
>> ---
>> hw/i386/acpi-build.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
>> index 236a20eaa8..023729c1f2 100644
>> --- a/hw/i386/acpi-build.c
>> +++ b/hw/i386/acpi-build.c
>> @@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)
>>
>> /* FACS */
>> static void
>> -build_facs(GArray *table_data, BIOSLinker *linker)
>> +build_facs(GArray *table_data)
>> {
>> AcpiFacsDescriptorRev1 *facs = acpi_data_push(table_data, sizeof *facs);
>> memcpy(&facs->signature, "FACS", 4);
>> @@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
>> * requirements.
>> */
>> facs = tables_blob->len;
>> - build_facs(tables_blob, tables->linker);
>> + build_facs(tables_blob);
>>
>> /* DSDT is pointed to by FADT */
>> dsdt = tables_blob->len;
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument
2019-01-30 3:02 [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument Wei Yang
2019-01-30 8:16 ` Igor Mammedov
@ 2019-01-30 11:15 ` Philippe Mathieu-Daudé
2019-01-30 12:59 ` Wei Yang
1 sibling, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-30 11:15 UTC (permalink / raw)
To: Wei Yang, qemu-devel, qemu-trivial; +Cc: imammedo, mst
On 1/30/19 4:02 AM, Wei Yang wrote:
> The second argument of build_facs() is not used, just remove it.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/i386/acpi-build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 236a20eaa8..023729c1f2 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)
>
> /* FACS */
> static void
> -build_facs(GArray *table_data, BIOSLinker *linker)
> +build_facs(GArray *table_data)
> {
> AcpiFacsDescriptorRev1 *facs = acpi_data_push(table_data, sizeof *facs);
> memcpy(&facs->signature, "FACS", 4);
> @@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
> * requirements.
> */
> facs = tables_blob->len;
> - build_facs(tables_blob, tables->linker);
> + build_facs(tables_blob);
>
> /* DSDT is pointed to by FADT */
> dsdt = tables_blob->len;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument
2019-01-30 11:15 ` Philippe Mathieu-Daudé
@ 2019-01-30 12:59 ` Wei Yang
0 siblings, 0 replies; 5+ messages in thread
From: Wei Yang @ 2019-01-30 12:59 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Wei Yang, qemu-devel, qemu-trivial, imammedo, mst
On Wed, Jan 30, 2019 at 12:15:57PM +0100, Philippe Mathieu-Daudé wrote:
>On 1/30/19 4:02 AM, Wei Yang wrote:
>> The second argument of build_facs() is not used, just remove it.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>
>Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks :-)
>
>> ---
>> hw/i386/acpi-build.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
>> index 236a20eaa8..023729c1f2 100644
>> --- a/hw/i386/acpi-build.c
>> +++ b/hw/i386/acpi-build.c
>> @@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)
>>
>> /* FACS */
>> static void
>> -build_facs(GArray *table_data, BIOSLinker *linker)
>> +build_facs(GArray *table_data)
>> {
>> AcpiFacsDescriptorRev1 *facs = acpi_data_push(table_data, sizeof *facs);
>> memcpy(&facs->signature, "FACS", 4);
>> @@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
>> * requirements.
>> */
>> facs = tables_blob->len;
>> - build_facs(tables_blob, tables->linker);
>> + build_facs(tables_blob);
>>
>> /* DSDT is pointed to by FADT */
>> dsdt = tables_blob->len;
>>
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-30 12:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-30 3:02 [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument Wei Yang
2019-01-30 8:16 ` Igor Mammedov
2019-01-30 8:54 ` Wei Yang
2019-01-30 11:15 ` Philippe Mathieu-Daudé
2019-01-30 12:59 ` Wei Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.