From: Kishon Vijay Abraham I <kishon@ti.com> To: Swapnil Jakhade <sjakhade@cadence.com>, <vkoul@kernel.org>, <p.zabel@pengutronix.de>, <linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: <mparab@cadence.com>, <lokeshvutla@ti.com> Subject: Re: [PATCH 03/14] phy: cadence-torrent: Add enum to support different input reference clocks Date: Thu, 13 May 2021 12:13:37 +0530 [thread overview] Message-ID: <3f1897aa-be23-c2ba-9e33-0d1983abb853@ti.com> (raw) In-Reply-To: <1617946456-27773-4-git-send-email-sjakhade@cadence.com> Hi Swapnil, On 09/04/21 11:04 am, Swapnil Jakhade wrote: > Torrent PHY supports different input reference clock frequencies. > Register configurations will be different based on reference clock value. > Prepare driver to support register configs for multiple reference clocks. > > Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com> $subject can be changed to something like "Add enum for supported input reference clocks frequencies" With that fixed Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/phy/cadence/phy-cadence-torrent.c | 51 +++++++++++++++++------ > 1 file changed, 38 insertions(+), 13 deletions(-) > > diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c > index 6eeb753fbb78..252920ea7fdf 100644 > --- a/drivers/phy/cadence/phy-cadence-torrent.c > +++ b/drivers/phy/cadence/phy-cadence-torrent.c > @@ -26,11 +26,13 @@ > > #define REF_CLK_19_2MHZ 19200000 > #define REF_CLK_25MHZ 25000000 > +#define REF_CLK_100MHZ 100000000 > > #define MAX_NUM_LANES 4 > #define DEFAULT_MAX_BIT_RATE 8100 /* in Mbps */ > > #define NUM_SSC_MODE 3 > +#define NUM_REF_CLK 3 > #define NUM_PHY_TYPE 6 > > #define POLL_TIMEOUT_US 5000 > @@ -273,6 +275,12 @@ enum cdns_torrent_phy_type { > TYPE_USB, > }; > > +enum cdns_torrent_ref_clk { > + CLK_19_2_MHZ, > + CLK_25_MHZ, > + CLK_100_MHZ > +}; > + > enum cdns_torrent_ssc_mode { > NO_SSC, > EXTERNAL_SSC, > @@ -296,7 +304,7 @@ struct cdns_torrent_phy { > struct reset_control *apb_rst; > struct device *dev; > struct clk *clk; > - unsigned long ref_clk_rate; > + enum cdns_torrent_ref_clk ref_clk_rate; > struct cdns_torrent_inst phys[MAX_NUM_LANES]; > int nsubnodes; > const struct cdns_torrent_data *init_data; > @@ -817,12 +825,12 @@ static int cdns_torrent_dp_configure_rate(struct cdns_torrent_phy *cdns_phy, > ndelay(200); > > /* DP Rate Change - VCO Output settings. */ > - if (cdns_phy->ref_clk_rate == REF_CLK_19_2MHZ) { > + if (cdns_phy->ref_clk_rate == CLK_19_2_MHZ) { > /* PMA common configuration 19.2MHz */ > cdns_torrent_dp_pma_cmn_vco_cfg_19_2mhz(cdns_phy, dp->link_rate, > dp->ssc); > cdns_torrent_dp_pma_cmn_cfg_19_2mhz(cdns_phy); > - } else if (cdns_phy->ref_clk_rate == REF_CLK_25MHZ) { > + } else if (cdns_phy->ref_clk_rate == CLK_25_MHZ) { > /* PMA common configuration 25MHz */ > cdns_torrent_dp_pma_cmn_vco_cfg_25mhz(cdns_phy, dp->link_rate, > dp->ssc); > @@ -1165,8 +1173,8 @@ static int cdns_torrent_dp_init(struct phy *phy) > struct regmap *regmap = cdns_phy->regmap_dptx_phy_reg; > > switch (cdns_phy->ref_clk_rate) { > - case REF_CLK_19_2MHZ: > - case REF_CLK_25MHZ: > + case CLK_19_2_MHZ: > + case CLK_25_MHZ: > /* Valid Ref Clock Rate */ > break; > default: > @@ -1198,11 +1206,11 @@ static int cdns_torrent_dp_init(struct phy *phy) > > /* PHY PMA registers configuration functions */ > /* Initialize PHY with max supported link rate, without SSC. */ > - if (cdns_phy->ref_clk_rate == REF_CLK_19_2MHZ) > + if (cdns_phy->ref_clk_rate == CLK_19_2_MHZ) > cdns_torrent_dp_pma_cmn_vco_cfg_19_2mhz(cdns_phy, > cdns_phy->max_bit_rate, > false); > - else if (cdns_phy->ref_clk_rate == REF_CLK_25MHZ) > + else if (cdns_phy->ref_clk_rate == CLK_25_MHZ) > cdns_torrent_dp_pma_cmn_vco_cfg_25mhz(cdns_phy, > cdns_phy->max_bit_rate, > false); > @@ -1228,10 +1236,10 @@ static void cdns_torrent_dp_pma_cfg(struct cdns_torrent_phy *cdns_phy, > { > unsigned int i; > > - if (cdns_phy->ref_clk_rate == REF_CLK_19_2MHZ) > + if (cdns_phy->ref_clk_rate == CLK_19_2_MHZ) > /* PMA common configuration 19.2MHz */ > cdns_torrent_dp_pma_cmn_cfg_19_2mhz(cdns_phy); > - else if (cdns_phy->ref_clk_rate == REF_CLK_25MHZ) > + else if (cdns_phy->ref_clk_rate == CLK_25_MHZ) > /* PMA common configuration 25MHz */ > cdns_torrent_dp_pma_cmn_cfg_25mhz(cdns_phy); > > @@ -1636,10 +1644,10 @@ static void cdns_torrent_dp_pma_lane_cfg(struct cdns_torrent_phy *cdns_phy, > unsigned int lane) > { > /* Per lane, refclock-dependent receiver detection setting */ > - if (cdns_phy->ref_clk_rate == REF_CLK_19_2MHZ) > + if (cdns_phy->ref_clk_rate == CLK_19_2_MHZ) > cdns_torrent_phy_write(cdns_phy->regmap_tx_lane_cdb[lane], > TX_RCVDET_ST_TMR, 0x0780); > - else if (cdns_phy->ref_clk_rate == REF_CLK_25MHZ) > + else if (cdns_phy->ref_clk_rate == CLK_25_MHZ) > cdns_torrent_phy_write(cdns_phy->regmap_tx_lane_cdb[lane], > TX_RCVDET_ST_TMR, 0x09C4); > > @@ -2270,6 +2278,7 @@ static int cdns_torrent_reset(struct cdns_torrent_phy *cdns_phy) > static int cdns_torrent_clk(struct cdns_torrent_phy *cdns_phy) > { > struct device *dev = cdns_phy->dev; > + unsigned long ref_clk_rate; > int ret; > > cdns_phy->clk = devm_clk_get(dev, "refclk"); > @@ -2284,13 +2293,29 @@ static int cdns_torrent_clk(struct cdns_torrent_phy *cdns_phy) > return ret; > } > > - cdns_phy->ref_clk_rate = clk_get_rate(cdns_phy->clk); > - if (!(cdns_phy->ref_clk_rate)) { > + ref_clk_rate = clk_get_rate(cdns_phy->clk); > + if (!ref_clk_rate) { > dev_err(cdns_phy->dev, "Failed to get ref clock rate\n"); > clk_disable_unprepare(cdns_phy->clk); > return -EINVAL; > } > > + switch (ref_clk_rate) { > + case REF_CLK_19_2MHZ: > + cdns_phy->ref_clk_rate = CLK_19_2_MHZ; > + break; > + case REF_CLK_25MHZ: > + cdns_phy->ref_clk_rate = CLK_25_MHZ; > + break; > + case REF_CLK_100MHZ: > + cdns_phy->ref_clk_rate = CLK_100_MHZ; > + break; > + default: > + dev_err(cdns_phy->dev, "Invalid Ref Clock Rate\n"); > + clk_disable_unprepare(cdns_phy->clk); > + return -EINVAL; > + } > + > return 0; > } > >
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com> To: Swapnil Jakhade <sjakhade@cadence.com>, <vkoul@kernel.org>, <p.zabel@pengutronix.de>, <linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: <mparab@cadence.com>, <lokeshvutla@ti.com> Subject: Re: [PATCH 03/14] phy: cadence-torrent: Add enum to support different input reference clocks Date: Thu, 13 May 2021 12:13:37 +0530 [thread overview] Message-ID: <3f1897aa-be23-c2ba-9e33-0d1983abb853@ti.com> (raw) In-Reply-To: <1617946456-27773-4-git-send-email-sjakhade@cadence.com> Hi Swapnil, On 09/04/21 11:04 am, Swapnil Jakhade wrote: > Torrent PHY supports different input reference clock frequencies. > Register configurations will be different based on reference clock value. > Prepare driver to support register configs for multiple reference clocks. > > Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com> $subject can be changed to something like "Add enum for supported input reference clocks frequencies" With that fixed Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/phy/cadence/phy-cadence-torrent.c | 51 +++++++++++++++++------ > 1 file changed, 38 insertions(+), 13 deletions(-) > > diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c > index 6eeb753fbb78..252920ea7fdf 100644 > --- a/drivers/phy/cadence/phy-cadence-torrent.c > +++ b/drivers/phy/cadence/phy-cadence-torrent.c > @@ -26,11 +26,13 @@ > > #define REF_CLK_19_2MHZ 19200000 > #define REF_CLK_25MHZ 25000000 > +#define REF_CLK_100MHZ 100000000 > > #define MAX_NUM_LANES 4 > #define DEFAULT_MAX_BIT_RATE 8100 /* in Mbps */ > > #define NUM_SSC_MODE 3 > +#define NUM_REF_CLK 3 > #define NUM_PHY_TYPE 6 > > #define POLL_TIMEOUT_US 5000 > @@ -273,6 +275,12 @@ enum cdns_torrent_phy_type { > TYPE_USB, > }; > > +enum cdns_torrent_ref_clk { > + CLK_19_2_MHZ, > + CLK_25_MHZ, > + CLK_100_MHZ > +}; > + > enum cdns_torrent_ssc_mode { > NO_SSC, > EXTERNAL_SSC, > @@ -296,7 +304,7 @@ struct cdns_torrent_phy { > struct reset_control *apb_rst; > struct device *dev; > struct clk *clk; > - unsigned long ref_clk_rate; > + enum cdns_torrent_ref_clk ref_clk_rate; > struct cdns_torrent_inst phys[MAX_NUM_LANES]; > int nsubnodes; > const struct cdns_torrent_data *init_data; > @@ -817,12 +825,12 @@ static int cdns_torrent_dp_configure_rate(struct cdns_torrent_phy *cdns_phy, > ndelay(200); > > /* DP Rate Change - VCO Output settings. */ > - if (cdns_phy->ref_clk_rate == REF_CLK_19_2MHZ) { > + if (cdns_phy->ref_clk_rate == CLK_19_2_MHZ) { > /* PMA common configuration 19.2MHz */ > cdns_torrent_dp_pma_cmn_vco_cfg_19_2mhz(cdns_phy, dp->link_rate, > dp->ssc); > cdns_torrent_dp_pma_cmn_cfg_19_2mhz(cdns_phy); > - } else if (cdns_phy->ref_clk_rate == REF_CLK_25MHZ) { > + } else if (cdns_phy->ref_clk_rate == CLK_25_MHZ) { > /* PMA common configuration 25MHz */ > cdns_torrent_dp_pma_cmn_vco_cfg_25mhz(cdns_phy, dp->link_rate, > dp->ssc); > @@ -1165,8 +1173,8 @@ static int cdns_torrent_dp_init(struct phy *phy) > struct regmap *regmap = cdns_phy->regmap_dptx_phy_reg; > > switch (cdns_phy->ref_clk_rate) { > - case REF_CLK_19_2MHZ: > - case REF_CLK_25MHZ: > + case CLK_19_2_MHZ: > + case CLK_25_MHZ: > /* Valid Ref Clock Rate */ > break; > default: > @@ -1198,11 +1206,11 @@ static int cdns_torrent_dp_init(struct phy *phy) > > /* PHY PMA registers configuration functions */ > /* Initialize PHY with max supported link rate, without SSC. */ > - if (cdns_phy->ref_clk_rate == REF_CLK_19_2MHZ) > + if (cdns_phy->ref_clk_rate == CLK_19_2_MHZ) > cdns_torrent_dp_pma_cmn_vco_cfg_19_2mhz(cdns_phy, > cdns_phy->max_bit_rate, > false); > - else if (cdns_phy->ref_clk_rate == REF_CLK_25MHZ) > + else if (cdns_phy->ref_clk_rate == CLK_25_MHZ) > cdns_torrent_dp_pma_cmn_vco_cfg_25mhz(cdns_phy, > cdns_phy->max_bit_rate, > false); > @@ -1228,10 +1236,10 @@ static void cdns_torrent_dp_pma_cfg(struct cdns_torrent_phy *cdns_phy, > { > unsigned int i; > > - if (cdns_phy->ref_clk_rate == REF_CLK_19_2MHZ) > + if (cdns_phy->ref_clk_rate == CLK_19_2_MHZ) > /* PMA common configuration 19.2MHz */ > cdns_torrent_dp_pma_cmn_cfg_19_2mhz(cdns_phy); > - else if (cdns_phy->ref_clk_rate == REF_CLK_25MHZ) > + else if (cdns_phy->ref_clk_rate == CLK_25_MHZ) > /* PMA common configuration 25MHz */ > cdns_torrent_dp_pma_cmn_cfg_25mhz(cdns_phy); > > @@ -1636,10 +1644,10 @@ static void cdns_torrent_dp_pma_lane_cfg(struct cdns_torrent_phy *cdns_phy, > unsigned int lane) > { > /* Per lane, refclock-dependent receiver detection setting */ > - if (cdns_phy->ref_clk_rate == REF_CLK_19_2MHZ) > + if (cdns_phy->ref_clk_rate == CLK_19_2_MHZ) > cdns_torrent_phy_write(cdns_phy->regmap_tx_lane_cdb[lane], > TX_RCVDET_ST_TMR, 0x0780); > - else if (cdns_phy->ref_clk_rate == REF_CLK_25MHZ) > + else if (cdns_phy->ref_clk_rate == CLK_25_MHZ) > cdns_torrent_phy_write(cdns_phy->regmap_tx_lane_cdb[lane], > TX_RCVDET_ST_TMR, 0x09C4); > > @@ -2270,6 +2278,7 @@ static int cdns_torrent_reset(struct cdns_torrent_phy *cdns_phy) > static int cdns_torrent_clk(struct cdns_torrent_phy *cdns_phy) > { > struct device *dev = cdns_phy->dev; > + unsigned long ref_clk_rate; > int ret; > > cdns_phy->clk = devm_clk_get(dev, "refclk"); > @@ -2284,13 +2293,29 @@ static int cdns_torrent_clk(struct cdns_torrent_phy *cdns_phy) > return ret; > } > > - cdns_phy->ref_clk_rate = clk_get_rate(cdns_phy->clk); > - if (!(cdns_phy->ref_clk_rate)) { > + ref_clk_rate = clk_get_rate(cdns_phy->clk); > + if (!ref_clk_rate) { > dev_err(cdns_phy->dev, "Failed to get ref clock rate\n"); > clk_disable_unprepare(cdns_phy->clk); > return -EINVAL; > } > > + switch (ref_clk_rate) { > + case REF_CLK_19_2MHZ: > + cdns_phy->ref_clk_rate = CLK_19_2_MHZ; > + break; > + case REF_CLK_25MHZ: > + cdns_phy->ref_clk_rate = CLK_25_MHZ; > + break; > + case REF_CLK_100MHZ: > + cdns_phy->ref_clk_rate = CLK_100_MHZ; > + break; > + default: > + dev_err(cdns_phy->dev, "Invalid Ref Clock Rate\n"); > + clk_disable_unprepare(cdns_phy->clk); > + return -EINVAL; > + } > + > return 0; > } > > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-05-13 6:43 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-09 5:34 [PATCH 00/14] PHY: Add multilink DP support in Cadence Torrent PHY driver Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-04-09 5:34 ` [PATCH 01/14] phy: cadence-torrent: Remove use of CamelCase to fix checkpatch CHECK message Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 6:35 ` Kishon Vijay Abraham I 2021-05-13 6:35 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 02/14] phy: cadence-torrent: Reorder few functions to remove function declarations Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 6:37 ` Kishon Vijay Abraham I 2021-05-13 6:37 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 03/14] phy: cadence-torrent: Add enum to support different input reference clocks Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 6:43 ` Kishon Vijay Abraham I [this message] 2021-05-13 6:43 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 04/14] phy: cadence-torrent: Select register configuration based on PHY reference clock Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 6:48 ` Kishon Vijay Abraham I 2021-05-13 6:48 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 05/14] phy: cadence-torrent: Add PHY registers for DP in array format Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 6:52 ` Kishon Vijay Abraham I 2021-05-13 6:52 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 06/14] phy: cadence-torrent: Reorder functions to avoid function declarations Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-04-09 5:34 ` [PATCH 07/14] " Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-04-09 5:34 ` [PATCH 08/14] phy: cadence-torrent: Add PHY configuration for DP with 100MHz ref clock Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 6:59 ` Kishon Vijay Abraham I 2021-05-13 6:59 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 09/14] phy: cadence-torrent: Add separate functions for reusable code Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 7:00 ` Kishon Vijay Abraham I 2021-05-13 7:00 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 10/14] phy: cadence-torrent: Add function to get PLL to be configured for DP Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 7:12 ` Kishon Vijay Abraham I 2021-05-13 7:12 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 11/14] phy: cadence-torrent: Add multilink DP support Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 7:44 ` Kishon Vijay Abraham I 2021-05-13 7:44 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 12/14] phy: cadence-torrent: Add PCIe + DP multilink configuration Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 7:47 ` Kishon Vijay Abraham I 2021-05-13 7:47 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 13/14] phy: cadence-torrent: Add debug information for PHY configuration Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 7:54 ` Kishon Vijay Abraham I 2021-05-13 7:54 ` Kishon Vijay Abraham I 2021-04-09 5:34 ` [PATCH 14/14] phy: cadence-torrent: Check PIPE mode PHY status to be ready for operation Swapnil Jakhade 2021-04-09 5:34 ` Swapnil Jakhade 2021-05-13 7:55 ` Kishon Vijay Abraham I 2021-05-13 7:55 ` Kishon Vijay Abraham I
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3f1897aa-be23-c2ba-9e33-0d1983abb853@ti.com \ --to=kishon@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=lokeshvutla@ti.com \ --cc=mparab@cadence.com \ --cc=p.zabel@pengutronix.de \ --cc=sjakhade@cadence.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.