From: Chao Yu <yuchao0@huawei.com> To: Jaegeuk Kim <jaegeuk@kernel.org> Cc: <linux-kernel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net> Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst Date: Mon, 10 May 2021 17:05:08 +0800 [thread overview] Message-ID: <3f7ebf46-536e-dc80-ebda-71b2034cb4c9@huawei.com> (raw) In-Reply-To: <6d574f4e-fed2-ded8-c9d5-4d88bff5d584@huawei.com> On 2021/4/22 14:07, Chao Yu wrote: > On 2021/4/22 11:59, Jaegeuk Kim wrote: >> On 04/21, Chao Yu wrote: >>> On 2021/3/11 4:52, Jaegeuk Kim wrote: >>>> On 03/09, Chao Yu wrote: >>>>> On 2021/3/9 8:01, Jaegeuk Kim wrote: >>>>>> On 03/05, Chao Yu wrote: >>>>>>> On 2021/3/5 4:20, Jaegeuk Kim wrote: >>>>>>>> On 02/27, Jaegeuk Kim wrote: >>>>>>>>> On 02/04, Chao Yu wrote: >>>>>>>>>> Jaegeuk, >>>>>>>>>> >>>>>>>>>> On 2021/2/2 16:00, Chao Yu wrote: >>>>>>>>>>> - for (i = 0; i < dic->nr_cpages; i++) { >>>>>>>>>>> + for (i = 0; i < cc->nr_cpages; i++) { >>>>>>>>>>> struct page *page = dic->cpages[i]; >>>>>>>>>> >>>>>>>>>> por_fsstress still hang in this line? >>>>>>>>> >>>>>>>>> I'm stuck on testing the patches, since the latest kernel is panicking somehow. >>>>>>>>> Let me update later, once I can test a bit. :( >>>>>>>> >>>>>>>> It seems this works without error. >>>>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9 >>>>>>> >>>>>>> Ah, good news. >>>>>>> >>>>>>> Thanks for helping to test the patch. :) >>>>>> >>>>>> Hmm, I hit this again. Let me check w/o compress_cache back. :( >>>>> >>>>> Oops :( >>>> >>>> Ok, apprantely that panic is caused by compress_cache. The test is running over >>>> 24hours w/o it. >>> >>> Jaegeuk, >>> >>> I'm still struggling troubleshooting this issue. >>> >>> However, I failed again to reproduce this bug, I doubt the reason may be >>> my test script and environment(device type/size) is different from yours. >>> (btw, I used pmem as back-end device, and test w/ all fault injection >>> points and w/o write_io/checkpoint fault injection points) >>> >>> Could you please share me your run.sh script? and test command? >>> >>> And I'd like to ask what's your device type and size? >> >> I'm using qemu with 16GB with this script. >> https://github.com/jaegeuk/xfstests-f2fs/blob/f2fs/run.sh >> >> ./run.sh por_fsstress > > Thanks, let me check the difference, and try again. Finally, I can reproduce this bug, and after troubleshooting this issue, I guess the root cause is not related to this patch, could you please test patch "f2fs: compress: fix race condition of overwrite vs truncate" with compress_cache enabled? I've ran por_fsstress case for 6 hours w/o any problems. Thanks, > > Thanks, > >> >>> >>> Thanks, >>> >>>> . >>>> >> . >> > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > . >
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com> To: Jaegeuk Kim <jaegeuk@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst Date: Mon, 10 May 2021 17:05:08 +0800 [thread overview] Message-ID: <3f7ebf46-536e-dc80-ebda-71b2034cb4c9@huawei.com> (raw) In-Reply-To: <6d574f4e-fed2-ded8-c9d5-4d88bff5d584@huawei.com> On 2021/4/22 14:07, Chao Yu wrote: > On 2021/4/22 11:59, Jaegeuk Kim wrote: >> On 04/21, Chao Yu wrote: >>> On 2021/3/11 4:52, Jaegeuk Kim wrote: >>>> On 03/09, Chao Yu wrote: >>>>> On 2021/3/9 8:01, Jaegeuk Kim wrote: >>>>>> On 03/05, Chao Yu wrote: >>>>>>> On 2021/3/5 4:20, Jaegeuk Kim wrote: >>>>>>>> On 02/27, Jaegeuk Kim wrote: >>>>>>>>> On 02/04, Chao Yu wrote: >>>>>>>>>> Jaegeuk, >>>>>>>>>> >>>>>>>>>> On 2021/2/2 16:00, Chao Yu wrote: >>>>>>>>>>> - for (i = 0; i < dic->nr_cpages; i++) { >>>>>>>>>>> + for (i = 0; i < cc->nr_cpages; i++) { >>>>>>>>>>> struct page *page = dic->cpages[i]; >>>>>>>>>> >>>>>>>>>> por_fsstress still hang in this line? >>>>>>>>> >>>>>>>>> I'm stuck on testing the patches, since the latest kernel is panicking somehow. >>>>>>>>> Let me update later, once I can test a bit. :( >>>>>>>> >>>>>>>> It seems this works without error. >>>>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9 >>>>>>> >>>>>>> Ah, good news. >>>>>>> >>>>>>> Thanks for helping to test the patch. :) >>>>>> >>>>>> Hmm, I hit this again. Let me check w/o compress_cache back. :( >>>>> >>>>> Oops :( >>>> >>>> Ok, apprantely that panic is caused by compress_cache. The test is running over >>>> 24hours w/o it. >>> >>> Jaegeuk, >>> >>> I'm still struggling troubleshooting this issue. >>> >>> However, I failed again to reproduce this bug, I doubt the reason may be >>> my test script and environment(device type/size) is different from yours. >>> (btw, I used pmem as back-end device, and test w/ all fault injection >>> points and w/o write_io/checkpoint fault injection points) >>> >>> Could you please share me your run.sh script? and test command? >>> >>> And I'd like to ask what's your device type and size? >> >> I'm using qemu with 16GB with this script. >> https://github.com/jaegeuk/xfstests-f2fs/blob/f2fs/run.sh >> >> ./run.sh por_fsstress > > Thanks, let me check the difference, and try again. Finally, I can reproduce this bug, and after troubleshooting this issue, I guess the root cause is not related to this patch, could you please test patch "f2fs: compress: fix race condition of overwrite vs truncate" with compress_cache enabled? I've ran por_fsstress case for 6 hours w/o any problems. Thanks, > > Thanks, > >> >>> >>> Thanks, >>> >>>> . >>>> >> . >> > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-05-10 9:05 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-02 8:00 [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst Chao Yu 2021-02-02 8:00 ` [f2fs-dev] " Chao Yu 2021-02-04 3:25 ` Chao Yu 2021-02-04 3:25 ` [f2fs-dev] " Chao Yu 2021-02-28 5:09 ` Jaegeuk Kim 2021-02-28 5:09 ` [f2fs-dev] " Jaegeuk Kim 2021-03-04 20:20 ` Jaegeuk Kim 2021-03-04 20:20 ` Jaegeuk Kim 2021-03-05 3:07 ` Chao Yu 2021-03-05 3:07 ` Chao Yu 2021-03-09 0:01 ` Jaegeuk Kim 2021-03-09 0:01 ` Jaegeuk Kim 2021-03-09 2:49 ` Chao Yu 2021-03-09 2:49 ` Chao Yu 2021-03-10 20:52 ` Jaegeuk Kim 2021-03-10 20:52 ` Jaegeuk Kim 2021-04-21 9:08 ` Chao Yu 2021-04-21 9:08 ` Chao Yu 2021-04-22 3:59 ` Jaegeuk Kim 2021-04-22 3:59 ` Jaegeuk Kim 2021-04-22 6:07 ` Chao Yu 2021-04-22 6:07 ` Chao Yu 2021-05-10 9:05 ` Chao Yu [this message] 2021-05-10 9:05 ` Chao Yu 2021-05-10 14:35 ` Jaegeuk Kim 2021-05-10 14:35 ` Jaegeuk Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3f7ebf46-536e-dc80-ebda-71b2034cb4c9@huawei.com \ --to=yuchao0@huawei.com \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.