From: "Stefan Schaeckeler (sschaeck)" <sschaeck@cisco.com>
To: Troy Lee <troy_lee@aspeedtech.com>,
Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
"Borislav Petkov" <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Robert Richter <rrichter@marvell.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>
Cc: "leetroy@gmail.com" <leetroy@gmail.com>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Stefan Schaeckeler <schaecsn@gmx.net>
Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver
Date: Mon, 7 Dec 2020 08:57:00 +0000 [thread overview]
Message-ID: <40547026-144F-443C-BF14-C7FA0E3229C5@cisco.com> (raw)
In-Reply-To: <PS1PR06MB26008D10C46C5DF0B47F81368AF40@PS1PR06MB2600.apcprd06.prod.outlook.com>
Hello Troy,
> Hi Stefan,
>
> The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off
> from u-boot and check if driver runs correctly.
I noticed now most changes are these "exports". As you removed them a later revision, the patch looks now lean and clean. I'll give you my Reviewed-by tag after you addressed Andrew's last comment.
> The test doc you provided is very nice and detailed, I'll try to reproduce the
> injection test in v2 patch.
It does not harm to redo the testing. That is time-consuming and with your current, now trivial changes, it's not really necessary.
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: "Stefan Schaeckeler (sschaeck)" <sschaeck@cisco.com>
To: Troy Lee <troy_lee@aspeedtech.com>,
Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
"Borislav Petkov" <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Robert Richter <rrichter@marvell.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>
Cc: "leetroy@gmail.com" <leetroy@gmail.com>,
Stefan Schaeckeler <schaecsn@gmx.net>,
Ryan Chen <ryan_chen@aspeedtech.com>
Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver
Date: Mon, 7 Dec 2020 08:57:00 +0000 [thread overview]
Message-ID: <40547026-144F-443C-BF14-C7FA0E3229C5@cisco.com> (raw)
In-Reply-To: <PS1PR06MB26008D10C46C5DF0B47F81368AF40@PS1PR06MB2600.apcprd06.prod.outlook.com>
Hello Troy,
> Hi Stefan,
>
> The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off
> from u-boot and check if driver runs correctly.
I noticed now most changes are these "exports". As you removed them a later revision, the patch looks now lean and clean. I'll give you my Reviewed-by tag after you addressed Andrew's last comment.
> The test doc you provided is very nice and detailed, I'll try to reproduce the
> injection test in v2 patch.
It does not harm to redo the testing. That is time-consuming and with your current, now trivial changes, it's not really necessary.
Stefan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-07 8:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 8:33 [PATCH 1/3] dt-bindings: edac: aspeed-sdram-edac: Add ast2400/ast2600 support Troy Lee
2020-11-30 8:33 ` Troy Lee
2020-11-30 8:33 ` [PATCH 2/3] ARM: dts: aspeed: Add AST2600 edac into common devicetree Troy Lee
2020-11-30 8:33 ` Troy Lee
2020-11-30 8:33 ` [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver Troy Lee
2020-11-30 8:33 ` Troy Lee
2020-11-30 9:15 ` Stefan Schaeckeler (sschaeck)
2020-11-30 9:15 ` Stefan Schaeckeler (sschaeck)
2020-12-01 10:04 ` Troy Lee
2020-12-01 10:04 ` Troy Lee
2020-12-07 8:57 ` Stefan Schaeckeler (sschaeck) [this message]
2020-12-07 8:57 ` Stefan Schaeckeler (sschaeck)
2020-12-01 1:11 ` Andrew Jeffery
2020-12-01 1:11 ` Andrew Jeffery
2020-12-01 9:36 ` Troy Lee
2020-12-01 9:36 ` Troy Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40547026-144F-443C-BF14-C7FA0E3229C5@cisco.com \
--to=sschaeck@cisco.com \
--cc=andrew@aj.id.au \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=james.morse@arm.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rrichter@marvell.com \
--cc=ryan_chen@aspeedtech.com \
--cc=schaecsn@gmx.net \
--cc=tony.luck@intel.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.