All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stefan Schaeckeler (sschaeck)" <sschaeck@cisco.com>
To: Troy Lee <troy_lee@aspeedtech.com>,
	Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@aj.id.au>,
	"Borislav Petkov" <bp@alien8.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	James Morse <james.morse@arm.com>,
	Robert Richter <rrichter@marvell.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT" 
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT" 
	<linux-aspeed@lists.ozlabs.org>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:EDAC-CORE" <linux-edac@vger.kernel.org>
Cc: "leetroy@gmail.com" <leetroy@gmail.com>,
	"ryan_chen@aspeedtech.com" <ryan_chen@aspeedtech.com>,
	Stefan Schaeckeler <schaecsn@gmx.net>
Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver
Date: Mon, 30 Nov 2020 09:15:46 +0000	[thread overview]
Message-ID: <4AD4AB7A-54E7-4922-9547-7E26D61F7C77@cisco.com> (raw)
In-Reply-To: <20201130083345.4814-3-troy_lee@aspeedtech.com>

Hello Troy,

> Adding AST2400 and AST2600 edac driver support.
>
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> ---
> drivers/edac/Kconfig       |   6 +-
> drivers/edac/aspeed_edac.c | 114 +++++++++++++++++++++++++++++--------
> 2 files changed, 94 insertions(+), 26 deletions(-)

Uh, there are quite some non-trivial changes. I'll have a look over the coming weekend.

Testing an edac driver comes with challenges. Did you test your code? If so, how?

That's how I was testing my original edac 2500 driver http://students.engr.scu.edu/~sschaeck/misc/aspeed-edac.html

 Stefan


WARNING: multiple messages have this Message-ID (diff)
From: "Stefan Schaeckeler (sschaeck)" <sschaeck@cisco.com>
To: Troy Lee <troy_lee@aspeedtech.com>,
	Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@aj.id.au>,
	"Borislav Petkov" <bp@alien8.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	James Morse <james.morse@arm.com>,
	Robert Richter <rrichter@marvell.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT"
	<linux-aspeed@lists.ozlabs.org>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:EDAC-CORE" <linux-edac@vger.kernel.org>
Cc: "leetroy@gmail.com" <leetroy@gmail.com>,
	Stefan Schaeckeler <schaecsn@gmx.net>,
	"ryan_chen@aspeedtech.com" <ryan_chen@aspeedtech.com>
Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver
Date: Mon, 30 Nov 2020 09:15:46 +0000	[thread overview]
Message-ID: <4AD4AB7A-54E7-4922-9547-7E26D61F7C77@cisco.com> (raw)
In-Reply-To: <20201130083345.4814-3-troy_lee@aspeedtech.com>

Hello Troy,

> Adding AST2400 and AST2600 edac driver support.
>
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> ---
> drivers/edac/Kconfig       |   6 +-
> drivers/edac/aspeed_edac.c | 114 +++++++++++++++++++++++++++++--------
> 2 files changed, 94 insertions(+), 26 deletions(-)

Uh, there are quite some non-trivial changes. I'll have a look over the coming weekend.

Testing an edac driver comes with challenges. Did you test your code? If so, how?

That's how I was testing my original edac 2500 driver http://students.engr.scu.edu/~sschaeck/misc/aspeed-edac.html

 Stefan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-30  9:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30  8:33 [PATCH 1/3] dt-bindings: edac: aspeed-sdram-edac: Add ast2400/ast2600 support Troy Lee
2020-11-30  8:33 ` Troy Lee
2020-11-30  8:33 ` [PATCH 2/3] ARM: dts: aspeed: Add AST2600 edac into common devicetree Troy Lee
2020-11-30  8:33   ` Troy Lee
2020-11-30  8:33 ` [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver Troy Lee
2020-11-30  8:33   ` Troy Lee
2020-11-30  9:15   ` Stefan Schaeckeler (sschaeck) [this message]
2020-11-30  9:15     ` Stefan Schaeckeler (sschaeck)
2020-12-01 10:04     ` Troy Lee
2020-12-01 10:04       ` Troy Lee
2020-12-07  8:57       ` Stefan Schaeckeler (sschaeck)
2020-12-07  8:57         ` Stefan Schaeckeler (sschaeck)
2020-12-01  1:11   ` Andrew Jeffery
2020-12-01  1:11     ` Andrew Jeffery
2020-12-01  9:36     ` Troy Lee
2020-12-01  9:36       ` Troy Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD4AB7A-54E7-4922-9547-7E26D61F7C77@cisco.com \
    --to=sschaeck@cisco.com \
    --cc=andrew@aj.id.au \
    --cc=bp@alien8.de \
    --cc=devicetree@vger.kernel.org \
    --cc=james.morse@arm.com \
    --cc=joel@jms.id.au \
    --cc=leetroy@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rrichter@marvell.com \
    --cc=ryan_chen@aspeedtech.com \
    --cc=schaecsn@gmx.net \
    --cc=tony.luck@intel.com \
    --cc=troy_lee@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.