* [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells
@ 2017-11-29 17:57 Julien Grall
2017-11-29 18:12 ` Stefano Stabellini
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2017-11-29 17:57 UTC (permalink / raw)
To: xen-devel; +Cc: sstabellini, Julien Grall, andre.przywara
Per the device-tree specific [1], when the property #address-cells
and #size-cells are not present, the default value should be resp. 1
and 2.
[1] https://www.devicetree.org/downloads/devicetree-specification-v0.1-20160524.pdf
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
This was discovered debugging DT generated by GRUB on ACPI-only
platform. I am not aware of any DT relying on that for now, but it
would still be nice to be compliant with the spec and avoid
surprise.
---
xen/arch/arm/bootfdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index 4a687e725d..8eba42c7b9 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -109,8 +109,8 @@ int __init device_tree_for_each_node(const void *fdt,
continue;
}
- as = depth > 0 ? address_cells[depth-1] : 0;
- ss = depth > 0 ? size_cells[depth-1] : 0;
+ as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
+ ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
address_cells[depth] = device_tree_get_u32(fdt, node,
"#address-cells", as);
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells
2017-11-29 17:57 [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells Julien Grall
@ 2017-11-29 18:12 ` Stefano Stabellini
2017-12-08 15:18 ` Julien Grall
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Stabellini @ 2017-11-29 18:12 UTC (permalink / raw)
To: Julien Grall; +Cc: sstabellini, andre.przywara, xen-devel
On Wed, 29 Nov 2017, Julien Grall wrote:
> Per the device-tree specific [1], when the property #address-cells
> and #size-cells are not present, the default value should be resp. 1
> and 2.
>
> [1] https://www.devicetree.org/downloads/devicetree-specification-v0.1-20160524.pdf
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
>
> This was discovered debugging DT generated by GRUB on ACPI-only
> platform. I am not aware of any DT relying on that for now, but it
> would still be nice to be compliant with the spec and avoid
> surprise.
> ---
> xen/arch/arm/bootfdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index 4a687e725d..8eba42c7b9 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -109,8 +109,8 @@ int __init device_tree_for_each_node(const void *fdt,
> continue;
> }
>
> - as = depth > 0 ? address_cells[depth-1] : 0;
> - ss = depth > 0 ? size_cells[depth-1] : 0;
> + as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
> + ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
>
> address_cells[depth] = device_tree_get_u32(fdt, node,
> "#address-cells", as);
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells
2017-11-29 18:12 ` Stefano Stabellini
@ 2017-12-08 15:18 ` Julien Grall
2017-12-08 21:18 ` Stefano Stabellini
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2017-12-08 15:18 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: andre.przywara, xen-devel
Hi,
On 29/11/17 18:12, Stefano Stabellini wrote:
> On Wed, 29 Nov 2017, Julien Grall wrote:
>> Per the device-tree specific [1], when the property #address-cells
>> and #size-cells are not present, the default value should be resp. 1
>> and 2.
>>
>> [1] https://www.devicetree.org/downloads/devicetree-specification-v0.1-20160524.pdf
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
This was acked but not applied to staging. Can you do it please?
Cheers,
>
>
>> ---
>>
>> This was discovered debugging DT generated by GRUB on ACPI-only
>> platform. I am not aware of any DT relying on that for now, but it
>> would still be nice to be compliant with the spec and avoid
>> surprise.
>> ---
>> xen/arch/arm/bootfdt.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
>> index 4a687e725d..8eba42c7b9 100644
>> --- a/xen/arch/arm/bootfdt.c
>> +++ b/xen/arch/arm/bootfdt.c
>> @@ -109,8 +109,8 @@ int __init device_tree_for_each_node(const void *fdt,
>> continue;
>> }
>>
>> - as = depth > 0 ? address_cells[depth-1] : 0;
>> - ss = depth > 0 ? size_cells[depth-1] : 0;
>> + as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
>> + ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
>>
>> address_cells[depth] = device_tree_get_u32(fdt, node,
>> "#address-cells", as);
>> --
>> 2.11.0
>>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells
2017-12-08 15:18 ` Julien Grall
@ 2017-12-08 21:18 ` Stefano Stabellini
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Stabellini @ 2017-12-08 21:18 UTC (permalink / raw)
To: Julien Grall; +Cc: Stefano Stabellini, andre.przywara, xen-devel
On Fri, 8 Dec 2017, Julien Grall wrote:
> Hi,
>
> On 29/11/17 18:12, Stefano Stabellini wrote:
> > On Wed, 29 Nov 2017, Julien Grall wrote:
> > > Per the device-tree specific [1], when the property #address-cells
> > > and #size-cells are not present, the default value should be resp. 1
> > > and 2.
> > >
> > > [1]
> > > https://www.devicetree.org/downloads/devicetree-specification-v0.1-20160524.pdf
> > >
> > > Signed-off-by: Julien Grall <julien.grall@linaro.org>
> >
> > Acked-by: Stefano Stabellini <sstabellini@kernel.org>
>
> This was acked but not applied to staging. Can you do it please?
It was in my arm-next branch together with a couple of patches from
Andre. I committed all three to staging.
>
> >
> >
> > > ---
> > >
> > > This was discovered debugging DT generated by GRUB on ACPI-only
> > > platform. I am not aware of any DT relying on that for now, but it
> > > would still be nice to be compliant with the spec and avoid
> > > surprise.
> > > ---
> > > xen/arch/arm/bootfdt.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> > > index 4a687e725d..8eba42c7b9 100644
> > > --- a/xen/arch/arm/bootfdt.c
> > > +++ b/xen/arch/arm/bootfdt.c
> > > @@ -109,8 +109,8 @@ int __init device_tree_for_each_node(const void *fdt,
> > > continue;
> > > }
> > > - as = depth > 0 ? address_cells[depth-1] : 0;
> > > - ss = depth > 0 ? size_cells[depth-1] : 0;
> > > + as = depth > 0 ? address_cells[depth-1] :
> > > DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
> > > + ss = depth > 0 ? size_cells[depth-1] :
> > > DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
> > > address_cells[depth] = device_tree_get_u32(fdt, node,
> > > "#address-cells",
> > > as);
> > > --
> > > 2.11.0
> > >
>
> --
> Julien Grall
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-08 21:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 17:57 [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells Julien Grall
2017-11-29 18:12 ` Stefano Stabellini
2017-12-08 15:18 ` Julien Grall
2017-12-08 21:18 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.