From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms@verge.net.au>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH 2/2] i2c: designware: Add support for a bus clock
Date: Tue, 17 Jul 2018 17:18:32 +0300 [thread overview]
Message-ID: <40f2729f38bd565a829d60d9cc8f508e33b0dc65.camel@linux.intel.com> (raw)
In-Reply-To: <TY1PR01MB1769BD3E271E217E0CFBAB46F55C0@TY1PR01MB1769.jpnprd01.prod.outlook.com>
On Tue, 2018-07-17 at 12:42 +0000, Phil Edworthy wrote:
> > While your point sounds valid (don't remember how clk_get() is
> > implemented), NULL is also OK to have.
>
> Ok as in there is no bus clock, right?
> So it should be:
> if (!IS_ERR_OR_NULL (dev->busclk))
Nope, NULL is no error case for optional clock.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-07-17 14:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 8:59 [PATCH 0/2] i2c: designware: Add support for a bus clock Phil Edworthy
2018-07-16 8:59 ` Phil Edworthy
2018-07-16 8:59 ` [PATCH 1/2] dt: snps,designware-i2c: Add clock bindings documentation Phil Edworthy
2018-07-20 16:19 ` Rob Herring
2018-07-16 8:59 ` [PATCH 2/2] i2c: designware: Add support for a bus clock Phil Edworthy
2018-07-17 12:07 ` Simon Horman
2018-07-17 12:23 ` Andy Shevchenko
2018-07-17 12:42 ` Phil Edworthy
2018-07-17 12:42 ` Phil Edworthy
2018-07-17 13:01 ` Geert Uytterhoeven
2018-07-17 13:12 ` Phil Edworthy
2018-07-17 14:18 ` Andy Shevchenko [this message]
2018-07-17 14:18 ` Andy Shevchenko
2018-07-17 14:40 ` Phil Edworthy
2018-07-17 14:40 ` Phil Edworthy
2018-07-17 14:47 ` Andy Shevchenko
2018-07-17 14:47 ` Andy Shevchenko
2018-07-17 14:57 ` Phil Edworthy
2018-07-17 14:57 ` Phil Edworthy
2018-07-18 9:14 ` Simon Horman
2018-07-18 9:14 ` Simon Horman
2018-07-18 9:21 ` Phil Edworthy
2018-07-18 9:21 ` Phil Edworthy
2018-07-19 7:42 ` Simon Horman
2018-07-19 7:42 ` Simon Horman
2018-07-18 11:06 ` Geert Uytterhoeven
2018-07-18 12:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40f2729f38bd565a829d60d9cc8f508e33b0dc65.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.