RE: [PATCH 2/2] i2c: designware: Add support for a bus clock

From: Phil Edworthy <phil.edworthy@renesas.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Simon Horman <horms@verge.net.au>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: RE: [PATCH 2/2] i2c: designware: Add support for a bus clock
Date: Tue, 17 Jul 2018 14:40:03 +0000	[thread overview]
Message-ID: <TY1PR01MB1769F130075F1635CC51532FF55C0@TY1PR01MB1769.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <40f2729f38bd565a829d60d9cc8f508e33b0dc65.camel@linux.intel.com>

Hi Andy,

On 17 July 2018 15:19, Andy Shevchenko wrote:
> On Tue, 2018-07-17 at 12:42 +0000, Phil Edworthy wrote:
> 
> > > While your point sounds valid (don't remember how clk_get() is
> > > implemented), NULL is also OK to have.
> >
> > Ok as in there is no bus clock, right?
> > So it should be:
> >  if (!IS_ERR_OR_NULL (dev->busclk))
> 
> Nope, NULL is no error case for optional clock.
I must be missing something here...
I agree that NULL for an optional clock is not an error. However, the 
code above is now:
+	if (prepare) {
+		/* Optional bus clock */
+		if (!IS_ERR_OR_NULL(dev->busclk)) {
+			ret = clk_prepare_enable(dev->busclk);
+			if (ret)
+				return ret;
+		}
+
 		return clk_prepare_enable(dev->clk);
+	}

So, if you have a valid busclk, it gets enabled, otherwise it is
left alone.

Thanks
Phil