* [PATCH] powerpc/msi: Fix compile error on mpc83xx
@ 2013-07-02 1:34 Jia Hongtao
2013-07-02 2:26 ` Jia Hongtao-B38951
0 siblings, 1 reply; 9+ messages in thread
From: Jia Hongtao @ 2013-07-02 1:34 UTC (permalink / raw)
To: linuxppc-dev, B07421; +Cc: b38951
mpic_get_primary_version() is not defined when not using MPIC.
The compile error log like:
arch/powerpc/sysdev/built-in.o: In function `fsl_of_msi_probe':
fsl_msi.c:(.text+0x150c): undefined reference to `fsl_mpic_primary_get_version'
Signed-off-by: Jia Hongtao <B38951@freescale.com>
Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
---
arch/powerpc/include/asm/mpic.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/powerpc/include/asm/mpic.h b/arch/powerpc/include/asm/mpic.h
index ea6bf72..97b5a63 100644
--- a/arch/powerpc/include/asm/mpic.h
+++ b/arch/powerpc/include/asm/mpic.h
@@ -394,7 +394,14 @@ struct mpic
#define MPIC_REGSET_TSI108 MPIC_REGSET(1) /* Tsi108/109 PIC */
/* Get the version of primary MPIC */
+#ifdef CONFIG_MPIC
extern u32 fsl_mpic_primary_get_version(void);
+#else
+static inline u32 fsl_mpic_primary_get_version(void)
+{
+ return 0;
+}
+#endif
/* Allocate the controller structure and setup the linux irq descs
* for the range if interrupts passed in. No HW initialization is
--
1.8.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* RE: [PATCH] powerpc/msi: Fix compile error on mpc83xx
2013-07-02 1:34 [PATCH] powerpc/msi: Fix compile error on mpc83xx Jia Hongtao
@ 2013-07-02 2:26 ` Jia Hongtao-B38951
0 siblings, 0 replies; 9+ messages in thread
From: Jia Hongtao-B38951 @ 2013-07-02 2:26 UTC (permalink / raw)
To: Jia Hongtao-B38951, linuxppc-dev, Wood Scott-B07421; +Cc: Li Yang-R58472
Please ignore this patch.
-Hongtao
> -----Original Message-----
> From: Jia Hongtao-B38951
> Sent: Tuesday, July 02, 2013 9:35 AM
> To: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421
> Cc: galak@kernel.crashing.org; Li Yang-R58472; Jia Hongtao-B38951
> Subject: [PATCH] powerpc/msi: Fix compile error on mpc83xx
>=20
> mpic_get_primary_version() is not defined when not using MPIC.
> The compile error log like:
>=20
> arch/powerpc/sysdev/built-in.o: In function `fsl_of_msi_probe':
> fsl_msi.c:(.text+0x150c): undefined reference to
> `fsl_mpic_primary_get_version'
>=20
> Signed-off-by: Jia Hongtao <B38951@freescale.com>
> Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
> ---
> arch/powerpc/include/asm/mpic.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>=20
> diff --git a/arch/powerpc/include/asm/mpic.h
> b/arch/powerpc/include/asm/mpic.h
> index ea6bf72..97b5a63 100644
> --- a/arch/powerpc/include/asm/mpic.h
> +++ b/arch/powerpc/include/asm/mpic.h
> @@ -394,7 +394,14 @@ struct mpic
> #define MPIC_REGSET_TSI108 MPIC_REGSET(1) /* Tsi108/109
> PIC */
>=20
> /* Get the version of primary MPIC */
> +#ifdef CONFIG_MPIC
> extern u32 fsl_mpic_primary_get_version(void);
> +#else
> +static inline u32 fsl_mpic_primary_get_version(void)
> +{
> + return 0;
> +}
> +#endif
>=20
> /* Allocate the controller structure and setup the linux irq descs
> * for the range if interrupts passed in. No HW initialization is
> --
> 1.8.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] powerpc/msi: Fix compile error on mpc83xx
@ 2013-07-02 1:36 Jia Hongtao
2013-07-10 2:04 ` Jia Hongtao-B38951
0 siblings, 1 reply; 9+ messages in thread
From: Jia Hongtao @ 2013-07-02 1:36 UTC (permalink / raw)
To: linuxppc-dev, B07421; +Cc: b38951
mpic_get_primary_version() is not defined when not using MPIC.
The compile error log like:
arch/powerpc/sysdev/built-in.o: In function `fsl_of_msi_probe':
fsl_msi.c:(.text+0x150c): undefined reference to `fsl_mpic_primary_get_version'
Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
---
arch/powerpc/include/asm/mpic.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/powerpc/include/asm/mpic.h b/arch/powerpc/include/asm/mpic.h
index ea6bf72..97b5a63 100644
--- a/arch/powerpc/include/asm/mpic.h
+++ b/arch/powerpc/include/asm/mpic.h
@@ -394,7 +394,14 @@ struct mpic
#define MPIC_REGSET_TSI108 MPIC_REGSET(1) /* Tsi108/109 PIC */
/* Get the version of primary MPIC */
+#ifdef CONFIG_MPIC
extern u32 fsl_mpic_primary_get_version(void);
+#else
+static inline u32 fsl_mpic_primary_get_version(void)
+{
+ return 0;
+}
+#endif
/* Allocate the controller structure and setup the linux irq descs
* for the range if interrupts passed in. No HW initialization is
--
1.8.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* RE: [PATCH] powerpc/msi: Fix compile error on mpc83xx
2013-07-02 1:36 Jia Hongtao
@ 2013-07-10 2:04 ` Jia Hongtao-B38951
2013-07-22 2:00 ` Jia Hongtao-B38951
0 siblings, 1 reply; 9+ messages in thread
From: Jia Hongtao-B38951 @ 2013-07-10 2:04 UTC (permalink / raw)
To: Wood Scott-B07421, linuxppc-dev; +Cc: Jia Hongtao-B38951, Li Yang-R58472
Hi Scott,
I made this patch to fix msi compile error on mpc83xx.
Could you please have a review.
Thanks.
-Hongtao
> -----Original Message-----
> From: Jia Hongtao-B38951
> Sent: Tuesday, July 02, 2013 9:37 AM
> To: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421
> Cc: galak@kernel.crashing.org; Li Yang-R58472; Jia Hongtao-B38951
> Subject: [PATCH] powerpc/msi: Fix compile error on mpc83xx
>=20
> mpic_get_primary_version() is not defined when not using MPIC.
> The compile error log like:
>=20
> arch/powerpc/sysdev/built-in.o: In function `fsl_of_msi_probe':
> fsl_msi.c:(.text+0x150c): undefined reference to
> `fsl_mpic_primary_get_version'
>=20
> Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
> ---
> arch/powerpc/include/asm/mpic.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>=20
> diff --git a/arch/powerpc/include/asm/mpic.h
> b/arch/powerpc/include/asm/mpic.h index ea6bf72..97b5a63 100644
> --- a/arch/powerpc/include/asm/mpic.h
> +++ b/arch/powerpc/include/asm/mpic.h
> @@ -394,7 +394,14 @@ struct mpic
> #define MPIC_REGSET_TSI108 MPIC_REGSET(1) /* Tsi108/109
> PIC */
>=20
> /* Get the version of primary MPIC */
> +#ifdef CONFIG_MPIC
> extern u32 fsl_mpic_primary_get_version(void);
> +#else
> +static inline u32 fsl_mpic_primary_get_version(void)
> +{
> + return 0;
> +}
> +#endif
>=20
> /* Allocate the controller structure and setup the linux irq descs
> * for the range if interrupts passed in. No HW initialization is
> --
> 1.8.0
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH] powerpc/msi: Fix compile error on mpc83xx
2013-07-10 2:04 ` Jia Hongtao-B38951
@ 2013-07-22 2:00 ` Jia Hongtao-B38951
2013-07-22 17:18 ` Scott Wood
0 siblings, 1 reply; 9+ messages in thread
From: Jia Hongtao-B38951 @ 2013-07-22 2:00 UTC (permalink / raw)
To: Wood Scott-B07421, linuxppc-dev; +Cc: Jia Hongtao-B38951, Li Yang-R58472
Hi Scott,
The fsl_msi.c build error on MPC83xx platform is fixed by this patch.
Could you please have a review?
Thanks.
-Hongtao
> -----Original Message-----
> From: Jia Hongtao-B38951
> Sent: Wednesday, July 10, 2013 10:04 AM
> To: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org
> Cc: galak@kernel.crashing.org; Li Yang-R58472; Jia Hongtao-B38951
> Subject: RE: [PATCH] powerpc/msi: Fix compile error on mpc83xx
>=20
> Hi Scott,
>=20
> I made this patch to fix msi compile error on mpc83xx.
> Could you please have a review.
>=20
> Thanks.
> -Hongtao
>=20
> > -----Original Message-----
> > From: Jia Hongtao-B38951
> > Sent: Tuesday, July 02, 2013 9:37 AM
> > To: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421
> > Cc: galak@kernel.crashing.org; Li Yang-R58472; Jia Hongtao-B38951
> > Subject: [PATCH] powerpc/msi: Fix compile error on mpc83xx
> >
> > mpic_get_primary_version() is not defined when not using MPIC.
> > The compile error log like:
> >
> > arch/powerpc/sysdev/built-in.o: In function `fsl_of_msi_probe':
> > fsl_msi.c:(.text+0x150c): undefined reference to
> > `fsl_mpic_primary_get_version'
> >
> > Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
> > ---
> > arch/powerpc/include/asm/mpic.h | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/powerpc/include/asm/mpic.h
> > b/arch/powerpc/include/asm/mpic.h index ea6bf72..97b5a63 100644
> > --- a/arch/powerpc/include/asm/mpic.h
> > +++ b/arch/powerpc/include/asm/mpic.h
> > @@ -394,7 +394,14 @@ struct mpic
> > #define MPIC_REGSET_TSI108 MPIC_REGSET(1) /* Tsi108/109
> > PIC */
> >
> > /* Get the version of primary MPIC */
> > +#ifdef CONFIG_MPIC
> > extern u32 fsl_mpic_primary_get_version(void);
> > +#else
> > +static inline u32 fsl_mpic_primary_get_version(void)
> > +{
> > + return 0;
> > +}
> > +#endif
> >
> > /* Allocate the controller structure and setup the linux irq descs
> > * for the range if interrupts passed in. No HW initialization is
> > --
> > 1.8.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] powerpc/msi: Fix compile error on mpc83xx
2013-07-22 2:00 ` Jia Hongtao-B38951
@ 2013-07-22 17:18 ` Scott Wood
2013-07-23 1:58 ` Jia Hongtao-B38951
0 siblings, 1 reply; 9+ messages in thread
From: Scott Wood @ 2013-07-22 17:18 UTC (permalink / raw)
To: Jia Hongtao-B38951
Cc: Wood Scott-B07421, Jia Hongtao-B38951, linuxppc-dev, Li Yang-R58472
On 07/21/2013 09:00:51 PM, Jia Hongtao-B38951 wrote:
> Hi Scott,
>=20
> The fsl_msi.c build error on MPC83xx platform is fixed by this patch.
>=20
> Could you please have a review?
>=20
> Thanks.
> -Hongtao
I will apply it when I apply the patch that depends on it. I hope to =20
resume applying patches soon.
-Scott=
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] powerpc/msi: Fix compile error on mpc83xx
2013-07-22 17:18 ` Scott Wood
@ 2013-07-23 1:58 ` Jia Hongtao-B38951
0 siblings, 0 replies; 9+ messages in thread
From: Jia Hongtao-B38951 @ 2013-07-23 1:58 UTC (permalink / raw)
To: Wood Scott-B07421; +Cc: linuxppc-dev, Li Yang-R58472
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, July 23, 2013 1:19 AM
> To: Jia Hongtao-B38951
> Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org;
> galak@kernel.crashing.org; Li Yang-R58472; Jia Hongtao-B38951
> Subject: Re: [PATCH] powerpc/msi: Fix compile error on mpc83xx
>=20
> On 07/21/2013 09:00:51 PM, Jia Hongtao-B38951 wrote:
> > Hi Scott,
> >
> > The fsl_msi.c build error on MPC83xx platform is fixed by this patch.
> >
> > Could you please have a review?
> >
> > Thanks.
> > -Hongtao
>=20
> I will apply it when I apply the patch that depends on it. I hope to
> resume applying patches soon.
>=20
> -Scott
Thanks.
- Hongtao
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] powerpc/msi: Fix compile error on mpc83xx
@ 2018-10-19 6:12 ` Christophe Leroy
0 siblings, 0 replies; 9+ messages in thread
From: Christophe Leroy @ 2018-10-19 6:12 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman, radu.rendec
Cc: linux-kernel, linuxppc-dev
mpic_get_primary_version() is not defined when not using MPIC.
The compile error log like:
arch/powerpc/sysdev/built-in.o: In function `fsl_of_msi_probe':
fsl_msi.c:(.text+0x150c): undefined reference to `fsl_mpic_primary_get_version'
Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
Signed-off-by: Scott Wood <scottwood@freescale.com>
Reported-by: Radu Rendec <radu.rendec@gmail.com>
Fixes: 807d38b73b6 ("powerpc/mpic: Add get_version API both for internal and external use")
Cc: stable@vger.kernel.org
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
arch/powerpc/include/asm/mpic.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/powerpc/include/asm/mpic.h b/arch/powerpc/include/asm/mpic.h
index fad8ddd697ac..0abf2e7fd222 100644
--- a/arch/powerpc/include/asm/mpic.h
+++ b/arch/powerpc/include/asm/mpic.h
@@ -393,7 +393,14 @@ extern struct bus_type mpic_subsys;
#define MPIC_REGSET_TSI108 MPIC_REGSET(1) /* Tsi108/109 PIC */
/* Get the version of primary MPIC */
+#ifdef CONFIG_MPIC
extern u32 fsl_mpic_primary_get_version(void);
+#else
+static inline u32 fsl_mpic_primary_get_version(void)
+{
+ return 0;
+}
+#endif
/* Allocate the controller structure and setup the linux irq descs
* for the range if interrupts passed in. No HW initialization is
--
2.13.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] powerpc/msi: Fix compile error on mpc83xx
@ 2018-10-19 6:12 ` Christophe Leroy
0 siblings, 0 replies; 9+ messages in thread
From: Christophe Leroy @ 2018-10-19 6:12 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman, radu.rendec
Cc: linuxppc-dev, linux-kernel
mpic_get_primary_version() is not defined when not using MPIC.
The compile error log like:
arch/powerpc/sysdev/built-in.o: In function `fsl_of_msi_probe':
fsl_msi.c:(.text+0x150c): undefined reference to `fsl_mpic_primary_get_version'
Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
Signed-off-by: Scott Wood <scottwood@freescale.com>
Reported-by: Radu Rendec <radu.rendec@gmail.com>
Fixes: 807d38b73b6 ("powerpc/mpic: Add get_version API both for internal and external use")
Cc: stable@vger.kernel.org
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
arch/powerpc/include/asm/mpic.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/powerpc/include/asm/mpic.h b/arch/powerpc/include/asm/mpic.h
index fad8ddd697ac..0abf2e7fd222 100644
--- a/arch/powerpc/include/asm/mpic.h
+++ b/arch/powerpc/include/asm/mpic.h
@@ -393,7 +393,14 @@ extern struct bus_type mpic_subsys;
#define MPIC_REGSET_TSI108 MPIC_REGSET(1) /* Tsi108/109 PIC */
/* Get the version of primary MPIC */
+#ifdef CONFIG_MPIC
extern u32 fsl_mpic_primary_get_version(void);
+#else
+static inline u32 fsl_mpic_primary_get_version(void)
+{
+ return 0;
+}
+#endif
/* Allocate the controller structure and setup the linux irq descs
* for the range if interrupts passed in. No HW initialization is
--
2.13.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-10-19 6:14 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-02 1:34 [PATCH] powerpc/msi: Fix compile error on mpc83xx Jia Hongtao
2013-07-02 2:26 ` Jia Hongtao-B38951
2013-07-02 1:36 Jia Hongtao
2013-07-10 2:04 ` Jia Hongtao-B38951
2013-07-22 2:00 ` Jia Hongtao-B38951
2013-07-22 17:18 ` Scott Wood
2013-07-23 1:58 ` Jia Hongtao-B38951
2018-10-19 6:12 Christophe Leroy
2018-10-19 6:12 ` Christophe Leroy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.