* [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
@ 2019-01-30 0:06 Wei Yang
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
` (3 more replies)
0 siblings, 4 replies; 28+ messages in thread
From: Wei Yang @ 2019-01-30 0:06 UTC (permalink / raw)
To: qemu-trivial, qemu-devel; +Cc: mst, laurent, imammedo, philmd, Wei Yang
There are several functions/variable which are not used anymore.
This serials just remove those without functional change.
v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"
Wei Yang (3):
hw/i386/pc.c: remove unused function pc_acpi_init()
hw/acpi: remove unused function acpi_table_add_builtin()
hw/acpi: remove unnecessary variable acpi_table_builtin
hw/acpi/core.c | 10 +---------
hw/i386/pc.c | 27 ---------------------------
include/hw/acpi/acpi.h | 1 -
include/hw/i386/pc.h | 1 -
4 files changed, 1 insertion(+), 38 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()
2019-01-30 0:06 [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
@ 2019-01-30 0:06 ` Wei Yang
2019-01-30 8:10 ` Igor Mammedov
2019-01-30 9:50 ` Thomas Huth
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
` (2 subsequent siblings)
3 siblings, 2 replies; 28+ messages in thread
From: Wei Yang @ 2019-01-30 0:06 UTC (permalink / raw)
To: qemu-trivial, qemu-devel; +Cc: mst, laurent, imammedo, philmd, Wei Yang
Function pc_acpi_init() is not used anymore.
Remove the definition and declaration.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
---
hw/i386/pc.c | 27 ---------------------------
include/hw/i386/pc.h | 1 -
2 files changed, 28 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 5317e08f60..734d3268fa 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
pci_address_space, -1);
}
-void pc_acpi_init(const char *default_dsdt)
-{
- char *filename;
-
- if (acpi_tables != NULL) {
- /* manually set via -acpitable, leave it alone */
- return;
- }
-
- filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
- if (filename == NULL) {
- warn_report("failed to find %s", default_dsdt);
- } else {
- QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
- &error_abort);
- Error *err = NULL;
-
- qemu_opt_set(opts, "file", filename, &error_abort);
-
- acpi_table_add_builtin(opts, &err);
- if (err) {
- warn_reportf_err(err, "failed to load %s: ", filename);
- }
- g_free(filename);
- }
-}
-
void xen_load_linux(PCMachineState *pcms)
{
int i;
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 9d29c4b1df..541124ba6d 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
void pc_cpus_init(PCMachineState *pcms);
void pc_hot_add_cpu(const int64_t id, Error **errp);
-void pc_acpi_init(const char *default_dsdt);
void pc_guest_info_init(PCMachineState *pcms);
--
2.19.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Qemu-devel] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin()
2019-01-30 0:06 [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
@ 2019-01-30 0:06 ` Wei Yang
2019-01-30 8:11 ` Igor Mammedov
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
2019-02-12 5:22 ` [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
3 siblings, 1 reply; 28+ messages in thread
From: Wei Yang @ 2019-01-30 0:06 UTC (permalink / raw)
To: qemu-trivial, qemu-devel; +Cc: mst, laurent, imammedo, philmd, Wei Yang
Function acpi_table_add_builtin() is not used anymore.
Remove the definition and declaration.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
---
hw/acpi/core.c | 6 ------
include/hw/acpi/acpi.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index d6f0709691..e9b1a85e54 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -305,12 +305,6 @@ out:
static bool acpi_table_builtin = false;
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp)
-{
- acpi_table_builtin = true;
- acpi_table_add(opts, errp);
-}
-
unsigned acpi_table_len(void *current)
{
struct acpi_table_header *hdr = current - sizeof(hdr->_length);
diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h
index c20ace0d0b..4a8bbaf1b5 100644
--- a/include/hw/acpi/acpi.h
+++ b/include/hw/acpi/acpi.h
@@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);
uint8_t *acpi_table_next(uint8_t *current);
unsigned acpi_table_len(void *current);
void acpi_table_add(const QemuOpts *opts, Error **errp);
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp);
typedef struct AcpiSlicOem AcpiSlicOem;
struct AcpiSlicOem {
--
2.19.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin
2019-01-30 0:06 [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
@ 2019-01-30 0:06 ` Wei Yang
2019-01-30 8:11 ` Igor Mammedov
2019-02-12 5:22 ` [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
3 siblings, 1 reply; 28+ messages in thread
From: Wei Yang @ 2019-01-30 0:06 UTC (permalink / raw)
To: qemu-trivial, qemu-devel; +Cc: mst, laurent, imammedo, philmd, Wei Yang
acpi_table_builtin is now always false, it is not necessary to check it
again.
This patch just removes it.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
---
hw/acpi/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index e9b1a85e54..f9c96535d1 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -303,8 +303,6 @@ out:
error_propagate(errp, err);
}
-static bool acpi_table_builtin = false;
-
unsigned acpi_table_len(void *current)
{
struct acpi_table_header *hdr = current - sizeof(hdr->_length);
@@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)
uint8_t *acpi_table_first(void)
{
- if (acpi_table_builtin || !acpi_tables) {
+ if (!acpi_tables) {
return NULL;
}
return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);
--
2.19.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
@ 2019-01-30 8:10 ` Igor Mammedov
2019-01-30 9:50 ` Thomas Huth
1 sibling, 0 replies; 28+ messages in thread
From: Igor Mammedov @ 2019-01-30 8:10 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-trivial, qemu-devel, mst, laurent, philmd
On Wed, 30 Jan 2019 08:06:51 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:
> Function pc_acpi_init() is not used anymore.
>
> Remove the definition and declaration.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/i386/pc.c | 27 ---------------------------
> include/hw/i386/pc.h | 1 -
> 2 files changed, 28 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 5317e08f60..734d3268fa 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
> pci_address_space, -1);
> }
>
> -void pc_acpi_init(const char *default_dsdt)
> -{
> - char *filename;
> -
> - if (acpi_tables != NULL) {
> - /* manually set via -acpitable, leave it alone */
> - return;
> - }
> -
> - filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
> - if (filename == NULL) {
> - warn_report("failed to find %s", default_dsdt);
> - } else {
> - QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
> - &error_abort);
> - Error *err = NULL;
> -
> - qemu_opt_set(opts, "file", filename, &error_abort);
> -
> - acpi_table_add_builtin(opts, &err);
> - if (err) {
> - warn_reportf_err(err, "failed to load %s: ", filename);
> - }
> - g_free(filename);
> - }
> -}
> -
> void xen_load_linux(PCMachineState *pcms)
> {
> int i;
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 9d29c4b1df..541124ba6d 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
>
> void pc_cpus_init(PCMachineState *pcms);
> void pc_hot_add_cpu(const int64_t id, Error **errp);
> -void pc_acpi_init(const char *default_dsdt);
>
> void pc_guest_info_init(PCMachineState *pcms);
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin()
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
@ 2019-01-30 8:11 ` Igor Mammedov
0 siblings, 0 replies; 28+ messages in thread
From: Igor Mammedov @ 2019-01-30 8:11 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-trivial, qemu-devel, mst, laurent, philmd
On Wed, 30 Jan 2019 08:06:52 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:
> Function acpi_table_add_builtin() is not used anymore.
>
> Remove the definition and declaration.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/acpi/core.c | 6 ------
> include/hw/acpi/acpi.h | 1 -
> 2 files changed, 7 deletions(-)
>
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index d6f0709691..e9b1a85e54 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -305,12 +305,6 @@ out:
>
> static bool acpi_table_builtin = false;
>
> -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp)
> -{
> - acpi_table_builtin = true;
> - acpi_table_add(opts, errp);
> -}
> -
> unsigned acpi_table_len(void *current)
> {
> struct acpi_table_header *hdr = current - sizeof(hdr->_length);
> diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h
> index c20ace0d0b..4a8bbaf1b5 100644
> --- a/include/hw/acpi/acpi.h
> +++ b/include/hw/acpi/acpi.h
> @@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);
> uint8_t *acpi_table_next(uint8_t *current);
> unsigned acpi_table_len(void *current);
> void acpi_table_add(const QemuOpts *opts, Error **errp);
> -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp);
>
> typedef struct AcpiSlicOem AcpiSlicOem;
> struct AcpiSlicOem {
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
@ 2019-01-30 8:11 ` Igor Mammedov
0 siblings, 0 replies; 28+ messages in thread
From: Igor Mammedov @ 2019-01-30 8:11 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-trivial, qemu-devel, mst, laurent, philmd
On Wed, 30 Jan 2019 08:06:53 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:
> acpi_table_builtin is now always false, it is not necessary to check it
> again.
>
> This patch just removes it.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/acpi/core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index e9b1a85e54..f9c96535d1 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -303,8 +303,6 @@ out:
> error_propagate(errp, err);
> }
>
> -static bool acpi_table_builtin = false;
> -
> unsigned acpi_table_len(void *current)
> {
> struct acpi_table_header *hdr = current - sizeof(hdr->_length);
> @@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)
>
> uint8_t *acpi_table_first(void)
> {
> - if (acpi_table_builtin || !acpi_tables) {
> + if (!acpi_tables) {
> return NULL;
> }
> return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-30 8:10 ` Igor Mammedov
@ 2019-01-30 9:50 ` Thomas Huth
2019-01-30 11:07 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 28+ messages in thread
From: Thomas Huth @ 2019-01-30 9:50 UTC (permalink / raw)
To: Wei Yang, qemu-trivial, qemu-devel, philmd; +Cc: imammedo, laurent, mst
On 2019-01-30 01:06, Wei Yang wrote:
> Function pc_acpi_init() is not used anymore.
>
> Remove the definition and declaration.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
Hi,
at least in my e-mail client here, it looks like Philippe's last name
got mojibaked here. It should be "Daudé", not "Daud茅", as far as I know.
Same thing also happened in patch 2 and 3.
Apart from that:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()
2019-01-30 9:50 ` Thomas Huth
@ 2019-01-30 11:07 ` Philippe Mathieu-Daudé
2019-01-30 12:58 ` Wei Yang
0 siblings, 1 reply; 28+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-30 11:07 UTC (permalink / raw)
To: Thomas Huth, Wei Yang, qemu-trivial, qemu-devel; +Cc: imammedo, laurent, mst
On 1/30/19 10:50 AM, Thomas Huth wrote:
> On 2019-01-30 01:06, Wei Yang wrote:
>> Function pc_acpi_init() is not used anymore.
>>
>> Remove the definition and declaration.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
>> Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
>
> Hi,
>
> at least in my e-mail client here, it looks like Philippe's last name
> got mojibaked here. It should be "Daudé", not "Daud茅", as far as I know.
> Same thing also happened in patch 2 and 3.
Thanks!
>
> Apart from that:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()
2019-01-30 11:07 ` Philippe Mathieu-Daudé
@ 2019-01-30 12:58 ` Wei Yang
0 siblings, 0 replies; 28+ messages in thread
From: Wei Yang @ 2019-01-30 12:58 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Thomas Huth, Wei Yang, qemu-trivial, qemu-devel, imammedo, laurent, mst
On Wed, Jan 30, 2019 at 12:07:02PM +0100, Philippe Mathieu-Daudé wrote:
>On 1/30/19 10:50 AM, Thomas Huth wrote:
>> On 2019-01-30 01:06, Wei Yang wrote:
>>> Function pc_acpi_init() is not used anymore.
>>>
>>> Remove the definition and declaration.
>>>
>>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>> Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
>>> Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
>>
>> Hi,
>>
>> at least in my e-mail client here, it looks like Philippe's last name
>> got mojibaked here. It should be "Daudé", not "Daud茅", as far as I know.
>> Same thing also happened in patch 2 and 3.
>
>Thanks!
>
Opps, sorry for that.
Not sure which part changes the encoding.
>>
>> Apart from that:
>>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-01-30 0:06 [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
` (2 preceding siblings ...)
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
@ 2019-02-12 5:22 ` Wei Yang
2019-02-12 5:34 ` Michael S. Tsirkin
3 siblings, 1 reply; 28+ messages in thread
From: Wei Yang @ 2019-02-12 5:22 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-trivial, qemu-devel, mst, laurent, imammedo, philmd
On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>There are several functions/variable which are not used anymore.
>
>This serials just remove those without functional change.
>
>v3: add ack and repost in a new thread
>v2: change commit log from "is now used in no place" to "in not used anymore"
Michael,
Looks this serials is not merged yet.
Is there any problem I need to fix?
>
>Wei Yang (3):
> hw/i386/pc.c: remove unused function pc_acpi_init()
> hw/acpi: remove unused function acpi_table_add_builtin()
> hw/acpi: remove unnecessary variable acpi_table_builtin
>
> hw/acpi/core.c | 10 +---------
> hw/i386/pc.c | 27 ---------------------------
> include/hw/acpi/acpi.h | 1 -
> include/hw/i386/pc.h | 1 -
> 4 files changed, 1 insertion(+), 38 deletions(-)
>
>--
>2.19.1
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-12 5:22 ` [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
@ 2019-02-12 5:34 ` Michael S. Tsirkin
2019-02-13 6:26 ` Wei Yang
2019-02-13 8:49 ` Laurent Vivier
0 siblings, 2 replies; 28+ messages in thread
From: Michael S. Tsirkin @ 2019-02-12 5:34 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-trivial, qemu-devel, laurent, imammedo, philmd
On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
> >There are several functions/variable which are not used anymore.
> >
> >This serials just remove those without functional change.
> >
> >v3: add ack and repost in a new thread
> >v2: change commit log from "is now used in no place" to "in not used anymore"
>
> Michael,
>
> Looks this serials is not merged yet.
>
> Is there any problem I need to fix?
Yes pls repost with fixed reviewed-by tags.
> >
> >Wei Yang (3):
> > hw/i386/pc.c: remove unused function pc_acpi_init()
> > hw/acpi: remove unused function acpi_table_add_builtin()
> > hw/acpi: remove unnecessary variable acpi_table_builtin
> >
> > hw/acpi/core.c | 10 +---------
> > hw/i386/pc.c | 27 ---------------------------
> > include/hw/acpi/acpi.h | 1 -
> > include/hw/i386/pc.h | 1 -
> > 4 files changed, 1 insertion(+), 38 deletions(-)
> >
> >--
> >2.19.1
>
> --
> Wei Yang
> Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-12 5:34 ` Michael S. Tsirkin
@ 2019-02-13 6:26 ` Wei Yang
2019-02-13 6:32 ` Philippe Mathieu-Daudé
2019-02-13 8:49 ` Laurent Vivier
1 sibling, 1 reply; 28+ messages in thread
From: Wei Yang @ 2019-02-13 6:26 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Wei Yang, qemu-trivial, qemu-devel, laurent, imammedo, philmd
On Tue, Feb 12, 2019 at 12:34:31AM -0500, Michael S. Tsirkin wrote:
>On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>> >There are several functions/variable which are not used anymore.
>> >
>> >This serials just remove those without functional change.
>> >
>> >v3: add ack and repost in a new thread
>> >v2: change commit log from "is now used in no place" to "in not used anymore"
>>
>> Michael,
>>
>> Looks this serials is not merged yet.
>>
>> Is there any problem I need to fix?
>
>Yes pls repost with fixed reviewed-by tags.
>
I tried to use git-sendemail to send those patches again.
The character 茅 looks good in patch file, while after git-sendemail this is
changed.
My encoding property in mail is :
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Looks the same as Philippe's.
Any hint on how to send out a correct character with git-sendemail?
>
>> >
>> >Wei Yang (3):
>> > hw/i386/pc.c: remove unused function pc_acpi_init()
>> > hw/acpi: remove unused function acpi_table_add_builtin()
>> > hw/acpi: remove unnecessary variable acpi_table_builtin
>> >
>> > hw/acpi/core.c | 10 +---------
>> > hw/i386/pc.c | 27 ---------------------------
>> > include/hw/acpi/acpi.h | 1 -
>> > include/hw/i386/pc.h | 1 -
>> > 4 files changed, 1 insertion(+), 38 deletions(-)
>> >
>> >--
>> >2.19.1
>>
>> --
>> Wei Yang
>> Help you, Help me
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-13 6:26 ` Wei Yang
@ 2019-02-13 6:32 ` Philippe Mathieu-Daudé
2019-02-13 7:01 ` Wei Yang
0 siblings, 1 reply; 28+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-13 6:32 UTC (permalink / raw)
To: Wei Yang, Michael S. Tsirkin; +Cc: qemu-trivial, qemu-devel, laurent, imammedo
Hi Wei,
On 2/13/19 7:26 AM, Wei Yang wrote:
> On Tue, Feb 12, 2019 at 12:34:31AM -0500, Michael S. Tsirkin wrote:
>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>> There are several functions/variable which are not used anymore.
>>>>
>>>> This serials just remove those without functional change.
>>>>
>>>> v3: add ack and repost in a new thread
>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>
>>> Michael,
>>>
>>> Looks this serials is not merged yet.
>>>
>>> Is there any problem I need to fix?
>>
>> Yes pls repost with fixed reviewed-by tags.
>>
>
> I tried to use git-sendemail to send those patches again.
>
> The character 茅 looks good in patch file, while after git-sendemail this is
> changed.
>
> My encoding property in mail is :
>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Language: en-US
> Content-Transfer-Encoding: 8bit
I'm not sure but you can try:
Content-Transfer-Encoding: base64
>
> Looks the same as Philippe's.
>
> Any hint on how to send out a correct character with git-sendemail?
If it doesn't work, then use my ASCII-reduced lastname, I can live with
that:
"Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>"
Thanks for trying,
Phil.
>
>>
>>>>
>>>> Wei Yang (3):
>>>> hw/i386/pc.c: remove unused function pc_acpi_init()
>>>> hw/acpi: remove unused function acpi_table_add_builtin()
>>>> hw/acpi: remove unnecessary variable acpi_table_builtin
>>>>
>>>> hw/acpi/core.c | 10 +---------
>>>> hw/i386/pc.c | 27 ---------------------------
>>>> include/hw/acpi/acpi.h | 1 -
>>>> include/hw/i386/pc.h | 1 -
>>>> 4 files changed, 1 insertion(+), 38 deletions(-)
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-13 6:32 ` Philippe Mathieu-Daudé
@ 2019-02-13 7:01 ` Wei Yang
0 siblings, 0 replies; 28+ messages in thread
From: Wei Yang @ 2019-02-13 7:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Wei Yang, Michael S. Tsirkin, qemu-trivial, qemu-devel, laurent,
imammedo
On Wed, Feb 13, 2019 at 07:32:23AM +0100, Philippe Mathieu-Daudé wrote:
>Hi Wei,
>
>On 2/13/19 7:26 AM, Wei Yang wrote:
>> On Tue, Feb 12, 2019 at 12:34:31AM -0500, Michael S. Tsirkin wrote:
>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>> There are several functions/variable which are not used anymore.
>>>>>
>>>>> This serials just remove those without functional change.
>>>>>
>>>>> v3: add ack and repost in a new thread
>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>
>>>> Michael,
>>>>
>>>> Looks this serials is not merged yet.
>>>>
>>>> Is there any problem I need to fix?
>>>
>>> Yes pls repost with fixed reviewed-by tags.
>>>
>>
>> I tried to use git-sendemail to send those patches again.
>>
>> The character 茅 looks good in patch file, while after git-sendemail this is
>> changed.
>>
>> My encoding property in mail is :
>>
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Language: en-US
>> Content-Transfer-Encoding: 8bit
>
>I'm not sure but you can try:
>
> Content-Transfer-Encoding: base64
>
Looks not work.
git send-email will detect the file's encoding is 8bit, so manually change to
base64 doesn't work.
>>
>> Looks the same as Philippe's.
>>
>> Any hint on how to send out a correct character with git-sendemail?
>
>If it doesn't work, then use my ASCII-reduced lastname, I can live with
>that:
>
>"Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>"
>
>Thanks for trying,
Thanks :-)
Let's wait a while to see whether someone else has an idea on that.
>
>Phil.
>
>>
>>>
>>>>>
>>>>> Wei Yang (3):
>>>>> hw/i386/pc.c: remove unused function pc_acpi_init()
>>>>> hw/acpi: remove unused function acpi_table_add_builtin()
>>>>> hw/acpi: remove unnecessary variable acpi_table_builtin
>>>>>
>>>>> hw/acpi/core.c | 10 +---------
>>>>> hw/i386/pc.c | 27 ---------------------------
>>>>> include/hw/acpi/acpi.h | 1 -
>>>>> include/hw/i386/pc.h | 1 -
>>>>> 4 files changed, 1 insertion(+), 38 deletions(-)
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-12 5:34 ` Michael S. Tsirkin
2019-02-13 6:26 ` Wei Yang
@ 2019-02-13 8:49 ` Laurent Vivier
2019-02-13 8:54 ` Wei Yang
2019-02-13 8:56 ` Philippe Mathieu-Daudé
1 sibling, 2 replies; 28+ messages in thread
From: Laurent Vivier @ 2019-02-13 8:49 UTC (permalink / raw)
To: Michael S. Tsirkin, Wei Yang; +Cc: qemu-trivial, qemu-devel, imammedo, philmd
On 12/02/2019 06:34, Michael S. Tsirkin wrote:
> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>> There are several functions/variable which are not used anymore.
>>>
>>> This serials just remove those without functional change.
>>>
>>> v3: add ack and repost in a new thread
>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>
>> Michael,
>>
>> Looks this serials is not merged yet.
>>
>> Is there any problem I need to fix?
>
> Yes pls repost with fixed reviewed-by tags.
Or I can take the series through the trivial branch and update manually
Philippe's lastname?
Laurent
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-13 8:49 ` Laurent Vivier
@ 2019-02-13 8:54 ` Wei Yang
2019-02-13 8:56 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 28+ messages in thread
From: Wei Yang @ 2019-02-13 8:54 UTC (permalink / raw)
To: Laurent Vivier
Cc: Michael S. Tsirkin, Wei Yang, qemu-trivial, qemu-devel, imammedo, philmd
On Wed, Feb 13, 2019 at 09:49:01AM +0100, Laurent Vivier wrote:
>On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>> There are several functions/variable which are not used anymore.
>>>>
>>>> This serials just remove those without functional change.
>>>>
>>>> v3: add ack and repost in a new thread
>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>
>>> Michael,
>>>
>>> Looks this serials is not merged yet.
>>>
>>> Is there any problem I need to fix?
>>
>> Yes pls repost with fixed reviewed-by tags.
>
>Or I can take the series through the trivial branch and update manually
>Philippe's lastname?
>
Thanks :-)
Let's see Michael's opinion.
>Laurent
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-13 8:49 ` Laurent Vivier
2019-02-13 8:54 ` Wei Yang
@ 2019-02-13 8:56 ` Philippe Mathieu-Daudé
2019-02-13 13:31 ` Wei Yang
2019-02-13 13:45 ` Laurent Vivier
1 sibling, 2 replies; 28+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-13 8:56 UTC (permalink / raw)
To: Laurent Vivier, Michael S. Tsirkin, Wei Yang
Cc: qemu-trivial, qemu-devel, imammedo
Hi Laurent,
On 2/13/19 9:49 AM, Laurent Vivier wrote:
> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>> There are several functions/variable which are not used anymore.
>>>>
>>>> This serials just remove those without functional change.
>>>>
>>>> v3: add ack and repost in a new thread
>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>
>>> Michael,
>>>
>>> Looks this serials is not merged yet.
>>>
>>> Is there any problem I need to fix?
>>
>> Yes pls repost with fixed reviewed-by tags.
>
> Or I can take the series through the trivial branch and update manually
> Philippe's lastname?
I appreciate the help with manual update, however Wei is not the only
one having this problem (other developpers has non-ASCII in their name,
and use such tags).
I'd rather prefer we find a proper configuration setup to help the
community.
Another (fair) approach is to forbid non-ASCII chars in all part of patches.
Regards,
Phil.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-13 8:56 ` Philippe Mathieu-Daudé
@ 2019-02-13 13:31 ` Wei Yang
2019-02-13 13:45 ` Laurent Vivier
1 sibling, 0 replies; 28+ messages in thread
From: Wei Yang @ 2019-02-13 13:31 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Laurent Vivier, Michael S. Tsirkin, Wei Yang, qemu-trivial,
imammedo, qemu-devel
On Wed, Feb 13, 2019 at 09:56:38AM +0100, Philippe Mathieu-Daudé wrote:
>Hi Laurent,
>
>On 2/13/19 9:49 AM, Laurent Vivier wrote:
>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>> There are several functions/variable which are not used anymore.
>>>>>
>>>>> This serials just remove those without functional change.
>>>>>
>>>>> v3: add ack and repost in a new thread
>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>
>>>> Michael,
>>>>
>>>> Looks this serials is not merged yet.
>>>>
>>>> Is there any problem I need to fix?
>>>
>>> Yes pls repost with fixed reviewed-by tags.
>>
>> Or I can take the series through the trivial branch and update manually
>> Philippe's lastname?
>
>I appreciate the help with manual update, however Wei is not the only
>one having this problem (other developpers has non-ASCII in their name,
>and use such tags).
>I'd rather prefer we find a proper configuration setup to help the
>community.
>
How you configure your git send-email? or related facility?
>Another (fair) approach is to forbid non-ASCII chars in all part of patches.
>
>Regards,
>
>Phil.
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-13 8:56 ` Philippe Mathieu-Daudé
2019-02-13 13:31 ` Wei Yang
@ 2019-02-13 13:45 ` Laurent Vivier
2019-02-14 0:03 ` Wei Yang
1 sibling, 1 reply; 28+ messages in thread
From: Laurent Vivier @ 2019-02-13 13:45 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Michael S. Tsirkin, Wei Yang
Cc: qemu-trivial, qemu-devel, imammedo
On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
> Hi Laurent,
>
> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>> There are several functions/variable which are not used anymore.
>>>>>
>>>>> This serials just remove those without functional change.
>>>>>
>>>>> v3: add ack and repost in a new thread
>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>
>>>> Michael,
>>>>
>>>> Looks this serials is not merged yet.
>>>>
>>>> Is there any problem I need to fix?
>>>
>>> Yes pls repost with fixed reviewed-by tags.
>>
>> Or I can take the series through the trivial branch and update manually
>> Philippe's lastname?
>
> I appreciate the help with manual update, however Wei is not the only
> one having this problem (other developpers has non-ASCII in their name,
> and use such tags).
> I'd rather prefer we find a proper configuration setup to help the
> community.
I'm wondering if it can be a problem with cut'n'paste rather than with
git-sendemail.
I think the following tags should cover Latin and Chinese characters:
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Thanks,
Laurent
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-13 13:45 ` Laurent Vivier
@ 2019-02-14 0:03 ` Wei Yang
2019-02-14 7:57 ` Laurent Vivier
0 siblings, 1 reply; 28+ messages in thread
From: Wei Yang @ 2019-02-14 0:03 UTC (permalink / raw)
To: Laurent Vivier
Cc: Philippe Mathieu-Daudé,
Michael S. Tsirkin, Wei Yang, qemu-trivial, qemu-devel, imammedo
On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote:
>On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
>> Hi Laurent,
>>
>> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>>> There are several functions/variable which are not used anymore.
>>>>>>
>>>>>> This serials just remove those without functional change.
>>>>>>
>>>>>> v3: add ack and repost in a new thread
>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>>
>>>>> Michael,
>>>>>
>>>>> Looks this serials is not merged yet.
>>>>>
>>>>> Is there any problem I need to fix?
>>>>
>>>> Yes pls repost with fixed reviewed-by tags.
>>>
>>> Or I can take the series through the trivial branch and update manually
>>> Philippe's lastname?
>>
>> I appreciate the help with manual update, however Wei is not the only
>> one having this problem (other developpers has non-ASCII in their name,
>> and use such tags).
>> I'd rather prefer we find a proper configuration setup to help the
>> community.
>
>I'm wondering if it can be a problem with cut'n'paste rather than with
>git-sendemail.
>
>I think the following tags should cover Latin and Chinese characters:
>
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
Looks not work.
I have tried this and also with
Content-Language: en-US
The character would be modified after git send-email.
>Thanks,
>Laurent
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-14 0:03 ` Wei Yang
@ 2019-02-14 7:57 ` Laurent Vivier
2019-02-14 8:10 ` Laurent Vivier
0 siblings, 1 reply; 28+ messages in thread
From: Laurent Vivier @ 2019-02-14 7:57 UTC (permalink / raw)
To: Wei Yang
Cc: Philippe Mathieu-Daudé,
Michael S. Tsirkin, qemu-trivial, qemu-devel, imammedo
On 14/02/2019 01:03, Wei Yang wrote:
> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote:
>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
>>> Hi Laurent,
>>>
>>> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>>>> There are several functions/variable which are not used anymore.
>>>>>>>
>>>>>>> This serials just remove those without functional change.
>>>>>>>
>>>>>>> v3: add ack and repost in a new thread
>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>>>
>>>>>> Michael,
>>>>>>
>>>>>> Looks this serials is not merged yet.
>>>>>>
>>>>>> Is there any problem I need to fix?
>>>>>
>>>>> Yes pls repost with fixed reviewed-by tags.
>>>>
>>>> Or I can take the series through the trivial branch and update manually
>>>> Philippe's lastname?
>>>
>>> I appreciate the help with manual update, however Wei is not the only
>>> one having this problem (other developpers has non-ASCII in their name,
>>> and use such tags).
>>> I'd rather prefer we find a proper configuration setup to help the
>>> community.
>>
>> I'm wondering if it can be a problem with cut'n'paste rather than with
>> git-sendemail.
>>
>> I think the following tags should cover Latin and Chinese characters:
>>
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>
> Looks not work.
>
> I have tried this and also with
>
> Content-Language: en-US
Could you send me a gzipped version of the 0001-XXX.patch in attachment
so I could see the real content before git-send-email?
Thansk,
Laurent
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-14 7:57 ` Laurent Vivier
@ 2019-02-14 8:10 ` Laurent Vivier
2019-02-14 8:18 ` Wei Yang
0 siblings, 1 reply; 28+ messages in thread
From: Laurent Vivier @ 2019-02-14 8:10 UTC (permalink / raw)
To: Wei Yang
Cc: Philippe Mathieu-Daudé,
Michael S. Tsirkin, qemu-trivial, qemu-devel, imammedo
On 14/02/2019 08:57, Laurent Vivier wrote:
> On 14/02/2019 01:03, Wei Yang wrote:
>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote:
>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
>>>> Hi Laurent,
>>>>
>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>>>>> There are several functions/variable which are not used anymore.
>>>>>>>>
>>>>>>>> This serials just remove those without functional change.
>>>>>>>>
>>>>>>>> v3: add ack and repost in a new thread
>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>>>>
>>>>>>> Michael,
>>>>>>>
>>>>>>> Looks this serials is not merged yet.
>>>>>>>
>>>>>>> Is there any problem I need to fix?
>>>>>>
>>>>>> Yes pls repost with fixed reviewed-by tags.
>>>>>
>>>>> Or I can take the series through the trivial branch and update manually
>>>>> Philippe's lastname?
>>>>
>>>> I appreciate the help with manual update, however Wei is not the only
>>>> one having this problem (other developpers has non-ASCII in their name,
>>>> and use such tags).
>>>> I'd rather prefer we find a proper configuration setup to help the
>>>> community.
>>>
>>> I'm wondering if it can be a problem with cut'n'paste rather than with
>>> git-sendemail.
>>>
>>> I think the following tags should cover Latin and Chinese characters:
>>>
>>> Content-Type: text/plain; charset=UTF-8
>>> Content-Transfer-Encoding: 8bit
>>>
>>
>> Looks not work.
>>
>> I have tried this and also with
>>
>> Content-Language: en-US
>
> Could you send me a gzipped version of the 0001-XXX.patch in attachment
> so I could see the real content before git-send-email?
OK, I've got it.
What I see is it is already corrupted, thus the problem is not with
git-send-email.
So either it is corrupted by git-format-patch (which is very unlikely,
we could see that if you push it to a public git repo) or it has been
corrupted when you have added it to the commit message.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-14 8:10 ` Laurent Vivier
@ 2019-02-14 8:18 ` Wei Yang
2019-02-14 8:23 ` Laurent Vivier
0 siblings, 1 reply; 28+ messages in thread
From: Wei Yang @ 2019-02-14 8:18 UTC (permalink / raw)
To: Laurent Vivier
Cc: Wei Yang, Philippe Mathieu-Daudé,
Michael S. Tsirkin, qemu-trivial, qemu-devel, imammedo
On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote:
>On 14/02/2019 08:57, Laurent Vivier wrote:
>> On 14/02/2019 01:03, Wei Yang wrote:
>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote:
>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
>>>>> Hi Laurent,
>>>>>
>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>>>>>> There are several functions/variable which are not used anymore.
>>>>>>>>>
>>>>>>>>> This serials just remove those without functional change.
>>>>>>>>>
>>>>>>>>> v3: add ack and repost in a new thread
>>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>>>>>
>>>>>>>> Michael,
>>>>>>>>
>>>>>>>> Looks this serials is not merged yet.
>>>>>>>>
>>>>>>>> Is there any problem I need to fix?
>>>>>>>
>>>>>>> Yes pls repost with fixed reviewed-by tags.
>>>>>>
>>>>>> Or I can take the series through the trivial branch and update manually
>>>>>> Philippe's lastname?
>>>>>
>>>>> I appreciate the help with manual update, however Wei is not the only
>>>>> one having this problem (other developpers has non-ASCII in their name,
>>>>> and use such tags).
>>>>> I'd rather prefer we find a proper configuration setup to help the
>>>>> community.
>>>>
>>>> I'm wondering if it can be a problem with cut'n'paste rather than with
>>>> git-sendemail.
>>>>
>>>> I think the following tags should cover Latin and Chinese characters:
>>>>
>>>> Content-Type: text/plain; charset=UTF-8
>>>> Content-Transfer-Encoding: 8bit
>>>>
>>>
>>> Looks not work.
>>>
>>> I have tried this and also with
>>>
>>> Content-Language: en-US
>>
>> Could you send me a gzipped version of the 0001-XXX.patch in attachment
>> so I could see the real content before git-send-email?
>
>OK, I've got it.
>
>What I see is it is already corrupted, thus the problem is not with
>git-send-email.
>
>So either it is corrupted by git-format-patch (which is very unlikely,
>we could see that if you push it to a public git repo) or it has been
>corrupted when you have added it to the commit message.
>
Hmm... maybe you are right.
But I found confused how to fix this.
When I use git commit --amend to fix it, the character looks good in my
editor. I use vim as my git editor.
But when I use git show, it display an unknown character.
And if I use git format-patch, the patch file looks good in my vim editor. But
corrupted if I use another editor.
Do you have any idea on this?
>Thanks,
>Laurent
>
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-14 8:18 ` Wei Yang
@ 2019-02-14 8:23 ` Laurent Vivier
2019-02-14 8:39 ` Wei Yang
2019-02-14 8:51 ` Wei Yang
0 siblings, 2 replies; 28+ messages in thread
From: Laurent Vivier @ 2019-02-14 8:23 UTC (permalink / raw)
To: Wei Yang
Cc: Philippe Mathieu-Daudé,
Michael S. Tsirkin, qemu-trivial, qemu-devel, imammedo
On 14/02/2019 09:18, Wei Yang wrote:
> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote:
>> On 14/02/2019 08:57, Laurent Vivier wrote:
>>> On 14/02/2019 01:03, Wei Yang wrote:
>>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote:
>>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
>>>>>> Hi Laurent,
>>>>>>
>>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>>>>>>> There are several functions/variable which are not used anymore.
>>>>>>>>>>
>>>>>>>>>> This serials just remove those without functional change.
>>>>>>>>>>
>>>>>>>>>> v3: add ack and repost in a new thread
>>>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>>>>>>
>>>>>>>>> Michael,
>>>>>>>>>
>>>>>>>>> Looks this serials is not merged yet.
>>>>>>>>>
>>>>>>>>> Is there any problem I need to fix?
>>>>>>>>
>>>>>>>> Yes pls repost with fixed reviewed-by tags.
>>>>>>>
>>>>>>> Or I can take the series through the trivial branch and update manually
>>>>>>> Philippe's lastname?
>>>>>>
>>>>>> I appreciate the help with manual update, however Wei is not the only
>>>>>> one having this problem (other developpers has non-ASCII in their name,
>>>>>> and use such tags).
>>>>>> I'd rather prefer we find a proper configuration setup to help the
>>>>>> community.
>>>>>
>>>>> I'm wondering if it can be a problem with cut'n'paste rather than with
>>>>> git-sendemail.
>>>>>
>>>>> I think the following tags should cover Latin and Chinese characters:
>>>>>
>>>>> Content-Type: text/plain; charset=UTF-8
>>>>> Content-Transfer-Encoding: 8bit
>>>>>
>>>>
>>>> Looks not work.
>>>>
>>>> I have tried this and also with
>>>>
>>>> Content-Language: en-US
>>>
>>> Could you send me a gzipped version of the 0001-XXX.patch in attachment
>>> so I could see the real content before git-send-email?
>>
>> OK, I've got it.
>>
>> What I see is it is already corrupted, thus the problem is not with
>> git-send-email.
>>
>> So either it is corrupted by git-format-patch (which is very unlikely,
>> we could see that if you push it to a public git repo) or it has been
>> corrupted when you have added it to the commit message.
>>
>
> Hmm... maybe you are right.
>
> But I found confused how to fix this.
>
> When I use git commit --amend to fix it, the character looks good in my
> editor. I use vim as my git editor.
>
> But when I use git show, it display an unknown character.
>
> And if I use git format-patch, the patch file looks good in my vim editor. But
> corrupted if I use another editor.
>
> Do you have any idea on this?
What is the result of command "locale" in your terminal?
How do you copy the characters to vim?
Thanks,
Laurent
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-14 8:23 ` Laurent Vivier
@ 2019-02-14 8:39 ` Wei Yang
2019-02-14 8:51 ` Wei Yang
1 sibling, 0 replies; 28+ messages in thread
From: Wei Yang @ 2019-02-14 8:39 UTC (permalink / raw)
To: Laurent Vivier
Cc: Wei Yang, Philippe Mathieu-Daudé,
Michael S. Tsirkin, qemu-trivial, qemu-devel, imammedo
On Thu, Feb 14, 2019 at 09:23:39AM +0100, Laurent Vivier wrote:
>On 14/02/2019 09:18, Wei Yang wrote:
>> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote:
>>> On 14/02/2019 08:57, Laurent Vivier wrote:
>>>> On 14/02/2019 01:03, Wei Yang wrote:
>>>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote:
>>>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
>>>>>>> Hi Laurent,
>>>>>>>
>>>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>>>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>>>>>>>> There are several functions/variable which are not used anymore.
>>>>>>>>>>>
>>>>>>>>>>> This serials just remove those without functional change.
>>>>>>>>>>>
>>>>>>>>>>> v3: add ack and repost in a new thread
>>>>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>>>>>>>
>>>>>>>>>> Michael,
>>>>>>>>>>
>>>>>>>>>> Looks this serials is not merged yet.
>>>>>>>>>>
>>>>>>>>>> Is there any problem I need to fix?
>>>>>>>>>
>>>>>>>>> Yes pls repost with fixed reviewed-by tags.
>>>>>>>>
>>>>>>>> Or I can take the series through the trivial branch and update manually
>>>>>>>> Philippe's lastname?
>>>>>>>
>>>>>>> I appreciate the help with manual update, however Wei is not the only
>>>>>>> one having this problem (other developpers has non-ASCII in their name,
>>>>>>> and use such tags).
>>>>>>> I'd rather prefer we find a proper configuration setup to help the
>>>>>>> community.
>>>>>>
>>>>>> I'm wondering if it can be a problem with cut'n'paste rather than with
>>>>>> git-sendemail.
>>>>>>
>>>>>> I think the following tags should cover Latin and Chinese characters:
>>>>>>
>>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>> Content-Transfer-Encoding: 8bit
>>>>>>
>>>>>
>>>>> Looks not work.
>>>>>
>>>>> I have tried this and also with
>>>>>
>>>>> Content-Language: en-US
>>>>
>>>> Could you send me a gzipped version of the 0001-XXX.patch in attachment
>>>> so I could see the real content before git-send-email?
>>>
>>> OK, I've got it.
>>>
>>> What I see is it is already corrupted, thus the problem is not with
>>> git-send-email.
>>>
>>> So either it is corrupted by git-format-patch (which is very unlikely,
>>> we could see that if you push it to a public git repo) or it has been
>>> corrupted when you have added it to the commit message.
>>>
>>
>> Hmm... maybe you are right.
>>
>> But I found confused how to fix this.
>>
>> When I use git commit --amend to fix it, the character looks good in my
>> editor. I use vim as my git editor.
>>
>> But when I use git show, it display an unknown character.
>>
>> And if I use git format-patch, the patch file looks good in my vim editor. But
>> corrupted if I use another editor.
>>
>> Do you have any idea on this?
>
>What is the result of command "locale" in your terminal?
>How do you copy the characters to vim?
>
My locale output:
$ locale
LANG=en_US.UTF-8
LANGUAGE=
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC=zh_CN.UTF-8
LC_TIME=zh_CN.UTF-8
LC_COLLATE="en_US.UTF-8"
LC_MONETARY=zh_CN.UTF-8
LC_MESSAGES="en_US.UTF-8"
LC_PAPER=zh_CN.UTF-8
LC_NAME=zh_CN.UTF-8
LC_ADDRESS=zh_CN.UTF-8
LC_TELEPHONE=zh_CN.UTF-8
LC_MEASUREMENT=zh_CN.UTF-8
LC_IDENTIFICATION=zh_CN.UTF-8
LC_ALL=
I copy&paste the character from mutt to vim. Let me see if it would work if I
save the character from mutt mail itself.
>Thanks,
>Laurent
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-14 8:23 ` Laurent Vivier
2019-02-14 8:39 ` Wei Yang
@ 2019-02-14 8:51 ` Wei Yang
2019-02-14 9:11 ` Laurent Vivier
1 sibling, 1 reply; 28+ messages in thread
From: Wei Yang @ 2019-02-14 8:51 UTC (permalink / raw)
To: Laurent Vivier
Cc: Wei Yang, Philippe Mathieu-Daudé,
Michael S. Tsirkin, qemu-trivial, qemu-devel, imammedo
On Thu, Feb 14, 2019 at 09:23:39AM +0100, Laurent Vivier wrote:
>On 14/02/2019 09:18, Wei Yang wrote:
>> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote:
>>> On 14/02/2019 08:57, Laurent Vivier wrote:
>>>> On 14/02/2019 01:03, Wei Yang wrote:
>>>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote:
>>>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
>>>>>>> Hi Laurent,
>>>>>>>
>>>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>>>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>>>>>>>> There are several functions/variable which are not used anymore.
>>>>>>>>>>>
>>>>>>>>>>> This serials just remove those without functional change.
>>>>>>>>>>>
>>>>>>>>>>> v3: add ack and repost in a new thread
>>>>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>>>>>>>
>>>>>>>>>> Michael,
>>>>>>>>>>
>>>>>>>>>> Looks this serials is not merged yet.
>>>>>>>>>>
>>>>>>>>>> Is there any problem I need to fix?
>>>>>>>>>
>>>>>>>>> Yes pls repost with fixed reviewed-by tags.
>>>>>>>>
>>>>>>>> Or I can take the series through the trivial branch and update manually
>>>>>>>> Philippe's lastname?
>>>>>>>
>>>>>>> I appreciate the help with manual update, however Wei is not the only
>>>>>>> one having this problem (other developpers has non-ASCII in their name,
>>>>>>> and use such tags).
>>>>>>> I'd rather prefer we find a proper configuration setup to help the
>>>>>>> community.
>>>>>>
>>>>>> I'm wondering if it can be a problem with cut'n'paste rather than with
>>>>>> git-sendemail.
>>>>>>
>>>>>> I think the following tags should cover Latin and Chinese characters:
>>>>>>
>>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>> Content-Transfer-Encoding: 8bit
>>>>>>
>>>>>
>>>>> Looks not work.
>>>>>
>>>>> I have tried this and also with
>>>>>
>>>>> Content-Language: en-US
>>>>
>>>> Could you send me a gzipped version of the 0001-XXX.patch in attachment
>>>> so I could see the real content before git-send-email?
>>>
>>> OK, I've got it.
>>>
>>> What I see is it is already corrupted, thus the problem is not with
>>> git-send-email.
>>>
>>> So either it is corrupted by git-format-patch (which is very unlikely,
>>> we could see that if you push it to a public git repo) or it has been
>>> corrupted when you have added it to the commit message.
>>>
>>
>> Hmm... maybe you are right.
>>
>> But I found confused how to fix this.
>>
>> When I use git commit --amend to fix it, the character looks good in my
>> editor. I use vim as my git editor.
>>
>> But when I use git show, it display an unknown character.
>>
>> And if I use git format-patch, the patch file looks good in my vim editor. But
>> corrupted if I use another editor.
>>
>> Do you have any idea on this?
>
>What is the result of command "locale" in your terminal?
>How do you copy the characters to vim?
>
Hi, Laurent
I tried to copied the character directly from Philippe's mail.
This time looks good from my mutt client. Hope it works for you.
Thanks!
>Thanks,
>Laurent
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi
2019-02-14 8:51 ` Wei Yang
@ 2019-02-14 9:11 ` Laurent Vivier
0 siblings, 0 replies; 28+ messages in thread
From: Laurent Vivier @ 2019-02-14 9:11 UTC (permalink / raw)
To: Wei Yang
Cc: Philippe Mathieu-Daudé,
Michael S. Tsirkin, qemu-trivial, qemu-devel, imammedo
On 14/02/2019 09:51, Wei Yang wrote:
> On Thu, Feb 14, 2019 at 09:23:39AM +0100, Laurent Vivier wrote:
>> On 14/02/2019 09:18, Wei Yang wrote:
>>> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote:
>>>> On 14/02/2019 08:57, Laurent Vivier wrote:
>>>>> On 14/02/2019 01:03, Wei Yang wrote:
>>>>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote:
>>>>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
>>>>>>>> Hi Laurent,
>>>>>>>>
>>>>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>>>>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>>>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>>>>>>>>> There are several functions/variable which are not used anymore.
>>>>>>>>>>>>
>>>>>>>>>>>> This serials just remove those without functional change.
>>>>>>>>>>>>
>>>>>>>>>>>> v3: add ack and repost in a new thread
>>>>>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore"
>>>>>>>>>>>
>>>>>>>>>>> Michael,
>>>>>>>>>>>
>>>>>>>>>>> Looks this serials is not merged yet.
>>>>>>>>>>>
>>>>>>>>>>> Is there any problem I need to fix?
>>>>>>>>>>
>>>>>>>>>> Yes pls repost with fixed reviewed-by tags.
>>>>>>>>>
>>>>>>>>> Or I can take the series through the trivial branch and update manually
>>>>>>>>> Philippe's lastname?
>>>>>>>>
>>>>>>>> I appreciate the help with manual update, however Wei is not the only
>>>>>>>> one having this problem (other developpers has non-ASCII in their name,
>>>>>>>> and use such tags).
>>>>>>>> I'd rather prefer we find a proper configuration setup to help the
>>>>>>>> community.
>>>>>>>
>>>>>>> I'm wondering if it can be a problem with cut'n'paste rather than with
>>>>>>> git-sendemail.
>>>>>>>
>>>>>>> I think the following tags should cover Latin and Chinese characters:
>>>>>>>
>>>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>>> Content-Transfer-Encoding: 8bit
>>>>>>>
>>>>>>
>>>>>> Looks not work.
>>>>>>
>>>>>> I have tried this and also with
>>>>>>
>>>>>> Content-Language: en-US
>>>>>
>>>>> Could you send me a gzipped version of the 0001-XXX.patch in attachment
>>>>> so I could see the real content before git-send-email?
>>>>
>>>> OK, I've got it.
>>>>
>>>> What I see is it is already corrupted, thus the problem is not with
>>>> git-send-email.
>>>>
>>>> So either it is corrupted by git-format-patch (which is very unlikely,
>>>> we could see that if you push it to a public git repo) or it has been
>>>> corrupted when you have added it to the commit message.
>>>>
>>>
>>> Hmm... maybe you are right.
>>>
>>> But I found confused how to fix this.
>>>
>>> When I use git commit --amend to fix it, the character looks good in my
>>> editor. I use vim as my git editor.
>>>
>>> But when I use git show, it display an unknown character.
>>>
>>> And if I use git format-patch, the patch file looks good in my vim editor. But
>>> corrupted if I use another editor.
>>>
>>> Do you have any idea on this?
>>
>> What is the result of command "locale" in your terminal?
>> How do you copy the characters to vim?
>>
>
> Hi, Laurent
>
> I tried to copied the character directly from Philippe's mail.
>
> This time looks good from my mutt client. Hope it works for you.
Yes, it's fine.
I let Michael to take the series for the pull request.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2019-02-14 9:11 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-30 0:06 [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-30 8:10 ` Igor Mammedov
2019-01-30 9:50 ` Thomas Huth
2019-01-30 11:07 ` Philippe Mathieu-Daudé
2019-01-30 12:58 ` Wei Yang
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
2019-01-30 8:11 ` Igor Mammedov
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
2019-01-30 8:11 ` Igor Mammedov
2019-02-12 5:22 ` [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-02-12 5:34 ` Michael S. Tsirkin
2019-02-13 6:26 ` Wei Yang
2019-02-13 6:32 ` Philippe Mathieu-Daudé
2019-02-13 7:01 ` Wei Yang
2019-02-13 8:49 ` Laurent Vivier
2019-02-13 8:54 ` Wei Yang
2019-02-13 8:56 ` Philippe Mathieu-Daudé
2019-02-13 13:31 ` Wei Yang
2019-02-13 13:45 ` Laurent Vivier
2019-02-14 0:03 ` Wei Yang
2019-02-14 7:57 ` Laurent Vivier
2019-02-14 8:10 ` Laurent Vivier
2019-02-14 8:18 ` Wei Yang
2019-02-14 8:23 ` Laurent Vivier
2019-02-14 8:39 ` Wei Yang
2019-02-14 8:51 ` Wei Yang
2019-02-14 9:11 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.