Re: [thermal: thermal/next] thermal/drivers/tsens: Convert msm8960 to reg_field

From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>, kernel test robot <lkp@intel.com>
Cc: thermal-bot for Ansuel Smith <tip-bot2@linutronix.de>,
	"open list:QUALCOMM CPUFREQ DRIVER MSM8996/APQ8096" 
	<linux-pm@vger.kernel.org>,
	kbuild-all@lists.01.org,
	Thara Gopinath <thara.gopinath@linaro.org>,
	Zhang Rui <rui.zhang@intel.com>, Amit Kucheria <amitk@kernel.org>
Subject: Re: [thermal: thermal/next] thermal/drivers/tsens: Convert msm8960 to reg_field
Date: Mon, 19 Apr 2021 10:58:00 +0200	[thread overview]
Message-ID: <4187051b-4dcf-88e0-ac3d-fb47ff42e3ef@linaro.org> (raw)
In-Reply-To: <CA+_ehUzAhPhqn62ivcxF+giMUy430eija7_sOSoNmC=291wq-g@mail.gmail.com>

On 15/04/2021 20:52, Ansuel Smith wrote:
>>
>> Hi thermal-bot,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v5.12-rc7]
>> [cannot apply to thermal/next next-20210415]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch]
>>
>> url:    https://github.com/0day-ci/linux/commits/thermal-bot-for-Ansuel-Smith/thermal-drivers-tsens-Convert-msm8960-to-reg_field/20210415-200542
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7f75285ca572eaabc028cf78c6ab5473d0d160be
>> config: arm-randconfig-r015-20210415 (attached as .config)
>> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # https://github.com/0day-ci/linux/commit/efea0f0570b6b581bdb2fad978a35fd1a521385b
>>         git remote add linux-review https://github.com/0day-ci/linux
>>         git fetch --no-tags linux-review thermal-bot-for-Ansuel-Smith/thermal-drivers-tsens-Convert-msm8960-to-reg_field/20210415-200542
>>         git checkout efea0f0570b6b581bdb2fad978a35fd1a521385b
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arm
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>    drivers/thermal/qcom/tsens-8960.c: In function 'init_8960':
>>>> drivers/thermal/qcom/tsens-8960.c:193:29: error: 'S0_STATUS_ADDR' undeclared (first use in this function); did you mean 'INT_STATUS_ADDR'?
>>      193 |    priv->sensor[i].status = S0_STATUS_ADDR + 40;
>>          |                             ^~~~~~~~~~~~~~
>>          |                             INT_STATUS_ADDR
>>    drivers/thermal/qcom/tsens-8960.c:193:29: note: each undeclared identifier is reported only once for each function it appears in
>>    drivers/thermal/qcom/tsens-8960.c: At top level:
>>>> drivers/thermal/qcom/tsens-8960.c:284:15: error: 'VER_0' undeclared here (not in a function); did you mean 'VER_0_1'?
>>      284 |  .ver_major = VER_0,
>>          |               ^~~~~
>>          |               VER_0_1
>>
>>
>> vim +193 drivers/thermal/qcom/tsens-8960.c

[ ... ]

> What happened here? This doesn't seem right.

Yes, it is. It means the series is not git bisect safe.

Please fix it.

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog