From: Ansuel Smith <ansuelsmth@gmail.com> To: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: kernel test robot <lkp@intel.com>, thermal-bot for Ansuel Smith <tip-bot2@linutronix.de>, "open list:QUALCOMM CPUFREQ DRIVER MSM8996/APQ8096" <linux-pm@vger.kernel.org>, kbuild-all@lists.01.org, Thara Gopinath <thara.gopinath@linaro.org>, Zhang Rui <rui.zhang@intel.com>, Amit Kucheria <amitk@kernel.org> Subject: Re: [thermal: thermal/next] thermal/drivers/tsens: Convert msm8960 to reg_field Date: Mon, 19 Apr 2021 14:08:10 +0200 [thread overview] Message-ID: <CA+_ehUziRf7Ls8PByz-9_L8SKB26+yRY-MrZK_26GqdycCkNhg@mail.gmail.com> (raw) In-Reply-To: <4187051b-4dcf-88e0-ac3d-fb47ff42e3ef@linaro.org> > > On 15/04/2021 20:52, Ansuel Smith wrote: > >> > >> Hi thermal-bot, > >> > >> Thank you for the patch! Yet something to improve: > >> > >> [auto build test ERROR on linus/master] > >> [also build test ERROR on v5.12-rc7] > >> [cannot apply to thermal/next next-20210415] > >> [If your patch is applied to the wrong git tree, kindly drop us a note. > >> And when submitting patch, we suggest to use '--base' as documented in > >> https://git-scm.com/docs/git-format-patch] > >> > >> url: https://github.com/0day-ci/linux/commits/thermal-bot-for-Ansuel-Smith/thermal-drivers-tsens-Convert-msm8960-to-reg_field/20210415-200542 > >> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7f75285ca572eaabc028cf78c6ab5473d0d160be > >> config: arm-randconfig-r015-20210415 (attached as .config) > >> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > >> reproduce (this is a W=1 build): > >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >> chmod +x ~/bin/make.cross > >> # https://github.com/0day-ci/linux/commit/efea0f0570b6b581bdb2fad978a35fd1a521385b > >> git remote add linux-review https://github.com/0day-ci/linux > >> git fetch --no-tags linux-review thermal-bot-for-Ansuel-Smith/thermal-drivers-tsens-Convert-msm8960-to-reg_field/20210415-200542 > >> git checkout efea0f0570b6b581bdb2fad978a35fd1a521385b > >> # save the attached .config to linux build tree > >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arm > >> > >> If you fix the issue, kindly add following tag as appropriate > >> Reported-by: kernel test robot <lkp@intel.com> > >> > >> All errors (new ones prefixed by >>): > >> > >> drivers/thermal/qcom/tsens-8960.c: In function 'init_8960': > >>>> drivers/thermal/qcom/tsens-8960.c:193:29: error: 'S0_STATUS_ADDR' undeclared (first use in this function); did you mean 'INT_STATUS_ADDR'? > >> 193 | priv->sensor[i].status = S0_STATUS_ADDR + 40; > >> | ^~~~~~~~~~~~~~ > >> | INT_STATUS_ADDR > >> drivers/thermal/qcom/tsens-8960.c:193:29: note: each undeclared identifier is reported only once for each function it appears in > >> drivers/thermal/qcom/tsens-8960.c: At top level: > >>>> drivers/thermal/qcom/tsens-8960.c:284:15: error: 'VER_0' undeclared here (not in a function); did you mean 'VER_0_1'? > >> 284 | .ver_major = VER_0, > >> | ^~~~~ > >> | VER_0_1 > >> > >> > >> vim +193 drivers/thermal/qcom/tsens-8960.c > > [ ... ] > > > What happened here? This doesn't seem right. > > Yes, it is. It means the series is not git bisect safe. > > Please fix it. > > I'm a bit confused. Should I send just a patch to fix this or I need to send the series again rebased with the new changes? > > -- > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Ansuel Smith <ansuelsmth@gmail.com> To: kbuild-all@lists.01.org Subject: Re: [thermal: thermal/next] thermal/drivers/tsens: Convert msm8960 to reg_field Date: Mon, 19 Apr 2021 14:08:10 +0200 [thread overview] Message-ID: <CA+_ehUziRf7Ls8PByz-9_L8SKB26+yRY-MrZK_26GqdycCkNhg@mail.gmail.com> (raw) In-Reply-To: <4187051b-4dcf-88e0-ac3d-fb47ff42e3ef@linaro.org> [-- Attachment #1: Type: text/plain, Size: 3225 bytes --] > > On 15/04/2021 20:52, Ansuel Smith wrote: > >> > >> Hi thermal-bot, > >> > >> Thank you for the patch! Yet something to improve: > >> > >> [auto build test ERROR on linus/master] > >> [also build test ERROR on v5.12-rc7] > >> [cannot apply to thermal/next next-20210415] > >> [If your patch is applied to the wrong git tree, kindly drop us a note. > >> And when submitting patch, we suggest to use '--base' as documented in > >> https://git-scm.com/docs/git-format-patch] > >> > >> url: https://github.com/0day-ci/linux/commits/thermal-bot-for-Ansuel-Smith/thermal-drivers-tsens-Convert-msm8960-to-reg_field/20210415-200542 > >> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7f75285ca572eaabc028cf78c6ab5473d0d160be > >> config: arm-randconfig-r015-20210415 (attached as .config) > >> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > >> reproduce (this is a W=1 build): > >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >> chmod +x ~/bin/make.cross > >> # https://github.com/0day-ci/linux/commit/efea0f0570b6b581bdb2fad978a35fd1a521385b > >> git remote add linux-review https://github.com/0day-ci/linux > >> git fetch --no-tags linux-review thermal-bot-for-Ansuel-Smith/thermal-drivers-tsens-Convert-msm8960-to-reg_field/20210415-200542 > >> git checkout efea0f0570b6b581bdb2fad978a35fd1a521385b > >> # save the attached .config to linux build tree > >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arm > >> > >> If you fix the issue, kindly add following tag as appropriate > >> Reported-by: kernel test robot <lkp@intel.com> > >> > >> All errors (new ones prefixed by >>): > >> > >> drivers/thermal/qcom/tsens-8960.c: In function 'init_8960': > >>>> drivers/thermal/qcom/tsens-8960.c:193:29: error: 'S0_STATUS_ADDR' undeclared (first use in this function); did you mean 'INT_STATUS_ADDR'? > >> 193 | priv->sensor[i].status = S0_STATUS_ADDR + 40; > >> | ^~~~~~~~~~~~~~ > >> | INT_STATUS_ADDR > >> drivers/thermal/qcom/tsens-8960.c:193:29: note: each undeclared identifier is reported only once for each function it appears in > >> drivers/thermal/qcom/tsens-8960.c: At top level: > >>>> drivers/thermal/qcom/tsens-8960.c:284:15: error: 'VER_0' undeclared here (not in a function); did you mean 'VER_0_1'? > >> 284 | .ver_major = VER_0, > >> | ^~~~~ > >> | VER_0_1 > >> > >> > >> vim +193 drivers/thermal/qcom/tsens-8960.c > > [ ... ] > > > What happened here? This doesn't seem right. > > Yes, it is. It means the series is not git bisect safe. > > Please fix it. > > I'm a bit confused. Should I send just a patch to fix this or I need to send the series again rebased with the new changes? > > -- > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-04-19 12:08 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-04 14:48 [PATCH v14 0/9] Add support for ipq8064 tsens Ansuel Smith 2021-04-04 14:48 ` [PATCH v14 1/9] drivers: thermal: tsens: Add VER_0 tsens version Ansuel Smith 2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/tsens: " thermal-bot for Ansuel Smith 2021-04-04 14:48 ` [PATCH v14 2/9] drivers: thermal: tsens: Don't hardcode sensor slope Ansuel Smith 2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/tsens: " thermal-bot for Ansuel Smith 2021-04-04 14:48 ` [PATCH v14 3/9] drivers: thermal: tsens: Convert msm8960 to reg_field Ansuel Smith 2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/tsens: " thermal-bot for Ansuel Smith 2021-04-15 18:03 ` kernel test robot 2021-04-15 18:03 ` kernel test robot 2021-04-15 18:52 ` Ansuel Smith 2021-04-15 18:52 ` Ansuel Smith 2021-04-19 8:58 ` Daniel Lezcano 2021-04-19 8:58 ` Daniel Lezcano 2021-04-19 12:08 ` Ansuel Smith [this message] 2021-04-19 12:08 ` Ansuel Smith 2021-04-20 7:16 ` Daniel Lezcano 2021-04-20 7:16 ` Daniel Lezcano 2021-04-20 11:04 ` Ansuel Smith 2021-04-20 11:04 ` Ansuel Smith 2021-04-20 11:32 ` Daniel Lezcano 2021-04-20 11:32 ` Daniel Lezcano 2021-04-20 18:36 ` Ansuel Smith 2021-04-20 18:36 ` Ansuel Smith 2021-04-15 20:27 ` kernel test robot 2021-04-15 20:27 ` kernel test robot 2021-04-04 14:48 ` [PATCH v14 4/9] drivers: thermal: tsens: Use init_common for msm8960 Ansuel Smith 2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/tsens: " thermal-bot for Ansuel Smith 2021-04-04 14:48 ` [PATCH v14 5/9] drivers: thermal: tsens: Fix bug in sensor enable " Ansuel Smith 2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/tsens: " thermal-bot for Ansuel Smith 2021-04-04 14:48 ` [PATCH v14 6/9] drivers: thermal: tsens: Replace custom 8960 apis with generic apis Ansuel Smith 2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/tsens: " thermal-bot for Ansuel Smith 2021-04-04 14:48 ` [PATCH v14 7/9] drivers: thermal: tsens: Drop unused define for msm8960 Ansuel Smith 2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/tsens: " thermal-bot for Ansuel Smith 2021-04-04 14:48 ` [PATCH v14 8/9] drivers: thermal: tsens: Add support for ipq8064-tsens Ansuel Smith 2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/tsens: " thermal-bot for Ansuel Smith 2021-04-04 14:48 ` [PATCH v14 9/9] dt-bindings: thermal: tsens: Document ipq8064 bindings Ansuel Smith 2021-04-15 12:03 ` [thermal: thermal/next] " thermal-bot for Ansuel Smith 2021-04-05 22:57 ` [PATCH v14 0/9] Add support for ipq8064 tsens Daniel Lezcano 2021-04-20 18:33 [thermal PATCH v15 2/9] drivers: thermal: tsens: Convert msm8960 to reg_field Ansuel Smith 2021-04-27 19:44 ` [thermal: thermal/next] thermal/drivers/tsens: " thermal-bot for Ansuel Smith
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+_ehUziRf7Ls8PByz-9_L8SKB26+yRY-MrZK_26GqdycCkNhg@mail.gmail.com \ --to=ansuelsmth@gmail.com \ --cc=amitk@kernel.org \ --cc=daniel.lezcano@linaro.org \ --cc=kbuild-all@lists.01.org \ --cc=linux-pm@vger.kernel.org \ --cc=lkp@intel.com \ --cc=rui.zhang@intel.com \ --cc=thara.gopinath@linaro.org \ --cc=tip-bot2@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.