From: Mark Brown <broonie@kernel.org>
To: 沈一超 <zhuning0077@gmail.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, perex@perex.cz, posteuca@mutex.one,
tiwai@suse.com, yangxiaohua <yangxiaohua@everest-semi.com>,
Zhu Ning <zhuning@everest-semi.com>
Subject: Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec
Date: Thu, 23 Mar 2023 13:54:36 +0000 [thread overview]
Message-ID: <42b02a34-1b96-4699-8b0d-3610c5376a7c@sirena.org.uk> (raw)
In-Reply-To: <CANPLYpD8Ty9QjMf3vs9n8wCCFyaHiiRpYM-b3kNGiA0r3q+sEg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]
On Thu, Mar 23, 2023 at 09:56:56AM +0800, 沈一超 wrote:
> > Yes, for example consider a critical notification - the system
> > may wish to ensure it is audible even if the user has taken off
> > their headphones for some reason.
> In practice the speaker and the headphone are conflicting devices, see
> https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/Intel/sof-essx8336/HiFi.conf
That's a particular UCM configuration that someone has created, someone
with a different set of use cases might create a different UCM setup (or
not use UCM at all). This is a large part of the point of having use
case configuration in userspace.
> There is no such situation, and the system doesn't produce sound from speaker
> when headphones are plugged in. The user may manually open speaker using
> amixer sset 'Speaker' on or pavucontrol.
Again, you're describing a specific configuration - someone might want
to do something different.
> The GPIO thing on Huawei Intel platform is too complicated, they use two GPIOs
> for headphone and speaker, and the headphone GPIO is inverted, which means low
> means on and high means off. Luckily there should be only one hardware config
> for the AMD acp3x platform GPIO and you may just choose the correct one.
There being two different GPIOs sounds like it just allows the headphone
and speaker to be controlled separately - that seems more flexible, not
a problem?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: 沈一超 <zhuning0077@gmail.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, posteuca@mutex.one, tiwai@suse.com,
yangxiaohua <yangxiaohua@everest-semi.com>,
Zhu Ning <zhuning@everest-semi.com>
Subject: Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec
Date: Thu, 23 Mar 2023 13:54:36 +0000 [thread overview]
Message-ID: <42b02a34-1b96-4699-8b0d-3610c5376a7c@sirena.org.uk> (raw)
In-Reply-To: <CANPLYpD8Ty9QjMf3vs9n8wCCFyaHiiRpYM-b3kNGiA0r3q+sEg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]
On Thu, Mar 23, 2023 at 09:56:56AM +0800, 沈一超 wrote:
> > Yes, for example consider a critical notification - the system
> > may wish to ensure it is audible even if the user has taken off
> > their headphones for some reason.
> In practice the speaker and the headphone are conflicting devices, see
> https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/Intel/sof-essx8336/HiFi.conf
That's a particular UCM configuration that someone has created, someone
with a different set of use cases might create a different UCM setup (or
not use UCM at all). This is a large part of the point of having use
case configuration in userspace.
> There is no such situation, and the system doesn't produce sound from speaker
> when headphones are plugged in. The user may manually open speaker using
> amixer sset 'Speaker' on or pavucontrol.
Again, you're describing a specific configuration - someone might want
to do something different.
> The GPIO thing on Huawei Intel platform is too complicated, they use two GPIOs
> for headphone and speaker, and the headphone GPIO is inverted, which means low
> means on and high means off. Luckily there should be only one hardware config
> for the AMD acp3x platform GPIO and you may just choose the correct one.
There being two different GPIOs sounds like it just allows the headphone
and speaker to be controlled separately - that seems more flexible, not
a problem?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-23 13:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 1:56 [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec 沈一超
2023-03-23 1:56 ` 沈一超
2023-03-23 13:54 ` Mark Brown [this message]
2023-03-23 13:54 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2023-08-18 7:58 Zhu Ning
2023-03-24 1:54 Zhu Ning
2023-03-24 1:54 ` Zhu Ning
2023-03-29 14:01 ` Mark Brown
2023-03-29 14:01 ` Mark Brown
2023-03-20 20:35 [PATCH 0/4] ASoC: amd: acp: Add sound support for a line of HUAWEI laptops Marian Postevca
2023-03-20 20:35 ` [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec Marian Postevca
2023-03-20 20:54 ` Mark Brown
2023-03-20 20:54 ` Mark Brown
2023-03-21 22:17 ` Marian Postevca
2023-03-21 22:17 ` Marian Postevca
2023-03-22 1:58 ` Pierre-Louis Bossart
2023-03-22 13:07 ` Mark Brown
2023-03-22 13:07 ` Mark Brown
2023-03-22 20:48 ` Marian Postevca
2023-03-22 20:48 ` Marian Postevca
2023-03-22 21:27 ` Mark Brown
2023-03-22 21:27 ` Mark Brown
2023-03-27 21:20 ` Marian Postevca
2023-03-27 21:20 ` Marian Postevca
2023-03-29 13:52 ` Mark Brown
2023-03-29 13:52 ` Mark Brown
2023-08-17 21:09 ` Marian Postevca
2023-08-17 21:47 ` Mark Brown
2023-08-17 22:20 ` Marian Postevca
2023-08-18 12:52 ` Mark Brown
2023-08-20 9:32 ` Marian Postevca
2023-08-21 14:09 ` Mark Brown
2023-03-21 0:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42b02a34-1b96-4699-8b0d-3610c5376a7c@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=posteuca@mutex.one \
--cc=tiwai@suse.com \
--cc=yangxiaohua@everest-semi.com \
--cc=zhuning0077@gmail.com \
--cc=zhuning@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.