From: Mark Brown <broonie@kernel.org>
To: Marian Postevca <posteuca@mutex.one>
Cc: 沈一超 <zhuning0077@gmail.com>,
yangxiaohua <yangxiaohua@everest-semi.com>,
"Zhu Ning" <zhuning@everest-semi.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec
Date: Wed, 22 Mar 2023 21:27:48 +0000 [thread overview]
Message-ID: <ZBty1CdPaWm0IcRi@sirena.org.uk> (raw)
In-Reply-To: <87ttycjyw3.fsf@mutex.one>
[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]
On Wed, Mar 22, 2023 at 10:48:28PM +0200, Marian Postevca wrote:
> Regarding playing the speaker and headphone simultaneously, is not
> something I took into account. Is this even a valid usecase? The intel driver
> for es8336 doesn't seem to support it.
Yes, for example consider a critical notification - the system
may wish to ensure it is audible even if the user has taken off
their headphones for some reason.
> >> This is needed because if suspending the laptop with the headphones
> >> inserted, when resuming, the sound is not working anymore. Sound stops
> >> working on speakers and headphones. Reinsertion and removals of the
> >> headphone doesn't solve the problem.
> >> This seems to be caused by the fact
> >> that the GPIO IRQ stops working in es8316_irq() after resume.
> > That's a bug that should be fixed.
> Agreed, but I don't know how easy it is to fix, and I would like to
> first offer users of these laptops a working sound driver.
> Afterwards this issue can be analyzed and properly fixed.
Surely if nothing else a good first step would be to have the
CODEC driver do whatever disabling the jack does on suspend
without needing the machine driver to bodge things?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Marian Postevca <posteuca@mutex.one>
Cc: 沈一超 <zhuning0077@gmail.com>,
yangxiaohua <yangxiaohua@everest-semi.com>,
"Zhu Ning" <zhuning@everest-semi.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec
Date: Wed, 22 Mar 2023 21:27:48 +0000 [thread overview]
Message-ID: <ZBty1CdPaWm0IcRi@sirena.org.uk> (raw)
In-Reply-To: <87ttycjyw3.fsf@mutex.one>
[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]
On Wed, Mar 22, 2023 at 10:48:28PM +0200, Marian Postevca wrote:
> Regarding playing the speaker and headphone simultaneously, is not
> something I took into account. Is this even a valid usecase? The intel driver
> for es8336 doesn't seem to support it.
Yes, for example consider a critical notification - the system
may wish to ensure it is audible even if the user has taken off
their headphones for some reason.
> >> This is needed because if suspending the laptop with the headphones
> >> inserted, when resuming, the sound is not working anymore. Sound stops
> >> working on speakers and headphones. Reinsertion and removals of the
> >> headphone doesn't solve the problem.
> >> This seems to be caused by the fact
> >> that the GPIO IRQ stops working in es8316_irq() after resume.
> > That's a bug that should be fixed.
> Agreed, but I don't know how easy it is to fix, and I would like to
> first offer users of these laptops a working sound driver.
> Afterwards this issue can be analyzed and properly fixed.
Surely if nothing else a good first step would be to have the
CODEC driver do whatever disabling the jack does on suspend
without needing the machine driver to bodge things?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-22 21:28 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 20:35 [PATCH 0/4] ASoC: amd: acp: Add sound support for a line of HUAWEI laptops Marian Postevca
2023-03-20 20:35 ` [PATCH 1/4] ASoC: es8316: Enable support for S32 LE format and MCLK div by 2 Marian Postevca
2023-03-20 20:43 ` Mark Brown
2023-03-20 20:43 ` Mark Brown
2023-03-21 17:09 ` Marian Postevca
2023-03-21 17:09 ` Marian Postevca
2023-03-21 17:21 ` Mark Brown
2023-03-21 17:21 ` Mark Brown
2023-03-20 20:35 ` [PATCH 2/4] ASoC: amd: acp: Add support for splitting the codec specific code from the ACP driver Marian Postevca
2023-03-20 20:35 ` [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec Marian Postevca
2023-03-20 20:54 ` Mark Brown
2023-03-20 20:54 ` Mark Brown
2023-03-21 22:17 ` Marian Postevca
2023-03-21 22:17 ` Marian Postevca
2023-03-22 1:58 ` Pierre-Louis Bossart
2023-03-22 13:07 ` Mark Brown
2023-03-22 13:07 ` Mark Brown
2023-03-22 20:48 ` Marian Postevca
2023-03-22 20:48 ` Marian Postevca
2023-03-22 21:27 ` Mark Brown [this message]
2023-03-22 21:27 ` Mark Brown
2023-03-27 21:20 ` Marian Postevca
2023-03-27 21:20 ` Marian Postevca
2023-03-29 13:52 ` Mark Brown
2023-03-29 13:52 ` Mark Brown
2023-08-17 21:09 ` Marian Postevca
2023-08-17 21:47 ` Mark Brown
2023-08-17 22:20 ` Marian Postevca
2023-08-18 12:52 ` Mark Brown
2023-08-20 9:32 ` Marian Postevca
2023-08-21 14:09 ` Mark Brown
2023-03-21 0:54 ` kernel test robot
2023-03-20 20:35 ` [PATCH 4/4] ASoC: amd: acp: Improve support for speaker power events Marian Postevca
2023-03-20 21:01 ` Mark Brown
2023-03-20 21:01 ` Mark Brown
2023-03-22 21:01 ` Marian Postevca
2023-03-22 21:01 ` Marian Postevca
2023-03-22 21:35 ` Mark Brown
2023-03-22 21:35 ` Mark Brown
2023-03-23 1:56 [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec 沈一超
2023-03-23 1:56 ` 沈一超
2023-03-23 13:54 ` Mark Brown
2023-03-23 13:54 ` Mark Brown
2023-03-24 1:54 Zhu Ning
2023-03-24 1:54 ` Zhu Ning
2023-03-29 14:01 ` Mark Brown
2023-03-29 14:01 ` Mark Brown
2023-08-18 7:58 Zhu Ning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBty1CdPaWm0IcRi@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=posteuca@mutex.one \
--cc=tiwai@suse.com \
--cc=yangxiaohua@everest-semi.com \
--cc=zhuning0077@gmail.com \
--cc=zhuning@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.