All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	netdev@vger.kernel.org, Keith Busch <keith.busch@intel.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v3 11/13] nvmet-tcp: add NVMe over TCP target driver
Date: Sun, 25 Nov 2018 01:13:00 -0800	[thread overview]
Message-ID: <4375f088-6afa-e0e6-1fdb-51359741660c@grimberg.me> (raw)
In-Reply-To: <20181122090655.GA27707@lst.de>


>> +	if (!cmd || queue->state == NVMET_TCP_Q_DISCONNECTING) {
>> +		cmd = nvmet_tcp_fetch_send_command(queue);
>> +		if (unlikely(!cmd))
>> +			return 0;
>> +	}
>> +
>> +	if (cmd->state == NVMET_TCP_SEND_DATA_PDU) {
>> +		ret = nvmet_try_send_data_pdu(cmd);
>> +		if (ret <= 0)
>> +			goto done_send;
>> +	}
>> +
>> +	if (cmd->state == NVMET_TCP_SEND_DATA) {
>> +		ret = nvmet_try_send_data(cmd);
>> +		if (ret <= 0)
>> +			goto done_send;
>> +	}
>> +
>> +	if (cmd->state == NVMET_TCP_SEND_DDGST) {
>> +		ret = nvmet_try_send_ddgst(cmd);
>> +		if (ret <= 0)
>> +			goto done_send;
>> +	}
>> +
>> +	if (cmd->state == NVMET_TCP_SEND_R2T) {
>> +		ret = nvmet_try_send_r2t(cmd, last_in_batch);
>> +		if (ret <= 0)
>> +			goto done_send;
>> +	}
>> +
>> +	if (cmd->state == NVMET_TCP_SEND_RESPONSE)
>> +		ret = nvmet_try_send_response(cmd, last_in_batch);
> 
> Use a switch statement?

The intent would be such that the state would transition with
the progression of the routine...

...

The rest of the comments will be addressed in the next submission..

WARNING: multiple messages have this Message-ID (diff)
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v3 11/13] nvmet-tcp: add NVMe over TCP target driver
Date: Sun, 25 Nov 2018 01:13:00 -0800	[thread overview]
Message-ID: <4375f088-6afa-e0e6-1fdb-51359741660c@grimberg.me> (raw)
In-Reply-To: <20181122090655.GA27707@lst.de>


>> +	if (!cmd || queue->state == NVMET_TCP_Q_DISCONNECTING) {
>> +		cmd = nvmet_tcp_fetch_send_command(queue);
>> +		if (unlikely(!cmd))
>> +			return 0;
>> +	}
>> +
>> +	if (cmd->state == NVMET_TCP_SEND_DATA_PDU) {
>> +		ret = nvmet_try_send_data_pdu(cmd);
>> +		if (ret <= 0)
>> +			goto done_send;
>> +	}
>> +
>> +	if (cmd->state == NVMET_TCP_SEND_DATA) {
>> +		ret = nvmet_try_send_data(cmd);
>> +		if (ret <= 0)
>> +			goto done_send;
>> +	}
>> +
>> +	if (cmd->state == NVMET_TCP_SEND_DDGST) {
>> +		ret = nvmet_try_send_ddgst(cmd);
>> +		if (ret <= 0)
>> +			goto done_send;
>> +	}
>> +
>> +	if (cmd->state == NVMET_TCP_SEND_R2T) {
>> +		ret = nvmet_try_send_r2t(cmd, last_in_batch);
>> +		if (ret <= 0)
>> +			goto done_send;
>> +	}
>> +
>> +	if (cmd->state == NVMET_TCP_SEND_RESPONSE)
>> +		ret = nvmet_try_send_response(cmd, last_in_batch);
> 
> Use a switch statement?

The intent would be such that the state would transition with
the progression of the routine...

...

The rest of the comments will be addressed in the next submission..

  reply	other threads:[~2018-11-25  9:13 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22  1:55 [PATCH v3 00/13] TCP transport binding for NVMe over Fabrics Sagi Grimberg
2018-11-22  1:55 ` Sagi Grimberg
2018-11-22  1:55 ` [PATCH v3 01/13] ath6kl: add ath6kl_ prefix to crypto_type Sagi Grimberg
2018-11-22  1:55   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 02/13] datagram: open-code copy_page_to_iter Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 03/13] iov_iter: pass void csum pointer to csum_and_copy_to_iter Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 04/13] datagram: consolidate datagram copy to iter helpers Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 05/13] iov_iter: introduce hash_and_copy_to_iter helper Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 06/13] datagram: introduce skb_copy_and_hash_datagram_iter helper Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 07/13] nvmet: Add install_queue callout Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 08/13] nvme-fabrics: allow user passing header digest Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 09/13] nvme-fabrics: allow user passing data digest Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 10/13] nvme-tcp: Add protocol header Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 11/13] nvmet-tcp: add NVMe over TCP target driver Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  9:06   ` Christoph Hellwig
2018-11-22  9:06     ` Christoph Hellwig
2018-11-25  9:13     ` Sagi Grimberg [this message]
2018-11-25  9:13       ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 12/13] nvmet: allow configfs tcp trtype configuration Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  8:02   ` Christoph Hellwig
2018-11-22  8:02     ` Christoph Hellwig
2018-11-25  9:10     ` Sagi Grimberg
2018-11-25  9:10       ` Sagi Grimberg
2018-11-27  0:05       ` Max Gurtovoy
2018-11-27  0:05         ` Max Gurtovoy
2018-11-27  7:48         ` Sagi Grimberg
2018-11-27  7:48           ` Sagi Grimberg
2018-11-27 10:20           ` Max Gurtovoy
2018-11-27 10:20             ` Max Gurtovoy
2018-11-22  1:56 ` [PATCH nvme-cli v3 14/13] fabrics: use trtype_str when parsing a discovery log entry Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH nvme-cli v3 15/13] nvme: Add TCP transport Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-26 15:47   ` Keith Busch
2018-11-26 15:47     ` Keith Busch
2018-11-27  7:45     ` Sagi Grimberg
2018-11-27  7:45       ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH nvme-cli v3 16/13] fabrics: add tcp port tsas decoding Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg
2018-11-22  1:56 ` [PATCH nvme-cli v3 17/13] fabrics: add transport header and data digest Sagi Grimberg
2018-11-22  1:56   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4375f088-6afa-e0e6-1fdb-51359741660c@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.