From: Max Gurtovoy <maxg@mellanox.com> To: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de> Cc: <linux-nvme@lists.infradead.org>, <linux-block@vger.kernel.org>, <netdev@vger.kernel.org>, Keith Busch <keith.busch@intel.com>, "David S. Miller" <davem@davemloft.net> Subject: Re: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver Date: Tue, 27 Nov 2018 02:05:14 +0200 [thread overview] Message-ID: <e4407485-843a-7968-c367-29d60baf8373@mellanox.com> (raw) In-Reply-To: <af432c70-1b3a-6c62-bb13-67bf7df1a43f@grimberg.me> +static enum blk_eh_timer_return >>> +nvme_tcp_timeout(struct request *rq, bool reserved) >>> +{ >>> + struct nvme_tcp_request *req = blk_mq_rq_to_pdu(rq); >>> + struct nvme_tcp_ctrl *ctrl = req->queue->ctrl; >>> + struct nvme_tcp_cmd_pdu *pdu = req->pdu; >>> + >>> + dev_dbg(ctrl->ctrl.device, >>> + "queue %d: timeout request %#x type %d\n", >>> + nvme_tcp_queue_id(req->queue), rq->tag, >>> + pdu->hdr.type); >>> + >>> + if (ctrl->ctrl.state != NVME_CTRL_LIVE) { >>> + union nvme_result res = {}; >>> + >>> + nvme_req(rq)->flags |= NVME_REQ_CANCELLED; >>> + nvme_end_request(rq, NVME_SC_ABORT_REQ, res); >>> + return BLK_EH_DONE; >> >> This looks odd. It's not really the timeout handlers job to >> call nvme_end_request here. > > Well.. if we are not yet LIVE, we will not trigger error > recovery, which means nothing will complete this command so > something needs to do it... > > I think that we need it for rdma too.. yes we do. and we've patches in our pipe. I'm thinking on a wider change in the error/recovery flows but might send it "as is" meanwhile. > > ... > > The rest of the comments will be addressed in the next submission..
WARNING: multiple messages have this Message-ID (diff)
From: maxg@mellanox.com (Max Gurtovoy) Subject: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver Date: Tue, 27 Nov 2018 02:05:14 +0200 [thread overview] Message-ID: <e4407485-843a-7968-c367-29d60baf8373@mellanox.com> (raw) In-Reply-To: <af432c70-1b3a-6c62-bb13-67bf7df1a43f@grimberg.me> +static enum blk_eh_timer_return >>> +nvme_tcp_timeout(struct request *rq, bool reserved) >>> +{ >>> +??? struct nvme_tcp_request *req = blk_mq_rq_to_pdu(rq); >>> +??? struct nvme_tcp_ctrl *ctrl = req->queue->ctrl; >>> +??? struct nvme_tcp_cmd_pdu *pdu = req->pdu; >>> + >>> +??? dev_dbg(ctrl->ctrl.device, >>> +??????? "queue %d: timeout request %#x type %d\n", >>> +??????? nvme_tcp_queue_id(req->queue), rq->tag, >>> +??????? pdu->hdr.type); >>> + >>> +??? if (ctrl->ctrl.state != NVME_CTRL_LIVE) { >>> +??????? union nvme_result res = {}; >>> + >>> +??????? nvme_req(rq)->flags |= NVME_REQ_CANCELLED; >>> +??????? nvme_end_request(rq, NVME_SC_ABORT_REQ, res); >>> +??????? return BLK_EH_DONE; >> >> This looks odd.? It's not really the timeout handlers job to >> call nvme_end_request here. > > Well.. if we are not yet LIVE, we will not trigger error > recovery, which means nothing will complete this command so > something needs to do it... > > I think that we need it for rdma too.. yes we do. and we've patches in our pipe. I'm thinking on a wider change in the error/recovery flows but might send it "as is" meanwhile. > > ... > > The rest of the comments will be addressed in the next submission..
next prev parent reply other threads:[~2018-11-27 0:06 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-22 1:55 [PATCH v3 00/13] TCP transport binding for NVMe over Fabrics Sagi Grimberg 2018-11-22 1:55 ` Sagi Grimberg 2018-11-22 1:55 ` [PATCH v3 01/13] ath6kl: add ath6kl_ prefix to crypto_type Sagi Grimberg 2018-11-22 1:55 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 02/13] datagram: open-code copy_page_to_iter Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 03/13] iov_iter: pass void csum pointer to csum_and_copy_to_iter Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 04/13] datagram: consolidate datagram copy to iter helpers Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 05/13] iov_iter: introduce hash_and_copy_to_iter helper Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 06/13] datagram: introduce skb_copy_and_hash_datagram_iter helper Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 07/13] nvmet: Add install_queue callout Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 08/13] nvme-fabrics: allow user passing header digest Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 09/13] nvme-fabrics: allow user passing data digest Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 10/13] nvme-tcp: Add protocol header Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 11/13] nvmet-tcp: add NVMe over TCP target driver Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 9:06 ` Christoph Hellwig 2018-11-22 9:06 ` Christoph Hellwig 2018-11-25 9:13 ` Sagi Grimberg 2018-11-25 9:13 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 12/13] nvmet: allow configfs tcp trtype configuration Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 8:02 ` Christoph Hellwig 2018-11-22 8:02 ` Christoph Hellwig 2018-11-25 9:10 ` Sagi Grimberg 2018-11-25 9:10 ` Sagi Grimberg 2018-11-27 0:05 ` Max Gurtovoy [this message] 2018-11-27 0:05 ` Max Gurtovoy 2018-11-27 7:48 ` Sagi Grimberg 2018-11-27 7:48 ` Sagi Grimberg 2018-11-27 10:20 ` Max Gurtovoy 2018-11-27 10:20 ` Max Gurtovoy 2018-11-22 1:56 ` [PATCH nvme-cli v3 14/13] fabrics: use trtype_str when parsing a discovery log entry Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH nvme-cli v3 15/13] nvme: Add TCP transport Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-26 15:47 ` Keith Busch 2018-11-26 15:47 ` Keith Busch 2018-11-27 7:45 ` Sagi Grimberg 2018-11-27 7:45 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH nvme-cli v3 16/13] fabrics: add tcp port tsas decoding Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg 2018-11-22 1:56 ` [PATCH nvme-cli v3 17/13] fabrics: add transport header and data digest Sagi Grimberg 2018-11-22 1:56 ` Sagi Grimberg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e4407485-843a-7968-c367-29d60baf8373@mellanox.com \ --to=maxg@mellanox.com \ --cc=davem@davemloft.net \ --cc=hch@lst.de \ --cc=keith.busch@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=netdev@vger.kernel.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.