From: Markus Elfring <Markus.Elfring@web.de>
To: Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: Wen Yang <wen.yang99@zte.com.cn>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions
Date: Sun, 28 Apr 2019 12:52:51 +0200 [thread overview]
Message-ID: <43884c4b-8146-9a35-ae5d-40ab17a4a04c@web.de> (raw)
In-Reply-To: <2816348.laE8LpYbrI@phil>
>> How do you think about to adjust the exception handling in these function
>> implementations a bit more according to the Linux coding style
>> (so that the addition of duplicate function calls would be avoided)?
>
> I actually requested not doing wild gotos for of_node_put calls,
> as it makes the code harder to read, especially when the "node"
> gets reused for a different node-source.
Does this feedback mean that you insist on another deviation
from the Linux coding style?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring-S0/GAf8tV78@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Yi Wang <wang.yi59-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Wen Yang <wen.yang99-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions
Date: Sun, 28 Apr 2019 12:52:51 +0200 [thread overview]
Message-ID: <43884c4b-8146-9a35-ae5d-40ab17a4a04c@web.de> (raw)
In-Reply-To: <2816348.laE8LpYbrI@phil>
>> How do you think about to adjust the exception handling in these function
>> implementations a bit more according to the Linux coding style
>> (so that the addition of duplicate function calls would be avoided)?
>
> I actually requested not doing wild gotos for of_node_put calls,
> as it makes the code harder to read, especially when the "node"
> gets reused for a different node-source.
Does this feedback mean that you insist on another deviation
from the Linux coding style?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: Yi Wang <wang.yi59@zte.com.cn>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Wen Yang <wen.yang99@zte.com.cn>,
linux-kernel@vger.kernel.org
Subject: Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions
Date: Sun, 28 Apr 2019 12:52:51 +0200 [thread overview]
Message-ID: <43884c4b-8146-9a35-ae5d-40ab17a4a04c@web.de> (raw)
In-Reply-To: <2816348.laE8LpYbrI@phil>
>> How do you think about to adjust the exception handling in these function
>> implementations a bit more according to the Linux coding style
>> (so that the addition of duplicate function calls would be avoided)?
>
> I actually requested not doing wild gotos for of_node_put calls,
> as it makes the code harder to read, especially when the "node"
> gets reused for a different node-source.
Does this feedback mean that you insist on another deviation
from the Linux coding style?
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-28 10:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 7:08 [PATCH v3] ARM: rockchip: fix a leaked reference by adding missing of_node_put Wen Yang
2019-04-26 7:08 ` Wen Yang
2019-04-28 6:27 ` [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions Markus Elfring
2019-04-28 6:27 ` Markus Elfring
2019-04-28 10:40 ` Heiko Stuebner
2019-04-28 10:40 ` Heiko Stuebner
2019-04-28 10:52 ` Markus Elfring [this message]
2019-04-28 10:52 ` Markus Elfring
2019-04-28 10:52 ` Markus Elfring
2019-04-28 10:46 ` [PATCH v3] ARM: rockchip: fix a leaked reference by adding missing of_node_put Heiko Stuebner
2019-04-28 10:46 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43884c4b-8146-9a35-ae5d-40ab17a4a04c@web.de \
--to=markus.elfring@web.de \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.