All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Wen Yang" <wen.yang99@zte.com.cn>,
	"Heiko Stübner" <heiko@sntech.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	"Florian Fainelli" <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>,
	Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions
Date: Sun, 28 Apr 2019 08:27:05 +0200	[thread overview]
Message-ID: <cee2ab03-d0b7-c9c6-acc3-d5aa28979e2b@web.de> (raw)
In-Reply-To: <1556262488-21072-1-git-send-email-wen.yang99@zte.com.cn>

>  arch/arm/mach-rockchip/platsmp.c | 12 ++++++++++--
>  arch/arm/mach-rockchip/pm.c      |  2 ++

* Would a commit subject variant be nicer?

* I dare to present a reminder for a recurring development topic.
  How do you think about to adjust the exception handling in these function
  implementations a bit more according to the Linux coding style
  (so that the addition of duplicate function calls would be avoided)?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: "Wen Yang" <wen.yang99@zte.com.cn>,
	"Heiko Stübner" <heiko@sntech.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	"Florian Fainelli" <f.fainelli@gmail.com>
Cc: Yi Wang <wang.yi59@zte.com.cn>,
	linux-kernel@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions
Date: Sun, 28 Apr 2019 08:27:05 +0200	[thread overview]
Message-ID: <cee2ab03-d0b7-c9c6-acc3-d5aa28979e2b@web.de> (raw)
In-Reply-To: <1556262488-21072-1-git-send-email-wen.yang99@zte.com.cn>

>  arch/arm/mach-rockchip/platsmp.c | 12 ++++++++++--
>  arch/arm/mach-rockchip/pm.c      |  2 ++

* Would a commit subject variant be nicer?

* I dare to present a reminder for a recurring development topic.
  How do you think about to adjust the exception handling in these function
  implementations a bit more according to the Linux coding style
  (so that the addition of duplicate function calls would be avoided)?

Regards,
Markus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-04-28  6:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26  7:08 [PATCH v3] ARM: rockchip: fix a leaked reference by adding missing of_node_put Wen Yang
2019-04-26  7:08 ` Wen Yang
2019-04-28  6:27 ` Markus Elfring [this message]
2019-04-28  6:27   ` [v3] ARM: rockchip: Fix a leaked reference by adding of_node_put() in two functions Markus Elfring
2019-04-28 10:40   ` Heiko Stuebner
2019-04-28 10:40     ` Heiko Stuebner
2019-04-28 10:52     ` Markus Elfring
2019-04-28 10:52       ` Markus Elfring
2019-04-28 10:52       ` Markus Elfring
2019-04-28 10:46 ` [PATCH v3] ARM: rockchip: fix a leaked reference by adding missing of_node_put Heiko Stuebner
2019-04-28 10:46   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cee2ab03-d0b7-c9c6-acc3-d5aa28979e2b@web.de \
    --to=markus.elfring@web.de \
    --cc=f.fainelli@gmail.com \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=wang.yi59@zte.com.cn \
    --cc=wen.yang99@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.