[PATCH 1/2] package: add extra_recommends to do_split_package()

* [PATCH 1/2] package: add extra_recommends to do_split_package()
@ 2022-02-09 17:30 Ross Burton
  2022-02-09 17:30 ` [PATCH 2/2] kernel-module-split: modules should recommend the kernel image Ross Burton
  0 siblings, 1 reply; 10+ messages in thread
From: Ross Burton @ 2022-02-09 17:30 UTC (permalink / raw)
  To: openembedded-core; +Cc: bruce.ashfield

It may be preferrable to add RRECOMMENDS instead of RDEPENDS to each of
the split packages, so add extra_recommends to do this.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/classes/package.bbclass | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index f4a661ba25a..2143abca0d1 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -79,7 +79,7 @@ def legitimize_package_name(s):
     # Remaining package name validity fixes
     return s.lower().replace('_', '-').replace('@', '+').replace(',', '+').replace('/', '-')
 
-def do_split_packages(d, root, file_regex, output_pattern, description, postinst=None, recursive=False, hook=None, extra_depends=None, aux_files_pattern=None, postrm=None, allow_dirs=False, prepend=False, match_path=False, aux_files_pattern_verbatim=None, allow_links=False, summary=None):
+def do_split_packages(d, root, file_regex, output_pattern, description, postinst=None, recursive=False, hook=None, extra_depends=None, extra_recommends=None, aux_files_pattern=None, postrm=None, allow_dirs=False, prepend=False, match_path=False, aux_files_pattern_verbatim=None, allow_links=False, summary=None):
     """
     Used in .bb files to split up dynamically generated subpackages of a
     given package, usually plugins or modules.
@@ -108,6 +108,8 @@ def do_split_packages(d, root, file_regex, output_pattern, description, postinst
                       all packages. The default value of None causes a
                       dependency on the main package (${PN}) - if you do
                       not want this, pass '' for this parameter.
+    extra_recommends -- extra runtime recommends (RRECOMMENDS) to be set for
+                      all packages. By default no recommends are added.
     aux_files_pattern -- extra item(s) to be added to FILES for each
                       package. Can be a single string item or a list of
                       strings for multiple items.  Must include %s.
@@ -222,6 +224,8 @@ def do_split_packages(d, root, file_regex, output_pattern, description, postinst
             d.setVar('FILES:' + pkg, oldfiles + " " + newfile)
         if extra_depends != '':
             d.appendVar('RDEPENDS:' + pkg, ' ' + extra_depends)
+        if extra_recommends:
+            d.appendVar('RRECOMMENDS:' + pkg, ' ' + extra_recommends)
         if not d.getVar('DESCRIPTION:' + pkg):
             d.setVar('DESCRIPTION:' + pkg, description % on)
         if not d.getVar('SUMMARY:' + pkg):
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 10+ messages in thread