From: Suzuki K Poulose <suzuki.poulose@arm.com> To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, linux-perf-users@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: mathieu.poirier@linaro.org, leo.yan@linaro.org, quic_jinlmao@quicinc.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, Mike Leach <mike.leach@linaro.org>, Adrian Hunter <adrian.hunter@intel.com> Subject: Re: [PATCH v6 11/14] kernel: events: Export perf_report_aux_output_id() Date: Fri, 6 Jan 2023 09:54:23 +0000 [thread overview] Message-ID: <44e87647-d64e-ee24-0046-06bb15f5a1f4@arm.com> (raw) In-Reply-To: <9ea2a0d8-b025-bb56-3a04-1a88e340da2d@arm.com> Peter, Ingo, Arnaldo On 13/12/2022 10:08, Suzuki K Poulose wrote: > Peter, > > On 24/11/2022 11:04, Suzuki Kuruppassery Poulose wrote: >> Peter >> >> >> On 23/11/2022 19:50, Mike Leach wrote: >>> CoreSight trace being updated to use the perf_report_aux_output_id() >>> in a similar way to intel-pt. >>> >>> This function in needs export visibility to allow it to be called from >>> kernel loadable modules, which CoreSight may configured to be built as. >>> >>> Signed-off-by: Mike Leach <mike.leach@linaro.org> >>> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> >>> --- >>> kernel/events/core.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/kernel/events/core.c b/kernel/events/core.c >>> index 4ec3717003d5..ad388552f1d5 100644 >>> --- a/kernel/events/core.c >>> +++ b/kernel/events/core.c >>> @@ -9231,6 +9231,7 @@ void perf_report_aux_output_id(struct >>> perf_event *event, u64 hw_id) >>> perf_output_end(&handle); >>> } >>> +EXPORT_SYMBOL_GPL(perf_report_aux_output_id); >> >> Are you happy with me picking up this change through the coresight >> tree ? >> >> Suzuki >> > > Please could you let me know your thoughts on this ? Coresight PMU would > use this to inform the dynamically allocated trace id for a CPU to the > perf via this HWID packet. > > If you are happy with the above change, I could pick it up via the > coresight tree with your Ack. Otherwise, please could you pick it > up ? > Please could you let us know if this is acceptable and if so, how can this be pushed ? CoreSight PMU (which can be built as a module) is using these packets to advertise the traceID allocated for a given CPU bound ETM (which is made dynamic due to the limited number of ids available). The perf tool can use these packets to then decode and separate the trace data from shared buffer. As of now, the series to enable the dynamic trace id allocation is blocked on this change. Kind regards Suzuki > Suzuki >
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com> To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, linux-perf-users@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: mathieu.poirier@linaro.org, leo.yan@linaro.org, quic_jinlmao@quicinc.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, Mike Leach <mike.leach@linaro.org>, Adrian Hunter <adrian.hunter@intel.com> Subject: Re: [PATCH v6 11/14] kernel: events: Export perf_report_aux_output_id() Date: Fri, 6 Jan 2023 09:54:23 +0000 [thread overview] Message-ID: <44e87647-d64e-ee24-0046-06bb15f5a1f4@arm.com> (raw) In-Reply-To: <9ea2a0d8-b025-bb56-3a04-1a88e340da2d@arm.com> Peter, Ingo, Arnaldo On 13/12/2022 10:08, Suzuki K Poulose wrote: > Peter, > > On 24/11/2022 11:04, Suzuki Kuruppassery Poulose wrote: >> Peter >> >> >> On 23/11/2022 19:50, Mike Leach wrote: >>> CoreSight trace being updated to use the perf_report_aux_output_id() >>> in a similar way to intel-pt. >>> >>> This function in needs export visibility to allow it to be called from >>> kernel loadable modules, which CoreSight may configured to be built as. >>> >>> Signed-off-by: Mike Leach <mike.leach@linaro.org> >>> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> >>> --- >>> kernel/events/core.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/kernel/events/core.c b/kernel/events/core.c >>> index 4ec3717003d5..ad388552f1d5 100644 >>> --- a/kernel/events/core.c >>> +++ b/kernel/events/core.c >>> @@ -9231,6 +9231,7 @@ void perf_report_aux_output_id(struct >>> perf_event *event, u64 hw_id) >>> perf_output_end(&handle); >>> } >>> +EXPORT_SYMBOL_GPL(perf_report_aux_output_id); >> >> Are you happy with me picking up this change through the coresight >> tree ? >> >> Suzuki >> > > Please could you let me know your thoughts on this ? Coresight PMU would > use this to inform the dynamically allocated trace id for a CPU to the > perf via this HWID packet. > > If you are happy with the above change, I could pick it up via the > coresight tree with your Ack. Otherwise, please could you pick it > up ? > Please could you let us know if this is acceptable and if so, how can this be pushed ? CoreSight PMU (which can be built as a module) is using these packets to advertise the traceID allocated for a given CPU bound ETM (which is made dynamic due to the limited number of ids available). The perf tool can use these packets to then decode and separate the trace data from shared buffer. As of now, the series to enable the dynamic trace id allocation is blocked on this change. Kind regards Suzuki > Suzuki > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-06 9:54 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-23 19:49 [PATCH v6 00/14] coresight: Add new API to allocate trace source ID values Mike Leach 2022-11-23 19:49 ` Mike Leach 2022-11-23 19:49 ` [PATCH v6 01/14] coresight: trace-id: Add API to dynamically assign Trace " Mike Leach 2022-11-23 19:49 ` Mike Leach 2022-11-23 19:49 ` [PATCH v6 02/14] coresight: Remove obsolete Trace ID unniqueness checks Mike Leach 2022-11-23 19:49 ` Mike Leach 2022-11-23 19:49 ` [PATCH v6 03/14] coresight: perf: traceid: Add perf ID allocation and notifiers Mike Leach 2022-11-23 19:49 ` Mike Leach 2022-11-23 19:50 ` [PATCH v6 04/14] coresight: stm: Update STM driver to use Trace ID API Mike Leach 2022-11-23 19:50 ` Mike Leach 2022-11-23 19:50 ` [PATCH v6 05/14] coresight: etm4x: Update ETM4 " Mike Leach 2022-11-23 19:50 ` Mike Leach 2022-11-23 19:50 ` [PATCH v6 06/14] coresight: etm3x: Update ETM3 " Mike Leach 2022-11-23 19:50 ` Mike Leach 2022-11-23 19:50 ` [PATCH v6 07/14] coresight: etmX.X: stm: Remove trace_id() callback Mike Leach 2022-11-23 19:50 ` Mike Leach 2022-11-23 19:50 ` [PATCH v6 08/14] coresight: trace id: Remove legacy get trace ID function Mike Leach 2022-11-23 19:50 ` Mike Leach 2022-11-23 19:50 ` [PATCH v6 09/14] perf: cs-etm: Move mapping of Trace ID and cpu into helper function Mike Leach 2022-11-23 19:50 ` Mike Leach 2022-11-23 19:50 ` [PATCH v6 10/14] perf: cs-etm: Update record event to use new Trace ID protocol Mike Leach 2022-11-23 19:50 ` Mike Leach 2022-11-23 19:50 ` [PATCH v6 11/14] kernel: events: Export perf_report_aux_output_id() Mike Leach 2022-11-23 19:50 ` Mike Leach 2022-11-24 11:04 ` Suzuki Kuruppassery Poulose 2022-11-24 11:04 ` Suzuki Kuruppassery Poulose 2022-12-13 10:08 ` Suzuki K Poulose 2022-12-13 10:08 ` Suzuki K Poulose 2023-01-06 9:54 ` Suzuki K Poulose [this message] 2023-01-06 9:54 ` Suzuki K Poulose 2023-01-12 15:06 ` Peter Zijlstra 2023-01-12 15:06 ` Peter Zijlstra 2022-11-23 19:50 ` [PATCH v6 12/14] perf: cs-etm: Handle PERF_RECORD_AUX_OUTPUT_HW_ID packet Mike Leach 2022-11-23 19:50 ` Mike Leach 2022-11-23 19:50 ` [PATCH v6 13/14] coresight: events: PERF_RECORD_AUX_OUTPUT_HW_ID used for Trace ID Mike Leach 2022-11-23 19:50 ` Mike Leach 2022-11-23 19:50 ` [PATCH v6 14/14] coresight: trace-id: Add debug & test macros to Trace ID allocation Mike Leach 2022-11-23 19:50 ` Mike Leach
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=44e87647-d64e-ee24-0046-06bb15f5a1f4@arm.com \ --to=suzuki.poulose@arm.com \ --cc=acme@kernel.org \ --cc=adrian.hunter@intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=coresight@lists.linaro.org \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=quic_jinlmao@quicinc.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.