From: "Chen, Rong A" <rong.a.chen@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Julia Lawall <julia.lawall@inria.fr>
Cc: Megha Dey <megha.dey@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Tomasz Kantecki <tomasz.kantecki@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-crypto@vger.kernel.org
Subject: Re: [kbuild-all] Re: [PATCH] crypto: fix flexible_array.cocci warnings
Date: Wed, 24 Nov 2021 11:17:23 +0800 [thread overview]
Message-ID: <4514c646-cae1-cd50-8a1c-1a550593c7a8@intel.com> (raw)
In-Reply-To: <20211120040625.GA25678@gondor.apana.org.au>
Hi Herbert,
On 11/20/2021 12:06 PM, Herbert Xu wrote:
> On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> Zero-length and one-element arrays are deprecated, see
>> Documentation/process/deprecated.rst
>> Flexible-array members should be used instead.
>>
>> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
>> ---
>>
>> tree: https://github.com/meghadey/crypto crypto-avx512
>> head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
>> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
Sorry for the noise, this patch tries to fix the above commit, it seems
the commit is still in the private tree, we have fixed it to avoid
sending to maintainers.
Best Regards,
Rong Chen
>> :::::: branch date: 7 weeks ago
>> :::::: commit date: 7 weeks ago
>>
>> aesni-intel_glue.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/x86/crypto/aesni-intel_glue.c
>> +++ b/arch/x86/crypto/aesni-intel_glue.c
>> @@ -87,7 +87,7 @@ struct gcm_context_data {
>> u64 partial_block_len;
>> u64 unused;
>> /* Allocate space for hash_keys later */
>> - u8 hash_keys[0];
>> + u8 hash_keys[];
>
> Which tree did this come from? Not only is this not zero in my
> tree, but it seems to have never been zero in the git history.
>
> Thanks,
>
WARNING: multiple messages have this Message-ID (diff)
From: Chen, Rong A <rong.a.chen@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] crypto: fix flexible_array.cocci warnings
Date: Wed, 24 Nov 2021 11:17:23 +0800 [thread overview]
Message-ID: <4514c646-cae1-cd50-8a1c-1a550593c7a8@intel.com> (raw)
In-Reply-To: <20211120040625.GA25678@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
Hi Herbert,
On 11/20/2021 12:06 PM, Herbert Xu wrote:
> On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> Zero-length and one-element arrays are deprecated, see
>> Documentation/process/deprecated.rst
>> Flexible-array members should be used instead.
>>
>> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
>> ---
>>
>> tree: https://github.com/meghadey/crypto crypto-avx512
>> head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
>> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
Sorry for the noise, this patch tries to fix the above commit, it seems
the commit is still in the private tree, we have fixed it to avoid
sending to maintainers.
Best Regards,
Rong Chen
>> :::::: branch date: 7 weeks ago
>> :::::: commit date: 7 weeks ago
>>
>> aesni-intel_glue.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/x86/crypto/aesni-intel_glue.c
>> +++ b/arch/x86/crypto/aesni-intel_glue.c
>> @@ -87,7 +87,7 @@ struct gcm_context_data {
>> u64 partial_block_len;
>> u64 unused;
>> /* Allocate space for hash_keys later */
>> - u8 hash_keys[0];
>> + u8 hash_keys[];
>
> Which tree did this come from? Not only is this not zero in my
> tree, but it seems to have never been zero in the git history.
>
> Thanks,
>
next prev parent reply other threads:[~2021-11-24 3:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 10:56 [PATCH] crypto: fix flexible_array.cocci warnings Julia Lawall
2021-11-12 10:56 ` Julia Lawall
2021-11-20 4:06 ` Herbert Xu
2021-11-20 4:06 ` Herbert Xu
2021-11-24 3:17 ` Chen, Rong A [this message]
2021-11-24 3:17 ` Chen, Rong A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4514c646-cae1-cd50-8a1c-1a550593c7a8@intel.com \
--to=rong.a.chen@intel.com \
--cc=bp@alien8.de \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=julia.lawall@inria.fr \
--cc=kbuild-all@lists.01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megha.dey@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tomasz.kantecki@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.