* [PATCH] crypto: fix flexible_array.cocci warnings
@ 2021-11-12 10:56 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2021-11-12 10:56 UTC (permalink / raw)
To: Megha Dey
Cc: kbuild-all, linux-kernel, Tomasz Kantecki, Herbert Xu,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin, linux-crypto, linux-kernel
From: kernel test robot <lkp@intel.com>
Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.
Generated by: scripts/coccinelle/misc/flexible_array.cocci
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://github.com/meghadey/crypto crypto-avx512
head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 weeks ago
:::::: commit date: 7 weeks ago
aesni-intel_glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
u64 partial_block_len;
u64 unused;
/* Allocate space for hash_keys later */
- u8 hash_keys[0];
+ u8 hash_keys[];
};
asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] crypto: fix flexible_array.cocci warnings
@ 2021-11-12 10:56 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2021-11-12 10:56 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
From: kernel test robot <lkp@intel.com>
Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.
Generated by: scripts/coccinelle/misc/flexible_array.cocci
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://github.com/meghadey/crypto crypto-avx512
head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 weeks ago
:::::: commit date: 7 weeks ago
aesni-intel_glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
u64 partial_block_len;
u64 unused;
/* Allocate space for hash_keys later */
- u8 hash_keys[0];
+ u8 hash_keys[];
};
asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] crypto: fix flexible_array.cocci warnings
2021-11-12 10:56 ` Julia Lawall
@ 2021-11-20 4:06 ` Herbert Xu
-1 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2021-11-20 4:06 UTC (permalink / raw)
To: Julia Lawall
Cc: Megha Dey, kbuild-all, linux-kernel, Tomasz Kantecki,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin, linux-crypto
On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Zero-length and one-element arrays are deprecated, see
> Documentation/process/deprecated.rst
> Flexible-array members should be used instead.
>
> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
>
> tree: https://github.com/meghadey/crypto crypto-avx512
> head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
> :::::: branch date: 7 weeks ago
> :::::: commit date: 7 weeks ago
>
> aesni-intel_glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -87,7 +87,7 @@ struct gcm_context_data {
> u64 partial_block_len;
> u64 unused;
> /* Allocate space for hash_keys later */
> - u8 hash_keys[0];
> + u8 hash_keys[];
Which tree did this come from? Not only is this not zero in my
tree, but it seems to have never been zero in the git history.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] crypto: fix flexible_array.cocci warnings
@ 2021-11-20 4:06 ` Herbert Xu
0 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2021-11-20 4:06 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]
On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Zero-length and one-element arrays are deprecated, see
> Documentation/process/deprecated.rst
> Flexible-array members should be used instead.
>
> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
>
> tree: https://github.com/meghadey/crypto crypto-avx512
> head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
> :::::: branch date: 7 weeks ago
> :::::: commit date: 7 weeks ago
>
> aesni-intel_glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -87,7 +87,7 @@ struct gcm_context_data {
> u64 partial_block_len;
> u64 unused;
> /* Allocate space for hash_keys later */
> - u8 hash_keys[0];
> + u8 hash_keys[];
Which tree did this come from? Not only is this not zero in my
tree, but it seems to have never been zero in the git history.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [kbuild-all] Re: [PATCH] crypto: fix flexible_array.cocci warnings
2021-11-20 4:06 ` Herbert Xu
@ 2021-11-24 3:17 ` Chen, Rong A
-1 siblings, 0 replies; 6+ messages in thread
From: Chen, Rong A @ 2021-11-24 3:17 UTC (permalink / raw)
To: Herbert Xu, Julia Lawall
Cc: Megha Dey, kbuild-all, linux-kernel, Tomasz Kantecki,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin, linux-crypto
Hi Herbert,
On 11/20/2021 12:06 PM, Herbert Xu wrote:
> On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> Zero-length and one-element arrays are deprecated, see
>> Documentation/process/deprecated.rst
>> Flexible-array members should be used instead.
>>
>> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
>> ---
>>
>> tree: https://github.com/meghadey/crypto crypto-avx512
>> head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
>> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
Sorry for the noise, this patch tries to fix the above commit, it seems
the commit is still in the private tree, we have fixed it to avoid
sending to maintainers.
Best Regards,
Rong Chen
>> :::::: branch date: 7 weeks ago
>> :::::: commit date: 7 weeks ago
>>
>> aesni-intel_glue.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/x86/crypto/aesni-intel_glue.c
>> +++ b/arch/x86/crypto/aesni-intel_glue.c
>> @@ -87,7 +87,7 @@ struct gcm_context_data {
>> u64 partial_block_len;
>> u64 unused;
>> /* Allocate space for hash_keys later */
>> - u8 hash_keys[0];
>> + u8 hash_keys[];
>
> Which tree did this come from? Not only is this not zero in my
> tree, but it seems to have never been zero in the git history.
>
> Thanks,
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] crypto: fix flexible_array.cocci warnings
@ 2021-11-24 3:17 ` Chen, Rong A
0 siblings, 0 replies; 6+ messages in thread
From: Chen, Rong A @ 2021-11-24 3:17 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
Hi Herbert,
On 11/20/2021 12:06 PM, Herbert Xu wrote:
> On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> Zero-length and one-element arrays are deprecated, see
>> Documentation/process/deprecated.rst
>> Flexible-array members should be used instead.
>>
>> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
>> ---
>>
>> tree: https://github.com/meghadey/crypto crypto-avx512
>> head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
>> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
Sorry for the noise, this patch tries to fix the above commit, it seems
the commit is still in the private tree, we have fixed it to avoid
sending to maintainers.
Best Regards,
Rong Chen
>> :::::: branch date: 7 weeks ago
>> :::::: commit date: 7 weeks ago
>>
>> aesni-intel_glue.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/x86/crypto/aesni-intel_glue.c
>> +++ b/arch/x86/crypto/aesni-intel_glue.c
>> @@ -87,7 +87,7 @@ struct gcm_context_data {
>> u64 partial_block_len;
>> u64 unused;
>> /* Allocate space for hash_keys later */
>> - u8 hash_keys[0];
>> + u8 hash_keys[];
>
> Which tree did this come from? Not only is this not zero in my
> tree, but it seems to have never been zero in the git history.
>
> Thanks,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-24 3:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 10:56 [PATCH] crypto: fix flexible_array.cocci warnings Julia Lawall
2021-11-12 10:56 ` Julia Lawall
2021-11-20 4:06 ` Herbert Xu
2021-11-20 4:06 ` Herbert Xu
2021-11-24 3:17 ` [kbuild-all] " Chen, Rong A
2021-11-24 3:17 ` Chen, Rong A
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.