From: Icenowy Zheng <icenowy@aosc.io>
To: wens@kernel.org, Chen-Yu Tsai <wens@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
inux-kernel@vger.kernel.org,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH 2/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI for Lichee Pi Zero
Date: Sat, 28 Nov 2020 11:35:25 +0800 [thread overview]
Message-ID: <4515AB80-D54A-41CF-A677-2109289E6138@aosc.io> (raw)
In-Reply-To: <CAGb2v65JA803yHVNS5=6-EAUFSN-cqoCetkJJ3kCDE7e89Tijw@mail.gmail.com>
于 2020年11月28日 GMT+08:00 上午11:09:17, Chen-Yu Tsai <wens@kernel.org> 写到:
>On Mon, Nov 23, 2020 at 6:22 PM Icenowy Zheng <icenowy@aosc.io> wrote:
>>
>>
>>
>> 于 2020年11月23日 GMT+08:00 上午11:37:43, Chen-Yu Tsai <wens@csie.org> 写到:
>> >On Sun, Nov 22, 2020 at 8:40 AM Icenowy Zheng <icenowy@aosc.io>
>wrote:
>> >>
>> >> As the USB port on Lichee Pi Zero works in the OTG mode, enable
>the
>> >> EHCI/OHCI controllers for it.
>> >
>> >You should probably mention that the host controllers work better
>> >than the OTG controller in host mode. Otherwise this change lacks
>> >justification for enabling two extra hardware blocks.
>>
>> Our PHY driver do not sense whether ?HCI is enabled or not, so
>> for host to work it's necessary to be enabled, otherwise the phy
>> driver will just route USB to unenabled ?HCI and fail.
>
>So, this was never working in Linux to begin with? You should mention
>that.
Okay.
>
>Maybe a fixes tag is in order then.
Well I can't judge whether this is necessary.
WARNING: multiple messages have this Message-ID (diff)
From: Icenowy Zheng <icenowy@aosc.io>
To: wens@kernel.org,Chen-Yu Tsai <wens@kernel.org>
Cc: devicetree <devicetree@vger.kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
inux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [linux-sunxi] [PATCH 2/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI for Lichee Pi Zero
Date: Sat, 28 Nov 2020 11:35:25 +0800 [thread overview]
Message-ID: <4515AB80-D54A-41CF-A677-2109289E6138@aosc.io> (raw)
In-Reply-To: <CAGb2v65JA803yHVNS5=6-EAUFSN-cqoCetkJJ3kCDE7e89Tijw@mail.gmail.com>
于 2020年11月28日 GMT+08:00 上午11:09:17, Chen-Yu Tsai <wens@kernel.org> 写到:
>On Mon, Nov 23, 2020 at 6:22 PM Icenowy Zheng <icenowy@aosc.io> wrote:
>>
>>
>>
>> 于 2020年11月23日 GMT+08:00 上午11:37:43, Chen-Yu Tsai <wens@csie.org> 写到:
>> >On Sun, Nov 22, 2020 at 8:40 AM Icenowy Zheng <icenowy@aosc.io>
>wrote:
>> >>
>> >> As the USB port on Lichee Pi Zero works in the OTG mode, enable
>the
>> >> EHCI/OHCI controllers for it.
>> >
>> >You should probably mention that the host controllers work better
>> >than the OTG controller in host mode. Otherwise this change lacks
>> >justification for enabling two extra hardware blocks.
>>
>> Our PHY driver do not sense whether ?HCI is enabled or not, so
>> for host to work it's necessary to be enabled, otherwise the phy
>> driver will just route USB to unenabled ?HCI and fail.
>
>So, this was never working in Linux to begin with? You should mention
>that.
Okay.
>
>Maybe a fixes tag is in order then.
Well I can't judge whether this is necessary.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-28 3:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 0:38 [PATCH 0/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI Icenowy Zheng
2020-11-22 0:38 ` Icenowy Zheng
2020-11-22 0:38 ` [PATCH 1/3] ARM: dts: sun8i: v3s: add EHCI/OHCI0 device nodes Icenowy Zheng
2020-11-22 0:38 ` Icenowy Zheng
2020-11-23 3:38 ` [linux-sunxi] " Chen-Yu Tsai
2020-11-23 3:38 ` Chen-Yu Tsai
2020-11-22 0:40 ` [PATCH 2/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI for Lichee Pi Zero Icenowy Zheng
2020-11-22 0:40 ` Icenowy Zheng
2020-11-23 3:37 ` [linux-sunxi] " Chen-Yu Tsai
2020-11-23 3:37 ` Chen-Yu Tsai
2020-11-23 10:21 ` Icenowy Zheng
2020-11-23 10:21 ` Icenowy Zheng
2020-11-28 3:09 ` Chen-Yu Tsai
2020-11-28 3:09 ` Chen-Yu Tsai
2020-11-28 3:35 ` Icenowy Zheng [this message]
2020-11-28 3:35 ` Icenowy Zheng
2020-11-22 0:40 ` [PATCH 3/3] ARM: dts: sun8i: s3: switch PineCube to use OHCI/EHCI only Icenowy Zheng
2020-11-22 0:40 ` Icenowy Zheng
2020-11-23 3:29 ` [linux-sunxi] " Chen-Yu Tsai
2020-11-23 3:29 ` Chen-Yu Tsai
2020-11-23 11:43 ` Maxime Ripard
2020-11-23 11:43 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4515AB80-D54A-41CF-A677-2109289E6138@aosc.io \
--to=icenowy@aosc.io \
--cc=devicetree@vger.kernel.org \
--cc=inux-kernel@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.